179493 2017-11-09 11:21:48 -0800 [LayoutState cleanup] Remove conditional push from RenderTableSection::calcRowLogicalHeight 2017-11-09 12:22:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1369976 0 zalan 2017-11-09 11:21:48 -0800 Pushing layout state is supposed to be cheap. 1369977 1 webkit-bug-importer 2017-11-09 11:22:14 -0800 <rdar://problem/35446631> 1369992 2 326471 zalan 2017-11-09 11:35:26 -0800 Created attachment 326471 Patch 1370004 3 326471 commit-queue 2017-11-09 12:22:13 -0800 Comment on attachment 326471 Patch Clearing flags on attachment: 326471 Committed r224641: <https://trac.webkit.org/changeset/224641> 1370005 4 commit-queue 2017-11-09 12:22:15 -0800 All reviewed patches have been landed. Closing bug. 326471 2017-11-09 11:35:26 -0800 2017-11-09 12:22:13 -0800 Patch bug-179493-20171109113525.patch text/plain 5460 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI1YzJkYTU5MmMyM2Uy ZTUzMmFiZWMwMzg3ZjFkNWY1OGNjNTE5OC4uNjJkMzY0Y2RhZjMzMDk2NGEwMzFkODA1ZWZhYmEx YjViMTFiZGY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE3LTExLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xheW91dFN0YXRlIGNsZWFu dXBdIFJlbW92ZSBjb25kaXRpb25hbCBwdXNoIGZyb20gUmVuZGVyVGFibGVTZWN0aW9uOjpjYWxj Um93TG9naWNhbEhlaWdodAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc5NDkzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTQ0NjYzMT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQdXNoaW5nIGxheW91 dCBzdGF0ZXMgaXMgY2hlYXAgYW5kIHdlIGRvIGl0IGZvciBldmVyeSBjb250YWluZXIgYW55d2F5 LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvTGF5b3V0U3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0U3RhdGVNYWlu dGFpbmVyOjpMYXlvdXRTdGF0ZU1haW50YWluZXIpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 U3RhdGVNYWludGFpbmVyOjp+TGF5b3V0U3RhdGVNYWludGFpbmVyKToKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dFN0YXRlTWFpbnRhaW5lcjo6cG9wKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dFN0YXRlTWFpbnRhaW5lcjo6cHVzaCk6IERlbGV0ZWQuCisgICAgICAgICogcmVuZGVyaW5nL0xh eW91dFN0YXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRTdGF0ZU1haW50YWluZXI6OmRp ZFB1c2ggY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZVNl Y3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVTZWN0aW9uOjpjYWxjUm93 TG9naWNhbEhlaWdodCk6CisKIDIwMTctMTEtMDkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbTGF5b3V0U3RhdGUgY2xlYW51cF0gUmVtb3ZlIHJlbmRlcmVyIGRh dGEgbWVtYmVycyBmcm9tIHN0YXRlIG1haW50YWluZXJzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9MYXlvdXRTdGF0ZS5jcHAKaW5kZXggNTM0ZTgxMGM3MmVjMGQxNmMxMWM4OTE1YTJjZGVlZWU5 YzllYTEwMi4uZDg4N2I5MmIzNTA2ZTRhYzg1YTgwNTZhMDUzMDcyMDFlMGQ3OGY0MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuY3BwCkBAIC0yNzYsNyArMjc2LDkgQEAg TGF5b3V0U3RhdGVNYWludGFpbmVyOjpMYXlvdXRTdGF0ZU1haW50YWluZXIoUmVuZGVyQm94JiBy b290LCBMYXlvdXRTaXplIG9mZnNldCwKICAgICA6IG1fY29udGV4dChyb290LnZpZXcoKS5mcmFt ZVZpZXcoKS5sYXlvdXRDb250ZXh0KCkpCiAgICAgLCBtX3BhaW50T2Zmc2V0Q2FjaGVJc0Rpc2Fi bGVkKGRpc2FibGVQYWludE9mZnNldENhY2hlKQogewotICAgIHB1c2gocm9vdCwgb2Zmc2V0LCBw YWdlSGVpZ2h0LCBwYWdlSGVpZ2h0Q2hhbmdlZCk7CisgICAgbV9kaWRQdXNoTGF5b3V0U3RhdGUg PSBtX2NvbnRleHQucHVzaExheW91dFN0YXRlKHJvb3QsIG9mZnNldCwgcGFnZUhlaWdodCwgcGFn ZUhlaWdodENoYW5nZWQpOworICAgIGlmIChtX2RpZFB1c2hMYXlvdXRTdGF0ZSAmJiBtX3BhaW50 T2Zmc2V0Q2FjaGVJc0Rpc2FibGVkKQorICAgICAgICBtX2NvbnRleHQuZGlzYWJsZVBhaW50T2Zm c2V0Q2FjaGUoKTsKIH0KIAogTGF5b3V0U3RhdGVNYWludGFpbmVyOjpMYXlvdXRTdGF0ZU1haW50 YWluZXIoTGF5b3V0Q29udGV4dCYgY29udGV4dCkKQEAgLTI4NiwzMCArMjg4LDE1IEBAIExheW91 dFN0YXRlTWFpbnRhaW5lcjo6TGF5b3V0U3RhdGVNYWludGFpbmVyKExheW91dENvbnRleHQmIGNv bnRleHQpCiAKIExheW91dFN0YXRlTWFpbnRhaW5lcjo6fkxheW91dFN0YXRlTWFpbnRhaW5lcigp CiB7Ci0gICAgLy8gRklYTUU6IFJlbW92ZSBjb25kaXRpb25hbCBwdXNoL3BvcC4KLSAgICBpZiAo bV9kaWRDYWxsUHVzaCAmJiAhbV9kaWRDYWxsUG9wKQorICAgIC8vIEZJWE1FOiBSZW1vdmUgY29u ZGl0aW9uYWwgcG9wLgorICAgIGlmICghbV9kaWRDYWxsUG9wKQogICAgICAgICBwb3AoKTsKLSAg ICBBU1NFUlQoIW1fZGlkQ2FsbFB1c2ggfHwgbV9kaWRDYWxsUHVzaCA9PSBtX2RpZENhbGxQb3Ap OwotfQotCi12b2lkIExheW91dFN0YXRlTWFpbnRhaW5lcjo6cHVzaChSZW5kZXJCb3gmIHJvb3Qs IExheW91dFNpemUgb2Zmc2V0LCBMYXlvdXRVbml0IHBhZ2VIZWlnaHQsIGJvb2wgcGFnZUhlaWdo dENoYW5nZWQpCi17Ci0gICAgQVNTRVJUKCFtX2RpZENhbGxQdXNoKTsKLSAgICBtX2RpZENhbGxQ dXNoID0gdHJ1ZTsKLSAgICAvLyBXZSBwdXNoIHN0YXRlIGV2ZW4gaWYgZGlzYWJsZWQsIGJlY2F1 c2Ugd2Ugc3RpbGwgbmVlZCB0byBzdG9yZSBsYXlvdXREZWx0YQotICAgIG1fZGlkUHVzaExheW91 dFN0YXRlID0gbV9jb250ZXh0LnB1c2hMYXlvdXRTdGF0ZShyb290LCBvZmZzZXQsIHBhZ2VIZWln aHQsIHBhZ2VIZWlnaHRDaGFuZ2VkKTsKLSAgICBpZiAoIW1fZGlkUHVzaExheW91dFN0YXRlKQot ICAgICAgICByZXR1cm47Ci0gICAgaWYgKG1fcGFpbnRPZmZzZXRDYWNoZUlzRGlzYWJsZWQpCi0g ICAgICAgIG1fY29udGV4dC5kaXNhYmxlUGFpbnRPZmZzZXRDYWNoZSgpOwogfQogCiB2b2lkIExh eW91dFN0YXRlTWFpbnRhaW5lcjo6cG9wKCkKIHsKICAgICBBU1NFUlQoIW1fZGlkQ2FsbFBvcCk7 CiAgICAgbV9kaWRDYWxsUG9wID0gdHJ1ZTsKLSAgICBpZiAoIW1fZGlkQ2FsbFB1c2gpCi0gICAg ICAgIHJldHVybjsKICAgICBpZiAoIW1fZGlkUHVzaExheW91dFN0YXRlKQogICAgICAgICByZXR1 cm47CiAgICAgbV9jb250ZXh0LnBvcExheW91dFN0YXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9MYXlvdXRTdGF0ZS5oCmluZGV4IDE3ODYyZGQ3OGI1NTQ1ZWQ2ZTY0ZDZiYjIwNjI4YmE1Mzkz YTBmNGQuLjBhNGNjZjg2ZDAzZjBiMmNjMTE0NjQ1NTA0NTlhYTI0NmJmYzc2NTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0ZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0ZS5oCkBAIC0xNDQsMTQgKzE0NCwxMSBAQCBwdWJs aWM6CiAgICAgZXhwbGljaXQgTGF5b3V0U3RhdGVNYWludGFpbmVyKExheW91dENvbnRleHQmKTsK ICAgICB+TGF5b3V0U3RhdGVNYWludGFpbmVyKCk7CiAKLSAgICB2b2lkIHB1c2goUmVuZGVyQm94 JiByb290LCBMYXlvdXRTaXplIG9mZnNldCwgTGF5b3V0VW5pdCBwYWdlSGVpZ2h0ID0gMCwgYm9v bCBwYWdlSGVpZ2h0Q2hhbmdlZCA9IGZhbHNlKTsKICAgICB2b2lkIHBvcCgpOwotICAgIGJvb2wg ZGlkUHVzaCgpIGNvbnN0IHsgcmV0dXJuIG1fZGlkQ2FsbFB1c2g7IH0KIAogcHJpdmF0ZToKICAg ICBMYXlvdXRDb250ZXh0JiBtX2NvbnRleHQ7CiAgICAgYm9vbCBtX3BhaW50T2Zmc2V0Q2FjaGVJ c0Rpc2FibGVkIHsgZmFsc2UgfTsKLSAgICBib29sIG1fZGlkQ2FsbFB1c2ggeyBmYWxzZSB9Owog ICAgIGJvb2wgbV9kaWRDYWxsUG9wIHsgZmFsc2UgfTsKICAgICBib29sIG1fZGlkUHVzaExheW91 dFN0YXRlIHsgZmFsc2UgfTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZVNlY3Rpb24uY3BwCmluZGV4IGM0Y2E1NTRkY2YwNzliNWNiZDk0MWU3NzM4MGU3MWMz NWJlN2I1MWIuLmQ3MWQ0NzM5MTNhODdjZWYyOGVjMzc5ZWJmNDc3ODljYjFkYmQ2NWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCkBAIC0y NzgsNyArMjc4LDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJUYWJsZVNlY3Rpb246OmNhbGNSb3dMb2dp Y2FsSGVpZ2h0KCkKICAgICBpZiAodGhpcyA9PSB0YWJsZSgpLT50b3BTZWN0aW9uKCkpCiAgICAg ICAgIHNwYWNpbmcgPSB0YWJsZSgpLT52Qm9yZGVyU3BhY2luZygpOwogCi0gICAgTGF5b3V0U3Rh dGVNYWludGFpbmVyIHN0YXRlUHVzaGVyKHZpZXcoKS5mcmFtZVZpZXcoKS5sYXlvdXRDb250ZXh0 KCkpOworICAgIExheW91dFN0YXRlTWFpbnRhaW5lciBzdGF0ZVB1c2hlcigqdGhpcywgbG9jYXRp b25PZmZzZXQoKSwgaGFzVHJhbnNmb3JtKCkgfHwgaGFzUmVmbGVjdGlvbigpIHx8IHN0eWxlKCku aXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSk7CiAKICAgICBtX3Jvd1Bvcy5yZXNpemUobV9n cmlkLnNpemUoKSArIDEpOwogICAgIG1fcm93UG9zWzBdID0gc3BhY2luZzsKQEAgLTMyOSwxMSAr MzI5LDYgQEAgTGF5b3V0VW5pdCBSZW5kZXJUYWJsZVNlY3Rpb246OmNhbGNSb3dMb2dpY2FsSGVp Z2h0KCkKICAgICAgICAgICAgICAgICB1bnNpZ25lZCBjZWxsU3RhcnRSb3cgPSBjZWxsLT5yb3dJ bmRleCgpOwogCiAgICAgICAgICAgICAgICAgaWYgKGNlbGwtPmhhc092ZXJyaWRlTG9naWNhbENv bnRlbnRIZWlnaHQoKSkgewotICAgICAgICAgICAgICAgICAgICBpZiAoIXN0YXRlUHVzaGVyLmRp ZFB1c2goKSkgewotICAgICAgICAgICAgICAgICAgICAgICAgLy8gVGVjaG5pY2FsbHksIHdlIHNo b3VsZCBhbHNvIHB1c2ggc3RhdGUgZm9yIHRoZSByb3csIGJ1dCBzaW5jZQotICAgICAgICAgICAg ICAgICAgICAgICAgLy8gcm93cyBkb24ndCBwdXNoIGEgY29vcmRpbmF0ZSB0cmFuc2Zvcm0sIHRo YXQncyBub3QgbmVjZXNzYXJ5LgotICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGVQdXNoZXIu cHVzaCgqdGhpcywgbG9jYXRpb25PZmZzZXQoKSk7Ci0gICAgICAgICAgICAgICAgICAgIH0KICAg ICAgICAgICAgICAgICAgICAgY2VsbC0+Y2xlYXJJbnRyaW5zaWNQYWRkaW5nKCk7CiAgICAgICAg ICAgICAgICAgICAgIGNlbGwtPmNsZWFyT3ZlcnJpZGVTaXplKCk7CiAgICAgICAgICAgICAgICAg ICAgIGNlbGwtPnNldENoaWxkTmVlZHNMYXlvdXQoTWFya09ubHlUaGlzKTsK