179488 2017-11-09 09:23:01 -0800 Fix preload/picture-type.html to address race conditions with preloader and necessary DPR test setup 2017-11-10 14:05:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 179231 P2 Normal --- 179545 1 colin webkit-unassigned achristensen commit-queue darin lforschler ryanhaddad oldest_to_newest 1369907 0 colin 2017-11-09 09:23:01 -0800 Current test http/preload/picture-type.html can fail because of race conditions from the test setup. In order to test <source sizes srcset> tags, the browser DPR must be fixed. There is a pre-existing deficiency in testRunner.setBackingScaleFactor which requires the browser to reload for the target DPR to be effective in `srcset` evaluation. This unfortunately creates test delays and a race condition with the preloader and the page reload. A less elegant solution is to adjust the `srcset` targets to account for a wide range of browser DPRs in the tests. This is adequate because this test is not testing the `srcset` evaluation logic but rather that `srcset` continues to work with the additional `type` attribute test. 1369933 1 326463 colin 2017-11-09 10:06:57 -0800 Created attachment 326463 Patch 1370353 2 ryanhaddad 2017-11-10 09:07:09 -0800 Alex, any chance that you can review this change today? 1370418 3 326463 commit-queue 2017-11-10 11:01:42 -0800 Comment on attachment 326463 Patch Clearing flags on attachment: 326463 Committed r224697: <https://trac.webkit.org/changeset/224697> 1370419 4 commit-queue 2017-11-10 11:01:44 -0800 All reviewed patches have been landed. Closing bug. 1370482 5 ryanhaddad 2017-11-10 14:00:27 -0800 The test is still a flaky failure after this change: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r224702%20(5659)/results.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/preload/picture-type-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/preload/picture-type-actual.txt @@ -1,40 +1,41 @@ -PASS internals.isPreloaded('resources/base-image1.png?0'); is true +FAIL internals.isPreloaded('resources/base-image1.png?0'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?0'); is false -PASS internals.isPreloaded('resources/base-image1.png?1'); is true +FAIL internals.isPreloaded('resources/base-image1.png?1'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?1'); is false -PASS internals.isPreloaded('resources/base-image1.png?2'); is true +FAIL internals.isPreloaded('resources/base-image1.png?2'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?2'); is false PASS internals.isPreloaded('resources/base-image1.png?3'); is false -PASS internals.isPreloaded('resources/preload-test.jpg?3'); is true +FAIL internals.isPreloaded('resources/preload-test.jpg?3'); should be true. Was false. PASS internals.isPreloaded('resources/base-image1.png?4'); is false PASS internals.isPreloaded('resources/base-image2.png?4'); is false -PASS internals.isPreloaded('resources/base-image3.png?4'); is true +FAIL internals.isPreloaded('resources/base-image3.png?4'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?4'); is false PASS internals.isPreloaded('resources/base-image1.png?5'); is false PASS internals.isPreloaded('resources/base-image2.png?5'); is false PASS internals.isPreloaded('resources/base-image3.png?5'); is false -PASS internals.isPreloaded('resources/preload-test.jpg?5'); is true -PASS internals.isPreloaded('resources/base-image1.png?6'); is true +FAIL internals.isPreloaded('resources/preload-test.jpg?5'); should be true. Was false. +FAIL internals.isPreloaded('resources/base-image1.png?6'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?6'); is false PASS internals.isPreloaded('resources/base-image1.png?7'); is false -PASS internals.isPreloaded('resources/preload-test.jpg?7'); is true -PASS internals.isPreloaded('resources/base-image1.png?8'); is true +FAIL internals.isPreloaded('resources/preload-test.jpg?7'); should be true. Was false. +FAIL internals.isPreloaded('resources/base-image1.png?8'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?8'); is false PASS internals.isPreloaded('resources/base-image1.png?9'); is false -PASS internals.isPreloaded('resources/preload-test.jpg?9'); is true -PASS internals.isPreloaded('resources/base-image1.png?10'); is true +FAIL internals.isPreloaded('resources/preload-test.jpg?9'); should be true. Was false. +FAIL internals.isPreloaded('resources/base-image1.png?10'); should be true. Was false. PASS internals.isPreloaded('resources/base-image2.png?10'); is false PASS internals.isPreloaded('resources/preload-test.jpg?10'); is false PASS internals.isPreloaded('resources/base-image1.png?11'); is false -PASS internals.isPreloaded('resources/base-image2.png?11'); is true +FAIL internals.isPreloaded('resources/base-image2.png?11'); should be true. Was false. PASS internals.isPreloaded('resources/preload-test.jpg?11'); is false -PASS internals.isPreloaded('resources/base-image1.png?12'); is true +FAIL internals.isPreloaded('resources/base-image1.png?12'); should be true. Was false. PASS internals.isPreloaded('resources/base-image2.png?12'); is false PASS internals.isPreloaded('resources/preload-test.jpg?12'); is false PASS internals.isPreloaded('resources/base-image1.png?13'); is false PASS internals.isPreloaded('resources/base-image2.png?13'); is false -PASS internals.isPreloaded('resources/preload-test.jpg?13'); is true +FAIL internals.isPreloaded('resources/preload-test.jpg?13'); should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1370484 6 ryanhaddad 2017-11-10 14:00:41 -0800 I'm going to roll it out again. 1370487 7 commit-queue 2017-11-10 14:01:47 -0800 Re-opened since this is blocked by bug 179545 1370493 8 ryanhaddad 2017-11-10 14:05:02 -0800 *** This bug has been marked as a duplicate of bug 179231 *** 326463 2017-11-09 10:06:57 -0800 2017-11-10 11:01:42 -0800 Patch bug-179488-20171109130656.patch text/plain 4085 colin U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODU4NTQ0NmY4OWEwNGU5NTI2MGVi N2ZhZTI5MmMxMjM4MDMwN2UwOC4uNmYyZmVmNzUyMzY4M2E2NzcyNzRmMTUwOTIwMjg3NTQ0NDVh MjY4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTExLTA5ICBDb2xpbiBCZW5kZWxsICA8 Y29saW5AYmVuZGVsbC5jYT4KKworICAgICAgICBGaXggcmFjZSBjb25kaXRpb25zIHdpdGggc2V0 QmFja2luZ1NjYWxlRmFjdG9yLCBwYWdlIHJlZnJlc2ggYW5kIHByZWxvYWRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NDg4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3ByZWxv YWQvcGljdHVyZS10eXBlLWV4cGVjdGVkLnR4dDogcmVtb3ZlIERQUiB0ZXN0CisgICAgICAgICog aHR0cC90ZXN0cy9wcmVsb2FkL3BpY3R1cmUtdHlwZS5odG1sOiB1cGRhdGVkIHNyY3NldCB0byBh Y2NvdW50IGZvcgorICAgICAgICB0ZXN0UnVubmVycyB3aXRoIERQUiA+IDEKKwogMjAxNy0xMS0w OSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBHYXJkZW5pbmcgMDkgbm92CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3ByZWxvYWQvcGljdHVyZS10eXBlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvcHJlbG9hZC9waWN0dXJlLXR5cGUtZXhwZWN0ZWQudHh0CmluZGV4IGQwMWE4MDVj ZjRkMTkzOGEwMzljNGM2YjFkODM3NzdjOGVkOTJlNDguLmVlM2I2ODU2NmQ2YWI5NzU4ZWY1OGIx MDY4YjI2ZjhjNjg3NzZjNjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJl bG9hZC9waWN0dXJlLXR5cGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvcHJlbG9hZC9waWN0dXJlLXR5cGUtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsMyBAQAotUEFT UyB3aW5kb3cuZGV2aWNlUGl4ZWxSYXRpbyBpcyAxCiBQQVNTIGludGVybmFscy5pc1ByZWxvYWRl ZCgncmVzb3VyY2VzL2Jhc2UtaW1hZ2UxLnBuZz8wJyk7IGlzIHRydWUKIFBBU1MgaW50ZXJuYWxz LmlzUHJlbG9hZGVkKCdyZXNvdXJjZXMvcHJlbG9hZC10ZXN0LmpwZz8wJyk7IGlzIGZhbHNlCiBQ QVNTIGludGVybmFscy5pc1ByZWxvYWRlZCgncmVzb3VyY2VzL2Jhc2UtaW1hZ2UxLnBuZz8xJyk7 IGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9waWN0 dXJlLXR5cGUuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9waWN0dXJlLXR5 cGUuaHRtbAppbmRleCBmN2M4NmI5MTk4OGQ1MWRmZThmZjNjMGFlOWQ5YTM3Zjc0ZGQwOTI5Li4x MjkxMjQwYjYwNzJkMWEyMGU2NWNkYzZiZmRmOTNhMGY1NDA1M2M2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3ByZWxvYWQvcGljdHVyZS10eXBlLmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9wcmVsb2FkL3BpY3R1cmUtdHlwZS5odG1sCkBAIC0xLDI1ICsxLDEz IEBACiA8aHRtbD4KIDxoZWFkPgotICAgIDxzY3JpcHQ+Ci0gICAgICAgIGlmICh3aW5kb3cudGVz dFJ1bm5lcikgewotICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0gICAgICAg ICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKLSAgICAgICAgICAgIHRlc3RSdW5uZXIu c2V0QmFja2luZ1NjYWxlRmFjdG9yKDEpOwotICAgICAgICAgICAgaWYgKCFzZXNzaW9uU3RvcmFn ZS5wYWdlUmVsb2FkZWQpIHsKLSAgICAgICAgICAgICAgICBzZXNzaW9uU3RvcmFnZS5wYWdlUmVs b2FkZWQgPSB0cnVlOwotICAgICAgICAgICAgICAgIC8vIGhhdmUgdG8gZm9yY2UgYSByZXN0YXJ0 IGJlY2F1c2Ugb2YgYSBidWcgaW4gZHluYW1pYyBjaGFuZ2VzIHdpdGggc3Jjc2V0Ci0gICAgICAg ICAgICAgICAgLy8gd2UgaGF2ZSB0byBmb3JjZSB0aGUgcmVzdGFydCBldmVuIGlmIERQUj0xIGZv ciBjb25zaXN0ZW5jeQotICAgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkge2RvY3Vt ZW50LmxvY2F0aW9uLnJlbG9hZCh0cnVlKX0sIDApOwotICAgICAgICAgICAgfQotICAgICAgICB9 Ci0gICAgPC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy9qcy10 ZXN0LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iaHR0cDovLzEyNy4wLjAuMTo4MDAw L3Jlc291cmNlcy9zbG93LXNjcmlwdC5wbD9kZWxheT0xMDAiPjwvc2NyaXB0PgogPC9oZWFkPgog PGJvZHk+CiA8c2NyaXB0PgogICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciAmJiB3aW5kb3cuaW50 ZXJuYWxzKSB7Ci0gICAgICAgIHNob3VsZEJlKCJ3aW5kb3cuZGV2aWNlUGl4ZWxSYXRpbyIsICIx Iik7CisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCiAgICAgICAgIHNob3VsZEJl VHJ1ZSgiaW50ZXJuYWxzLmlzUHJlbG9hZGVkKCdyZXNvdXJjZXMvYmFzZS1pbWFnZTEucG5nPzAn KTsiKTsKICAgICAgICAgc2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmlzUHJlbG9hZGVkKCdyZXNv dXJjZXMvcHJlbG9hZC10ZXN0LmpwZz8wJyk7Iik7CiAgICAgICAgIHNob3VsZEJlVHJ1ZSgiaW50 ZXJuYWxzLmlzUHJlbG9hZGVkKCdyZXNvdXJjZXMvYmFzZS1pbWFnZTEucG5nPzEnKTsiKTsKQEAg LTY1LDkgKzUzLDYgQEAKICAgICAgICAgc2hvdWxkQmVGYWxzZSgiaW50ZXJuYWxzLmlzUHJlbG9h ZGVkKCdyZXNvdXJjZXMvYmFzZS1pbWFnZTEucG5nPzEzJyk7Iik7CiAgICAgICAgIHNob3VsZEJl RmFsc2UoImludGVybmFscy5pc1ByZWxvYWRlZCgncmVzb3VyY2VzL2Jhc2UtaW1hZ2UyLnBuZz8x MycpOyIpOwogICAgICAgICBzaG91bGRCZVRydWUoImludGVybmFscy5pc1ByZWxvYWRlZCgncmVz b3VyY2VzL3ByZWxvYWQtdGVzdC5qcGc/MTMnKTsiKTsKLQotICAgICAgICBkZWxldGUgc2Vzc2lv blN0b3JhZ2UucGFnZVJlbG9hZGVkOwotICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK ICAgICB9CiA8L3NjcmlwdD4KIDwhLS0gQ29udHJvbCBncm91cCAtLT4KQEAgLTkwLDExICs3NSwx MSBAQAogICAgIDxpbWcgc3JjPSJyZXNvdXJjZXMvcHJlbG9hZC10ZXN0LmpwZz8zIj4KIDwvcGlj dHVyZT4KIDxwaWN0dXJlPgotICAgIDxzb3VyY2UgdHlwZT0iaW1hZ2UvcG5nIiBzaXplcz0iNDAw cHgiIHNyY3NldD0icmVzb3VyY2VzL2Jhc2UtaW1hZ2UxLnBuZz80IDIwMHcsIHJlc291cmNlcy9i YXNlLWltYWdlMy5wbmc/NCA0MDB3LCByZXNvdXJjZXMvYmFzZS1pbWFnZTIucG5nPzQgODAwdyI+ CisgICAgPHNvdXJjZSB0eXBlPSJpbWFnZS9wbmciIHNpemVzPSIyMDBweCIgc3Jjc2V0PSJyZXNv dXJjZXMvYmFzZS1pbWFnZTEucG5nPzQgMTAwdywgcmVzb3VyY2VzL2Jhc2UtaW1hZ2UzLnBuZz80 IDgwMHcsIHJlc291cmNlcy9iYXNlLWltYWdlMi5wbmc/NCAxMDAwdyI+CiAgICAgPGltZyBzcmM9 InJlc291cmNlcy9wcmVsb2FkLXRlc3QuanBnPzQiPgogPC9waWN0dXJlPgogPHBpY3R1cmU+Ci0g ICAgPHNvdXJjZSB0eXBlPSJpbWFnZS9iYWQiIHNpemVzPSI0MDBweCIgc3Jjc2V0PSJyZXNvdXJj ZXMvYmFzZS1pbWFnZTEucG5nPzUgMjAwdywgcmVzb3VyY2VzL2Jhc2UtaW1hZ2UzLnBuZz81IDQw MHcsIHJlc291cmNlcy9iYXNlLWltYWdlMi5wbmc/NSA4MDB3IiA+CisgICAgPHNvdXJjZSB0eXBl PSJpbWFnZS9iYWQiIHNpemVzPSIyMDBweCIgc3Jjc2V0PSJyZXNvdXJjZXMvYmFzZS1pbWFnZTEu cG5nPzUgMTAwdywgcmVzb3VyY2VzL2Jhc2UtaW1hZ2UzLnBuZz81IDgwMHcsIHJlc291cmNlcy9i YXNlLWltYWdlMi5wbmc/NSAxMDAwdyIgPgogICAgIDxpbWcgc3JjPSJyZXNvdXJjZXMvcHJlbG9h ZC10ZXN0LmpwZz81Ij4KIDwvcGljdHVyZT4KIDxwaWN0dXJlPgo=