179486 2017-11-09 09:13:43 -0800 ServiceWorker ResourceResponse should not assert in platformCertificateInfo() 2017-11-15 09:39:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue sam webkit-bug-importer oldest_to_newest 1369899 0 youennf 2017-11-09 09:13:43 -0800 ServiceWorker ResourceResponse should not assert in platformCertificateInfo() 1369900 1 326455 youennf 2017-11-09 09:16:02 -0800 Created attachment 326455 Patch 1369970 2 326455 sam 2017-11-09 11:07:14 -0800 Comment on attachment 326455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326455&action=review > Source/WebCore/ChangeLog:10 > + In that case, platformCertificateInfo should return std::nullopt. platformCertificateInfo doesn't return an optional, so I don't think this makes sense. It just returns a default constructed CertificateInfo. 1369997 3 326473 youennf 2017-11-09 11:48:02 -0800 Created attachment 326473 Patch 1370021 4 326473 commit-queue 2017-11-09 12:58:19 -0800 Comment on attachment 326473 Patch Clearing flags on attachment: 326473 Committed r224644: <https://trac.webkit.org/changeset/224644> 1370022 5 commit-queue 2017-11-09 12:58:20 -0800 All reviewed patches have been landed. Closing bug. 1371942 6 webkit-bug-importer 2017-11-15 09:39:22 -0800 <rdar://problem/35562166> 326455 2017-11-09 09:16:02 -0800 2017-11-09 11:48:01 -0800 Patch bug-179486-20171109091601.patch text/plain 1831 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE3NmZlODFhYjVhODcx M2RkNDhjMWRjY2EyYzY1YmVhZTNhZDkzZS4uM2U2N2NjODg0MzI3ZDU3MDgwMTg5OWYxMDdmZjMx Y2IwZTZiZTU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTExLTA5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTZXJ2aWNlV29ya2VyIFJl c291cmNlUmVzcG9uc2Ugc2hvdWxkIG5vdCBhc3NlcnQgaW4gcGxhdGZvcm1DZXJ0aWZpY2F0ZUlu Zm8oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5 NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g Y2hhbmdlIG9mIGJlaGF2aW9yLgorICAgICAgICBJbiBjYXNlIGEgUmVzcG9uc2UgaXMgcmV0dXJu ZWQgYnkgU2VydmljZSBXb3JrZXIsIHRoZXJlIG1heSBiZSBubyByZWxhdGVkIGludGVybmFsIHJl c3BvbnNlLgorICAgICAgICBJbiB0aGF0IGNhc2UsIHBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvIHNo b3VsZCByZXR1cm4gc3RkOjpudWxsb3B0LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9j b2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJj ZVJlc3BvbnNlOjpwbGF0Zm9ybUNlcnRpZmljYXRlSW5mbyBjb25zdCk6CisKIDIwMTctMTEtMDkg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTGF5b3V0U3RhdGUg Y2xlYW51cF0gQWRkIHBhZ2luYXRpb24gcGFyYW1ldGVyIHRvIHN1YnRyZWUgTGF5b3V0U3RhdGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3Vy Y2VSZXNwb25zZUNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2Nv YS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KaW5kZXggZTUzODFhMTEzODdiNDA5ZDgwMDUzMjI1 OGVkZmQzYmM1MmM5ODQ4OC4uNjk2OTIwMDFhNWFlNGU0ZmJiYmNlMzQwMzgxYjNlOTE3MTc5Y2Nj MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNv dXJjZVJlc3BvbnNlQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0KQEAgLTc2LDEwICs3NiwxMCBAQCB2b2lk IFJlc291cmNlUmVzcG9uc2U6OmRpc2FibGVMYXp5SW5pdGlhbGl6YXRpb24oKQogQ2VydGlmaWNh dGVJbmZvIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvKCkgY29uc3QK IHsKICNpZiBVU0UoQ0ZVUkxDT05ORUNUSU9OKQotICAgIEFTU0VSVChtX2NmUmVzcG9uc2UpOwor ICAgIEFTU0VSVChtX2NmUmVzcG9uc2UgfHwgc291cmNlKCkgPT0gU291cmNlOjpTZXJ2aWNlV29y a2VyKTsKICAgICBDRlVSTFJlc3BvbnNlUmVmIGNmUmVzcG9uc2UgPSBtX2NmUmVzcG9uc2UuZ2V0 KCk7CiAjZWxzZQotICAgIEFTU0VSVChtX25zUmVzcG9uc2UpOworICAgIEFTU0VSVChtX25zUmVz cG9uc2UgfHwgc291cmNlKCkgPT0gU291cmNlOjpTZXJ2aWNlV29ya2VyKTsKICAgICBDRlVSTFJl c3BvbnNlUmVmIGNmUmVzcG9uc2UgPSBbbV9uc1Jlc3BvbnNlIF9DRlVSTFJlc3BvbnNlXTsKICNl bmRpZgogCg== 326473 2017-11-09 11:48:02 -0800 2017-11-09 12:58:19 -0800 Patch bug-179486-20171109114801.patch text/plain 1886 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU3N2VhNWIxMDY2OWQ3 NmFiODdhZGVlOTIxNTk5MzZhMWMxOTFlZC4uOGE4MzI5NTdmODU4ZGNmNWM4MDYxNTE2MDFhMTA0 MzU2NjlkMWIxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTExLTA5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBTZXJ2aWNlV29ya2VyIFJl c291cmNlUmVzcG9uc2Ugc2hvdWxkIG5vdCBhc3NlcnQgaW4gcGxhdGZvcm1DZXJ0aWZpY2F0ZUlu Zm8oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5 NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g Y2hhbmdlIG9mIGJlaGF2aW9yLgorICAgICAgICBJbiBjYXNlIGEgUmVzcG9uc2UgaXMgcmV0dXJu ZWQgYnkgU2VydmljZSBXb3JrZXIsIHRoZXJlIG1heSBiZSBubyByZWxhdGVkIGludGVybmFsIHJl c3BvbnNlLgorICAgICAgICBJbiB0aGF0IGNhc2UsIHBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvIGlz IHJldHVybmluZyBhbiBlbXB0eSBDZXJ0aWZpY2F0ZUluZm8uCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2NvY29hL1Jlc291cmNlUmVzcG9uc2VDb2NvYS5tbToKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvIGNvbnN0KToKKwor MjAxNy0xMS0wOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKICAgICAgICAg QWRkIHN1cHBvcnQgZm9yIHNlcnZpY2Ugd29ya2VyIGdlbmVyYXRlZCByZWRpcmVjdGlvbnMKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTQ5OAogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291cmNl UmVzcG9uc2VDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2Ev UmVzb3VyY2VSZXNwb25zZUNvY29hLm1tCmluZGV4IGU1MzgxYTExMzg3YjQwOWQ4MDA1MzIyNThl ZGZkM2JjNTJjOTg0ODguLjY5NjkyMDAxYTVhZTRlNGZiYmJjZTM0MDM4MWIzZTkxNzE3OWNjYzIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3Vy Y2VSZXNwb25zZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y29jb2EvUmVzb3VyY2VSZXNwb25zZUNvY29hLm1tCkBAIC03NiwxMCArNzYsMTAgQEAgdm9pZCBS ZXNvdXJjZVJlc3BvbnNlOjpkaXNhYmxlTGF6eUluaXRpYWxpemF0aW9uKCkKIENlcnRpZmljYXRl SW5mbyBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNlcnRpZmljYXRlSW5mbygpIGNvbnN0CiB7 CiAjaWYgVVNFKENGVVJMQ09OTkVDVElPTikKLSAgICBBU1NFUlQobV9jZlJlc3BvbnNlKTsKKyAg ICBBU1NFUlQobV9jZlJlc3BvbnNlIHx8IHNvdXJjZSgpID09IFNvdXJjZTo6U2VydmljZVdvcmtl cik7CiAgICAgQ0ZVUkxSZXNwb25zZVJlZiBjZlJlc3BvbnNlID0gbV9jZlJlc3BvbnNlLmdldCgp OwogI2Vsc2UKLSAgICBBU1NFUlQobV9uc1Jlc3BvbnNlKTsKKyAgICBBU1NFUlQobV9uc1Jlc3Bv bnNlIHx8IHNvdXJjZSgpID09IFNvdXJjZTo6U2VydmljZVdvcmtlcik7CiAgICAgQ0ZVUkxSZXNw b25zZVJlZiBjZlJlc3BvbnNlID0gW21fbnNSZXNwb25zZSBfQ0ZVUkxSZXNwb25zZV07CiAjZW5k aWYKIAo=