179484 2017-11-09 09:03:06 -0800 [LayoutState cleanup] LayoutState::m_lineGrid should be a weak pointer 2017-11-09 10:22:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue darin koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1369890 0 zalan 2017-11-09 09:03:06 -0800 ssia. 1369891 1 webkit-bug-importer 2017-11-09 09:04:15 -0800 <rdar://problem/35442725> 1369898 2 326454 zalan 2017-11-09 09:13:00 -0800 Created attachment 326454 Patch 1369906 3 326454 darin 2017-11-09 09:22:36 -0800 Comment on attachment 326454 Patch Didn’t need to add any null checks? 1369928 4 zalan 2017-11-09 10:02:40 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 326454 [details] > Patch > > Didn’t need to add any null checks? We already check for null on m_lineGrid. 1369937 5 326454 commit-queue 2017-11-09 10:22:01 -0800 Comment on attachment 326454 Patch Clearing flags on attachment: 326454 Committed r224632: <https://trac.webkit.org/changeset/224632> 1369938 6 commit-queue 2017-11-09 10:22:03 -0800 All reviewed patches have been landed. Closing bug. 326454 2017-11-09 09:13:00 -0800 2017-11-09 10:22:01 -0800 Patch bug-179484-20171109091259.patch text/plain 4233 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE3NmZlODFhYjVhODcx M2RkNDhjMWRjY2EyYzY1YmVhZTNhZDkzZS4uMzJlMThjMTIxNzIyNGY3MzI5NDBlNWJlOTZhYjcy Y2EwODNlNmYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTExLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xheW91dFN0YXRlIGNsZWFu dXBdIExheW91U3RhdGU6Om1fbGluZUdyaWQgc2hvdWxkIGJlIGEgd2VhayBwb2ludGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0ODQKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzM1NDQyNzI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvTGF5b3V0U3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 U3RhdGU6OnByb3BhZ2F0ZUxpbmVHcmlkSW5mbyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRT dGF0ZTo6ZXN0YWJsaXNoTGluZUdyaWQpOgorICAgICAgICAqIHJlbmRlcmluZy9MYXlvdXRTdGF0 ZS5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0U3RhdGU6OmxpbmVHcmlkIGNvbnN0KToKKwog MjAxNy0xMS0wOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM YXlvdXRTdGF0ZSBjbGVhbnVwXSBBZGQgcGFnaW5hdGlvbiBwYXJhbWV0ZXIgdG8gc3VidHJlZSBM YXlvdXRTdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheW91dFN0 YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0ZS5jcHAKaW5kZXgg ZDQzMDYyNjgxNWIwZjE5N2FmMWUwMmNlMGJmZDBjZjVkODJiZmMzNS4uYzIxM2FlMmM3OTg2ZDJm NjUxMjAzOTFhNDZmOGNjZTgyZjYxYzA0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL0xheW91dFN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5 b3V0U3RhdGUuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIK ICNpbmNsdWRlICJSZW5kZXJNdWx0aUNvbHVtbkZsb3cuaCIKICNpbmNsdWRlICJSZW5kZXJWaWV3 LmgiCisjaW5jbHVkZSA8d3RmL1dlYWtQdHIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBA IC0yMjMsNyArMjI0LDcgQEAgdm9pZCBMYXlvdXRTdGF0ZTo6cHJvcGFnYXRlTGluZUdyaWRJbmZv KGNvbnN0IExheW91dFN0YXRlJiBhbmNlc3RvciwgUmVuZGVyQm94JgogICAgIGlmIChyZW5kZXJl ci5pc1Vuc3BsaXR0YWJsZUZvclBhZ2luYXRpb24oKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg bV9saW5lR3JpZCA9IGFuY2VzdG9yLmxpbmVHcmlkKCk7CisgICAgbV9saW5lR3JpZCA9IG1ha2VX ZWFrUHRyKGFuY2VzdG9yLmxpbmVHcmlkKCkpOwogICAgIG1fbGluZUdyaWRPZmZzZXQgPSBhbmNl c3Rvci5saW5lR3JpZE9mZnNldCgpOwogICAgIG1fbGluZUdyaWRQYWdpbmF0aW9uT3JpZ2luID0g YW5jZXN0b3IubGluZUdyaWRQYWdpbmF0aW9uT3JpZ2luKCk7CiB9CkBAIC0yMzQsMTYgKzIzNSwx NiBAQCB2b2lkIExheW91dFN0YXRlOjplc3RhYmxpc2hMaW5lR3JpZChjb25zdCBMYXlvdXRDb250 ZXh0OjpMYXlvdXRTdGF0ZVN0YWNrJiBsYXlvdQogICAgIGlmIChtX2xpbmVHcmlkKSB7CiAgICAg ICAgIGlmIChtX2xpbmVHcmlkLT5zdHlsZSgpLmxpbmVHcmlkKCkgPT0gcmVuZGVyZXIuc3R5bGUo KS5saW5lR3JpZCgpKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBSZW5kZXJCbG9ja0Zs b3cqIGN1cnJlbnRHcmlkID0gbV9saW5lR3JpZDsKKyAgICAgICAgYXV0byogY3VycmVudEdyaWQg PSBtX2xpbmVHcmlkLmdldCgpOwogICAgICAgICBmb3IgKGludCBpID0gbGF5b3V0U3RhdGVTdGFj ay5zaXplKCkgLSAxOyBpIDw9IDA7IC0taSkgewogICAgICAgICAgICAgYXV0byYgY3VycmVudFN0 YXRlID0gKmxheW91dFN0YXRlU3RhY2tbaV0uZ2V0KCk7CiAgICAgICAgICAgICBpZiAoY3VycmVu dFN0YXRlLm1fbGluZUdyaWQgPT0gY3VycmVudEdyaWQpCiAgICAgICAgICAgICAgICAgY29udGlu dWU7Ci0gICAgICAgICAgICBjdXJyZW50R3JpZCA9IGN1cnJlbnRTdGF0ZS5tX2xpbmVHcmlkOwor ICAgICAgICAgICAgY3VycmVudEdyaWQgPSBjdXJyZW50U3RhdGUubGluZUdyaWQoKTsKICAgICAg ICAgICAgIGlmICghY3VycmVudEdyaWQpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICBpZiAoY3VycmVudEdyaWQtPnN0eWxlKCkubGluZUdyaWQoKSA9PSByZW5kZXJlci5zdHls ZSgpLmxpbmVHcmlkKCkpIHsKLSAgICAgICAgICAgICAgICBtX2xpbmVHcmlkID0gY3VycmVudEdy aWQ7CisgICAgICAgICAgICAgICAgbV9saW5lR3JpZCA9IG1ha2VXZWFrUHRyKGN1cnJlbnRHcmlk KTsKICAgICAgICAgICAgICAgICBtX2xpbmVHcmlkT2Zmc2V0ID0gY3VycmVudFN0YXRlLm1fbGlu ZUdyaWRPZmZzZXQ7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQpAQCAt MjUxLDcgKzI1Miw3IEBAIHZvaWQgTGF5b3V0U3RhdGU6OmVzdGFibGlzaExpbmVHcmlkKGNvbnN0 IExheW91dENvbnRleHQ6OkxheW91dFN0YXRlU3RhY2smIGxheW91CiAgICAgfQogICAgIAogICAg IC8vIFdlIGRpZG4ndCBmaW5kIGFuIGFscmVhZHktZXN0YWJsaXNoZWQgZ3JpZCB3aXRoIHRoaXMg aWRlbnRpZmllci4gT3VyIHJlbmRlciBvYmplY3QgZXN0YWJsaXNoZXMgdGhlIGdyaWQuCi0gICAg bV9saW5lR3JpZCA9ICZyZW5kZXJlcjsKKyAgICBtX2xpbmVHcmlkID0gbWFrZVdlYWtQdHIocmVu ZGVyZXIpOwogICAgIG1fbGluZUdyaWRPZmZzZXQgPSBtX2xheW91dE9mZnNldDsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmggYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuaAppbmRleCA2YzJmODRmZTEzNzJjNTNlMDU2 MTY4Y2NlYWQ2NWNjY2Y4ZDNjZGRmLi4zMTMwODRlZDVjYTdhZmQ1NjM0YjUyMjhkNTZhMTA0OGYx NTFkZTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuaApAQCAtNjYsNyAr NjYsNyBAQCBwdWJsaWM6CiAgICAgTGF5b3V0VW5pdCBwYWdlTG9naWNhbEhlaWdodCgpIGNvbnN0 IHsgcmV0dXJuIG1fcGFnZUxvZ2ljYWxIZWlnaHQ7IH0KICAgICBib29sIHBhZ2VMb2dpY2FsSGVp Z2h0Q2hhbmdlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkOyB9 CiAKLSAgICBSZW5kZXJCbG9ja0Zsb3cqIGxpbmVHcmlkKCkgY29uc3QgeyByZXR1cm4gbV9saW5l R3JpZDsgfQorICAgIFJlbmRlckJsb2NrRmxvdyogbGluZUdyaWQoKSBjb25zdCB7IHJldHVybiBt X2xpbmVHcmlkLmdldCgpOyB9CiAgICAgTGF5b3V0U2l6ZSBsaW5lR3JpZE9mZnNldCgpIGNvbnN0 IHsgcmV0dXJuIG1fbGluZUdyaWRPZmZzZXQ7IH0KICAgICBMYXlvdXRTaXplIGxpbmVHcmlkUGFn aW5hdGlvbk9yaWdpbigpIGNvbnN0IHsgcmV0dXJuIG1fbGluZUdyaWRQYWdpbmF0aW9uT3JpZ2lu OyB9CiAKQEAgLTEwOCw3ICsxMDgsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9sYXlvdXREZWx0 YVlTYXR1cmF0ZWQgOiAxOwogI2VuZGlmCiAgICAgLy8gVGhlIGN1cnJlbnQgbGluZSBncmlkIHRo YXQgd2UncmUgc25hcHBpbmcgdG8gYW5kIHRoZSBvZmZzZXQgb2YgdGhlIHN0YXJ0IG9mIHRoZSBn cmlkLgotICAgIFJlbmRlckJsb2NrRmxvdyogbV9saW5lR3JpZCB7IG51bGxwdHIgfTsKKyAgICBX ZWFrUHRyPFJlbmRlckJsb2NrRmxvdz4gbV9saW5lR3JpZDsKIAogICAgIC8vIEZJWE1FOiBEaXN0 aW5ndWlzaCBiZXR3ZWVuIHRoZSBsYXlvdXQgY2xpcCByZWN0IGFuZCB0aGUgcGFpbnQgY2xpcCBy ZWN0IHdoaWNoIG1heSBiZSBsYXJnZXIsCiAgICAgLy8gZS5nLiwgYmVjYXVzZSBvZiBjb21wb3Np dGVkIHNjcm9sbGluZy4K