<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179478</bug_id>
          
          <creation_ts>2017-11-09 07:44:48 -0800</creation_ts>
          <short_desc>[JSC] Optimize default constructor implementation for derived class with array iterator protocol check</short_desc>
          <delta_ts>2017-11-09 08:28:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>178064</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1369867</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-11-09 07:44:48 -0800</bug_when>
    <thetext>Current default constructor implementation for derived class is,

constructor(...args)
{
    super(...args);
}

But the above code allocates arrays until FTL while that is apparently unnecessary for many cases.
It makes super() call construct_varargs with opaque array... Which is not good since DFGByteCodeParser do not handle it well if the constructor is non JS.
So, extends Array case is not optimized well in this case.

We would like to explore the performance improvement by changing this to

constructor(...args)
{
    if (@isArrayIteratorProtocolFastAndNonObservable()) {
        @superForwardArguments();
        return;
    }
    super(@spread());
}</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>