179471 2017-11-09 03:13:13 -0800 REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests. 2017-11-12 23:41:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179419 P2 Normal --- 179317 1 clopez webkit-unassigned bburg bugs-noreply cgarcia darin joepeck mcatanzaro oldest_to_newest 1369837 0 clopez 2017-11-09 03:13:13 -0800 Revision r224566 <https://trac.webkit.org/r224566> caused ~26 unexpected inspector related test timeouts Regressions: Unexpected timeouts (26) inspector/console/console-message.html [ Timeout ] inspector/console/console-time.html [ Timeout ] inspector/console/heapSnapshot.html [ Timeout ] inspector/console/js-source-locations.html [ Timeout ] inspector/console/x-frame-options-message.html [ Timeout ] inspector/heap/tracking.html [ Timeout ] inspector/layers/layers-anonymous.html [ Timeout ] inspector/layers/layers-blending-compositing-reasons.html [ Timeout ] inspector/layers/layers-compositing-reasons.html [ Timeout ] inspector/layers/layers-for-node.html [ Timeout ] inspector/layers/layers-generated-content.html [ Timeout ] inspector/layers/layers-reflected-content.html [ Timeout ] inspector/memory/tracking.html [ Timeout ] inspector/page/media-query-list-listener-exception.html [ Timeout ] inspector/protocol/backend-dispatcher-argument-errors.html [ Timeout ] inspector/protocol/backend-dispatcher-malformed-message-errors.html [ Timeout ] inspector/runtime/CommandLineAPI-inspect.html [ Timeout ] inspector/script-profiler/event-type-API.html [ Timeout ] inspector/script-profiler/event-type-Microtask.html [ Timeout ] inspector/script-profiler/event-type-Other.html [ Timeout ] inspector/script-profiler/tracking.html [ Timeout ] inspector/unit-tests/async-test-suite.html [ Timeout ] inspector/unit-tests/protocol-test-dispatch-event-to-frontend.html [ Timeout ] inspector/unit-tests/sync-test-suite.html [ Timeout ] inspector/worker/worker-create-and-terminate.html [ Timeout ] inspector/worker/worker-recover-if-inspector-close.html [ Timeout ] I have double checked this by reverting r224566 locally (this test pass with this reverted) 1370271 1 326568 cgarcia 2017-11-10 00:51:56 -0800 Created attachment 326568 Patch 1370283 2 326568 clopez 2017-11-10 04:48:55 -0800 Comment on attachment 326568 Patch From my un-expertise on the webinspector, the patch looks fine ... However I wonder why this (as well as bug 179419 which was fixed with a very similar patch) is not happening on the Mac port??? It will be helpful if someone with more expertise in this code can review it. 1370392 3 326568 bburg 2017-11-10 10:00:14 -0800 Comment on attachment 326568 Patch r=me as well, I'm not sure that TestStub was minified before for Mac, but I guess there is no harm in it. 1370851 4 cgarcia 2017-11-12 23:41:26 -0800 Committed r224745: <https://trac.webkit.org/changeset/224745> 326568 2017-11-10 00:51:56 -0800 2017-11-10 09:37:37 -0800 Patch wk-inspector-test.diff text/plain 5438 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMjk5Y2U2YzA1ZC4uMTBhMDgxNTFmYjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNy0xMS0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMjI0NTY2KTogW0dUS10gMjYgbmV3IHRpbWVvdXRzIG9uIGlu c3BlY3RvciByZWxhdGVkIHRlc3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc5NDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVW5za2lwIHRlc3RzIHRoYXQgYXJlIHBhc3Npbmcgbm93LgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTctMTEtMDkgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTZXJ2aWNlV29ya2VyUmVnaXN0 cmF0aW9uIG9iamVjdHMgbWF5IGdldCByZWN5Y2xlZCBmb3IgZGlmZmVyZW50IFNXU2VydmVyUmVn aXN0cmF0aW9uIG9iamVjdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggNTdiYWMzODhjMDEuLmY0YWI3ODg3Mjk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjIwMSwzMyArMjIwMSw2IEBAIHdlYmtpdC5vcmcv Yi8xNzg0NTQgZWRpdGluZy9wYXN0ZWJvYXJkL2RhdGF0cmFuc2Zlci1pdGVtcy1wYXN0ZS1wbGFp bnRleHQuaHRtbCBbCiAKIHdlYmtpdC5vcmcvYi8xNzg3OTIgZmFzdC9ldmVudHMvdG91Y2gvdG91 Y2gtaW5zaWRlLWlmcmFtZS5odG1sIFsgVGltZW91dCBdCiAKLXdlYmtpdC5vcmcvYi8xNzk0NzEg aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1tZXNzYWdlLmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtp dC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS10aW1lLmh0bWwgWyBUaW1l b3V0IF0KLXdlYmtpdC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL2NvbnNvbGUvaGVhcFNuYXBzaG90 Lmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL2NvbnNvbGUv anMtc291cmNlLWxvY2F0aW9ucy5odG1sIFsgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTc5NDcx IGluc3BlY3Rvci9jb25zb2xlL3gtZnJhbWUtb3B0aW9ucy1tZXNzYWdlLmh0bWwgWyBUaW1lb3V0 IF0KLXdlYmtpdC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL2hlYXAvdHJhY2tpbmcuaHRtbCBbIFRp bWVvdXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvbGF5ZXJzL2xheWVycy1hbm9u eW1vdXMuaHRtbCBbIFRpbWVvdXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvbGF5 ZXJzL2xheWVycy1jb21wb3NpdGluZy1yZWFzb25zLmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5v cmcvYi8xNzk0NzEgaW5zcGVjdG9yL2xheWVycy9sYXllcnMtZm9yLW5vZGUuaHRtbCBbIFRpbWVv dXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvbGF5ZXJzL2xheWVycy1nZW5lcmF0 ZWQtY29udGVudC5odG1sIFsgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rv ci9sYXllcnMvbGF5ZXJzLXJlZmxlY3RlZC1jb250ZW50Lmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtp dC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL21lbW9yeS90cmFja2luZy5odG1sIFsgVGltZW91dCBd Ci13ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rvci9wYWdlL21lZGlhLXF1ZXJ5LWxpc3QtbGlz dGVuZXItZXhjZXB0aW9uLmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8xNzk0NzEgaW5z cGVjdG9yL3Byb3RvY29sL2JhY2tlbmQtZGlzcGF0Y2hlci1hcmd1bWVudC1lcnJvcnMuaHRtbCBb IFRpbWVvdXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvcHJvdG9jb2wvYmFja2Vu ZC1kaXNwYXRjaGVyLW1hbGZvcm1lZC1tZXNzYWdlLWVycm9ycy5odG1sIFsgVGltZW91dCBdCi13 ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rvci9ydW50aW1lL0NvbW1hbmRMaW5lQVBJLWluc3Bl Y3QuaHRtbCBbIFRpbWVvdXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3Ivc2NyaXB0 LXByb2ZpbGVyL2V2ZW50LXR5cGUtQVBJLmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8x Nzk0NzEgaW5zcGVjdG9yL3NjcmlwdC1wcm9maWxlci9ldmVudC10eXBlLU1pY3JvdGFzay5odG1s IFsgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rvci9zY3JpcHQtcHJvZmls ZXIvZXZlbnQtdHlwZS1PdGhlci5odG1sIFsgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTc5NDcx IGluc3BlY3Rvci9zY3JpcHQtcHJvZmlsZXIvdHJhY2tpbmcuaHRtbCBbIFRpbWVvdXQgXQotd2Vi a2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvdW5pdC10ZXN0cy9hc3luYy10ZXN0LXN1aXRlLmh0 bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8xNzk0NzEgaW5zcGVjdG9yL3VuaXQtdGVzdHMv cHJvdG9jb2wtdGVzdC1kaXNwYXRjaC1ldmVudC10by1mcm9udGVuZC5odG1sIFsgVGltZW91dCBd Ci13ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rvci91bml0LXRlc3RzL3N5bmMtdGVzdC1zdWl0 ZS5odG1sIFsgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTc5NDcxIGluc3BlY3Rvci93b3JrZXIv d29ya2VyLWNyZWF0ZS1hbmQtdGVybWluYXRlLmh0bWwgWyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcv Yi8xNzk0NzEgaW5zcGVjdG9yL3dvcmtlci93b3JrZXItcmVjb3Zlci1pZi1pbnNwZWN0b3ItY2xv c2UuaHRtbCBbIFRpbWVvdXQgXQotd2Via2l0Lm9yZy9iLzE3OTQ3MSBpbnNwZWN0b3IvdW5pdC10 ZXN0cy9icmVha3BvaW50LWxvZy1tZXNzYWdlLWxleGVyLmh0bWwgWyBUaW1lb3V0IF0KLQogIy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFRlc3RzIHRpbWluZyBvdXQK ICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpp bmRleCBjYzdkY2EyY2IyZC4uMWQ3NDQ5ZjNlOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDE3LTExLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjQ1NjYpOiBbR1RLXSAyNiBu ZXcgdGltZW91dHMgb24gaW5zcGVjdG9yIHJlbGF0ZWQgdGVzdHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0NzEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0U3R1Yi5odG1sIGFuZCBUZXN0U3R1 Yi5qcyB3YXMgbWlzc2luZyBpbiByZXNvdXJjZXMgYnVuZGxlLgorCisgICAgICAgICogU2NyaXB0 cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy5wbDogQWxzbyBjb21iaW5lIHJlc291cmNl cyBmb3IgVGVzdFN0dWIuCisKIDIwMTctMTEtMDkgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHll dkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzIFJlZGVzaWduOiBj bGlja2luZyBvbiBpbmxpbmUgc3dhdGNoZXMgYW5kIHByb3BlcnR5IGNoZWNrYm94ZXMgc2hvdWxk IG5vdCBhZGQgYSBuZXcgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9TY3JpcHRzL2NvcHktdXNlci1pbnRlcmZhY2UtcmVzb3VyY2VzLnBsIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1NjcmlwdHMvY29weS11c2VyLWludGVyZmFjZS1yZXNvdXJjZXMucGwKaW5kZXgg N2Q4ODcxYjhiMDMuLmJjMDM3MjBjMzg3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvU2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy5wbAorKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy5wbApA QCAtMzc5LDYgKzM3OSwxNyBAQCBpZiAoJHNob3VsZENvbWJpbmVUZXN0KSB7CiAgICAgIyBDb3B5 IG92ZXIgVGVzdC5odG1sLgogICAgIGNvcHkoJGRlcml2ZWRTb3VyY2VzVGVzdEhUTUwsIEZpbGU6 OlNwZWMtPmNhdGZpbGUoJHRhcmdldFJlc291cmNlUGF0aCwgJ1Rlc3QuaHRtbCcpKTsKIAorICAg ICMgQ29tYmluZSB0aGUgSmF2YVNjcmlwdCBmaWxlcyBmb3IgdGVzdGluZyBpbnRvIGEgc2luZ2xl IGZpbGUgKFRlc3RTdHViLmpzKS4KKyAgICBzeXN0ZW0oJHBlcmwsICRjb21iaW5lUmVzb3VyY2Vz Q21kLAorICAgICAgICAnLS1pbnB1dC1odG1sJywgRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdWlSb290 LCAnVGVzdFN0dWIuaHRtbCcpLAorICAgICAgICAnLS1kZXJpdmVkLXNvdXJjZXMtZGlyJywgJGRl cml2ZWRTb3VyY2VzRGlyLAorICAgICAgICAnLS1vdXRwdXQtZGlyJywgJGRlcml2ZWRTb3VyY2Vz RGlyLAorICAgICAgICAnLS1vdXRwdXQtc2NyaXB0LW5hbWUnLCAnVGVzdFN0dWJDb21iaW5lZC5q cycpOworCisgICAgIyBDb3B5IG92ZXIgVGVzdFN0dWIuaHRtbCBhbmQgVGVzdFN0dWJDb21iaW5l ZC5qcy4KKyAgICBjb3B5KEZpbGU6OlNwZWMtPmNhdGZpbGUoJGRlcml2ZWRTb3VyY2VzRGlyLCAn VGVzdFN0dWIuaHRtbCcpLCBGaWxlOjpTcGVjLT5jYXRmaWxlKCR0YXJnZXRSZXNvdXJjZVBhdGgs ICdUZXN0U3R1Yi5odG1sJykpOworICAgIGNvcHkoRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkZGVyaXZl ZFNvdXJjZXNEaXIsICdUZXN0U3R1YkNvbWJpbmVkLmpzJyksIEZpbGU6OlNwZWMtPmNhdGZpbGUo JHRhcmdldFJlc291cmNlUGF0aCwgJ1Rlc3RTdHViQ29tYmluZWQuanMnKSk7CisKICAgICAjIENv cHkgdGhlIExlZ2FjeSBkaXJlY3RvcnkuCiAgICAgZGl0dG8oRmlsZTo6U3BlYy0+Y2F0ZmlsZSgk dWlSb290LCAnUHJvdG9jb2wnLCAnTGVnYWN5JyksIEZpbGU6OlNwZWMtPmNhdGZpbGUoJHByb3Rv Y29sRGlyLCAnTGVnYWN5JykpOwogfQo=