179466 2017-11-08 21:22:53 -0800 Include a more complete block signature in public headers to avoid potential -Wstrict-prototypes warnings 2017-12-13 10:26:26 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180757 InRadar P2 Normal --- 1 joepeck joepeck beidson commit-queue joepeck mitz webkit-bug-importer oldest_to_newest 1369788 0 joepeck 2017-11-08 21:22:53 -0800 Sometimes when building against a local build of WebKit I see errors like: > WKHTTPCookieStore.h:59:78: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes] > - (void)setCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler; > ^ > void > WKHTTPCookieStore.h:64:81: error: this block declaration is not a prototype [-Werror,-Wstrict-prototypes] > - (void)deleteCookie:(NSHTTPCookie *)cookie completionHandler:(nullable void (^)())completionHandler; > ^ > void > 2 errors generated. We can address this my providing a by providing a better block signature, more in line with other WebKit void block signatures. 1369789 1 326427 joepeck 2017-11-08 21:23:22 -0800 Created attachment 326427 [PATCH] Proposed Fix 1369797 2 326427 commit-queue 2017-11-08 22:05:13 -0800 Comment on attachment 326427 [PATCH] Proposed Fix Clearing flags on attachment: 326427 Committed r224619: <https://trac.webkit.org/changeset/224619> 1369798 3 commit-queue 2017-11-08 22:05:15 -0800 All reviewed patches have been landed. Closing bug. 1371951 4 webkit-bug-importer 2017-11-15 09:40:06 -0800 <rdar://problem/35562189> 326427 2017-11-08 21:23:22 -0800 2017-11-08 22:05:13 -0800 [PATCH] Proposed Fix strict-1.patch text/plain 3130 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTQwN2M5NDAyMmEuLmYyZjEwYTA5ZTU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE3LTExLTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgSW5jbHVkZSBhIG1vcmUgY29tcGxldGUgYmxvY2sgc2lnbmF0dXJlIGluIHB1 YmxpYyBoZWFkZXJzIHRvIGF2b2lkIHBvdGVudGlhbCAtV3N0cmljdC1wcm90b3R5cGVzIHdhcm5p bmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0 NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tIVFRQQ29va2llU3RvcmUuaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL0NvY29hL1dLSFRUUENvb2tpZVN0b3JlLm1tOgorICAgICAgICAoLVtXS0hUVFBDb29r aWVTdG9yZSBzZXRDb29raWU6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisgICAgICAgICgtW1dLSFRU UENvb2tpZVN0b3JlIGRlbGV0ZUNvb2tpZTpjb21wbGV0aW9uSGFuZGxlcjpdKToKKwogMjAxNy0x MS0wOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBb QXR0YWNobWVudCBTdXBwb3J0XSBJbXBsZW1lbnQgZGVsZWdhdGUgaG9va3MgZm9yIGF0dGFjaG1l bnQgZWxlbWVudCBpbnNlcnRpb24gYW5kIHJlbW92YWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0hUVFBDb29raWVTdG9yZS5oIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLSFRUUENvb2tpZVN0b3JlLmgKaW5kZXggZjE0OWRlNDc5 NzQuLmFhYzljNDQyMmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tIVFRQQ29va2llU3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tIVFRQQ29va2llU3RvcmUuaApAQCAtNTYsMTIgKzU2LDEyIEBAIFdLX0NMQVNT X0FWQUlMQUJMRShtYWNvc3goMTAuMTMpLCBpb3MoMTEuMCkpCiAgQHBhcmFtIGNvb2tpZSBUaGUg Y29va2llIHRvIHNldC4KICBAcGFyYW0gY29tcGxldGlvbkhhbmRsZXIgQSBibG9jayB0byBpbnZv a2Ugb25jZSB0aGUgY29va2llIGhhcyBiZWVuIHN0b3JlZC4KICAqLwotLSAodm9pZClzZXRDb29r aWU6KE5TSFRUUENvb2tpZSAqKWNvb2tpZSBjb21wbGV0aW9uSGFuZGxlcjoobnVsbGFibGUgdm9p ZCAoXikoKSljb21wbGV0aW9uSGFuZGxlcjsKKy0gKHZvaWQpc2V0Q29va2llOihOU0hUVFBDb29r aWUgKiljb29raWUgY29tcGxldGlvbkhhbmRsZXI6KG51bGxhYmxlIHZvaWQgKF4pKHZvaWQpKWNv bXBsZXRpb25IYW5kbGVyOwogCiAvKiEgQGFic3RyYWN0IERlbGV0ZSB0aGUgc3BlY2lmaWVkIGNv b2tpZS4KICBAcGFyYW0gY29tcGxldGlvbkhhbmRsZXIgQSBibG9jayB0byBpbnZva2Ugb25jZSB0 aGUgY29va2llIGhhcyBiZWVuIGRlbGV0ZWQuCiAgKi8KLS0gKHZvaWQpZGVsZXRlQ29va2llOihO U0hUVFBDb29raWUgKiljb29raWUgY29tcGxldGlvbkhhbmRsZXI6KG51bGxhYmxlIHZvaWQgKF4p KCkpY29tcGxldGlvbkhhbmRsZXI7CistICh2b2lkKWRlbGV0ZUNvb2tpZTooTlNIVFRQQ29va2ll ICopY29va2llIGNvbXBsZXRpb25IYW5kbGVyOihudWxsYWJsZSB2b2lkICheKSh2b2lkKSljb21w bGV0aW9uSGFuZGxlcjsKIAogLyohIEBhYnN0cmFjdCBBZGRzIGEgV0tIVFRQQ29va2llU3RvcmVP YnNlcnZlciBvYmplY3Qgd2l0aCB0aGUgY29va2llIHN0b3JlLgogIEBwYXJhbSBvYnNlcnZlciBU aGUgb2JzZXJ2ZXIgb2JqZWN0IHRvIGFkZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS0hUVFBDb29raWVTdG9yZS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS0hUVFBDb29raWVTdG9yZS5tbQppbmRleCA1MmQ0ZWNlMmRlYy4u ZDBjZDVkODM0ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS0hUVFBDb29raWVTdG9yZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tIVFRQQ29va2llU3RvcmUubW0KQEAgLTg0LDcgKzg0LDcgQEAgLSAodm9pZClnZXRB bGxDb29raWVzOih2b2lkICheKShOU0FycmF5PE5TSFRUUENvb2tpZSAqPiAqKSljb21wbGV0aW9u SGFuZGxlcgogICAgIH0pOwogfQogCi0tICh2b2lkKXNldENvb2tpZTooTlNIVFRQQ29va2llICop Y29va2llIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKSgpKWNvbXBsZXRpb25IYW5kbGVyCist ICh2b2lkKXNldENvb2tpZTooTlNIVFRQQ29va2llICopY29va2llIGNvbXBsZXRpb25IYW5kbGVy Oih2b2lkICheKSh2b2lkKSljb21wbGV0aW9uSGFuZGxlcgogewogICAgIF9jb29raWVTdG9yZS0+ c2V0Q29va2llKGNvb2tpZSwgW2hhbmRsZXIgPSBhZG9wdE5TKFtjb21wbGV0aW9uSGFuZGxlciBj b3B5XSldKCkgewogICAgICAgICBhdXRvIHJhd0hhbmRsZXIgPSAodm9pZCAoXikoKSloYW5kbGVy LmdldCgpOwpAQCAtOTQsNyArOTQsNyBAQCAtICh2b2lkKXNldENvb2tpZTooTlNIVFRQQ29va2ll ICopY29va2llIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKSgpKWNvbXBsZXRpbwogCiB9CiAK LS0gKHZvaWQpZGVsZXRlQ29va2llOihOU0hUVFBDb29raWUgKiljb29raWUgY29tcGxldGlvbkhh bmRsZXI6KHZvaWQgKF4pKCkpY29tcGxldGlvbkhhbmRsZXIKKy0gKHZvaWQpZGVsZXRlQ29va2ll OihOU0hUVFBDb29raWUgKiljb29raWUgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZvaWQp KWNvbXBsZXRpb25IYW5kbGVyCiB7CiAgICAgX2Nvb2tpZVN0b3JlLT5kZWxldGVDb29raWUoY29v a2llLCBbaGFuZGxlciA9IGFkb3B0TlMoW2NvbXBsZXRpb25IYW5kbGVyIGNvcHldKV0oKSB7CiAg ICAgICAgIGF1dG8gcmF3SGFuZGxlciA9ICh2b2lkICheKSgpKWhhbmRsZXIuZ2V0KCk7Cg==