179465 2017-11-08 20:35:49 -0800 [LayoutState cleanup] Add pagination parameter to subtree LayoutState 2017-11-09 07:08:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1369781 0 zalan 2017-11-08 20:35:49 -0800 so that the last setters can be removed from LayoutState. 1369782 1 webkit-bug-importer 2017-11-08 20:38:32 -0800 <rdar://problem/35434096> 1369783 2 326425 zalan 2017-11-08 20:40:38 -0800 Created attachment 326425 Patch 1369857 3 326425 commit-queue 2017-11-09 07:08:50 -0800 Comment on attachment 326425 Patch Clearing flags on attachment: 326425 Committed r224625: <https://trac.webkit.org/changeset/224625> 1369858 4 commit-queue 2017-11-09 07:08:51 -0800 All reviewed patches have been landed. Closing bug. 326425 2017-11-08 20:40:38 -0800 2017-11-09 07:08:50 -0800 Patch bug-179465-20171108204037.patch text/plain 5238 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMyMDU4Y2IwMTBkOGJh ZDhkNzhmNDQwMTMzY2QzYWIxYTFmN2U1OS4uOGIzODI0NWFhZjE0ZGRjNjNhODEyZjJhNjJjY2Nl MDI0MjM5MDM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTExLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xheW91dFN0YXRlIGNsZWFu dXBdIEFkZCBwYWdpbmF0aW9uIHBhcmFtZXRlciB0byBzdWJ0cmVlIExheW91dFN0YXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0NjUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzM1NDM0MDk2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEl0IGVuYWJsZXMgdXMgdG8gcmVtb3ZlIHRoZSBsYXN0IHNl dHRlcnMgZnJvbSBMYXlvdXRTdGF0ZS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25h bGl0eS4KKworICAgICAgICAqIHBhZ2UvTGF5b3V0Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpMYXlvdXRDb250ZXh0OjpwdXNoTGF5b3V0U3RhdGVGb3JQYWdpbmF0aW9uSWZOZWVkZWQp OgorICAgICAgICAqIHJlbmRlcmluZy9MYXlvdXRTdGF0ZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXRTdGF0ZTo6TGF5b3V0U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0U3Rh dGU6OmxheW91dERlbHRhTWF0Y2hlcyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRT dGF0ZTo6bGF5b3V0RGVsdGFNYXRjaGVzKTogRGVsZXRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcv TGF5b3V0U3RhdGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dFN0YXRlOjppc1BhZ2luYXRl ZCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRTdGF0ZTo6c2V0SXNQYWdpbmF0ZWQp OiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0U3RhdGU6OnNldFBhZ2VMb2dpY2Fs SGVpZ2h0KTogRGVsZXRlZC4KKwogMjAxNy0xMS0wOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtMYXlvdXRTdGF0ZSBjbGVhbnVwXSBMYXlvdXRDb250ZXh0IHNo b3VsZCBvd24gdGhlIHN0YWNrIG9mIExheW91dFN0YXRlIG9iamVjdHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTGF5b3V0Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0xheW91dENvbnRleHQuY3BwCmluZGV4IDdkNTgzMmMwZjRlNDUxNWMwMDYyOWFiNjZmMDQ1MGE1 NWQ0MGYxZjEuLjQwY2UwYWE3OGQ1ZTg1NzY3NWYzMmU4NWQyNTI2NDA0NTI2ZTc1ZTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTGF5b3V0Q29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9MYXlvdXRDb250ZXh0LmNwcApAQCAtNTY5LDEwICs1NjksNyBAQCBib29s IExheW91dENvbnRleHQ6OnB1c2hMYXlvdXRTdGF0ZUZvclBhZ2luYXRpb25JZk5lZWRlZChSZW5k ZXJCbG9ja0Zsb3cmIGxheW91dAogewogICAgIGlmIChsYXlvdXRTdGF0ZSgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0gICAgbV9sYXlvdXRTdGF0ZVN0YWNrLmFwcGVuZChzdGQ6Om1ha2VfdW5p cXVlPExheW91dFN0YXRlPihsYXlvdXRSb290KSk7Ci0gICAgbGF5b3V0U3RhdGUoKS0+c2V0SXNQ YWdpbmF0ZWQoKTsKLSAgICAvLyBUaGlzIGlzIGp1c3QgYSBmbGFnIGZvciBrbm93biBwYWdlIGhl aWdodCAoc2VlIFJlbmRlckJsb2NrRmxvdzo6Y2hlY2tGb3JQYWdpbmF0aW9uTG9naWNhbEhlaWdo dENoYW5nZSkuCi0gICAgbGF5b3V0U3RhdGUoKS0+c2V0UGFnZUxvZ2ljYWxIZWlnaHQoMSk7Cisg ICAgbV9sYXlvdXRTdGF0ZVN0YWNrLmFwcGVuZChzdGQ6Om1ha2VfdW5pcXVlPExheW91dFN0YXRl PihsYXlvdXRSb290LCBMYXlvdXRTdGF0ZTo6SXNQYWdpbmF0ZWQ6OlllcykpOwogICAgIHJldHVy biB0cnVlOwogfQogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xh eW91dFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0ZS5jcHAK aW5kZXggYzc0NWQ0NzM4MzVlMDYxMTlkYWJjZGU3MjRjZjk3YzU3MzY1ZWVlNS4uNDRlNDUxMTA5 MzJlZTUwODBiZTczMDNmNTE2YzA2MzUxMjQ4NmIzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvTGF5b3V0U3RhdGUuY3BwCkBAIC0zNCw5ICszNCw5IEBACiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAotTGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQor TGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyLCBJc1BhZ2lu YXRlZCBpc1BhZ2luYXRlZCkKICAgICA6IG1fY2xpcHBlZChmYWxzZSkKLSAgICAsIG1faXNQYWdp bmF0ZWQoZmFsc2UpCisgICAgLCBtX2lzUGFnaW5hdGVkKGlzUGFnaW5hdGVkID09IElzUGFnaW5h dGVkOjpZZXMpCiAgICAgLCBtX3BhZ2VMb2dpY2FsSGVpZ2h0Q2hhbmdlZChmYWxzZSkKICNpZiAh QVNTRVJUX0RJU0FCTEVECiAgICAgLCBtX2xheW91dERlbHRhWFNhdHVyYXRlZChmYWxzZSkKQEAg LTU3LDYgKzU3LDEwIEBAIExheW91dFN0YXRlOjpMYXlvdXRTdGF0ZShSZW5kZXJFbGVtZW50JiBy ZW5kZXJlcikKICAgICAgICAgICAgIG1fcGFpbnRPZmZzZXQgLT0gdG9MYXlvdXRTaXplKGNvbnRh aW5lckJveC5zY3JvbGxQb3NpdGlvbigpKTsKICAgICAgICAgfQogICAgIH0KKyAgICBpZiAobV9p c1BhZ2luYXRlZCkgeworICAgICAgICAvLyBUaGlzIGlzIGp1c3QgYSBmbGFnIGZvciBrbm93biBw YWdlIGhlaWdodCAoc2VlIFJlbmRlckJsb2NrRmxvdzo6Y2hlY2tGb3JQYWdpbmF0aW9uTG9naWNh bEhlaWdodENoYW5nZSkuCisgICAgICAgIG1fcGFnZUxvZ2ljYWxIZWlnaHQgPSAxOworICAgIH0K IH0KIAogTGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKGNvbnN0IExheW91dENvbnRleHQ6OkxheW91 dFN0YXRlU3RhY2smIGxheW91dFN0YXRlU3RhY2ssIFJlbmRlckJveCYgcmVuZGVyZXIsIGNvbnN0 IExheW91dFNpemUmIG9mZnNldCwgTGF5b3V0VW5pdCBwYWdlTG9naWNhbEhlaWdodCwgYm9vbCBw YWdlTG9naWNhbEhlaWdodENoYW5nZWQpCkBAIC0yMjEsNyArMjI1LDcgQEAgdm9pZCBMYXlvdXRT dGF0ZTo6YWRkTGF5b3V0RGVsdGEoTGF5b3V0U2l6ZSBkZWx0YSkKIH0KIAogI2lmICFBU1NFUlRf RElTQUJMRUQKLWJvb2wgTGF5b3V0U3RhdGU6OmxheW91dERlbHRhTWF0Y2hlcyhMYXlvdXRTaXpl IGRlbHRhKQorYm9vbCBMYXlvdXRTdGF0ZTo6bGF5b3V0RGVsdGFNYXRjaGVzKExheW91dFNpemUg ZGVsdGEpIGNvbnN0CiB7CiAgICAgcmV0dXJuIChkZWx0YS53aWR0aCgpID09IG1fbGF5b3V0RGVs dGEud2lkdGgoKSB8fCBtX2xheW91dERlbHRhWFNhdHVyYXRlZCkgJiYgKGRlbHRhLmhlaWdodCgp ID09IG1fbGF5b3V0RGVsdGEuaGVpZ2h0KCkgfHwgbV9sYXlvdXREZWx0YVlTYXR1cmF0ZWQpOwog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuaAppbmRleCBhNGRhOWZiNmNhMmY5 Nzg5NTJkNGQ4NzE1NTE2MjQzMGRkZjJkNGIwLi40NjYyYzdjN2RhMWJkNzlkM2UyZmZiYzEzZTZl YmUzMGEzYWZiYzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0 U3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuaApAQCAt NTMsMTYgKzUzLDE1IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogICAgIExheW91dFN0YXRlKGNv bnN0IExheW91dENvbnRleHQ6OkxheW91dFN0YXRlU3RhY2smLCBSZW5kZXJCb3gmLCBjb25zdCBM YXlvdXRTaXplJiBvZmZzZXQsIExheW91dFVuaXQgcGFnZUhlaWdodCwgYm9vbCBwYWdlSGVpZ2h0 Q2hhbmdlZCk7Ci0gICAgZXhwbGljaXQgTGF5b3V0U3RhdGUoUmVuZGVyRWxlbWVudCYpOworICAg IGVudW0gY2xhc3MgSXNQYWdpbmF0ZWQgeyBObywgWWVzIH07CisgICAgZXhwbGljaXQgTGF5b3V0 U3RhdGUoUmVuZGVyRWxlbWVudCYsIElzUGFnaW5hdGVkID0gSXNQYWdpbmF0ZWQ6Ok5vKTsKIAog ICAgIGJvb2wgaXNQYWdpbmF0ZWQoKSBjb25zdCB7IHJldHVybiBtX2lzUGFnaW5hdGVkOyB9Ci0g ICAgdm9pZCBzZXRJc1BhZ2luYXRlZCgpIHsgbV9pc1BhZ2luYXRlZCA9IHRydWU7IH0KIAogICAg IC8vIFRoZSBwYWdlIGxvZ2ljYWwgb2Zmc2V0IGlzIHRoZSBvYmplY3QncyBvZmZzZXQgZnJvbSB0 aGUgdG9wIG9mIHRoZSBwYWdlIGluIHRoZSBwYWdlIHByb2dyZXNzaW9uCiAgICAgLy8gZGlyZWN0 aW9uIChzbyBhbiB4LW9mZnNldCBpbiB2ZXJ0aWNhbCB0ZXh0IGFuZCBhIHktb2Zmc2V0IGZvciBo b3Jpem9udGFsIHRleHQpLgogICAgIExheW91dFVuaXQgcGFnZUxvZ2ljYWxPZmZzZXQoUmVuZGVy Qm94KiwgTGF5b3V0VW5pdCBjaGlsZExvZ2ljYWxPZmZzZXQpIGNvbnN0OwogICAgIAotICAgIHZv aWQgc2V0UGFnZUxvZ2ljYWxIZWlnaHQoTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0KSB7IG1fcGFn ZUxvZ2ljYWxIZWlnaHQgPSBsb2dpY2FsSGVpZ2h0OyB9CiAgICAgTGF5b3V0VW5pdCBwYWdlTG9n aWNhbEhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZUxvZ2ljYWxIZWlnaHQ7IH0KICAgICBi b29sIHBhZ2VMb2dpY2FsSGVpZ2h0Q2hhbmdlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZUxvZ2lj YWxIZWlnaHRDaGFuZ2VkOyB9CiAKQEAgLTg5LDcgKzg4LDcgQEAgcHVibGljOgogICAgIHZvaWQg YWRkTGF5b3V0RGVsdGEoTGF5b3V0U2l6ZSk7CiAgICAgTGF5b3V0U2l6ZSBsYXlvdXREZWx0YSgp IGNvbnN0IHsgcmV0dXJuIG1fbGF5b3V0RGVsdGE7IH0KICNpZiAhQVNTRVJUX0RJU0FCTEVECi0g ICAgYm9vbCBsYXlvdXREZWx0YU1hdGNoZXMoTGF5b3V0U2l6ZSk7CisgICAgYm9vbCBsYXlvdXRE ZWx0YU1hdGNoZXMoTGF5b3V0U2l6ZSkgY29uc3Q7CiAjZW5kaWYKIAogcHJpdmF0ZToK