179464 2017-11-08 20:03:33 -0800 AVSampleBufferGenerator leaks seen on leaks bot 2017-11-15 09:44:54 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue eric.carlson jer.noble joepeck webkit-bug-importer oldest_to_newest 1369775 0 joepeck 2017-11-08 20:03:33 -0800 AVSampleBufferGenerator leaks seen on leaks bot > Leak: 0x7fdf4f187bc0 size=16 zone: DefaultMallocZone_0x10803d000 AVSampleBufferGenerator ObjC AVFoundation > 0xa60e7731 0x001dffff 0x4f1a71e0 0x00007fdf 1w.......q.O.... > Call stack: [thread 0x7fffad1d0340]: > | 0x2 > | start > | DumpRenderTreeMain(int, char const**) DumpRenderTree.mm:1407 > | dumpRenderTree(int, char const**) DumpRenderTree.mm:1291 > | runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) DumpRenderTree.mm:2027 > | CFRunLoopRunSpecific > | __CFRunLoopRun > | __CFRunLoopDoSources0 > | __CFRunLoopDoSource0 > | __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ > | __NSThreadPerformPerform > | WTF::dispatchFunctionsFromMainThread() MainThread.cpp:132 > | WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]::$_7>::call() WebCoreResourceHandleAsOperationQueueDelegate.mm:0 > | WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) ResourceLoader.cpp:684 > | WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) SubresourceLoader.cpp:577 > | WebCore::CachedImage::finishLoading(WebCore::SharedBuffer*) CachedImage.cpp:463 > | WebCore::ImageSource::dataChanged(WebCore::SharedBuffer*, bool) ImageSource.cpp:118 > | WebCore::ImageDecoderAVFObjC::setData(WebCore::SharedBuffer&, bool) ImageDecoderAVFObjC.mm:636 > | WebCore::ImageDecoderAVFObjC::readSampleMetadata() ImageDecoderAVFObjC.mm:352 > | _objc_rootAlloc > | class_createInstance > | calloc > | malloc_zone_calloc 1369776 1 326422 joepeck 2017-11-08 20:05:28 -0800 Created attachment 326422 [PATCH] Proposed Fix 1369812 2 326422 commit-queue 2017-11-08 23:59:35 -0800 Comment on attachment 326422 [PATCH] Proposed Fix Clearing flags on attachment: 326422 Committed r224620: <https://trac.webkit.org/changeset/224620> 1369813 3 commit-queue 2017-11-08 23:59:36 -0800 All reviewed patches have been landed. Closing bug. 1371990 4 webkit-bug-importer 2017-11-15 09:44:54 -0800 <rdar://problem/35562353> 326422 2017-11-08 20:05:28 -0800 2017-11-08 23:59:35 -0800 [PATCH] Proposed Fix adopt-1.patch text/plain 2118 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MjliMmRmM2VmOC4uOGUyMzNmMjBkMTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0xMS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIEFWU2FtcGxlQnVmZmVyR2VuZXJhdG9yIGxlYWtzIHNlZW4gb24gbGVh a3MgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Nzk0NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0ltYWdlRGVjb2RlckFWRk9iakMu bW06CisgICAgICAgIChXZWJDb3JlOjpJbWFnZURlY29kZXJBVkZPYmpDOjpyZWFkU2FtcGxlTWV0 YWRhdGEpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyQVZGT2JqQzo6Y3JlYXRlRnJh bWVJbWFnZUF0SW5kZXgpOgorICAgICAgICBBZG9wdCB0aGUgYWxsb2NhdGlvbiBpbnRvIG91ciBS ZXRhaW5QdHIuCisKKzIwMTctMTEtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IEludGVybmFsIHByb3BlcnRpZXMg b2YgUGF5bWVudFJlcXVlc3QgaW4gV2ViIEluc3BlY3RvciBDb25zb2xlCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkyNzYKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvSW1hZ2VE ZWNvZGVyQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL0ltYWdlRGVjb2RlckFWRk9iakMubW0KaW5kZXggNTQyZDAxMDViZjMuLjkz ZjI3MWJkODVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9JbWFnZURlY29kZXJBVkZPYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0ltYWdlRGVjb2RlckFWRk9i akMubW0KQEAgLTM0OSw3ICszNDksNyBAQCB2b2lkIEltYWdlRGVjb2RlckFWRk9iakM6OnJlYWRT YW1wbGVNZXRhZGF0YSgpCiAgICAgbV9zYW1wbGVEYXRhLnJlc2l6ZShzdGF0aWNfY2FzdDxzaXpl X3Q+KHNhbXBsZUNvdW50KSk7CiAKICAgICBpZiAoIW1fZ2VuZXJhdG9yKQotICAgICAgICBtX2dl bmVyYXRvciA9IFthbGxvY0FWU2FtcGxlQnVmZmVyR2VuZXJhdG9ySW5zdGFuY2UoKSBpbml0V2l0 aEFzc2V0Om1fYXNzZXQuZ2V0KCkgdGltZWJhc2U6bmlsXTsKKyAgICAgICAgbV9nZW5lcmF0b3Ig PSBhZG9wdE5TKFthbGxvY0FWU2FtcGxlQnVmZmVyR2VuZXJhdG9ySW5zdGFuY2UoKSBpbml0V2l0 aEFzc2V0Om1fYXNzZXQuZ2V0KCkgdGltZWJhc2U6bmlsXSk7CiAKICAgICBmb3IgKHNpemVfdCBp bmRleCA9IDA7IGluZGV4IDwgc3RhdGljX2Nhc3Q8c2l6ZV90PihzYW1wbGVDb3VudCk7ICsraW5k ZXgpIHsKICAgICAgICAgYXV0byYgc2FtcGxlRGF0YSA9IG1fc2FtcGxlRGF0YVtpbmRleF07CkBA IC01ODAsNyArNTgwLDcgQEAgTmF0aXZlSW1hZ2VQdHIgSW1hZ2VEZWNvZGVyQVZGT2JqQzo6Y3Jl YXRlRnJhbWVJbWFnZUF0SW5kZXgoc2l6ZV90IGluZGV4LCBTdWJzYW0KICAgICB9CiAKICAgICBp ZiAoIW1fZ2VuZXJhdG9yKQotICAgICAgICBtX2dlbmVyYXRvciA9IFthbGxvY0FWU2FtcGxlQnVm ZmVyR2VuZXJhdG9ySW5zdGFuY2UoKSBpbml0V2l0aEFzc2V0Om1fYXNzZXQuZ2V0KCkgdGltZWJh c2U6bmlsXTsKKyAgICAgICAgbV9nZW5lcmF0b3IgPSBhZG9wdE5TKFthbGxvY0FWU2FtcGxlQnVm ZmVyR2VuZXJhdG9ySW5zdGFuY2UoKSBpbml0V2l0aEFzc2V0Om1fYXNzZXQuZ2V0KCkgdGltZWJh c2U6bmlsXSk7CiAKICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2U7CiAgICAgd2hpbGUg KHRydWUpIHsK