179453 2017-11-08 15:53:28 -0800 Add Windows powershell EWS script 2017-11-15 09:39:45 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen bfulgham commit-queue lforschler pvollan ryanhaddad webkit-bug-importer oldest_to_newest 1369665 0 don.olmstead 2017-11-08 15:53:28 -0800 Currently everything runs through shell scripts which requires cygwin. Add a Powershell equivalent for Windows 1369673 1 326399 don.olmstead 2017-11-08 16:07:58 -0800 Created attachment 326399 Patch 1369679 2 326399 bfulgham 2017-11-08 16:27:00 -0800 Comment on attachment 326399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326399&action=review I think this looks fine as a new direction, especially since it doesn't affect or existing tooling at all. I had a couple of minor questions about paths that I'd like you to confirm before landing. > Tools/EWSTools/Start-Queue.ps1:47 > + git clean -f; # Remove any left-over layout test results, added files, etc. Does Powershell know where to find 'git'? Or do we need to make sure it's now part of the user's path? Can this script complain if 'git' is not in the path? > Tools/EWSTools/Start-Queue.ps1:88 > + python /Tools/BuildSlaveSupport/kill-old-processes Ditto my 'git' comments about 'perl' and 'python'. Is Powershell smart enough to find them if you installed ActiveState stuff, or do we need to document for the user that they should add relevant paths to the system environment? 1369681 3 326399 bfulgham 2017-11-08 16:27:40 -0800 Comment on attachment 326399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326399&action=review > Tools/EWSTools/Start-Queue.ps1:86 > + perl ./Tools/Scripts/update-webkit --no-auxiliary-libs; Does Powershell always do the right thing with Unix-style paths? That's a very nice feature! 1369682 4 don.olmstead 2017-11-08 16:29:05 -0800 (In reply to Brent Fulgham from comment #2) > Comment on attachment 326399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326399&action=review > > I think this looks fine as a new direction, especially since it doesn't > affect or existing tooling at all. I had a couple of minor questions about > paths that I'd like you to confirm before landing. > > > Tools/EWSTools/Start-Queue.ps1:47 > > + git clean -f; # Remove any left-over layout test results, added files, etc. > > Does Powershell know where to find 'git'? Or do we need to make sure it's > now part of the user's path? Can this script complain if 'git' is not in the > path? > > > Tools/EWSTools/Start-Queue.ps1:88 > > + python /Tools/BuildSlaveSupport/kill-old-processes > > Ditto my 'git' comments about 'perl' and 'python'. Is Powershell smart > enough to find them if you installed ActiveState stuff, or do we need to > document for the user that they should add relevant paths to the system > environment? We're assuming that its on the path and accessible. (In reply to Brent Fulgham from comment #3) > Comment on attachment 326399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326399&action=review > > > Tools/EWSTools/Start-Queue.ps1:86 > > + perl ./Tools/Scripts/update-webkit --no-auxiliary-libs; > > Does Powershell always do the right thing with Unix-style paths? That's a > very nice feature! Yep it works fine. 1369706 5 326399 commit-queue 2017-11-08 16:54:02 -0800 Comment on attachment 326399 Patch Clearing flags on attachment: 326399 Committed r224610: <https://trac.webkit.org/changeset/224610> 1369707 6 commit-queue 2017-11-08 16:54:03 -0800 All reviewed patches have been landed. Closing bug. 1371946 7 webkit-bug-importer 2017-11-15 09:39:45 -0800 <rdar://problem/35562177> 326399 2017-11-08 16:07:58 -0800 2017-11-08 16:54:02 -0800 Patch bug-179453.diff text/plain 3895 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZTk5 NzFkOWU4NS4uZTRlZjNjNGYxNWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0xMS0wOCAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIEFkZCBXaW5kb3dzIHBvd2Vyc2hl bGwgRVdTIHNjcmlwdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc5NDUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBFV1NUb29scy9TdGFydC1RdWV1ZS5wczE6IEFkZGVkLgorCiAyMDE3LTExLTA4ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiB1c2UgSlNPTjo6e0FycmF5LE9iamVjdCxWYWx1ZX0gaW5zdGVhZCBvZiBJbnNw ZWN0b3J7QXJyYXksT2JqZWN0LFZhbHVlfQpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdTVG9vbHMvU3Rh cnQtUXVldWUucHMxIGIvVG9vbHMvRVdTVG9vbHMvU3RhcnQtUXVldWUucHMxCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi44ZWQwMjM2ZGEwOQotLS0gL2Rldi9udWxsCisr KyBiL1Rvb2xzL0VXU1Rvb2xzL1N0YXJ0LVF1ZXVlLnBzMQpAQCAtMCwwICsxLDg5IEBACisjIENv cHlyaWdodCAoQykgMjAxNyBTb255IEludGVyYWN0aXZlIEVudGVydGFpbm1lbnQgSW5jLgorIwor IyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRo IG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisjIGFyZSBtZXQ6CisjIDEuIFJlZGlzdHJpYnV0aW9u cyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4K KyMgMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBh Ym92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhl ciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIyAKKyMgVEhJUyBT T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBg QVMgSVMnJyBBTkQgQU5ZCisjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBE SVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BF Q0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOworIyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyMgQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElO Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMKKyMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKKzwjCisgICAgLlN5bm9wc2lzCisgICAgU3RhcnRz IGEgRVdTIGJvdCBmb3IgV2ViS2l0LgorCisgICAgLlBhcmFtZXRlciBRdWV1ZQorICAgIFRoZSBu YW1lIG9mIHRoZSBFV1MgcXVldWUuCisgICAgLlBhcmFtZXRlciBOYW1lCisgICAgVGhlIG5hbWUg b2YgdGhlIEVXUyBzZXJ2ZXIuCisgICAgLlBhcmFtZXRlciBJdGVyYXRpb25zCisgICAgVGhlIG51 bWJlciBvZiBpdGVyYXRpb25zIHRvIHJ1biB3ZWJraXQtcGF0Y2ggZm9yIGJlZm9yZSBjbGVhbmlu ZyB0aGUgYm90J3Mgd29ya2luZyBkaXJlY3RvcnkuCisjPgorCitQYXJhbSgKKyAgICBbUGFyYW1l dGVyKE1hbmRhdG9yeSldCisgICAgW3N0cmluZ10gJHF1ZXVlLAorICAgIFtQYXJhbWV0ZXIoTWFu ZGF0b3J5KV0KKyAgICBbc3RyaW5nXSAkbmFtZSwKKyAgICBbUGFyYW1ldGVyKCldCisgICAgW2lu dF0gJGl0ZXJhdGlvbnMgPSAxMAorKQorCisKK2Z1bmN0aW9uIENsZWFuLUdpdAoreworICAgIGdp dCBjbGVhbiAtZjsgIyBSZW1vdmUgYW55IGxlZnQtb3ZlciBsYXlvdXQgdGVzdCByZXN1bHRzLCBh ZGRlZCBmaWxlcywgZXRjLgorICAgIGdpdCByZWJhc2UgLS1hYm9ydDsgIyBJZiB3ZSBnb3Qga2ls bGVkIGR1cmluZyBhIGdpdCByZWJhc2UsIHdlIG5lZWQgdG8gY2xlYW4gdXAuCisgICAgZ2l0IGZl dGNoIG9yaWdpbjsgIyBBdm9pZCB1cGRhdGluZyB0aGUgd29ya2luZyBjb3B5IHRvIGEgc3RhbGUg cmV2aXNpb24uCisgICAgZ2l0IGNoZWNrb3V0IG9yaWdpbi9tYXN0ZXIgLWY7CisgICAgZ2l0IGJy YW5jaCAtRCBtYXN0ZXI7CisgICAgZ2l0IGNoZWNrb3V0IG9yaWdpbi9tYXN0ZXIgLWIgbWFzdGVy OworfQorCisjIFRPRE86IFN3aXRjaCB0byB0ZXN0LXdlYmtpdHB5IHdoZW4gaXQgd29ya3Mgd2l0 aG91dCBjeWd3aW4KK2Z1bmN0aW9uIENsZWFuLVB5dGhvbkMKK3sKKyAgICBXcml0ZS1Ib3N0ICdS ZW1vdmluZyBweWMgZmlsZXMnOworCisgICAgJHB5Y0ZpbGVzID0gR2V0LUNoaWxkSXRlbSBUb29s cyAtSW5jbHVkZSAqLnB5YyAtUmVjdXJzZTsKKworICAgIGZvcmVhY2ggKCRmaWxlIGluICRweWNG aWxlcykgeworICAgICAgICBXcml0ZS1Ib3N0ICgnUmVtb3ZpbmcgezB9JyAtZiAkZmlsZS5GdWxs TmFtZSk7CisgICAgICAgIFJlbW92ZS1JdGVtICRmaWxlLkZ1bGxOYW1lOworICAgIH0KK30KKwor ZnVuY3Rpb24gQ2xlYW4tV2ViS2l0QnVpbGQKK3sKKyAgICBpZiAoVGVzdC1QYXRoIF9fY21ha2Vf c3lzdGVtaW5mb3JtYXRpb24pIHsKKyAgICAgICAgV3JpdGUtSG9zdCAnUmVtb3ZpbmcgQ01ha2Ug Y2FjaGUnOworICAgICAgICBSZW1vdmUtSXRlbSBfX2NtYWtlX3N5c3RlbWluZm9ybWF0aW9uIC1S ZWN1cnNlIC1Gb3JjZTsKKyAgICB9CisKKyAgICBpZiAoVGVzdC1QYXRoIFdlYktpdEJ1aWxkKSB7 CisgICAgICAgIFdyaXRlLUhvc3QgJ1JlbW92aW5nIFdlYktpdEJ1aWxkJzsKKyAgICAgICAgUmVt b3ZlLUl0ZW0gV2ViS2l0QnVpbGQgLVJlY3Vyc2UgLUZvcmNlOworICAgIH0KK30KKword2hpbGUg KCR0cnVlKSB7CisgICAgQ2xlYW4tV2ViS2l0QnVpbGQ7CisgICAgQ2xlYW4tUHl0aG9uQzsKKyAg ICBDbGVhbi1HaXQ7CisKKyAgICBwZXJsIC4vVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0IC0t bm8tYXV4aWxpYXJ5LWxpYnM7CisgICAgcHl0aG9uIC4vVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0 Y2ggJHF1ZXVlIC0tYm90LWlkPSRuYW1lIC0tbm8tY29uZmlybSAtLWV4aXQtYWZ0ZXItaXRlcmF0 aW9uICRpdGVyYXRpb25zOworICAgIHB5dGhvbiAvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQva2ls bC1vbGQtcHJvY2Vzc2VzCit9Cg==