179442 2017-11-08 13:19:13 -0800 REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded 2017-11-13 19:47:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179651 InRadar P2 Normal --- 1 rniwa rniwa ap buildbot cdumez commit-queue dbates esprehn+autocc kangil.han simon.fraser oldest_to_newest 1369547 0 rniwa 2017-11-08 13:19:13 -0800 REGRESSION(r224534): Crash inside Document::updateStyleIfNeeded 1369549 1 326355 rniwa 2017-11-08 13:20:45 -0800 Created attachment 326355 Disable assertins in iOS 1369558 2 simon.fraser 2017-11-08 13:26:44 -0800 rdar://problem/35421652 1369666 3 326355 commit-queue 2017-11-08 15:54:19 -0800 Comment on attachment 326355 Disable assertins in iOS Clearing flags on attachment: 326355 Committed r224604: <https://trac.webkit.org/changeset/224604> 1369667 4 commit-queue 2017-11-08 15:54:21 -0800 All reviewed patches have been landed. Closing bug. 1369747 5 326355 ap 2017-11-08 18:59:24 -0800 Comment on attachment 326355 Disable assertins in iOS View in context: https://bugs.webkit.org/attachment.cgi?id=326355&action=review > Source/WebCore/dom/Document.cpp:1942 > +#if !USE(WEB_THREAD) How does this work? We don't have separate WebCore builds for WebKit2 and legacy WebKit, so won't this completely disable the assertion on iOS? 1369765 6 simon.fraser 2017-11-08 19:42:45 -0800 Yes, it does. We plan to re-enable the assertion after some bug fixing. 1369802 7 rniwa 2017-11-08 23:10:56 -0800 (In reply to Alexey Proskuryakov from comment #5) > Comment on attachment 326355 [details] > Disable assertins in iOS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326355&action=review > > > Source/WebCore/dom/Document.cpp:1942 > > +#if !USE(WEB_THREAD) > > How does this work? We don't have separate WebCore builds for WebKit2 and > legacy WebKit, so won't this completely disable the assertion on iOS? Yes. That's the intent to unblock the submission. I intend on fixing the assertion next week when I actually have an engineering time. 326355 2017-11-08 13:20:45 -0800 2017-11-08 15:54:19 -0800 Disable assertins in iOS bug-179442-20171108132043.patch text/plain 1816 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDU5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTA4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIyNDUzNCk6 IENyYXNoIGluc2lkZSBEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NDQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSB0aGUgYXNzZXJ0aW9u IHdoZW4gdGhlIHdlYiB0aHJlYWQgaXMgdXNlZC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlTGF5b3V0KToKKwogMjAxNy0xMS0wOCAg V2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbQXR0YWNo bWVudCBTdXBwb3J0XSBJbXBsZW1lbnQgZGVsZWdhdGUgaG9va3MgZm9yIGF0dGFjaG1lbnQgZWxl bWVudCBpbnNlcnRpb24gYW5kIHJlbW92YWwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAko cmV2aXNpb24gMjI0NTkzKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTkzOSw3ICsxOTM5LDkgQEAgYm9vbCBEb2N1bWVudDo6dXBkYXRlU3R5 bGVJZk5lZWRlZCgpCiAgICAgfQogCiAgICAgLy8gVGhlIGVhcmx5IGV4aXQgZm9yIG5lZWRzU3R5 bGVSZWNhbGMoKSBpcyBuZWVkZWQgd2hlbiB1cGRhdGVXaWRnZXRQb3NpdGlvbnMoKSBpcyBjYWxs ZWQgaW4gcnVuT3JTY2hlZHVsZUFzeW5jaHJvbm91c1Rhc2tzKCkuCisjaWYgIVVTRShXRUJfVEhS RUFEKQogICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oTm9FdmVu dERpc3BhdGNoQXNzZXJ0aW9uOjpJbk1haW5UaHJlYWQ6OmlzRXZlbnRBbGxvd2VkKCkgfHwgKGZy YW1lVmlldyAmJiBmcmFtZVZpZXctPmlzSW5DaGlsZEZyYW1lV2l0aEZyYW1lRmxhdHRlbmluZygp KSk7CisjZW5kaWYKIAogICAgIHJlc29sdmVTdHlsZSgpOwogICAgIHJldHVybiB0cnVlOwpAQCAt MTk1Niw4ICsxOTU4LDkgQEAgdm9pZCBEb2N1bWVudDo6dXBkYXRlTGF5b3V0KCkKICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisjaWYgIVVTRShX RUJfVEhSRUFEKQogICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04o Tm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uOjpJbk1haW5UaHJlYWQ6OmlzRXZlbnRBbGxvd2VkKCkg fHwgKGZyYW1lVmlldyAmJiBmcmFtZVZpZXctPmlzSW5DaGlsZEZyYW1lV2l0aEZyYW1lRmxhdHRl bmluZygpKSk7Ci0KKyNlbmRpZgogCiAgICAgUmVuZGVyVmlldzo6UmVwYWludFJlZ2lvbkFjY3Vt dWxhdG9yIHJlcGFpbnRSZWdpb25BY2N1bXVsYXRvcihyZW5kZXJWaWV3KCkpOwogCg==