179427 2017-11-08 09:26:33 -0800 Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] 2017-11-15 09:41:42 -0800 1 1 1 Unclassified WebKit bmalloc Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue ggaren mcatanzaro saam webkit-bug-importer oldest_to_newest 1369448 0 mcatanzaro 2017-11-08 09:26:33 -0800 r224555 "We should PROT_NONE the Gigacage runway so OOB accesses crash" introduced this GCC warning: [15/2288] Building CXX object Source/b...les/bmalloc.dir/bmalloc/Gigacage.cpp.o ../../Source/bmalloc/bmalloc/Gigacage.cpp: In lambda function: ../../Source/bmalloc/bmalloc/Gigacage.cpp:44:46: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] #define GIGACAGE_RUNWAY (16llu * 1024 * 1024 * 1024) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/bmalloc/bmalloc/Gigacage.cpp:159:17: note: in expansion of macro ‘GIGACAGE_RUNWAY’ if (GIGACAGE_RUNWAY) { ^~~~~~~~~~~~~~~ 1369449 1 326332 mcatanzaro 2017-11-08 09:27:59 -0800 Created attachment 326332 Patch 1369450 2 326333 mcatanzaro 2017-11-08 09:28:18 -0800 Created attachment 326333 Patch 1369476 3 326333 saam 2017-11-08 10:31:59 -0800 Comment on attachment 326333 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326333&action=review > Source/bmalloc/bmalloc/Gigacage.cpp:159 > +#if !BCPU(ARM64) Not a fan of this. Can we just make it if (GIGACAGE_RUNWAY > 0)? 1369479 4 saam 2017-11-08 10:32:37 -0800 (In reply to Saam Barati from comment #3) > Comment on attachment 326333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326333&action=review > > > Source/bmalloc/bmalloc/Gigacage.cpp:159 > > +#if !BCPU(ARM64) > > Not a fan of this. Can we just make it > if (GIGACAGE_RUNWAY > 0)? To elaborate, this code shouldn't worry about which CPU it's on. If we decide to define GIGACAGE_RUNWAY for ARM64, we now need to change two lines of code instead of one. 1369489 5 mcatanzaro 2017-11-08 10:56:38 -0800 (In reply to Saam Barati from comment #3) > Not a fan of this. Can we just make it > if (GIGACAGE_RUNWAY > 0)? D'oh, that's way better. 1369490 6 326339 mcatanzaro 2017-11-08 10:57:02 -0800 Created attachment 326339 Patch 1369497 7 326339 commit-queue 2017-11-08 11:30:39 -0800 Comment on attachment 326339 Patch Clearing flags on attachment: 326339 Committed r224588: <https://trac.webkit.org/changeset/224588> 1369498 8 commit-queue 2017-11-08 11:30:41 -0800 All reviewed patches have been landed. Closing bug. 1371962 9 webkit-bug-importer 2017-11-15 09:41:42 -0800 <rdar://problem/35562198> 326332 2017-11-08 09:27:59 -0800 2017-11-08 09:28:17 -0800 Patch bug-179427-20171108112758.patch text/plain 1830 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMjgzNjRlODJlY2YxMDM4 ZTBmNjYzYzJhMDkzOWQ3MGY4M2ZlNTk4OC4uZTAzNzc0Y2U4OWZkYzFiNjExNmE2NGYxYWIyOTIy YTU2NzU2NTg3NiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTA4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBHaWdhY2Fn ZS5jcHA6NDQ6NDY6IHdhcm5pbmc6IOKAmCrigJkgaW4gYm9vbGVhbiBjb250ZXh0LCBzdWdnZXN0 IOKAmCYm4oCZIGluc3RlYWQgWy1XaW50LWluLWJvb2wtY29udGV4dF0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTQyNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgR0NDIHdhcm5pbmcgY2FuIGJl IGF2b2lkZWQgaWYgd2UgdXNlIGEgY29tcGlsZS10aW1lIGNvbmRpdGlvbiByYXRoZXIgdGhhbiBh IHJ1bnRpbWUKKyAgICAgICAgY29uZGl0aW9uIHdoZW4gdGVzdGluZyB0aGUgdmFsdWUgb2YgYSBw cmVwcm9jZXNzb3IgZGVmaW5pdGlvbi4KKworICAgICAgICAqIGJtYWxsb2MvR2lnYWNhZ2UuY3Bw OgorICAgICAgICAoR2lnYWNhZ2U6OmVuc3VyZUdpZ2FjYWdlKToKKwogMjAxNy0xMS0wNyAgU2Fh bSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZSBzaG91bGQgUFJPVF9O T05FIHRoZSBHaWdhY2FnZSBydW53YXkgc28gT09CIGFjY2Vzc2VzIGNyYXNoCmRpZmYgLS1naXQg YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvR2lnYWNhZ2UuY3BwCmluZGV4IDg1ZDQzYWY0MjRjNmMyZDM2NDBlYWI2YzFhYjI0MWE0 YjlhMzZkM2YuLjRkYmRhMGNhZGYyYTY0OWQxNzg2MzkyMzM2NDU3NmM3NWNkZDFlYzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCisrKyBiL1NvdXJjZS9i bWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCkBAIC0xNTYsMTEgKzE1NiwxMSBAQCB2b2lkIGVu c3VyZUdpZ2FjYWdlKCkKICAgICAgICAgICAgICAgICBCQ1JBU0goKTsKICAgICAgICAgICAgIH0K IAotICAgICAgICAgICAgaWYgKEdJR0FDQUdFX1JVTldBWSkgewotICAgICAgICAgICAgICAgIGNo YXIqIHJ1bndheSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJhc2UpICsgdG90YWxTaXplIC0g R0lHQUNBR0VfUlVOV0FZOwotICAgICAgICAgICAgICAgIC8vIE1ha2UgT09CIGFjY2Vzc2VzIGlu dG8gdGhlIHJ1bndheSBjcmFzaC4KLSAgICAgICAgICAgICAgICB2bVJldm9rZVBlcm1pc3Npb25z KHJ1bndheSwgR0lHQUNBR0VfUlVOV0FZKTsKLSAgICAgICAgICAgIH0KKyNpZiAhQkNQVShBUk02 NCkKKyAgICAgICAgICAgIGNoYXIqIHJ1bndheSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJh c2UpICsgdG90YWxTaXplIC0gKEdJR0FDQUdFX1JVTldBWSk7CisgICAgICAgICAgICAvLyBNYWtl IE9PQiBhY2Nlc3NlcyBpbnRvIHRoZSBydW53YXkgY3Jhc2guCisgICAgICAgICAgICB2bVJldm9r ZVBlcm1pc3Npb25zKHJ1bndheSwgR0lHQUNBR0VfUlVOV0FZKTsKKyNlbmRpZgogCiAgICAgICAg ICAgICB2bURlYWxsb2NhdGVQaHlzaWNhbFBhZ2VzKGJhc2UsIHRvdGFsU2l6ZSk7CiAgICAgICAg ICAgICAK 326333 2017-11-08 09:28:18 -0800 2017-11-08 10:57:00 -0800 Patch bug-179427-20171108112817.patch text/plain 1828 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMjgzNjRlODJlY2YxMDM4 ZTBmNjYzYzJhMDkzOWQ3MGY4M2ZlNTk4OC4uZTAzNzc0Y2U4OWZkYzFiNjExNmE2NGYxYWIyOTIy YTU2NzU2NTg3NiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTA4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBHaWdhY2Fn ZS5jcHA6NDQ6NDY6IHdhcm5pbmc6IOKAmCrigJkgaW4gYm9vbGVhbiBjb250ZXh0LCBzdWdnZXN0 IOKAmCYm4oCZIGluc3RlYWQgWy1XaW50LWluLWJvb2wtY29udGV4dF0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTQyNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgR0NDIHdhcm5pbmcgY2FuIGJl IGF2b2lkZWQgaWYgd2UgdXNlIGEgY29tcGlsZS10aW1lIGNvbmRpdGlvbiByYXRoZXIgdGhhbiBh IHJ1bnRpbWUKKyAgICAgICAgY29uZGl0aW9uIHdoZW4gdGVzdGluZyB0aGUgdmFsdWUgb2YgYSBw cmVwcm9jZXNzb3IgZGVmaW5pdGlvbi4KKworICAgICAgICAqIGJtYWxsb2MvR2lnYWNhZ2UuY3Bw OgorICAgICAgICAoR2lnYWNhZ2U6OmVuc3VyZUdpZ2FjYWdlKToKKwogMjAxNy0xMS0wNyAgU2Fh bSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZSBzaG91bGQgUFJPVF9O T05FIHRoZSBHaWdhY2FnZSBydW53YXkgc28gT09CIGFjY2Vzc2VzIGNyYXNoCmRpZmYgLS1naXQg YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvR2lnYWNhZ2UuY3BwCmluZGV4IDg1ZDQzYWY0MjRjNmMyZDM2NDBlYWI2YzFhYjI0MWE0 YjlhMzZkM2YuLjVlNjg3ZDcwNGZmNWNhMjlkNzdkYWVjODkxMDdiZDFkOGZkMTEwYzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCisrKyBiL1NvdXJjZS9i bWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCkBAIC0xNTYsMTEgKzE1NiwxMSBAQCB2b2lkIGVu c3VyZUdpZ2FjYWdlKCkKICAgICAgICAgICAgICAgICBCQ1JBU0goKTsKICAgICAgICAgICAgIH0K IAotICAgICAgICAgICAgaWYgKEdJR0FDQUdFX1JVTldBWSkgewotICAgICAgICAgICAgICAgIGNo YXIqIHJ1bndheSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJhc2UpICsgdG90YWxTaXplIC0g R0lHQUNBR0VfUlVOV0FZOwotICAgICAgICAgICAgICAgIC8vIE1ha2UgT09CIGFjY2Vzc2VzIGlu dG8gdGhlIHJ1bndheSBjcmFzaC4KLSAgICAgICAgICAgICAgICB2bVJldm9rZVBlcm1pc3Npb25z KHJ1bndheSwgR0lHQUNBR0VfUlVOV0FZKTsKLSAgICAgICAgICAgIH0KKyNpZiAhQkNQVShBUk02 NCkKKyAgICAgICAgICAgIGNoYXIqIHJ1bndheSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGJh c2UpICsgdG90YWxTaXplIC0gR0lHQUNBR0VfUlVOV0FZOworICAgICAgICAgICAgLy8gTWFrZSBP T0IgYWNjZXNzZXMgaW50byB0aGUgcnVud2F5IGNyYXNoLgorICAgICAgICAgICAgdm1SZXZva2VQ ZXJtaXNzaW9ucyhydW53YXksIEdJR0FDQUdFX1JVTldBWSk7CisjZW5kaWYKIAogICAgICAgICAg ICAgdm1EZWFsbG9jYXRlUGh5c2ljYWxQYWdlcyhiYXNlLCB0b3RhbFNpemUpOwogICAgICAgICAg ICAgCg== 326339 2017-11-08 10:57:02 -0800 2017-11-08 11:30:39 -0800 Patch bug-179427-20171108125701.patch text/plain 1433 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMjgzNjRlODJlY2YxMDM4 ZTBmNjYzYzJhMDkzOWQ3MGY4M2ZlNTk4OC4uODkzYWVmNDM1MDlmMGQ3MzlhMjYwNWVjZWFhY2Yz NjcxNmY0ZmQyZSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTA4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBHaWdhY2Fn ZS5jcHA6NDQ6NDY6IHdhcm5pbmc6IOKAmCrigJkgaW4gYm9vbGVhbiBjb250ZXh0LCBzdWdnZXN0 IOKAmCYm4oCZIGluc3RlYWQgWy1XaW50LWluLWJvb2wtY29udGV4dF0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTQyNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR3ZWFrIHRoZSBjb25kaXRpb25hbCB0 byBzdXBwcmVzcyB0aGUgd2FybmluZy4KKworICAgICAgICAqIGJtYWxsb2MvR2lnYWNhZ2UuY3Bw OgorICAgICAgICAoR2lnYWNhZ2U6OmVuc3VyZUdpZ2FjYWdlKToKKwogMjAxNy0xMS0wNyAgU2Fh bSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZSBzaG91bGQgUFJPVF9O T05FIHRoZSBHaWdhY2FnZSBydW53YXkgc28gT09CIGFjY2Vzc2VzIGNyYXNoCmRpZmYgLS1naXQg YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0dpZ2FjYWdlLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvR2lnYWNhZ2UuY3BwCmluZGV4IDg1ZDQzYWY0MjRjNmMyZDM2NDBlYWI2YzFhYjI0MWE0 YjlhMzZkM2YuLmE5ODhiMGFhMTVjNmUyODVjMjdhZTRiODE1MjIzMDkyM2ZjMGVhMzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCisrKyBiL1NvdXJjZS9i bWFsbG9jL2JtYWxsb2MvR2lnYWNhZ2UuY3BwCkBAIC0xNTYsNyArMTU2LDcgQEAgdm9pZCBlbnN1 cmVHaWdhY2FnZSgpCiAgICAgICAgICAgICAgICAgQkNSQVNIKCk7CiAgICAgICAgICAgICB9CiAK LSAgICAgICAgICAgIGlmIChHSUdBQ0FHRV9SVU5XQVkpIHsKKyAgICAgICAgICAgIGlmIChHSUdB Q0FHRV9SVU5XQVkgPiAwKSB7CiAgICAgICAgICAgICAgICAgY2hhciogcnVud2F5ID0gcmVpbnRl cnByZXRfY2FzdDxjaGFyKj4oYmFzZSkgKyB0b3RhbFNpemUgLSBHSUdBQ0FHRV9SVU5XQVk7CiAg ICAgICAgICAgICAgICAgLy8gTWFrZSBPT0IgYWNjZXNzZXMgaW50byB0aGUgcnVud2F5IGNyYXNo LgogICAgICAgICAgICAgICAgIHZtUmV2b2tlUGVybWlzc2lvbnMocnVud2F5LCBHSUdBQ0FHRV9S VU5XQVkpOwo=