179419 2017-11-08 01:39:35 -0800 REGRESSION(r224566): [GTK][WPE] Many inspector tests are failing after r224566 2017-11-09 07:16:45 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161212 https://bugs.webkit.org/show_bug.cgi?id=179471 Gtk, LayoutTestFailure, Regression P2 Normal --- 1 cgarcia webkit-unassigned aboya bburg bugs-noreply clopez commit-queue joepeck oldest_to_newest 1369374 0 cgarcia 2017-11-08 01:39:35 -0800 All of them fail with the following error: Uncaught exception in Inspector page: ReferenceError: Can't find variable: CodeMirror [TestCombined.js:36658:15] This is because Test.html, even when combined, is trying to load CodeMirror from External/CodeMirror, but CodeMirror was already combined for Main.html. We need to also combine CodeMirror for Test.html. I don't know why this works in Mac. 1369375 1 326316 cgarcia 2017-11-08 01:42:00 -0800 Created attachment 326316 Patch 1369390 2 cgarcia 2017-11-08 03:43:59 -0800 Joe, Brian I guess this is ok for Mac too, at least EWS didn't complain. 1369809 3 cgarcia 2017-11-08 23:48:17 -0800 *** Bug 179430 has been marked as a duplicate of this bug. *** 1369811 4 326316 cgarcia 2017-11-08 23:51:27 -0800 Comment on attachment 326316 Patch Ok, I'm landing this because it broke many tests. Joe, Brian if you have any objection or comment I'll fix it in a follow up. 1369816 5 326316 commit-queue 2017-11-09 00:12:07 -0800 Comment on attachment 326316 Patch Clearing flags on attachment: 326316 Committed r224621: <https://trac.webkit.org/changeset/224621> 1369817 6 commit-queue 2017-11-09 00:12:09 -0800 All reviewed patches have been landed. Closing bug. 326316 2017-11-08 01:42:00 -0800 2017-11-09 00:12:07 -0800 Patch wk-test-inspector.diff text/plain 3499 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4N2E3Y2QzZGRjLi45OWEwNmMzYzE4YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMTEtMDggIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjIyNDU2Nik6IFtHVEtdW1dQRV0gTWFueSBpbnNwZWN0b3IgdGVzdHMgYXJlIGZhaWxpbmcg YWZ0ZXIgcjIyNDU2NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc5NDE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsIG9mIHRoZW0gZmFpbCB3aXRoIHRoZSBmb2xsb3dpbmcgZXJyb3I6CisKKyAgICAg ICAgVW5jYXVnaHQgZXhjZXB0aW9uIGluIEluc3BlY3RvciBwYWdlOiBSZWZlcmVuY2VFcnJvcjog Q2FuJ3QgZmluZCB2YXJpYWJsZTogQ29kZU1pcnJvciBbVGVzdENvbWJpbmVkLmpzOjM2NjU4OjE1 XQorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSBUZXN0Lmh0bWwsIGV2ZW4gd2hlbiBjb21iaW5l ZCwgaXMgdHJ5aW5nIHRvIGxvYWQgQ29kZU1pcnJvciBmcm9tIEV4dGVybmFsL0NvZGVNaXJyb3Is IGJ1dAorICAgICAgICBDb2RlTWlycm9yIHdhcyBhbHJlYWR5IGNvbWJpbmVkIGZvciBNYWluLmh0 bWwuIFdlIG5lZWQgdG8gYWxzbyBjb21iaW5lIENvZGVNaXJyb3IgZm9yIFRlc3QuaHRtbC4KKwor ICAgICAgICAqIFNjcmlwdHMvY29weS11c2VyLWludGVyZmFjZS1yZXNvdXJjZXMucGw6CisKIDIw MTctMTEtMDYgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogU3R5bGVzIFJlZGVzaWduOiBEaXNwbGF5IHdhcm5pbmdzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNl LXJlc291cmNlcy5wbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNlci1p bnRlcmZhY2UtcmVzb3VyY2VzLnBsCmluZGV4IDVjMzY3ZjE2YmUzLi43ZDg4NzFiOGIwMyAxMDA3 NTUKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29weS11c2VyLWludGVyZmFj ZS1yZXNvdXJjZXMucGwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29weS11 c2VyLWludGVyZmFjZS1yZXNvdXJjZXMucGwKQEAgLTMzNSw3ICszMzUsMTYgQEAgaWYgKCRzaG91 bGRDb21iaW5lVGVzdCkgewogCiAgICAgbXkgJGRlcml2ZWRTb3VyY2VzVGVzdEhUTUwgPSBGaWxl OjpTcGVjLT5jYXRmaWxlKCRkZXJpdmVkU291cmNlc0RpciwgJ1Rlc3QuaHRtbCcpOwogICAgIG15 ICRkZXJpdmVkU291cmNlc1Rlc3RKUyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJGRlcml2ZWRTb3Vy Y2VzRGlyLCAnVGVzdENvbWJpbmVkLmpzJyk7Ci0gICAgIyBDb21iaW5lIHRoZSBFc3ByaW1hIEph dmFTY3JpcHQgZmlsZXMgZm9yIHRlc3RpbmcgaW50byBhIHNpbmdsZSBmaWxlIChFc3ByaW1hLmpz KS4KKyAgICAjIENvbWJpbmUgdGhlIENvZGVNaXJyb3IgSmF2YVNjcmlwdCBmaWxlcyBpbnRvIHNp bmdsZSBmaWxlIChUZXN0Q29kZU1pcnJvci5qcykuCisgICAgc3lzdGVtKCRwZXJsLCAkY29tYmlu ZVJlc291cmNlc0NtZCwKKyAgICAgICAgJy0taW5wdXQtZGlyJywgJ0V4dGVybmFsL0NvZGVNaXJy b3InLAorICAgICAgICAnLS1pbnB1dC1odG1sJywgJGRlcml2ZWRTb3VyY2VzVGVzdEhUTUwsCisg ICAgICAgICctLWlucHV0LWh0bWwtZGlyJywgJHVpUm9vdCwKKyAgICAgICAgJy0tZGVyaXZlZC1z b3VyY2VzLWRpcicsICRkZXJpdmVkU291cmNlc0RpciwKKyAgICAgICAgJy0tb3V0cHV0LWRpcics ICRkZXJpdmVkU291cmNlc0RpciwKKyAgICAgICAgJy0tb3V0cHV0LXNjcmlwdC1uYW1lJywgJ1Rl c3RDb2RlTWlycm9yLmpzJyk7CisKKyAgICAjIENvbWJpbmUgdGhlIEVzcHJpbWEgSmF2YVNjcmlw dCBmaWxlcyBmb3IgdGVzdGluZyBpbnRvIGEgc2luZ2xlIGZpbGUgKFRlc3RFc3ByaW1hLmpzKS4K ICAgICBzeXN0ZW0oJHBlcmwsICRjb21iaW5lUmVzb3VyY2VzQ21kLAogICAgICAgICAnLS1pbnB1 dC1kaXInLCAnRXh0ZXJuYWwvRXNwcmltYScsCiAgICAgICAgICctLWlucHV0LWh0bWwnLCAkZGVy aXZlZFNvdXJjZXNUZXN0SFRNTCwKQEAgLTM0OCwxMyArMzU3LDIxIEBAIGlmICgkc2hvdWxkQ29t YmluZVRlc3QpIHsKICAgICBteSAkdGFyZ2V0VGVzdEpTID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgk dGFyZ2V0UmVzb3VyY2VQYXRoLCAnVGVzdENvbWJpbmVkLmpzJyk7CiAgICAgc2VlZEZpbGUoJHRh cmdldFRlc3RKUywgJGluc3BlY3RvckxpY2Vuc2UpOwogCi0gICAgIyBFeHBvcnQgdGhlIGxpY2Vu c2UgaW50byBFc3ByaW1hLmpzLgorICAgICMgRXhwb3J0IHRoZSBsaWNlbnNlIGludG8gVGVzdENv ZGVNaXJyb3IuanMuCisgICAgbXkgJHRhcmdldENvZGVNaXJyb3JKUyA9IEZpbGU6OlNwZWMtPmNh dGZpbGUoJHRhcmdldFJlc291cmNlUGF0aCwgJ1Rlc3RDb2RlTWlycm9yLmpzJyk7CisgICAgc2Vl ZEZpbGUoJHRhcmdldENvZGVNaXJyb3JKUywgJGNvZGVNaXJyb3JMaWNlbnNlKTsKKworICAgICMg RXhwb3J0IHRoZSBsaWNlbnNlIGludG8gVGVzdEVzcHJpbWEuanMuCiAgICAgbXkgJHRhcmdldEVz cHJpbWFKUyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHRhcmdldFJlc291cmNlUGF0aCwgJ1Rlc3RF c3ByaW1hLmpzJyk7CiAgICAgc2VlZEZpbGUoJHRhcmdldEVzcHJpbWFKUywgJGVzcHJpbWFMaWNl bnNlKTsKIAogICAgICMgQXBwZW5kIFRlc3RDb21iaW5lZC5qcyB0byB0aGUgbGljZW5zZSB0aGF0 IHdhcyBleHBvcnRlZCBhYm92ZS4KICAgICBhcHBlbmRGaWxlKCR0YXJnZXRUZXN0SlMsICRkZXJp dmVkU291cmNlc1Rlc3RKUyk7CiAKKyAgICAjIEFwcGVuZCBDb2RlTWlycm9yLmpzIHRvIHRoZSBs aWNlbnNlIHRoYXQgd2FzIGV4cG9ydGVkIGFib3ZlLgorICAgIG15ICRkZXJpdmVkU291cmNlc0Nv ZGVNaXJyb3JKUyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJGRlcml2ZWRTb3VyY2VzRGlyLCAnVGVz dENvZGVNaXJyb3IuanMnKTsKKyAgICBhcHBlbmRGaWxlKCR0YXJnZXRDb2RlTWlycm9ySlMsICRk ZXJpdmVkU291cmNlc0NvZGVNaXJyb3JKUyk7CisKICAgICAjIEFwcGVuZCBFc3ByaW1hLmpzIHRv IHRoZSBsaWNlbnNlIHRoYXQgd2FzIGV4cG9ydGVkIGFib3ZlLgogICAgIG15ICRkZXJpdmVkU291 cmNlc0VzcHJpbWFKUyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJGRlcml2ZWRTb3VyY2VzRGlyLCAn VGVzdEVzcHJpbWEuanMnKTsKICAgICBhcHBlbmRGaWxlKCR0YXJnZXRFc3ByaW1hSlMsICRkZXJp dmVkU291cmNlc0VzcHJpbWFKUyk7Cg==