179407 2017-11-07 20:47:29 -0800 Web Inspector: Remove unused Page.ScriptIdentifier protocol type 2017-11-15 09:39:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck buildbot commit-queue inspector-bugzilla-changes joepeck keith_miller mark.lam mattbaker msaboff saam webkit-bug-importer oldest_to_newest 1369324 0 joepeck 2017-11-07 20:47:29 -0800 Remove unused Page.ScriptIdentifier protocol type As far as I can tell this was never used by our frontend. Maybe a very very long time ago. 1369326 1 326299 joepeck 2017-11-07 20:48:29 -0800 Created attachment 326299 [PATCH] Proposed Fix 1369471 2 326299 mattbaker 2017-11-08 10:12:50 -0800 Comment on attachment 326299 [PATCH] Proposed Fix r=me 1369477 3 326299 commit-queue 2017-11-08 10:32:28 -0800 Comment on attachment 326299 [PATCH] Proposed Fix Clearing flags on attachment: 326299 Committed r224586: <https://trac.webkit.org/changeset/224586> 1369478 4 commit-queue 2017-11-08 10:32:29 -0800 All reviewed patches have been landed. Closing bug. 1371939 5 webkit-bug-importer 2017-11-15 09:39:13 -0800 <rdar://problem/35562159> 326299 2017-11-07 20:48:29 -0800 2017-11-08 10:32:28 -0800 [PATCH] Proposed Fix unused-type-1.patch text/plain 7334 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGViZDNkMjEyMWFjLi5lYjUyYzExNzU5ZiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTEtMDcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW51c2VkIFBhZ2UuU2NyaXB0SWRlbnRpZmllciBwcm90b2NvbCB0eXBlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0MDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9w cm90b2NvbC9QYWdlLmpzb246CisgICAgICAgIFJlbW92ZSB1bnVzZWQgcHJvdG9jb2wgdHlwZS4K KwogMjAxNy0xMS0wNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg QWNjZXNzQ2FzZTo6Z2VuZXJhdGVJbXBsKCkgc2hvdWxkIGV4Y2x1ZGUgdGhlIHJlc3VsdCByZWdp c3RlciB3aGVuIHJlc3RvcmluZyByZWdpc3RlcnMgYWZ0ZXIgYSBjYWxsLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9QYWdlLmpzb24gYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL1BhZ2UuanNvbgppbmRleCA4NTQ0 ZDRkNDY4Zi4uNmU4YjA5ZjUzNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcHJvdG9jb2wvUGFnZS5qc29uCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvcHJvdG9jb2wvUGFnZS5qc29uCkBAIC03OCwxMSArNzgsNiBAQAogICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAic2VjdXJlIiwgInR5cGUiOiAiYm9vbGVhbiIsICJkZXNjcmlwdGlv biI6ICJUcnVlIGlmIGNvb2tpZSBpcyBzZWN1cmUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAic2Vzc2lvbiIsICJ0eXBlIjogImJvb2xlYW4iLCAiZGVzY3JpcHRpb24iOiAiVHJ1ZSBp biBjYXNlIG9mIHNlc3Npb24gY29va2llLiIgfQogICAgICAgICAgICAgXQotICAgICAgICB9LAot ICAgICAgICB7Ci0gICAgICAgICAgICAiaWQiOiAiU2NyaXB0SWRlbnRpZmllciIsCi0gICAgICAg ICAgICAidHlwZSI6ICJzdHJpbmciLAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVuaXF1 ZSBzY3JpcHQgaWRlbnRpZmllci4iCiAgICAgICAgIH0KICAgICBdLAogICAgICJjb21tYW5kcyI6 IFsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4N2E3Y2QzZGRjLi44YTdkZDI3MThlOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMTEtMDcgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBSZW1vdmUgdW51c2VkIFBhZ2UuU2NyaXB0SWRlbnRpZmllciBwcm90b2NvbCB0eXBlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0MDcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFZlcnNpb25z L0luc3BlY3Rvci1pT1MtMTAuMC5qc29uOgorICAgICAgICAqIFZlcnNpb25zL0luc3BlY3Rvci1p T1MtMTAuMy5qc29uOgorICAgICAgICAqIFZlcnNpb25zL0luc3BlY3Rvci1pT1MtMTEuMC5qc29u OgorICAgICAgICAqIFZlcnNpb25zL0luc3BlY3Rvci1pT1MtNy4wLmpzb246CisgICAgICAgICog VmVyc2lvbnMvSW5zcGVjdG9yLWlPUy04LjAuanNvbjoKKyAgICAgICAgKiBWZXJzaW9ucy9JbnNw ZWN0b3ItaU9TLTkuMC5qc29uOgorICAgICAgICAqIFZlcnNpb25zL0luc3BlY3Rvci1pT1MtOS4z Lmpzb246CisgICAgICAgIFJlbW92ZSB1bnVzZWQgcHJvdG9jb2wgdHlwZS4KKwogMjAxNy0xMS0w NiAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBTdHlsZXMgUmVkZXNpZ246IERpc3BsYXkgd2FybmluZ3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTEwLjAuanNvbiBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTEwLjAuanNvbgpp bmRleCBhMDExNDI4MjQxZi4uOWUwYzZjZGIyMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTEwLjAuanNvbgorKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy0xMC4wLmpzb24KQEAgLTI3MTcsMTEg KzI3MTcsNiBAQAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic2VjdXJlIiwgInR5cGUiOiAi Ym9vbGVhbiIsICJkZXNjcmlwdGlvbiI6ICJUcnVlIGlmIGNvb2tpZSBpcyBzZWN1cmUuIiB9LAog ICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic2Vzc2lvbiIsICJ0eXBlIjogImJvb2xlYW4iLCAi ZGVzY3JpcHRpb24iOiAiVHJ1ZSBpbiBjYXNlIG9mIHNlc3Npb24gY29va2llLiIgfQogICAgICAg ICAgICAgXQotICAgICAgICB9LAotICAgICAgICB7Ci0gICAgICAgICAgICAiaWQiOiAiU2NyaXB0 SWRlbnRpZmllciIsCi0gICAgICAgICAgICAidHlwZSI6ICJzdHJpbmciLAotICAgICAgICAgICAg ImRlc2NyaXB0aW9uIjogIlVuaXF1ZSBzY3JpcHQgaWRlbnRpZmllci4iCiAgICAgICAgIH0KICAg ICBdLAogICAgICJjb21tYW5kcyI6IFsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTEwLjMuanNvbiBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTEwLjMuanNvbgppbmRleCA3MjI5YmQ2M2I4YS4uYzlk ODdlMGQyMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNw ZWN0b3ItaU9TLTEwLjMuanNvbgorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMv SW5zcGVjdG9yLWlPUy0xMC4zLmpzb24KQEAgLTI3NjMsMTEgKzI3NjMsNiBAQAogICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAic2VjdXJlIiwgInR5cGUiOiAiYm9vbGVhbiIsICJkZXNjcmlwdGlv biI6ICJUcnVlIGlmIGNvb2tpZSBpcyBzZWN1cmUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAic2Vzc2lvbiIsICJ0eXBlIjogImJvb2xlYW4iLCAiZGVzY3JpcHRpb24iOiAiVHJ1ZSBp biBjYXNlIG9mIHNlc3Npb24gY29va2llLiIgfQogICAgICAgICAgICAgXQotICAgICAgICB9LAot ICAgICAgICB7Ci0gICAgICAgICAgICAiaWQiOiAiU2NyaXB0SWRlbnRpZmllciIsCi0gICAgICAg ICAgICAidHlwZSI6ICJzdHJpbmciLAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVuaXF1 ZSBzY3JpcHQgaWRlbnRpZmllci4iCiAgICAgICAgIH0KICAgICBdLAogICAgICJjb21tYW5kcyI6 IFsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3It aU9TLTExLjAuanNvbiBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3It aU9TLTExLjAuanNvbgppbmRleCAwNTkxZGZhNTQyMC4uZDY5NjczZTcxZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTExLjAuanNvbgor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy0xMS4wLmpz b24KQEAgLTI4NzgsMTEgKzI4NzgsNiBAQAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic2Vj dXJlIiwgInR5cGUiOiAiYm9vbGVhbiIsICJkZXNjcmlwdGlvbiI6ICJUcnVlIGlmIGNvb2tpZSBp cyBzZWN1cmUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic2Vzc2lvbiIsICJ0eXBl IjogImJvb2xlYW4iLCAiZGVzY3JpcHRpb24iOiAiVHJ1ZSBpbiBjYXNlIG9mIHNlc3Npb24gY29v a2llLiIgfQogICAgICAgICAgICAgXQotICAgICAgICB9LAotICAgICAgICB7Ci0gICAgICAgICAg ICAiaWQiOiAiU2NyaXB0SWRlbnRpZmllciIsCi0gICAgICAgICAgICAidHlwZSI6ICJzdHJpbmci LAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVuaXF1ZSBzY3JpcHQgaWRlbnRpZmllci4i CiAgICAgICAgIH0KICAgICBdLAogICAgICJjb21tYW5kcyI6IFsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTcuMC5qc29uIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1ZlcnNpb25zL0luc3BlY3Rvci1pT1MtNy4wLmpzb24KaW5kZXggMWUz NzNhYWZhMWEuLjdhMThhNjMxYzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VmVyc2lvbnMvSW5zcGVjdG9yLWlPUy03LjAuanNvbgorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy03LjAuanNvbgpAQCAtMTA5LDExICsxMDksNiBAQAog ICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNlY3VyZSIsICJ0eXBlIjogImJvb2xlYW4i LCAiZGVzY3JpcHRpb24iOiAiVHJ1ZSBpZiBjb29raWUgaXMgc2VjdXJlLiIgfSwKICAgICAgICAg ICAgICAgICAgICAgeyAibmFtZSI6ICJzZXNzaW9uIiwgInR5cGUiOiAiYm9vbGVhbiIsICJkZXNj cmlwdGlvbiI6ICJUcnVlIGluIGNhc2Ugb2Ygc2Vzc2lvbiBjb29raWUuIiB9CiAgICAgICAgICAg ICAgICAgXQotICAgICAgICAgICAgfSwKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAi aWQiOiAiU2NyaXB0SWRlbnRpZmllciIsCi0gICAgICAgICAgICAgICAgInR5cGUiOiAic3RyaW5n IiwKLSAgICAgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiVW5pcXVlIHNjcmlwdCBpZGVudGlm aWVyLiIKICAgICAgICAgICAgIH0KICAgICAgICAgXSwKICAgICAgICAgImNvbW1hbmRzIjogWwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1ZlcnNpb25zL0luc3BlY3Rvci1pT1Mt OC4wLmpzb24gYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy04 LjAuanNvbgppbmRleCBkODU3ZmU3YWI2Ny4uMzI2OGIwNzM5MmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTguMC5qc29uCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTguMC5qc29uCkBAIC0y NTkzLDExICsyNTkzLDYgQEAKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNlY3VyZSIsICJ0 eXBlIjogImJvb2xlYW4iLCAiZGVzY3JpcHRpb24iOiAiVHJ1ZSBpZiBjb29raWUgaXMgc2VjdXJl LiIgfSwKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNlc3Npb24iLCAidHlwZSI6ICJib29s ZWFuIiwgImRlc2NyaXB0aW9uIjogIlRydWUgaW4gY2FzZSBvZiBzZXNzaW9uIGNvb2tpZS4iIH0K ICAgICAgICAgICAgIF0KLSAgICAgICAgfSwKLSAgICAgICAgewotICAgICAgICAgICAgImlkIjog IlNjcmlwdElkZW50aWZpZXIiLAotICAgICAgICAgICAgInR5cGUiOiAic3RyaW5nIiwKLSAgICAg ICAgICAgICJkZXNjcmlwdGlvbiI6ICJVbmlxdWUgc2NyaXB0IGlkZW50aWZpZXIuIgogICAgICAg ICB9CiAgICAgXSwKICAgICAiY29tbWFuZHMiOiBbCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy05LjAuanNvbiBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0b3ItaU9TLTkuMC5qc29uCmluZGV4IDlkMDE5ODcyZjk3 Li41MWY3NTUyNzEwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1ZlcnNpb25z L0luc3BlY3Rvci1pT1MtOS4wLmpzb24KKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1ZlcnNp b25zL0luc3BlY3Rvci1pT1MtOS4wLmpzb24KQEAgLTI0NzEsMTEgKzI0NzEsNiBAQAogICAgICAg ICAgICAgICAgIHsgIm5hbWUiOiAic2VjdXJlIiwgInR5cGUiOiAiYm9vbGVhbiIsICJkZXNjcmlw dGlvbiI6ICJUcnVlIGlmIGNvb2tpZSBpcyBzZWN1cmUuIiB9LAogICAgICAgICAgICAgICAgIHsg Im5hbWUiOiAic2Vzc2lvbiIsICJ0eXBlIjogImJvb2xlYW4iLCAiZGVzY3JpcHRpb24iOiAiVHJ1 ZSBpbiBjYXNlIG9mIHNlc3Npb24gY29va2llLiIgfQogICAgICAgICAgICAgXQotICAgICAgICB9 LAotICAgICAgICB7Ci0gICAgICAgICAgICAiaWQiOiAiU2NyaXB0SWRlbnRpZmllciIsCi0gICAg ICAgICAgICAidHlwZSI6ICJzdHJpbmciLAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVu aXF1ZSBzY3JpcHQgaWRlbnRpZmllci4iCiAgICAgICAgIH0KICAgICBdLAogICAgICJjb21tYW5k cyI6IFsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9WZXJzaW9ucy9JbnNwZWN0 b3ItaU9TLTkuMy5qc29uIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1ZlcnNpb25zL0luc3BlY3Rv ci1pT1MtOS4zLmpzb24KaW5kZXggYTRiODBjZDlkNzUuLmI1NzU1MGMxNmY1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy05LjMuanNvbgor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVmVyc2lvbnMvSW5zcGVjdG9yLWlPUy05LjMuanNv bgpAQCAtMjU0NiwxMSArMjU0Niw2IEBACiAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJzZWN1 cmUiLCAidHlwZSI6ICJib29sZWFuIiwgImRlc2NyaXB0aW9uIjogIlRydWUgaWYgY29va2llIGlz IHNlY3VyZS4iIH0sCiAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJzZXNzaW9uIiwgInR5cGUi OiAiYm9vbGVhbiIsICJkZXNjcmlwdGlvbiI6ICJUcnVlIGluIGNhc2Ugb2Ygc2Vzc2lvbiBjb29r aWUuIiB9CiAgICAgICAgICAgICBdCi0gICAgICAgIH0sCi0gICAgICAgIHsKLSAgICAgICAgICAg ICJpZCI6ICJTY3JpcHRJZGVudGlmaWVyIiwKLSAgICAgICAgICAgICJ0eXBlIjogInN0cmluZyIs Ci0gICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiVW5pcXVlIHNjcmlwdCBpZGVudGlmaWVyLiIK ICAgICAgICAgfQogICAgIF0sCiAgICAgImNvbW1hbmRzIjogWwo=