179400 2017-11-07 16:05:28 -0800 There is no such thing as block element continuation 2017-11-15 12:09:39 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham buildbot simon.fraser webkit-bug-importer zalan oldest_to_newest 1369260 0 koivisto 2017-11-07 16:05:28 -0800 There are no non-anonymous block continuations. This is dead code. 1369261 1 326272 koivisto 2017-11-07 16:07:50 -0800 Created attachment 326272 patch 1369262 2 buildbot 2017-11-07 16:10:37 -0800 Attachment 326272 did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlock.cpp:420: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1369274 3 koivisto 2017-11-07 17:03:26 -0800 https://trac.webkit.org/r224561 1372083 4 webkit-bug-importer 2017-11-15 12:09:39 -0800 <rdar://problem/35567042> 326272 2017-11-07 16:07:50 -0800 2017-11-07 16:15:19 -0800 patch no-block-element-continuation.patch text/plain 5401 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDU1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTExLTA3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUaGVyZSBpcyBubyBzdWNoIHRo aW5nIGFzIGJsb2NrIGVsZW1lbnQgY29udGludWF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgbm8gbm9uLWFub255bW91cyBibG9j ayBjb250aW51YXRpb25zLiBUaGlzIGlzIGRlYWQgY29kZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpib3JkZXJPclBhZGRpbmdMb2dp Y2FsV2lkdGhDaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpzdHlsZURp ZENoYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6YmxvY2tFbGVtZW50Q29u dGludWF0aW9uIGNvbnN0KTogRGVsZXRlZC4KKworICAgICAgICAgICAgVGhpcyB3b3VsZCBhbHdh eXMgcmV0dXJuIG51bGwuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKwog MjAxNy0xMS0wNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg SW1wbGVtZW50ICJVcGRhdGVXb3JrZXJTdGF0ZSIgYW5kIHVzZSBpdApJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAyMjQ1MDcpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 MTIsMTggKzQxMiwxOCBAQCB2b2lkIFJlbmRlckJsb2NrOjpzdHlsZVdpbGxDaGFuZ2UoU3R5bGVE CiAgICAgUmVuZGVyQm94OjpzdHlsZVdpbGxDaGFuZ2UoZGlmZiwgbmV3U3R5bGUpOwogfQogCi1z dGF0aWMgYm9vbCBib3JkZXJPclBhZGRpbmdMb2dpY2FsV2lkdGhDaGFuZ2VkKGNvbnN0IFJlbmRl clN0eWxlKiBvbGRTdHlsZSwgY29uc3QgUmVuZGVyU3R5bGUqIG5ld1N0eWxlKQorc3RhdGljIGJv b2wgYm9yZGVyT3JQYWRkaW5nTG9naWNhbFdpZHRoQ2hhbmdlZChjb25zdCBSZW5kZXJTdHlsZSYg b2xkU3R5bGUsIGNvbnN0IFJlbmRlclN0eWxlJiBuZXdTdHlsZSkKIHsKLSAgICBpZiAobmV3U3R5 bGUtPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCi0gICAgICAgIHJldHVybiBvbGRTdHlsZS0+ Ym9yZGVyTGVmdFdpZHRoKCkgIT0gbmV3U3R5bGUtPmJvcmRlckxlZnRXaWR0aCgpCi0gICAgICAg ICAgICB8fCBvbGRTdHlsZS0+Ym9yZGVyUmlnaHRXaWR0aCgpICE9IG5ld1N0eWxlLT5ib3JkZXJS aWdodFdpZHRoKCkKLSAgICAgICAgICAgIHx8IG9sZFN0eWxlLT5wYWRkaW5nTGVmdCgpICE9IG5l d1N0eWxlLT5wYWRkaW5nTGVmdCgpCi0gICAgICAgICAgICB8fCBvbGRTdHlsZS0+cGFkZGluZ1Jp Z2h0KCkgIT0gbmV3U3R5bGUtPnBhZGRpbmdSaWdodCgpOwotCi0gICAgcmV0dXJuIG9sZFN0eWxl LT5ib3JkZXJUb3BXaWR0aCgpICE9IG5ld1N0eWxlLT5ib3JkZXJUb3BXaWR0aCgpCi0gICAgICAg IHx8IG9sZFN0eWxlLT5ib3JkZXJCb3R0b21XaWR0aCgpICE9IG5ld1N0eWxlLT5ib3JkZXJCb3R0 b21XaWR0aCgpCi0gICAgICAgIHx8IG9sZFN0eWxlLT5wYWRkaW5nVG9wKCkgIT0gbmV3U3R5bGUt PnBhZGRpbmdUb3AoKQotICAgICAgICB8fCBvbGRTdHlsZS0+cGFkZGluZ0JvdHRvbSgpICE9IG5l d1N0eWxlLT5wYWRkaW5nQm90dG9tKCk7CisgICAgaWYgKG5ld1N0eWxlLmlzSG9yaXpvbnRhbFdy aXRpbmdNb2RlKCkpCisgICAgICAgIHJldHVybiBvbGRTdHlsZS5ib3JkZXJMZWZ0V2lkdGgoKSAh PSBuZXdTdHlsZS5ib3JkZXJMZWZ0V2lkdGgoKQorICAgICAgICAgICAgfHwgb2xkU3R5bGUuYm9y ZGVyUmlnaHRXaWR0aCgpICE9IG5ld1N0eWxlLmJvcmRlclJpZ2h0V2lkdGgoKQorICAgICAgICAg ICAgfHwgb2xkU3R5bGUucGFkZGluZ0xlZnQoKSAhPSBuZXdTdHlsZS5wYWRkaW5nTGVmdCgpCisg ICAgICAgICAgICB8fCBvbGRTdHlsZS5wYWRkaW5nUmlnaHQoKSAhPSBuZXdTdHlsZS5wYWRkaW5n UmlnaHQoKTsKKworICAgIHJldHVybiBvbGRTdHlsZS5ib3JkZXJUb3BXaWR0aCgpICE9IG5ld1N0 eWxlLmJvcmRlclRvcFdpZHRoKCkKKyAgICAgICAgfHwgb2xkU3R5bGUuYm9yZGVyQm90dG9tV2lk dGgoKSAhPSBuZXdTdHlsZS5ib3JkZXJCb3R0b21XaWR0aCgpCisgICAgICAgIHx8IG9sZFN0eWxl LnBhZGRpbmdUb3AoKSAhPSBuZXdTdHlsZS5wYWRkaW5nVG9wKCkKKyAgICAgICAgfHwgb2xkU3R5 bGUucGFkZGluZ0JvdHRvbSgpICE9IG5ld1N0eWxlLnBhZGRpbmdCb3R0b20oKTsKIH0KIAogdm9p ZCBSZW5kZXJCbG9jazo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0 IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKQEAgLTQzNCwxOCArNDM0LDExIEBAIHZvaWQgUmVuZGVy QmxvY2s6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGkKICAgICBpZiAoaGFkVHJhbnNmb3JtICE9IGhh c1RyYW5zZm9ybSgpKQogICAgICAgICBhZGp1c3RGcmFnbWVudGVkRmxvd1N0YXRlT25Db250YWlu aW5nQmxvY2tDaGFuZ2VJZk5lZWRlZCgpOwogCi0gICAgYXV0byYgbmV3U3R5bGUgPSBzdHlsZSgp OwotICAgIGlmICghaXNBbm9ueW1vdXNCbG9jaygpICYmICFpc0NvbnRpbnVhdGlvbigpKSB7Ci0g ICAgICAgIC8vIEVuc3VyZSB0aGF0IGFsbCBvZiBvdXIgY29udGludWF0aW9uIGJsb2NrcyBwaWNr IHVwIHRoZSBuZXcgc3R5bGUuCi0gICAgICAgIGZvciAoUmVuZGVyQmxvY2sqIGN1cnJDb250ID0g YmxvY2tFbGVtZW50Q29udGludWF0aW9uKCk7IGN1cnJDb250OyBjdXJyQ29udCA9IGN1cnJDb250 LT5ibG9ja0VsZW1lbnRDb250aW51YXRpb24oKSkKLSAgICAgICAgICAgIGN1cnJDb250LT5zZXRT dHlsZShSZW5kZXJTdHlsZTo6Y2xvbmUobmV3U3R5bGUpKTsKLSAgICB9Ci0KICAgICBwcm9wYWdh dGVTdHlsZVRvQW5vbnltb3VzQ2hpbGRyZW4oUHJvcGFnYXRlVG9CbG9ja0NoaWxkcmVuT25seSk7 CiAKICAgICAvLyBJdCdzIHBvc3NpYmxlIGZvciBvdXIgYm9yZGVyL3BhZGRpbmcgdG8gY2hhbmdl LCBidXQgZm9yIHRoZSBvdmVyYWxsIGxvZ2ljYWwgd2lkdGggb2YgdGhlIGJsb2NrIHRvCiAgICAg Ly8gZW5kIHVwIGJlaW5nIHRoZSBzYW1lLiBXZSBrZWVwIHRyYWNrIG9mIHRoaXMgY2hhbmdlIHNv IGluIGxheW91dEJsb2NrLCB3ZSBjYW4ga25vdyB0byBzZXQgcmVsYXlvdXRDaGlsZHJlbj10cnVl LgotICAgIHNldFNob3VsZEZvcmNlUmVsYXlvdXRDaGlsZHJlbihvbGRTdHlsZSAmJiBkaWZmID09 IFN0eWxlRGlmZmVyZW5jZUxheW91dCAmJiBuZWVkc0xheW91dCgpICYmIGJvcmRlck9yUGFkZGlu Z0xvZ2ljYWxXaWR0aENoYW5nZWQob2xkU3R5bGUsICZuZXdTdHlsZSkpOworICAgIHNldFNob3Vs ZEZvcmNlUmVsYXlvdXRDaGlsZHJlbihvbGRTdHlsZSAmJiBkaWZmID09IFN0eWxlRGlmZmVyZW5j ZUxheW91dCAmJiBuZWVkc0xheW91dCgpICYmIGJvcmRlck9yUGFkZGluZ0xvZ2ljYWxXaWR0aENo YW5nZWQoKm9sZFN0eWxlLCBzdHlsZSgpKSk7CiB9CiAKIFJlbmRlckJsb2NrKiBSZW5kZXJCbG9j azo6Y29udGludWF0aW9uQmVmb3JlKFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQpCkBAIC0xNzQz LDE3ICsxNzM2LDYgQEAgUmVuZGVySW5saW5lKiBSZW5kZXJCbG9jazo6aW5saW5lRWxlbWVudAog ICAgIHJldHVybiBpczxSZW5kZXJJbmxpbmU+KGNvbnRpbnVhdGlvbikgPyBkb3duY2FzdDxSZW5k ZXJJbmxpbmU+KGNvbnRpbnVhdGlvbikgOiBudWxscHRyOwogfQogCi1SZW5kZXJCbG9jayogUmVu ZGVyQmxvY2s6OmJsb2NrRWxlbWVudENvbnRpbnVhdGlvbigpIGNvbnN0Ci17Ci0gICAgUmVuZGVy Qm94TW9kZWxPYmplY3QqIGN1cnJlbnRDb250aW51YXRpb24gPSBjb250aW51YXRpb24oKTsKLSAg ICBpZiAoIWN1cnJlbnRDb250aW51YXRpb24gfHwgY3VycmVudENvbnRpbnVhdGlvbi0+aXNJbmxp bmUoKSkKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgUmVuZGVyQmxvY2smIG5leHRDb250 aW51YXRpb24gPSBkb3duY2FzdDxSZW5kZXJCbG9jaz4oKmN1cnJlbnRDb250aW51YXRpb24pOwot ICAgIGlmIChuZXh0Q29udGludWF0aW9uLmlzQW5vbnltb3VzQmxvY2soKSkKLSAgICAgICAgcmV0 dXJuIG5leHRDb250aW51YXRpb24uYmxvY2tFbGVtZW50Q29udGludWF0aW9uKCk7Ci0gICAgcmV0 dXJuICZuZXh0Q29udGludWF0aW9uOwotfQotICAgIAogc3RhdGljIENvbnRpbnVhdGlvbk91dGxp bmVUYWJsZU1hcCogY29udGludWF0aW9uT3V0bGluZVRhYmxlKCkKIHsKICAgICBzdGF0aWMgTmV2 ZXJEZXN0cm95ZWQ8Q29udGludWF0aW9uT3V0bGluZVRhYmxlTWFwPiB0YWJsZTsKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCShyZXZpc2lvbiAyMjQ1MDcpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAt MTkwLDcgKzE5MCw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNBbm9ueW1vdXNCbG9ja0NvbnRp bnVhdGlvbigpIGNvbnN0IHsgcmV0dXJuIGlzQW5vbnltb3VzQmxvY2soKSAmJiBjb250aW51YXRp b24oKTsgfQogICAgIFdFQkNPUkVfRVhQT1JUIFJlbmRlcklubGluZSogaW5saW5lRWxlbWVudENv bnRpbnVhdGlvbigpIGNvbnN0OwotICAgIFJlbmRlckJsb2NrKiBibG9ja0VsZW1lbnRDb250aW51 YXRpb24oKSBjb25zdDsKIAogICAgIHN0YXRpYyBSZW5kZXJQdHI8UmVuZGVyQmxvY2s+IGNyZWF0 ZUFub255bW91c1dpdGhQYXJlbnRSZW5kZXJlckFuZERpc3BsYXkoY29uc3QgUmVuZGVyQm94JiBw YXJlbnQsIEVEaXNwbGF5ID0gQkxPQ0spOwogICAgIFJlbmRlclB0cjxSZW5kZXJCbG9jaz4gY3Jl YXRlQW5vbnltb3VzQmxvY2soRURpc3BsYXkgPSBCTE9DSykgY29uc3Q7Cg==