179397 2017-11-07 15:18:08 -0800 [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy 2017-11-15 09:39:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 frederik.riedel webkit-unassigned commit-queue frederik.riedel webkit-bug-importer wenson_hsieh oldest_to_newest 1369238 0 frederik.riedel 2017-11-07 15:18:08 -0800 Use new class name from UIKit when checking UITextSuggestion type. It seems like https://bugs.webkit.org/show_bug.cgi?id=178416 only covers the WebKit2 part of this but not WebKit1. The old UITextSuggestion type is still being used in DOMHTMLInputElement and should be replaced. 1369239 1 326268 frederik.riedel 2017-11-07 15:20:41 -0800 Created attachment 326268 Patch 1369668 2 326268 wenson_hsieh 2017-11-08 15:55:44 -0800 Comment on attachment 326268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326268&action=review Good catch, Frederik! Just a few comments, inline. > Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:39 > +// FIXME: This can be safely removed once <rdar://problem/34583628> lands in the SDK. This @implementation can be safely removed now :) Instead of making pieces of DOMHTMLInputElement.mm contingent on USE(APPLE_INTERNAL_SDK), I think we should instead define the new interfaces as needed to build against an SDK without this header. In other words, we should be doing something along the lines of: #if TARGET_OS_IPHONE #if __has_include(<UIKit/UITextAutofillSuggestion.h>) // Just import the header directly. #else // Declare an @interface for UITextAutofillSuggestion, with whichever properties we'll need to build. #endif #endif // TARGET_OS_IPHONE > Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:706 > #if USE(APPLE_INTERNAL_SDK) && TARGET_OS_IPHONE I know this isn't new with this patch, but we should really make this guarded on just TARGET_OS_PHONE, and not additionally guard it with USE(APPLE_INTERNAL_SDK). In general, we strive to only have USE(APPLE_INTERNAL_SDK) in headers rather than implementation files. That way, WebKit built with the internal SDK won't behave differently than WebKit built using OpenSource (there are some exceptions, as you probably recall, but this case in particular isn't one where we need to draw a distinction between internal/open source configurations). 1369838 3 326268 frederik.riedel 2017-11-09 03:22:19 -0800 Comment on attachment 326268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326268&action=review >> Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:39 >> +// FIXME: This can be safely removed once <rdar://problem/34583628> lands in the SDK. > > This @implementation can be safely removed now :) > > Instead of making pieces of DOMHTMLInputElement.mm contingent on USE(APPLE_INTERNAL_SDK), I think we should instead define the new interfaces as needed to build against an SDK without this header. In other words, we should be doing something along the lines of: > > #if TARGET_OS_IPHONE > #if __has_include(<UIKit/UITextAutofillSuggestion.h>) > > // Just import the header directly. > > #else > > // Declare an @interface for UITextAutofillSuggestion, with whichever properties we'll need to build. > > #endif > #endif // TARGET_OS_IPHONE Done. Import if available and otherwise declaring the interface with @properties for username and password, because we use them below. >> Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:706 >> #if USE(APPLE_INTERNAL_SDK) && TARGET_OS_IPHONE > > I know this isn't new with this patch, but we should really make this guarded on just TARGET_OS_PHONE, and not additionally guard it with USE(APPLE_INTERNAL_SDK). In general, we strive to only have USE(APPLE_INTERNAL_SDK) in headers rather than implementation files. That way, WebKit built with the internal SDK won't behave differently than WebKit built using OpenSource (there are some exceptions, as you probably recall, but this case in particular isn't one where we need to draw a distinction between internal/open source configurations). That makes sense, I removed the APPLE_INTERNAL_SDK guard here. This should work now because the @interface declaration for UITextAutofillSuggestion above sits behind the same guard. 1369839 4 326438 frederik.riedel 2017-11-09 03:25:58 -0800 Created attachment 326438 Patch 1369848 5 326444 frederik.riedel 2017-11-09 04:50:18 -0800 Created attachment 326444 Patch 1370293 6 326444 wenson_hsieh 2017-11-10 07:14:38 -0800 Comment on attachment 326444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326444&action=review > Source/WebKitLegacy/mac/ChangeLog:3 > + Replaced the old placeholder UIKit class with the real class name in WebKitLegacy. This is a minor nit, but I just noticed - the ChangeLog title here should be the same as the title of the bug ([iOS] Use new class name...). Is it OK if you make this tweak and upload a new patch? 1370299 7 326576 frederik.riedel 2017-11-10 07:40:49 -0800 Created attachment 326576 Patch 1370331 8 326576 commit-queue 2017-11-10 08:25:18 -0800 Comment on attachment 326576 Patch Clearing flags on attachment: 326576 Committed r224682: <https://trac.webkit.org/changeset/224682> 1370332 9 commit-queue 2017-11-10 08:25:20 -0800 All reviewed patches have been landed. Closing bug. 1371947 10 webkit-bug-importer 2017-11-15 09:39:50 -0800 <rdar://problem/35562181> 326268 2017-11-07 15:20:41 -0800 2017-11-09 03:25:53 -0800 Patch bug-179397-20171108002039.patch text/plain 3293 frederik.riedel U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNjAzZWYyZGFmZWQ0ODc2MzUwNTZkYWEwMTlkMDEzNjIyZDQ2NTIzNi4uNDBmZTg3ODhjZDdl ODVmOGY0YTM3ZmRiZWYzOTQ4MjU5YjI4MjIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTA3ICBGcmVkZXJpayBSaWVkZWwgIDxmcmVkZXJp ay5yaWVkZWxAZnJvZ2cuaW8+CisKKyAgICAgICAgUmVwbGFjZWQgdGhlIG9sZCBwbGFjZWhvbGRl ciBVSUtpdCBjbGFzcyB3aXRoIHRoZSByZWFsIGNsYXNzIG5hbWUgaW4gV2ViS2l0TGVnYWN5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5Mzk3CisK KyAgICAgICAgKiBET00vRE9NSFRNTElucHV0RWxlbWVudC5tbToKKyAgICAgICAgKC1bVUlUZXh0 QXV0b2ZpbGxTdWdnZXN0aW9uIGluaXRXaXRoVXNlcm5hbWU6cGFzc3dvcmQ6XSk6CisgICAgICAg ICgrW1VJVGV4dEF1dG9maWxsU3VnZ2VzdGlvbiBhdXRvZmlsbFN1Z2dlc3Rpb25XaXRoVXNlcm5h bWU6cGFzc3dvcmQ6XSk6CisgICAgICAgICgtW0RPTUhUTUxJbnB1dEVsZW1lbnQgaW5zZXJ0VGV4 dFN1Z2dlc3Rpb246XSk6CisKIDIwMTctMTEtMDYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIFJlc291cmNlTG9hZGVyOjp3aWxsU2Vu ZFJlcXVlc3RJbnRlcm5hbCBhc3luY2hyb25vdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRM ZWdhY3kvbWFjL0RPTS9ET01IVE1MSW5wdXRFbGVtZW50Lm1tIGIvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQubW0KaW5kZXggOGMyMDQzMzcyMWZjOTI1NDQ0 OTdhYzdlYzQzN2M2OWVhMDQ2Y2EwMC4uNGU2ZjgyN2YxN2VkYzc4YmVmNGU1YTQ4MDU2Mjg4NTA1 YjgwZmZhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJ bnB1dEVsZW1lbnQubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJ bnB1dEVsZW1lbnQubW0KQEAgLTM0LDE5ICszNCwyNiBAQAogI2ltcG9ydCAiRE9NUHJpdmF0ZS5o IgogI2ltcG9ydCAiRXhjZXB0aW9uSGFuZGxlcnMuaCIKIAotLy8gRklYTUU6IFNpbXBsaWZ5IHRo aXMgb25jZSA8cmRhcjovL3Byb2JsZW0vMzQ1ODM2Mjg+IGlzIGF2YWlsYWJsZSBpbiB0aGUgYnVp bGQuCiAjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgVEFSR0VUX09TX0lQSE9ORQotI2lm IF9faGFzX2luY2x1ZGUoPFVJS2l0L1VJS2V5Ym9hcmRMb2dpbkNyZWRlbnRpYWxzU3VnZ2VzdGlv bi5oPikKLSNpbXBvcnQgPFVJS2l0L1VJS2V5Ym9hcmRMb2dpbkNyZWRlbnRpYWxzU3VnZ2VzdGlv bi5oPgotI2Vsc2UKLSNpbXBvcnQgPFVJS2l0L1VJVGV4dElucHV0X1ByaXZhdGUuaD4KLUBpbnRl cmZhY2UgVUlLZXlib2FyZExvZ2luQ3JlZGVudGlhbHNTdWdnZXN0aW9uIDogVUlUZXh0U3VnZ2Vz dGlvbgotCi1AcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmluZyAqdXNlcm5hbWU7 Ci1AcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmluZyAqcGFzc3dvcmQ7CisjaWYg IV9faGFzX2luY2x1ZGUoPFVJS2l0L1VJVGV4dEF1dG9maWxsU3VnZ2VzdGlvbi5oPikKKy8vIEZJ WE1FOiBUaGlzIGNhbiBiZSBzYWZlbHkgcmVtb3ZlZCBvbmNlIDxyZGFyOi8vcHJvYmxlbS8zNDU4 MzYyOD4gbGFuZHMgaW4gdGhlIFNESy4KK0BpbXBsZW1lbnRhdGlvbiBVSVRleHRBdXRvZmlsbFN1 Z2dlc3Rpb24KKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aFVzZXJuYW1lOihOU1N0cmluZyAqKXVz ZXJuYW1lIHBhc3N3b3JkOihOU1N0cmluZyAqKXBhc3N3b3JkCit7CisgICAgc2VsZiA9IFtzdXBl ciBpbml0XTsKKyAgICBpZiAoc2VsZikgeworICAgICAgICBfdXNlcm5hbWUgPSB1c2VybmFtZTsK KyAgICAgICAgX3Bhc3N3b3JkID0gcGFzc3dvcmQ7CisgICAgfQorICAgIHJldHVybiBzZWxmOwor fQogCisrIChpbnN0YW5jZXR5cGUpYXV0b2ZpbGxTdWdnZXN0aW9uV2l0aFVzZXJuYW1lOihOU1N0 cmluZyAqKXVzZXJuYW1lIHBhc3N3b3JkOihOU1N0cmluZyAqKXBhc3N3b3JkCit7CisgICAgcmV0 dXJuIFtbc2VsZiBhbGxvY10gaW5pdFdpdGhVc2VybmFtZTp1c2VybmFtZSBwYXNzd29yZDpwYXNz d29yZF07Cit9CiBAZW5kCi0jZW5kaWYgLy8gX19oYXNfaW5jbHVkZSg8VUlLaXQvVUlLZXlib2Fy ZExvZ2luQ3JlZGVudGlhbHNTdWdnZXN0aW9uLmg+KQorI2VuZGlmIC8vICFfX2hhc19pbmNsdWRl KDxVSUtpdC9VSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24uaD4pCiAjZW5kaWYgLy8gVVNFKEFQUExF X0lOVEVSTkFMX1NESykgJiYgVEFSR0VUX09TX0lQSE9ORQogCiAjaW1wb3J0IDxXZWJDb3JlL0F1 dG9maWxsRWxlbWVudHMuaD4KQEAgLTY5NywxMiArNzA0LDEyIEBACiB9CiAKICNpZiBVU0UoQVBQ TEVfSU5URVJOQUxfU0RLKSAmJiBUQVJHRVRfT1NfSVBIT05FCi0tICh2b2lkKWluc2VydFRleHRT dWdnZXN0aW9uOihVSUtleWJvYXJkTG9naW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24gKiljcmVkZW50 aWFsc1N1Z2dlc3Rpb24KKy0gKHZvaWQpaW5zZXJ0VGV4dFN1Z2dlc3Rpb246KFVJVGV4dEF1dG9m aWxsU3VnZ2VzdGlvbiAqKWNyZWRlbnRpYWxTdWdnZXN0aW9uCiB7CiAgICAgV2ViQ29yZTo6SlNN YWluVGhyZWFkTnVsbFN0YXRlIHN0YXRlOwogICAgIGlmIChpczxXZWJDb3JlOjpIVE1MSW5wdXRF bGVtZW50PihJTVBMKSkgewogICAgICAgICBpZiAoYXV0byBhdXRvZmlsbEVsZW1lbnRzID0gV2Vi Q29yZTo6QXV0b2ZpbGxFbGVtZW50czo6Y29tcHV0ZUF1dG9maWxsRWxlbWVudHMoKklNUEwpKQot ICAgICAgICAgICAgYXV0b2ZpbGxFbGVtZW50cy0+YXV0b2ZpbGwoY3JlZGVudGlhbHNTdWdnZXN0 aW9uLnVzZXJuYW1lLCBjcmVkZW50aWFsc1N1Z2dlc3Rpb24ucGFzc3dvcmQpOworICAgICAgICAg ICAgYXV0b2ZpbGxFbGVtZW50cy0+YXV0b2ZpbGwoY3JlZGVudGlhbFN1Z2dlc3Rpb24udXNlcm5h bWUsIGNyZWRlbnRpYWxTdWdnZXN0aW9uLnBhc3N3b3JkKTsKICAgICB9CiB9CiAjZW5kaWYgLy8g VVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgVEFSR0VUX09TX0lQSE9ORQo= 326438 2017-11-09 03:25:58 -0800 2017-11-09 04:50:13 -0800 Patch bug-179397-20171109122556.patch text/plain 2999 frederik.riedel U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNjAzZWYyZGFmZWQ0ODc2MzUwNTZkYWEwMTlkMDEzNjIyZDQ2NTIzNi4uYzM1Mjg3NzBjODQw MmNjM2MyZjViYjQzZjllZDA0MDgzZmY3ZjFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTA5ICBGcmVkZXJpayBSaWVkZWwgIDxmcmVkZXJp ay5yaWVkZWxAZnJvZ2cuaW8+CisKKyAgICAgICAgUmVwbGFjZWQgdGhlIG9sZCBwbGFjZWhvbGRl ciBVSUtpdCBjbGFzcyB3aXRoIHRoZSByZWFsIGNsYXNzIG5hbWUgaW4gV2ViS2l0TGVnYWN5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5Mzk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBET00vRE9N SFRNTElucHV0RWxlbWVudC5tbToKKyAgICAgICAgKC1bRE9NSFRNTElucHV0RWxlbWVudCBpbnNl cnRUZXh0U3VnZ2VzdGlvbjpdKToKKwogMjAxNy0xMS0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgUmVzb3VyY2VMb2FkZXI6Ondp bGxTZW5kUmVxdWVzdEludGVybmFsIGFzeW5jaHJvbm91cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQubW0gYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9ET00vRE9NSFRNTElucHV0RWxlbWVudC5tbQppbmRleCA4YzIwNDMzNzIxZmM5 MjU0NDQ5N2FjN2VjNDM3YzY5ZWEwNDZjYTAwLi4wOTA0MjIxMGRmMjcyYTdhNDJkZjJlZTYzMDM4 ZDc3YzI1Y2M4MmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9N SFRNTElucHV0RWxlbWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9N SFRNTElucHV0RWxlbWVudC5tbQpAQCAtMzQsMjAgKzM0LDIyIEBACiAjaW1wb3J0ICJET01Qcml2 YXRlLmgiCiAjaW1wb3J0ICJFeGNlcHRpb25IYW5kbGVycy5oIgogCi0vLyBGSVhNRTogU2ltcGxp ZnkgdGhpcyBvbmNlIDxyZGFyOi8vcHJvYmxlbS8zNDU4MzYyOD4gaXMgYXZhaWxhYmxlIGluIHRo ZSBidWlsZC4KLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBUQVJHRVRfT1NfSVBIT05F Ci0jaWYgX19oYXNfaW5jbHVkZSg8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlhbHNTdWdn ZXN0aW9uLmg+KQotI2ltcG9ydCA8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlhbHNTdWdn ZXN0aW9uLmg+CisjaWYgVEFSR0VUX09TX0lQSE9ORQorI2lmIF9faGFzX2luY2x1ZGUoPFVJS2l0 L1VJVGV4dEF1dG9maWxsU3VnZ2VzdGlvbi5oPikKKworI2ltcG9ydCA8VUlLaXQvVUlUZXh0QXV0 b2ZpbGxTdWdnZXN0aW9uLmg+CisKICNlbHNlCi0jaW1wb3J0IDxVSUtpdC9VSVRleHRJbnB1dF9Q cml2YXRlLmg+Ci1AaW50ZXJmYWNlIFVJS2V5Ym9hcmRMb2dpbkNyZWRlbnRpYWxzU3VnZ2VzdGlv biA6IFVJVGV4dFN1Z2dlc3Rpb24KIAotQHByb3BlcnR5IChub25hdG9taWMsIGFzc2lnbikgTlNT dHJpbmcgKnVzZXJuYW1lOwotQHByb3BlcnR5IChub25hdG9taWMsIGFzc2lnbikgTlNTdHJpbmcg KnBhc3N3b3JkOworQGludGVyZmFjZSBVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24KKworQHByb3Bl cnR5IChOU1N0cmluZyAqKSB1c2VybmFtZTsKK0Bwcm9wZXJ0eSAoTlNTdHJpbmcgKikgcGFzc3dv cmQ7CiAKIEBlbmQKLSNlbmRpZiAvLyBfX2hhc19pbmNsdWRlKDxVSUtpdC9VSUtleWJvYXJkTG9n aW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24uaD4pCi0jZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFM X1NESykgJiYgVEFSR0VUX09TX0lQSE9ORQorCisjZW5kaWYgLy8gX19oYXNfaW5jbHVkZSg8VUlL aXQvVUlUZXh0QXV0b2ZpbGxTdWdnZXN0aW9uLmg+KQorI2VuZGlmIC8vIFRBUkdFVF9PU19JUEhP TkUKIAogI2ltcG9ydCA8V2ViQ29yZS9BdXRvZmlsbEVsZW1lbnRzLmg+CiAjaW1wb3J0IDxXZWJD b3JlL0ZpbGVMaXN0Lmg+CkBAIC02OTYsMTYgKzY5OCwxNiBAQAogICAgIHJldHVybiBAeyBAIl9X ZWJWaWV3VVJMIiA6IGRvY3VtZW50VVJMIH07CiB9CiAKLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxf U0RLKSAmJiBUQVJHRVRfT1NfSVBIT05FCi0tICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9uOihV SUtleWJvYXJkTG9naW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24gKiljcmVkZW50aWFsc1N1Z2dlc3Rp b24KKyNpZiBUQVJHRVRfT1NfSVBIT05FCistICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9uOihV SVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24gKiljcmVkZW50aWFsU3VnZ2VzdGlvbgogewogICAgIFdl YkNvcmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKICAgICBpZiAoaXM8V2ViQ29yZTo6 SFRNTElucHV0RWxlbWVudD4oSU1QTCkpIHsKICAgICAgICAgaWYgKGF1dG8gYXV0b2ZpbGxFbGVt ZW50cyA9IFdlYkNvcmU6OkF1dG9maWxsRWxlbWVudHM6OmNvbXB1dGVBdXRvZmlsbEVsZW1lbnRz KCpJTVBMKSkKLSAgICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRlbnRp YWxzU3VnZ2VzdGlvbi51c2VybmFtZSwgY3JlZGVudGlhbHNTdWdnZXN0aW9uLnBhc3N3b3JkKTsK KyAgICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRlbnRpYWxTdWdnZXN0 aW9uLnVzZXJuYW1lLCBjcmVkZW50aWFsU3VnZ2VzdGlvbi5wYXNzd29yZCk7CiAgICAgfQogfQot I2VuZGlmIC8vIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFRBUkdFVF9PU19JUEhPTkUKKyNl bmRpZiAvLyBUQVJHRVRfT1NfSVBIT05FCiAKIEBlbmQKIAo= 326444 2017-11-09 04:50:18 -0800 2017-11-10 07:40:44 -0800 Patch bug-179397-20171109135017.patch text/plain 2996 frederik.riedel U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNjAzZWYyZGFmZWQ0ODc2MzUwNTZkYWEwMTlkMDEzNjIyZDQ2NTIzNi4uYzM1Mjg3NzBjODQw MmNjM2MyZjViYjQzZjllZDA0MDgzZmY3ZjFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTA5ICBGcmVkZXJpayBSaWVkZWwgIDxmcmVkZXJp ay5yaWVkZWxAZnJvZ2cuaW8+CisKKyAgICAgICAgUmVwbGFjZWQgdGhlIG9sZCBwbGFjZWhvbGRl ciBVSUtpdCBjbGFzcyB3aXRoIHRoZSByZWFsIGNsYXNzIG5hbWUgaW4gV2ViS2l0TGVnYWN5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5Mzk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBET00vRE9N SFRNTElucHV0RWxlbWVudC5tbToKKyAgICAgICAgKC1bRE9NSFRNTElucHV0RWxlbWVudCBpbnNl cnRUZXh0U3VnZ2VzdGlvbjpdKToKKwogMjAxNy0xMS0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgUmVzb3VyY2VMb2FkZXI6Ondp bGxTZW5kUmVxdWVzdEludGVybmFsIGFzeW5jaHJvbm91cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQubW0gYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9ET00vRE9NSFRNTElucHV0RWxlbWVudC5tbQppbmRleCA4YzIwNDMzNzIxZmM5 MjU0NDQ5N2FjN2VjNDM3YzY5ZWEwNDZjYTAwLi5lYzJlMTBhMzA1MjFkMmZiNDY1ODFlZDg5Mjg3 M2M3MmM5ZTFhNzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9N SFRNTElucHV0RWxlbWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9ET00vRE9N SFRNTElucHV0RWxlbWVudC5tbQpAQCAtMzQsMjAgKzM0LDIzIEBACiAjaW1wb3J0ICJET01Qcml2 YXRlLmgiCiAjaW1wb3J0ICJFeGNlcHRpb25IYW5kbGVycy5oIgogCi0vLyBGSVhNRTogU2ltcGxp ZnkgdGhpcyBvbmNlIDxyZGFyOi8vcHJvYmxlbS8zNDU4MzYyOD4gaXMgYXZhaWxhYmxlIGluIHRo ZSBidWlsZC4KLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBUQVJHRVRfT1NfSVBIT05F Ci0jaWYgX19oYXNfaW5jbHVkZSg8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlhbHNTdWdn ZXN0aW9uLmg+KQotI2ltcG9ydCA8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlhbHNTdWdn ZXN0aW9uLmg+CisjaWYgVEFSR0VUX09TX0lQSE9ORQorI2lmIF9faGFzX2luY2x1ZGUoPFVJS2l0 L1VJVGV4dEF1dG9maWxsU3VnZ2VzdGlvbi5oPikKKworI2ltcG9ydCA8VUlLaXQvVUlUZXh0QXV0 b2ZpbGxTdWdnZXN0aW9uLmg+CisKICNlbHNlCi0jaW1wb3J0IDxVSUtpdC9VSVRleHRJbnB1dF9Q cml2YXRlLmg+Ci1AaW50ZXJmYWNlIFVJS2V5Ym9hcmRMb2dpbkNyZWRlbnRpYWxzU3VnZ2VzdGlv biA6IFVJVGV4dFN1Z2dlc3Rpb24KIAorQGludGVyZmFjZSBVSVRleHRTdWdnZXN0aW9uIDogTlNP YmplY3QKK0BlbmQKKworQGludGVyZmFjZSBVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24gOiBVSVRl eHRTdWdnZXN0aW9uCiBAcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmluZyAqdXNl cm5hbWU7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmluZyAqcGFzc3dvcmQ7 Ci0KIEBlbmQKLSNlbmRpZiAvLyBfX2hhc19pbmNsdWRlKDxVSUtpdC9VSUtleWJvYXJkTG9naW5D cmVkZW50aWFsc1N1Z2dlc3Rpb24uaD4pCi0jZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFMX1NE SykgJiYgVEFSR0VUX09TX0lQSE9ORQorCisjZW5kaWYgLy8gX19oYXNfaW5jbHVkZSg8VUlLaXQv VUlUZXh0QXV0b2ZpbGxTdWdnZXN0aW9uLmg+KQorI2VuZGlmIC8vIFRBUkdFVF9PU19JUEhPTkUK IAogI2ltcG9ydCA8V2ViQ29yZS9BdXRvZmlsbEVsZW1lbnRzLmg+CiAjaW1wb3J0IDxXZWJDb3Jl L0ZpbGVMaXN0Lmg+CkBAIC02OTYsMTYgKzY5OSwxNiBAQAogICAgIHJldHVybiBAeyBAIl9XZWJW aWV3VVJMIiA6IGRvY3VtZW50VVJMIH07CiB9CiAKLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KSAmJiBUQVJHRVRfT1NfSVBIT05FCi0tICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9uOihVSUtl eWJvYXJkTG9naW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24gKiljcmVkZW50aWFsc1N1Z2dlc3Rpb24K KyNpZiBUQVJHRVRfT1NfSVBIT05FCistICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9uOihVSVRl eHRBdXRvZmlsbFN1Z2dlc3Rpb24gKiljcmVkZW50aWFsU3VnZ2VzdGlvbgogewogICAgIFdlYkNv cmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKICAgICBpZiAoaXM8V2ViQ29yZTo6SFRN TElucHV0RWxlbWVudD4oSU1QTCkpIHsKICAgICAgICAgaWYgKGF1dG8gYXV0b2ZpbGxFbGVtZW50 cyA9IFdlYkNvcmU6OkF1dG9maWxsRWxlbWVudHM6OmNvbXB1dGVBdXRvZmlsbEVsZW1lbnRzKCpJ TVBMKSkKLSAgICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRlbnRpYWxz U3VnZ2VzdGlvbi51c2VybmFtZSwgY3JlZGVudGlhbHNTdWdnZXN0aW9uLnBhc3N3b3JkKTsKKyAg ICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRlbnRpYWxTdWdnZXN0aW9u LnVzZXJuYW1lLCBjcmVkZW50aWFsU3VnZ2VzdGlvbi5wYXNzd29yZCk7CiAgICAgfQogfQotI2Vu ZGlmIC8vIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFRBUkdFVF9PU19JUEhPTkUKKyNlbmRp ZiAvLyBUQVJHRVRfT1NfSVBIT05FCiAKIEBlbmQKIAo= 326576 2017-11-10 07:40:49 -0800 2017-11-10 08:25:18 -0800 Patch bug-179397-20171110164048.patch text/plain 3002 frederik.riedel U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNjAzZWYyZGFmZWQ0ODc2MzUwNTZkYWEwMTlkMDEzNjIyZDQ2NTIzNi4uOGNmOTBjZmUyNDBk Y2VmYWU2MjQ4MjE2NjBiMjczMGM0YWIyNjMwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTA5ICBGcmVkZXJpayBSaWVkZWwgIDxmcmVkZXJp ay5yaWVkZWxAZnJvZ2cuaW8+CisKKyAgICAgICAgW2lPU10gVXNlIG5ldyBjbGFzcyBuYW1lIGZy b20gVUlLaXQgd2hlbiBjaGVja2luZyBVSVRleHRTdWdnZXN0aW9uIHR5cGUgZm9yIFdlYktpdExl Z2FjeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5 Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE T00vRE9NSFRNTElucHV0RWxlbWVudC5tbToKKyAgICAgICAgKC1bRE9NSFRNTElucHV0RWxlbWVu dCBpbnNlcnRUZXh0U3VnZ2VzdGlvbjpdKToKKwogMjAxNy0xMS0wNiAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgUmVzb3VyY2VMb2Fk ZXI6OndpbGxTZW5kUmVxdWVzdEludGVybmFsIGFzeW5jaHJvbm91cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvRE9NL0RPTUhUTUxJbnB1dEVsZW1lbnQubW0gYi9Tb3VyY2Uv V2ViS2l0TGVnYWN5L21hYy9ET00vRE9NSFRNTElucHV0RWxlbWVudC5tbQppbmRleCA4YzIwNDMz NzIxZmM5MjU0NDQ5N2FjN2VjNDM3YzY5ZWEwNDZjYTAwLi5lYzJlMTBhMzA1MjFkMmZiNDY1ODFl ZDg5Mjg3M2M3MmM5ZTFhNzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9E T00vRE9NSFRNTElucHV0RWxlbWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9E T00vRE9NSFRNTElucHV0RWxlbWVudC5tbQpAQCAtMzQsMjAgKzM0LDIzIEBACiAjaW1wb3J0ICJE T01Qcml2YXRlLmgiCiAjaW1wb3J0ICJFeGNlcHRpb25IYW5kbGVycy5oIgogCi0vLyBGSVhNRTog U2ltcGxpZnkgdGhpcyBvbmNlIDxyZGFyOi8vcHJvYmxlbS8zNDU4MzYyOD4gaXMgYXZhaWxhYmxl IGluIHRoZSBidWlsZC4KLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBUQVJHRVRfT1Nf SVBIT05FCi0jaWYgX19oYXNfaW5jbHVkZSg8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlh bHNTdWdnZXN0aW9uLmg+KQotI2ltcG9ydCA8VUlLaXQvVUlLZXlib2FyZExvZ2luQ3JlZGVudGlh bHNTdWdnZXN0aW9uLmg+CisjaWYgVEFSR0VUX09TX0lQSE9ORQorI2lmIF9faGFzX2luY2x1ZGUo PFVJS2l0L1VJVGV4dEF1dG9maWxsU3VnZ2VzdGlvbi5oPikKKworI2ltcG9ydCA8VUlLaXQvVUlU ZXh0QXV0b2ZpbGxTdWdnZXN0aW9uLmg+CisKICNlbHNlCi0jaW1wb3J0IDxVSUtpdC9VSVRleHRJ bnB1dF9Qcml2YXRlLmg+Ci1AaW50ZXJmYWNlIFVJS2V5Ym9hcmRMb2dpbkNyZWRlbnRpYWxzU3Vn Z2VzdGlvbiA6IFVJVGV4dFN1Z2dlc3Rpb24KIAorQGludGVyZmFjZSBVSVRleHRTdWdnZXN0aW9u IDogTlNPYmplY3QKK0BlbmQKKworQGludGVyZmFjZSBVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24g OiBVSVRleHRTdWdnZXN0aW9uCiBAcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmlu ZyAqdXNlcm5hbWU7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBOU1N0cmluZyAqcGFz c3dvcmQ7Ci0KIEBlbmQKLSNlbmRpZiAvLyBfX2hhc19pbmNsdWRlKDxVSUtpdC9VSUtleWJvYXJk TG9naW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24uaD4pCi0jZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVS TkFMX1NESykgJiYgVEFSR0VUX09TX0lQSE9ORQorCisjZW5kaWYgLy8gX19oYXNfaW5jbHVkZSg8 VUlLaXQvVUlUZXh0QXV0b2ZpbGxTdWdnZXN0aW9uLmg+KQorI2VuZGlmIC8vIFRBUkdFVF9PU19J UEhPTkUKIAogI2ltcG9ydCA8V2ViQ29yZS9BdXRvZmlsbEVsZW1lbnRzLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL0ZpbGVMaXN0Lmg+CkBAIC02OTYsMTYgKzY5OSwxNiBAQAogICAgIHJldHVybiBAeyBA Il9XZWJWaWV3VVJMIiA6IGRvY3VtZW50VVJMIH07CiB9CiAKLSNpZiBVU0UoQVBQTEVfSU5URVJO QUxfU0RLKSAmJiBUQVJHRVRfT1NfSVBIT05FCi0tICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9u OihVSUtleWJvYXJkTG9naW5DcmVkZW50aWFsc1N1Z2dlc3Rpb24gKiljcmVkZW50aWFsc1N1Z2dl c3Rpb24KKyNpZiBUQVJHRVRfT1NfSVBIT05FCistICh2b2lkKWluc2VydFRleHRTdWdnZXN0aW9u OihVSVRleHRBdXRvZmlsbFN1Z2dlc3Rpb24gKiljcmVkZW50aWFsU3VnZ2VzdGlvbgogewogICAg IFdlYkNvcmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKICAgICBpZiAoaXM8V2ViQ29y ZTo6SFRNTElucHV0RWxlbWVudD4oSU1QTCkpIHsKICAgICAgICAgaWYgKGF1dG8gYXV0b2ZpbGxF bGVtZW50cyA9IFdlYkNvcmU6OkF1dG9maWxsRWxlbWVudHM6OmNvbXB1dGVBdXRvZmlsbEVsZW1l bnRzKCpJTVBMKSkKLSAgICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRl bnRpYWxzU3VnZ2VzdGlvbi51c2VybmFtZSwgY3JlZGVudGlhbHNTdWdnZXN0aW9uLnBhc3N3b3Jk KTsKKyAgICAgICAgICAgIGF1dG9maWxsRWxlbWVudHMtPmF1dG9maWxsKGNyZWRlbnRpYWxTdWdn ZXN0aW9uLnVzZXJuYW1lLCBjcmVkZW50aWFsU3VnZ2VzdGlvbi5wYXNzd29yZCk7CiAgICAgfQog fQotI2VuZGlmIC8vIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFRBUkdFVF9PU19JUEhPTkUK KyNlbmRpZiAvLyBUQVJHRVRfT1NfSVBIT05FCiAKIEBlbmQKIAo=