179369 2017-11-07 03:21:46 -0800 WebDriver: capabilities with null value shouldn't be added to the validated capabilities object 2017-11-15 09:40:04 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer oldest_to_newest 1368964 0 cgarcia 2017-11-07 03:21:46 -0800 https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities "4. If deserialized is not null, set a property on result with name name and value deserialized." We are adding it, causing a failure when matching capabilities. 1368965 1 326202 cgarcia 2017-11-07 03:24:35 -0800 Created attachment 326202 Patch 1370041 2 326202 bburg 2017-11-09 13:53:48 -0800 Comment on attachment 326202 Patch r=me 1370255 3 cgarcia 2017-11-09 23:26:07 -0800 Committed r224667: <https://trac.webkit.org/changeset/224667> 1371950 4 webkit-bug-importer 2017-11-15 09:40:04 -0800 <rdar://problem/35562186> 326202 2017-11-07 03:24:35 -0800 2017-11-09 13:53:48 -0800 Patch wd-null-capabilities.diff text/plain 1860 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMGQwYWI4MTZkZjIuLmYyMDAzZTQ1MGM3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTExLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGNhcGFiaWxpdGllcyB3aXRo IG51bGwgdmFsdWUgc2hvdWxkbid0IGJlIGFkZGVkIHRvIHRoZSB2YWxpZGF0ZWQgY2FwYWJpbGl0 aWVzIG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc5MzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgIjQuIElmIGRlc2VyaWFsaXplZCBpcyBub3QgbnVsbCwgc2V0IGEgcHJvcGVydHkgb24gcmVz dWx0IHdpdGggbmFtZSBuYW1lIGFuZCB2YWx1ZSBkZXNlcmlhbGl6ZWQuIgorCisgICAgICAgIDcu MiBQcm9jZXNzaW5nIENhcGFiaWxpdGllcworICAgICAgICBodHRwczovL3czYy5naXRodWIuaW8v d2ViZHJpdmVyL3dlYmRyaXZlci1zcGVjLmh0bWwjZGZuLXZhbGlkYXRlLWNhcGFiaWxpdGllcwor CisgICAgICAgIEZpeGVzOiBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3Nlc3Npb25zL25l d19zZXNzaW9uL2NyZWF0ZV9maXJzdE1hdGNoLnB5Ojp0ZXN0X3ZhbGlkW3BsYXRmb3JtTmFtZS1O b25lXQorCisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2 ZXI6OldlYkRyaXZlclNlcnZpY2U6OnZhbGlkYXRlZENhcGFiaWxpdGllcyBjb25zdCk6CisKIDIw MTctMTAtMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFdlYkRyaXZlcjogdW5rbm93biBjYXBhYmlsaXRpZXMgc2hvdWxkIHByb2R1Y2UgYW4g SW52YWxpZEFyZ3VtZW50IGVycm9yIHdoZW4gdmFsaWRhdGluZyBjYXBhYmlsaXRpZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAgYi9Tb3VyY2UvV2Vi RHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IGE4MzJiNGE5M2I4Li5jNDdlYzM0MTZl NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBAIC0zNzIsOCArMzcyLDgg QEAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gV2ViRHJpdmVyU2VydmljZTo6dmFsaWRhdGVkQ2Fw YWJpbGl0aWVzKGNvbnN0IEluc3BlY3Rvck8KICAgICBhdXRvIGVuZCA9IGNhcGFiaWxpdGllcy5l bmQoKTsKICAgICBmb3IgKGF1dG8gaXQgPSBjYXBhYmlsaXRpZXMuYmVnaW4oKTsgaXQgIT0gZW5k OyArK2l0KSB7CiAgICAgICAgIGlmIChpdC0+dmFsdWUtPmlzTnVsbCgpKQotICAgICAgICAgICAg cmVzdWx0LT5zZXRWYWx1ZShpdC0+a2V5LCBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+KGl0LT52YWx1 ZSkpOwotICAgICAgICBlbHNlIGlmIChpdC0+a2V5ID09ICJhY2NlcHRJbnNlY3VyZUNlcnRzIikg eworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIGlmIChpdC0+a2V5ID09ICJhY2NlcHRJ bnNlY3VyZUNlcnRzIikgewogICAgICAgICAgICAgYm9vbCBhY2NlcHRJbnNlY3VyZUNlcnRzOwog ICAgICAgICAgICAgaWYgKCFpdC0+dmFsdWUtPmFzQm9vbGVhbihhY2NlcHRJbnNlY3VyZUNlcnRz KSkKICAgICAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsK