179365 2017-11-07 00:19:19 -0800 REGRESSION(r223773): [GTK] WebKitWebInspector bring-to-front signal is emitted right after open-window 2017-11-08 04:55:31 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply joepeck mcatanzaro oldest_to_newest 1368947 0 cgarcia 2017-11-07 00:19:19 -0800 In the GTK+ API, open-window already implies presenting the window to bring it to the front, so it's not expected that bring-to-front is emitted on open. This is happening since r223773 that moved common code from platform specific inspector files to the main file, but in the case of open the mac implementation was not exactly the same as the GTK+ one. This broke /webkit2/WebKitWebInspector/default and /webkit2/WebKitWebInspector/manual-attach-detach. 1368948 1 326198 cgarcia 2017-11-07 00:23:57 -0800 Created attachment 326198 Patch I'm not happy adding a platform ifdef to WebInspectorProxy.cpp after a refactoring to share code, but in this case I don't see a better way. Going back to platformOpen() when only one line differs is not better. 1368981 2 326198 mcatanzaro 2017-11-07 06:19:32 -0800 Comment on attachment 326198 Patch OK, unless Brian or Joe want to take a different approach. 1369018 3 326198 bburg 2017-11-07 08:49:15 -0800 Comment on attachment 326198 Patch If there is some way to check this inside platformBringToFront() and do nothing in this case, that would be better. Having a platform guard around a virtual platform method seems nonsensical. 1369353 4 cgarcia 2017-11-07 23:45:58 -0800 (In reply to Brian Burg from comment #3) > Comment on attachment 326198 [details] > Patch > > If there is some way to check this inside platformBringToFront() and do > nothing in this case, that would be better. Having a platform guard around a > virtual platform method seems nonsensical. Yes I can add a m_isOpening and check it from GTK specific impl, I discarded that because it's adding a member just for that and only used by GTK+. 1369354 5 326309 cgarcia 2017-11-07 23:46:32 -0800 Created attachment 326309 Patch for landing Removed the platform ifdef in cross-platform file. 1369394 6 cgarcia 2017-11-08 04:55:31 -0800 Committed r224575: <https://trac.webkit.org/changeset/224575> 326198 2017-11-07 00:23:57 -0800 2017-11-07 23:46:32 -0800 Patch wk2-inspector-bring-to-front.diff text/plain 1733 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNTU2MjM0NDZlMDcuLjcxNGYxNjM2OTFjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE3LTExLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjM3NzMpOiBbR1RLXSBXZWJLaXRXZWJJbnNw ZWN0b3IgYnJpbmctdG8tZnJvbnQgc2lnbmFsIGlzIGVtaXR0ZWQgcmlnaHQgYWZ0ZXIgb3Blbi13 aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTM2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu IHRoZSBHVEsrIEFQSSwgb3Blbi13aW5kb3cgYWxyZWFkeSBpbXBsaWVzIHByZXNlbnRpbmcgdGhl IHdpbmRvdyB0byBicmluZyBpdCB0byB0aGUgZnJvbnQsIHNvIGl0J3Mgbm90CisgICAgICAgIGV4 cGVjdGVkIHRoYXQgYnJpbmctdG8tZnJvbnQgaXMgZW1pdHRlZCBvbiBvcGVuLiBUaGlzIGlzIGhh cHBlbmluZyBzaW5jZSByMjIzNzczIHRoYXQgbW92ZWQgY29tbW9uIGNvZGUgZnJvbQorICAgICAg ICBwbGF0Zm9ybSBzcGVjaWZpYyBpbnNwZWN0b3IgZmlsZXMgdG8gdGhlIG1haW4gZmlsZSwgYnV0 IGluIHRoZSBjYXNlIG9mIG9wZW4gdGhlIG1hYyBpbXBsZW1lbnRhdGlvbiB3YXMgbm90CisgICAg ICAgIGV4YWN0bHkgdGhlIHNhbWUgYXMgdGhlIEdUSysgb25lLiBUaGlzIGJyb2tlIC93ZWJraXQy L1dlYktpdFdlYkluc3BlY3Rvci9kZWZhdWx0IGFuZAorICAgICAgICAvd2Via2l0Mi9XZWJLaXRX ZWJJbnNwZWN0b3IvbWFudWFsLWF0dGFjaC1kZXRhY2guCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv V2ViSW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94 eTo6b3Blbik6IERvIG5vdCBicmluZyB0byBmcm9udCBpbiBHVEsrIHBvcnQuCisKIDIwMTctMTEt MDYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBNYWtlIFJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3RJbnRlcm5hbCBhc3luY2hyb25v dXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5 LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAppbmRl eCA4ZDkwOWNkM2FkYi4uOGI1MjFmMTdkN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKQEAgLTQwMSw3ICs0MDEsMTAgQEAgdm9pZCBXZWJJbnNw ZWN0b3JQcm94eTo6b3BlbigpCiAgICAgZWxzZQogICAgICAgICBwbGF0Zm9ybUNyZWF0ZUZyb250 ZW5kV2luZG93KCk7CiAKKyNpZiAhUExBVEZPUk0oR1RLKQorICAgIC8vIEluIEdUSysgd2luZG93 IGlzIGFscmVhZHkgaW4gZnJvbnQgd2hlbiB0aGUgaW5zcGVjdG9yIHdpbmRvdyBpcyBjcmVhdGVk LgogICAgIHBsYXRmb3JtQnJpbmdUb0Zyb250KCk7CisjZW5kaWYKIH0KIAogdm9pZCBXZWJJbnNw ZWN0b3JQcm94eTo6ZGlkQ2xvc2UoKQo= 326309 2017-11-07 23:46:32 -0800 2017-11-07 23:46:32 -0800 Patch for landing wk2-inspector-bring-to-front.diff text/plain 3188 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWFkMGZkMmEyZDEuLmRiYTJhMzM1YjBiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIyIEBACisyMDE3LTExLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjM3NzMpOiBbR1RLXSBXZWJLaXRXZWJJbnNw ZWN0b3IgYnJpbmctdG8tZnJvbnQgc2lnbmFsIGlzIGVtaXR0ZWQgcmlnaHQgYWZ0ZXIgb3Blbi13 aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTM2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJvLgorCisgICAgICAg IEluIHRoZSBHVEsrIEFQSSwgb3Blbi13aW5kb3cgYWxyZWFkeSBpbXBsaWVzIHByZXNlbnRpbmcg dGhlIHdpbmRvdyB0byBicmluZyBpdCB0byB0aGUgZnJvbnQsIHNvIGl0J3Mgbm90CisgICAgICAg IGV4cGVjdGVkIHRoYXQgYnJpbmctdG8tZnJvbnQgaXMgZW1pdHRlZCBvbiBvcGVuLiBUaGlzIGlz IGhhcHBlbmluZyBzaW5jZSByMjIzNzczIHRoYXQgbW92ZWQgY29tbW9uIGNvZGUgZnJvbQorICAg ICAgICBwbGF0Zm9ybSBzcGVjaWZpYyBpbnNwZWN0b3IgZmlsZXMgdG8gdGhlIG1haW4gZmlsZSwg YnV0IGluIHRoZSBjYXNlIG9mIG9wZW4gdGhlIG1hYyBpbXBsZW1lbnRhdGlvbiB3YXMgbm90Cisg ICAgICAgIGV4YWN0bHkgdGhlIHNhbWUgYXMgdGhlIEdUSysgb25lLiBUaGlzIGJyb2tlIC93ZWJr aXQyL1dlYktpdFdlYkluc3BlY3Rvci9kZWZhdWx0IGFuZAorICAgICAgICAvd2Via2l0Mi9XZWJL aXRXZWJJbnNwZWN0b3IvbWFudWFsLWF0dGFjaC1kZXRhY2guCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQ cm94eTo6b3Blbik6IFNldCBtX2lzT3BlbmluZyBmb3IgdGhlIHNjb3BlIG9mIHRoZSBmdW5jdGlv bi4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDogQWRkIG1faXNPcGVu aW5nLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1CcmluZ1RvRnJvbnQp OiBSZXR1cm4gZWFybHkgaWYgbV9pc09wZW5pbmcgaXMgdHJ1ZS4KKwogMjAxNy0xMS0wNyAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMjI0MTc5KTogW0dUS10gU2V2ZXJhbCBXZWJWaWV3RWRpdG9yIHRlc3RzIGFyZSBmYWls aW5nIHNpbmNlIHIyMjQxNzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl Ykluc3BlY3RvclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3Rv clByb3h5LmNwcAppbmRleCA4ZDkwOWNkM2FkYi4uYTE1ODk2OGYxMmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKQEAgLTQwLDYgKzQwLDcgQEAK ICNpbmNsdWRlICJXZWJQcm9jZXNzUG9vbC5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eS5o IgogI2luY2x1ZGUgPFdlYkNvcmUvTm90SW1wbGVtZW50ZWQuaD4KKyNpbmNsdWRlIDx3dGYvU2V0 Rm9yU2NvcGUuaD4KIAogI2lmIFBMQVRGT1JNKEdUSykKICNpbmNsdWRlICJXZWJJbnNwZWN0b3JQ cm94eUNsaWVudC5oIgpAQCAtMzkzLDYgKzM5NCw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6 Om9wZW4oKQogICAgIGlmICghbV9pbnNwZWN0b3JQYWdlKQogICAgICAgICByZXR1cm47CiAKKyAg ICBTZXRGb3JTY29wZTxib29sPiBpc09wZW5pbmcobV9pc09wZW5pbmcsIHRydWUpOwogICAgIG1f aXNWaXNpYmxlID0gdHJ1ZTsKICAgICBtX2luc3BlY3RvclBhZ2UtPnByb2Nlc3MoKS5zZW5kKE1l c3NhZ2VzOjpXZWJJbnNwZWN0b3JVSTo6U2V0SXNWaXNpYmxlKG1faXNWaXNpYmxlKSwgbV9pbnNw ZWN0b3JQYWdlLT5wYWdlSUQoKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYkluc3BlY3RvclByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJJbnNw ZWN0b3JQcm94eS5oCmluZGV4IGMxZDJlMjc1MWQ0Li4zMWQ5YWI0MDc2YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCkBAIC0yMjUsNiArMjI1LDcgQEAg cHJpdmF0ZToKICAgICBib29sIG1faWdub3JlRmlyc3RCcmluZ1RvRnJvbnQgeyBmYWxzZSB9Owog ICAgIGJvb2wgbV9lbGVtZW50U2VsZWN0aW9uQWN0aXZlIHsgZmFsc2UgfTsKICAgICBib29sIG1f aWdub3JlRWxlbWVudFNlbGVjdGlvbkNoYW5nZSB7IGZhbHNlIH07CisgICAgYm9vbCBtX2lzT3Bl bmluZyB7IGZhbHNlIH07CiAKICAgICBJUEM6OkF0dGFjaG1lbnQgbV9jb25uZWN0aW9uSWRlbnRp ZmllcjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYkluc3Bl Y3RvclByb3h5R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0 b3JQcm94eUd0ay5jcHAKaW5kZXggODY1YjM5MzBmOWMuLjc4YmUwODcyYjNjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAK QEAgLTMwMiw2ICszMDIsOSBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUhpZGUo KQogCiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUJyaW5nVG9Gcm9udCgpCiB7Cisg ICAgaWYgKG1faXNPcGVuaW5nKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAobV9jbGllbnQg JiYgbV9jbGllbnQtPmJyaW5nVG9Gcm9udCgqdGhpcykpCiAgICAgICAgIHJldHVybjsKIAo=