17936 2008-03-18 22:17:46 -0700 "ASSERTION FAILED: false" (GetterSetterImp::toObject is called) 2008-09-02 19:47:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 13638 1 jruderman zwarich gavin.sharp zwarich oldest_to_newest 74384 0 jruderman 2008-03-18 22:17:46 -0700 testkjs doesn't like this script. b = 3; this.__defineSetter__("a", function() {}); this.__defineSetter__("b", function() {}); delete a; b.c; A Debug build of testkjs exits, saying ASSERTION FAILED: false (/Users/jruderman/WebKit/JavaScriptCore/kjs/internal.cpp:191 virtual KJS::JSObject* KJS::GetterSetterImp::toObject(KJS::ExecState*) const) A Release build of testjks says "TypeError: Null value" when perhaps it should say "TypeError: Undefined value", but nothing really bad happens. 74472 1 mrowe 2008-03-19 14:46:01 -0700 <rdar://problem/5320744> 74474 2 mrowe 2008-03-19 14:48:58 -0700 JSObject::defineSetter calls putDirect(propertyName, gs, GetterSetter), where "GetterSetter" is an attribute. If a property exists with the name, this ends up inside PropertyMap::put at the following code: // Put a new value in an existing hash table entry. m_u.table->entries()[entryIndex - 1].value = value; // Attributes are intentionally not updated. The problem here is the fact that we do not update the attribute of the property, which will lead to the PropertyMap returning an incorrect value for containsGettersOrSetters() when it is called after the setter for "a" in the test case is deleted. 89888 3 zwarich 2008-09-01 22:02:52 -0700 It seems that this was fixed by the refactoring of the getter and setter code in r36016, the revision that introduced polymorphic inline caching. I'll write a test so we can close this bug. 89963 4 23134 zwarich 2008-09-02 18:35:33 -0700 Created attachment 23134 Proposed patch adding layout tests 89966 5 zwarich 2008-09-02 19:47:39 -0700 Landed in r36035. 23134 2008-09-02 18:35:33 -0700 2008-09-02 19:11:37 -0700 Proposed patch adding layout tests delete.diff text/plain 6359 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2MDMw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDkt MDIgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgZm9yIGJ1ZyAxNzkz NjogIkFTU0VSVElPTiBGQUlMRUQ6IGZhbHNlIiAoR2V0dGVyU2V0dGVySW1wOjp0b09iamVjdCBp cyBjYWxsZWQpCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc5MzY+CisKKyAgICAgICAgVGhpcyBidWcgd2FzIGZpeGVkIGJ5IHRoZSByZXdyaXRlIG9m IG11Y2ggb2YgdGhlIGNvZGUgaGFuZGxpbmcgZ2V0dGVycworICAgICAgICBhbmQgc2V0dGVycyBp biByMzYwMTYsIHRoZSByZXZpc2lvbiB0aGF0IGludHJvZHVjZWQgdGhlIHBvbHltb3JwaGljCisg ICAgICAgIGlubGluZSBjYWNoZS4KKworICAgICAgICAqIGZhc3QvanMvZGVsZXRlLWdldHRlcnMt c2V0dGVycy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvZGVsZXRlLWdl dHRlcnMtc2V0dGVycy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9k ZWxldGUtZ2V0dGVycy1zZXR0ZXJzLmpzOiBBZGRlZC4KKwogMjAwOC0wOC0yOSAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4K SW5kZXg6IGZhc3QvanMvZGVsZXRlLWdldHRlcnMtc2V0dGVycy1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gZmFzdC9qcy9kZWxldGUtZ2V0dGVycy1zZXR0ZXJzLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIGZhc3QvanMvZGVsZXRlLWdldHRlcnMtc2V0dGVycy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjUgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCBkZWxl dGlvbiBvZiBwcm9wZXJ0aWVzIHdvcmtzIHByb3Blcmx5IHdpdGggZ2V0dGVycyBhbmQgc2V0dGVy cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgYjEucHJvcGVydHkgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ2IxJyBbdW5kZWZp bmVkXSBpcyBub3QgYW4gb2JqZWN0Li4KK1BBU1MgYTIucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9u IFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ2EyJyBbdW5kZWZpbmVkXSBpcyBub3Qg YW4gb2JqZWN0Li4KK1BBU1MgYjMucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjog UmVzdWx0IG9mIGV4cHJlc3Npb24gJ2IzJyBbdW5kZWZpbmVkXSBpcyBub3QgYW4gb2JqZWN0Li4K K1BBU1MgYTQucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4 cHJlc3Npb24gJ2E0JyBbdW5kZWZpbmVkXSBpcyBub3QgYW4gb2JqZWN0Li4KK1BBU1MgYjUucHJv cGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ2I1 JyBbdW5kZWZpbmVkXSBpcyBub3QgYW4gb2JqZWN0Li4KK1BBU1MgYTYucHJvcGVydHkgdGhyZXcg ZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ2E2JyBbdW5kZWZpbmVk XSBpcyBub3QgYW4gb2JqZWN0Li4KK1BBU1MgYjcucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5 cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ2I3JyBbdW5kZWZpbmVkXSBpcyBub3QgYW4g b2JqZWN0Li4KK1BBU1MgYTgucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVz dWx0IG9mIGV4cHJlc3Npb24gJ2E4JyBbdW5kZWZpbmVkXSBpcyBub3QgYW4gb2JqZWN0Li4KK1BB U1MgbzEuYi5wcm9wZXJ0eSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBSZXN1bHQgb2YgZXhw cmVzc2lvbiAnbzEuYicgW3VuZGVmaW5lZF0gaXMgbm90IGFuIG9iamVjdC4uCitQQVNTIG8xLmEu cHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24g J28xLmEnIFt1bmRlZmluZWRdIGlzIG5vdCBhbiBvYmplY3QuLgorUEFTUyBvMy5iLnByb3BlcnR5 IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFJlc3VsdCBvZiBleHByZXNzaW9uICdvMy5iJyBb dW5kZWZpbmVkXSBpcyBub3QgYW4gb2JqZWN0Li4KK1BBU1MgbzQuYS5wcm9wZXJ0eSB0aHJldyBl eGNlcHRpb24gVHlwZUVycm9yOiBSZXN1bHQgb2YgZXhwcmVzc2lvbiAnbzQuYScgW3VuZGVmaW5l ZF0gaXMgbm90IGFuIG9iamVjdC4uCitQQVNTIG81LmIucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9u IFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4cHJlc3Npb24gJ281LmInIFt1bmRlZmluZWRdIGlzIG5v dCBhbiBvYmplY3QuLgorUEFTUyBvNi5hLnByb3BlcnR5IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJy b3I6IFJlc3VsdCBvZiBleHByZXNzaW9uICdvNi5hJyBbdW5kZWZpbmVkXSBpcyBub3QgYW4gb2Jq ZWN0Li4KK1BBU1MgbzcuYi5wcm9wZXJ0eSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBSZXN1 bHQgb2YgZXhwcmVzc2lvbiAnbzcuYicgW3VuZGVmaW5lZF0gaXMgbm90IGFuIG9iamVjdC4uCitQ QVNTIG84LmEucHJvcGVydHkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogUmVzdWx0IG9mIGV4 cHJlc3Npb24gJ284LmEnIFt1bmRlZmluZWRdIGlzIG5vdCBhbiBvYmplY3QuLgorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IGZhc3QvanMv ZGVsZXRlLWdldHRlcnMtc2V0dGVycy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGZhc3QvanMvZGVsZXRl LWdldHRlcnMtc2V0dGVycy5odG1sCShyZXZpc2lvbiAwKQorKysgZmFzdC9qcy9kZWxldGUtZ2V0 dGVycy1zZXR0ZXJzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQ RSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8 bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+ Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZGVsZXRlLWdldHRlcnMtc2V0dGVycy5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBmYXN0L2pzL3Jlc291cmNlcy9kZWxldGUtZ2V0 dGVycy1zZXR0ZXJzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGZhc3QvanMvcmVzb3VyY2VzL2RlbGV0ZS1n ZXR0ZXJzLXNldHRlcnMuanMJKHJldmlzaW9uIDApCisrKyBmYXN0L2pzL3Jlc291cmNlcy9kZWxl dGUtZ2V0dGVycy1zZXR0ZXJzLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwMSBAQAorZGVz Y3JpcHRpb24oCisiVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGRlbGV0aW9uIG9mIHByb3BlcnRpZXMg d29ya3MgcHJvcGVybHkgd2l0aCBnZXR0ZXJzIGFuZCBzZXR0ZXJzLiIKKyk7CisKK2IxID0gMTsK K3RoaXMuX19kZWZpbmVTZXR0ZXJfXygiYTEiLCBmdW5jdGlvbigpIHt9KTsKK3RoaXMuX19kZWZp bmVTZXR0ZXJfXygiYjEiLCBmdW5jdGlvbigpIHt9KTsKK2RlbGV0ZSBhMTsKK3Nob3VsZFRocm93 KCJiMS5wcm9wZXJ0eSIpOworIAorYTIgPSAxOwordGhpcy5fX2RlZmluZVNldHRlcl9fKCJhMiIs IGZ1bmN0aW9uKCkge30pOwordGhpcy5fX2RlZmluZVNldHRlcl9fKCJiMiIsIGZ1bmN0aW9uKCkg e30pOworZGVsZXRlIGIyOworc2hvdWxkVGhyb3coImEyLnByb3BlcnR5Iik7CisKK2IzID0gMTsK K3RoaXMuX19kZWZpbmVHZXR0ZXJfXygiYTMiLCBmdW5jdGlvbigpIHt9KTsKK3RoaXMuX19kZWZp bmVHZXR0ZXJfXygiYjMiLCBmdW5jdGlvbigpIHt9KTsKK2RlbGV0ZSBhMzsKK3Nob3VsZFRocm93 KCJiMy5wcm9wZXJ0eSIpOworCithNCA9IDE7Cit0aGlzLl9fZGVmaW5lR2V0dGVyX18oImE0Iiwg ZnVuY3Rpb24oKSB7fSk7Cit0aGlzLl9fZGVmaW5lR2V0dGVyX18oImI0IiwgZnVuY3Rpb24oKSB7 fSk7CitkZWxldGUgYjQ7CitzaG91bGRUaHJvdygiYTQucHJvcGVydHkiKTsKKworYjUgPSAxOwor dGhpcy5fX2RlZmluZVNldHRlcl9fKCJhNSIsIGZ1bmN0aW9uKCkge30pOwordGhpcy5fX2RlZmlu ZUdldHRlcl9fKCJiNSIsIGZ1bmN0aW9uKCkge30pOworZGVsZXRlIGE1Oworc2hvdWxkVGhyb3co ImI1LnByb3BlcnR5Iik7CisgCithNiA9IDE7Cit0aGlzLl9fZGVmaW5lU2V0dGVyX18oImE2Iiwg ZnVuY3Rpb24oKSB7fSk7Cit0aGlzLl9fZGVmaW5lR2V0dGVyX18oImI2IiwgZnVuY3Rpb24oKSB7 fSk7CitkZWxldGUgYjY7CitzaG91bGRUaHJvdygiYTYucHJvcGVydHkiKTsKKworYjcgPSAxOwor dGhpcy5fX2RlZmluZUdldHRlcl9fKCJhNyIsIGZ1bmN0aW9uKCkge30pOwordGhpcy5fX2RlZmlu ZVNldHRlcl9fKCJiNyIsIGZ1bmN0aW9uKCkge30pOworZGVsZXRlIGE3Oworc2hvdWxkVGhyb3co ImI3LnByb3BlcnR5Iik7CisKK2E4ID0gMTsKK3RoaXMuX19kZWZpbmVHZXR0ZXJfXygiYTgiLCBm dW5jdGlvbigpIHt9KTsKK3RoaXMuX19kZWZpbmVTZXR0ZXJfXygiYjgiLCBmdW5jdGlvbigpIHt9 KTsKK2RlbGV0ZSBiODsKK3Nob3VsZFRocm93KCJhOC5wcm9wZXJ0eSIpOworCit2YXIgbzEgPSB7 IGI6IDEgfTsKK28xLl9fZGVmaW5lU2V0dGVyX18oImEiLCBmdW5jdGlvbigpIHt9KTsKK28xLl9f ZGVmaW5lU2V0dGVyX18oImIiLCBmdW5jdGlvbigpIHt9KTsKK2RlbGV0ZSBvMS5hOworc2hvdWxk VGhyb3coIm8xLmIucHJvcGVydHkiKTsKKwordmFyIG8yID0geyBhOiAxIH07CitvMi5fX2RlZmlu ZVNldHRlcl9fKCJhIiwgZnVuY3Rpb24oKSB7fSk7CitvMi5fX2RlZmluZVNldHRlcl9fKCJiIiwg ZnVuY3Rpb24oKSB7fSk7CitkZWxldGUgbzIuYjsKK3Nob3VsZFRocm93KCJvMS5hLnByb3BlcnR5 Iik7CisKK3ZhciBvMyA9IHsgYjogMSB9OworbzMuX19kZWZpbmVHZXR0ZXJfXygiYSIsIGZ1bmN0 aW9uKCkge30pOworbzMuX19kZWZpbmVHZXR0ZXJfXygiYiIsIGZ1bmN0aW9uKCkge30pOworZGVs ZXRlIG8zLmE7CitzaG91bGRUaHJvdygibzMuYi5wcm9wZXJ0eSIpOworCit2YXIgbzQgPSB7IGE6 IDEgfTsKK280Ll9fZGVmaW5lR2V0dGVyX18oImEiLCBmdW5jdGlvbigpIHt9KTsKK280Ll9fZGVm aW5lR2V0dGVyX18oImIiLCBmdW5jdGlvbigpIHt9KTsKK2RlbGV0ZSBvNC5iOworc2hvdWxkVGhy b3coIm80LmEucHJvcGVydHkiKTsKKwordmFyIG81ID0geyBiOiAxIH07CitvNS5fX2RlZmluZVNl dHRlcl9fKCJhIiwgZnVuY3Rpb24oKSB7fSk7CitvNS5fX2RlZmluZVNldHRlcl9fKCJiIiwgZnVu Y3Rpb24oKSB7fSk7CitkZWxldGUgbzUuYTsKK3Nob3VsZFRocm93KCJvNS5iLnByb3BlcnR5Iik7 CisKK3ZhciBvNiA9IHsgYTogMSB9OworbzYuX19kZWZpbmVTZXR0ZXJfXygiYSIsIGZ1bmN0aW9u KCkge30pOworbzYuX19kZWZpbmVTZXR0ZXJfXygiYiIsIGZ1bmN0aW9uKCkge30pOworZGVsZXRl IG82LmI7CitzaG91bGRUaHJvdygibzYuYS5wcm9wZXJ0eSIpOworCit2YXIgbzcgPSB7IGI6IDEg fTsKK283Ll9fZGVmaW5lR2V0dGVyX18oImEiLCBmdW5jdGlvbigpIHt9KTsKK283Ll9fZGVmaW5l R2V0dGVyX18oImIiLCBmdW5jdGlvbigpIHt9KTsKK2RlbGV0ZSBvNy5hOworc2hvdWxkVGhyb3co Im83LmIucHJvcGVydHkiKTsKKwordmFyIG84ID0geyBhOiAxIH07CitvOC5fX2RlZmluZUdldHRl cl9fKCJhIiwgZnVuY3Rpb24oKSB7fSk7CitvOC5fX2RlZmluZUdldHRlcl9fKCJiIiwgZnVuY3Rp b24oKSB7fSk7CitkZWxldGUgbzguYjsKK3Nob3VsZFRocm93KCJvOC5hLnByb3BlcnR5Iik7CisK K3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=