<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179356</bug_id>
          
          <creation_ts>2017-11-06 18:07:21 -0800</creation_ts>
          <short_desc>[GStreamer] Failure in gst_gl_context_thread_add</short_desc>
          <delta_ts>2021-04-23 06:10:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>224972</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>calvaris</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1368878</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-06 18:07:21 -0800</bug_when>
    <thetext>There&apos;s another thread inside _mesa_glsl_compile_shader at the same time. Maybe that&apos;s bad?

Thread 1 (Thread 0x2b8428401700 (LWP 5903)):
#0  0x00002b83a02d292f in exec_node_remove () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/list.h:170
#1  _ZN9exec_node6removeEv () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/list.h:248
#2  _Z31optimize_dead_builtin_variablesP9exec_list16ir_variable_mode () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/opt_dead_builtin_variables.cpp:79
#3  0x00002b83a0293cfb in _mesa_glsl_compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/glsl_parser_extras.cpp:1647
#4  0x00002b83a015fbba in compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/mesa/main/shaderapi.c:980
#5  0x00002b831fceb3d2 in _compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglslstage.c:486
#6  0x00002b831fcda990 in gst_gl_context_thread_add () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglcontext.c:1537
#7  0x00002b831fcebe07 in gst_glsl_stage_compile () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglslstage.c:542
#8  0x00002b831fce81eb in gst_gl_shader_compile_attach_stage () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglshader.c:603
#9  0x00002b831fcee03f in _create_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglcolorconvert.c:1830
#10 _init_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglcolorconvert.c:2028
#11 _do_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglcolorconvert.c:2368
#12 0x00002b831fcf2683 in _run_message_sync () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglwindow.c:601
#13 0x00002b831fcf2622 in _run_message_async () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglwindow.c:668
#14 0x00002b8320cd15ca in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3212
#15 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3865
#16 0x00002b8320cd1948 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3938
#17 0x00002b8320cd1c62 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:4134
#18 0x00002b831fcf26f5 in gst_gl_window_default_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglwindow.c:527
#19 0x00002b831fcdb95c in gst_gl_context_create_thread () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.5/gst-libs/gst/gl/gstglcontext.c:1273
#20 0x00002b8320cf8315 in g_thread_proxy () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gthread.c:784
#21 0x00002b8323f2b494 in start_thread (arg=0x2b8428401700) at pthread_create.c:333
#22 0x00002b832510793f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

Full backtrace here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r224517%20(4057)/imported/w3c/web-platform-tests/mediacapture-fromelement/capture-crash-log.txt

It&apos;s crashing imported/w3c/web-platform-tests/mediacapture-fromelement/capture.html so I&apos;ll update the expectations for that accordingly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1368886</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-06 18:28:40 -0800</bug_when>
    <thetext>Note: it&apos;s flaky.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397219</commentid>
    <comment_count>2</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2018-02-07 10:12:57 -0800</bug_when>
    <thetext>I can&apos;t make it fail here. Perhaps it&apos;s no longer flaky after the update to gst 1.12?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397256</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-07 11:49:28 -0800</bug_when>
    <thetext>Last crash on the GTK release bot was r228208:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r228208%20(5378)/imported/w3c/web-platform-tests/mediacapture-fromelement/capture-crash-log.txt

so no, I don&apos;t think so.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397257</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-07 11:50:10 -0800</bug_when>
    <thetext>I believe lots of tests were failing with this crash, BTW, so many that I wondered if we should undo the switch to GStreamerGL. I wonder if we have other bug reports for this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397478</commentid>
    <comment_count>5</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2018-02-08 01:05:12 -0800</bug_when>
    <thetext>Was this ever reported to Mesa and/or GStreamer bugzilla?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1397529</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-02-08 08:12:51 -0800</bug_when>
    <thetext>(In reply to Philippe Normand from comment #5)
&gt; Was this ever reported to Mesa and/or GStreamer bugzilla?

Nope.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1743341</commentid>
    <comment_count>7</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2021-03-24 09:22:23 -0700</bug_when>
    <thetext>I don&apos;t see a crash, just a failure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1743351</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-03-24 09:36:16 -0700</bug_when>
    <thetext>Yeah well this specific trace is 3 years old, we did several Mesa and GStreamer updates since :)

Maybe update the TestExpectations then?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1743717</commentid>
    <comment_count>9</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2021-03-25 03:26:02 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #8)
&gt; Yeah well this specific trace is 3 years old, we did several Mesa and
&gt; GStreamer updates since :)
&gt; 
&gt; Maybe update the TestExpectations then?

It does not appear as crash, just as failure, so I&apos;ll update the bug summary</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1753555</commentid>
    <comment_count>10</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-04-23 06:10:39 -0700</bug_when>
    <thetext>Test is already marked as failing in the generic TestExpectations so no need to have another one in our ports.

Also since we don&apos;t support video.captureStream() anyway, I don&apos;t see how this test could pass, hence duplicate of bug 224972.

*** This bug has been marked as a duplicate of bug 224972 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>