179349 2017-11-06 16:01:47 -0800 Only build ImageDiff for mac 2017-11-06 16:48:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue lforschler thorton webkit-bug-importer oldest_to_newest 1368819 0 jbedard 2017-11-06 16:01:47 -0800 ImageDiff should usually be built for the platform of the machine doing the building, not the target SDK. 1368821 1 webkit-bug-importer 2017-11-06 16:04:03 -0800 <rdar://problem/35376244> 1368822 2 webkit-bug-importer 2017-11-06 16:04:32 -0800 <rdar://problem/35376237> 1368828 3 326166 jbedard 2017-11-06 16:12:32 -0800 Created attachment 326166 Patch 1368837 4 326166 commit-queue 2017-11-06 16:48:44 -0800 Comment on attachment 326166 Patch Clearing flags on attachment: 326166 Committed r224518: <https://trac.webkit.org/changeset/224518> 1368838 5 commit-queue 2017-11-06 16:48:46 -0800 All reviewed patches have been landed. Closing bug. 326166 2017-11-06 16:12:32 -0800 2017-11-06 16:48:44 -0800 Patch bug-179349-20171106161232.patch text/plain 1140 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDUxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTExLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBPbmx5IGJ1aWxkIEltYWdlRGlmZiBmb3IgbWFjCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkzNDkKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM1Mzc2MjM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogSW1hZ2VEaWZmL01ha2VmaWxlOgorCiAyMDE3LTExLTA2ICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtBdHRhY2htZW50IFN1 cHBvcnRdIEltcGxlbWVudCBkZWxlZ2F0ZSBob29rcyBmb3IgYXR0YWNobWVudCBlbGVtZW50IGlu c2VydGlvbiBhbmQgcmVtb3ZhbApJbmRleDogVG9vbHMvSW1hZ2VEaWZmL01ha2VmaWxlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0ltYWdlRGlmZi9NYWtlZmlsZQkocmV2aXNpb24gMjI0NDkzKQorKysg VG9vbHMvSW1hZ2VEaWZmL01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC00LDUgKzQsMTMgQEAg aWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lLCQoU0RLUk9PVCkpKQogCU9WRVJSSURFX1NES1JP T1QgPSBkZWZhdWx0CiAJT1ZFUlJJREVfQVJDSFMgPSBkZWZhdWx0CiBlbmRpZgoraWZuZXEgKCwk KGZpbmRzdHJpbmcgd2F0Y2gsJChTREtST09UKSkpCisJT1ZFUlJJREVfU0RLUk9PVCA9IGRlZmF1 bHQKKwlPVkVSUklERV9BUkNIUyA9IGRlZmF1bHQKK2VuZGlmCitpZm5lcSAoLCQoZmluZHN0cmlu ZyB0diwkKFNES1JPT1QpKSkKKwlPVkVSUklERV9TREtST09UID0gZGVmYXVsdAorCU9WRVJSSURF X0FSQ0hTID0gZGVmYXVsdAorZW5kaWYKIAogaW5jbHVkZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQK