179325 2017-11-06 10:06:03 -0800 Uncaught Exception: TypeError: null is not an object (evaluating 'mimeType.endsWith') 2017-11-06 12:32:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg webkit-unassigned bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1368674 0 bburg 2017-11-06 10:06:03 -0800 ------- Inspected URL: Apple Internal :( Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/605.1.13+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: null is not an object (evaluating 'mimeType.endsWith') (at MIMETypeUtilities.js:127:17) fileExtensionForMIMEType @ MIMETypeUtilities.js:127:17 _customContentViewConstructorForResource @ ResourceClusterContentView.js:338:56 _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:322:99 ResourceClusterContentView @ ResourceClusterContentView.js:64:49 createFromRepresentedObject @ ContentView.js:52:53 contentViewForRepresentedObject @ ContentView.js:199:72 showContentViewForRepresentedObject @ ContentBrowser.js:149:63 showRepresentedObject @ ContentBrowserTabContentView.js:197:64 showRepresentedObject @ Main.js:1135:41 _treeSelectionDidChange @ ResourceSidebarPanel.js:464:37 dispatch @ Object.js:170:30 dispatchEventToListeners @ Object.js:177:17 select @ TreeElement.js:536:49 selectOnMouseDown @ TreeElement.js:493:20 treeElementMouseDown @ TreeElement.js:287:46 ------- * STEPS TO REPRODUCE 1. Load the page (pasted in radar), switch to Network Tab, click on the socket.io resource => Uncaught Exception 1368675 1 webkit-bug-importer 2017-11-06 10:06:26 -0800 <rdar://problem/35366896> 1368693 2 joepeck 2017-11-06 10:29:58 -0800 I think I had fixed this on my CacheStorage branch, but its easy to add a check now. 1368723 3 326139 joepeck 2017-11-06 11:34:03 -0800 Created attachment 326139 [PATCH] Proposed Fix 1368725 4 326139 bburg 2017-11-06 11:36:38 -0800 Comment on attachment 326139 [PATCH] Proposed Fix r=me 1368759 5 326139 commit-queue 2017-11-06 12:32:09 -0800 Comment on attachment 326139 [PATCH] Proposed Fix Clearing flags on attachment: 326139 Committed r224507: <https://trac.webkit.org/changeset/224507> 1368760 6 commit-queue 2017-11-06 12:32:11 -0800 All reviewed patches have been landed. Closing bug. 326139 2017-11-06 11:34:03 -0800 2017-11-06 12:32:09 -0800 [PATCH] Proposed Fix mime-1.patch text/plain 5090 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZmM2OWZjYTVjZS4uNGEzY2M2NDc4ZTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxNy0xMS0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFVuY2F1Z2h0IEV4Y2VwdGlvbjogVHlwZUVycm9yOiBudWxsIGlzIG5vdCBhbiBvYmplY3Qg KGV2YWx1YXRpbmcgJ21pbWVUeXBlLmVuZHNXaXRoJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTMyNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzUzNjY4OTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvdW5pdC10ZXN0cy9taW1ldHlwZS11dGlsaXRpZXMtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGluc3BlY3Rvci91bml0LXRlc3RzL21pbWV0eXBlLXV0aWxpdGllcy5odG1s OgorICAgICAgICBBZGQgdGVzdHMgZm9yIG51bGwgY2FzZXMuCisKIDIwMTctMTEtMDYgIENvbGlu IEJlbmRlbGwgIDxjb2xpbkBiZW5kZWxsLmNhPgogCiAgICAgICAgIEFkZCB0ZXN0cyB0byBlbnN1 cmUgdGhhdCA8c291cmNlPiB0YWdzIGFyZSBvbmx5IHByZWxvYWRlZCB3aGVuIHRoZSBgdHlwZWAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL21pbWV0eXBlLXV0 aWxpdGllcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9t aW1ldHlwZS11dGlsaXRpZXMtZXhwZWN0ZWQudHh0CmluZGV4IGY2Zjc3YjFjN2JlLi5hY2NlNjI1 YzQ3NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvbWltZXR5 cGUtdXRpbGl0aWVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5p dC10ZXN0cy9taW1ldHlwZS11dGlsaXRpZXMtZXhwZWN0ZWQudHh0CkBAIC0xLDYgKzEsNyBAQAog CiA9PSBSdW5uaW5nIHRlc3Qgc3VpdGU6IE1JTUVUeXBlVXRpbGl0aWVzCiAtLSBSdW5uaW5nIHRl c3QgY2FzZTogZmlsZUV4dGVuc2lvbkZvclVSTAorUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIG51 bGwgVVJMIHNob3VsZCBiZSBudWxsLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIGludmFsaWQg VVJMIHNob3VsZCBiZSBudWxsLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIFVSTCB3aXRob3V0 IGxhc3QgcGF0aCBjb21wb25lbnQgc2hvdWxkIGJlIG51bGwuCiBQQVNTOiBGaWxlIGV4dGVuc2lv biBmb3IgVVJMIHdpdGhvdXQgbGFzdCBwYXRoIGNvbXBvbmVudCBzaG91bGQgYmUgbnVsbC4KQEAg LTE0LDYgKzE1LDcgQEAgUEFTUzogRmlsZSBleHRlbnNpb24gZm9yICJzY3JpcHQuanMiIHNob3Vs ZCBiZSAianMiLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yICJzY3JpcHQubWluLmpzIiBzaG91 bGQgYmUgImpzIi4KIAogLS0gUnVubmluZyB0ZXN0IGNhc2U6IGZpbGVFeHRlbnNpb25Gb3JNSU1F VHlwZQorUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIG51bGwgbWltZSB0eXBlIHNob3VsZCBiZSBu dWxsLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIGludmFsaWQgbWltZSB0eXBlIHNob3VsZCBi ZSBudWxsLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yIHVua25vd24gbWltZSB0eXBlIHNob3Vs ZCBiZSBudWxsLgogUEFTUzogRmlsZSBleHRlbnNpb24gZm9yICJpbWFnZS9qcGVnIiBzaG91bGQg YmUgImpwZyIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9t aW1ldHlwZS11dGlsaXRpZXMuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3Rz L21pbWV0eXBlLXV0aWxpdGllcy5odG1sCmluZGV4IGM5ODY1YjVlMTdjLi4zZjI4Y2E2YTI2MiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvbWltZXR5cGUtdXRp bGl0aWVzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvbWltZXR5 cGUtdXRpbGl0aWVzLmh0bWwKQEAgLTEwLDYgKzEwLDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAg c3VpdGUuYWRkVGVzdENhc2UoewogICAgICAgICBuYW1lOiAiZmlsZUV4dGVuc2lvbkZvclVSTCIs CiAgICAgICAgIHRlc3QoKSB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFs KFdJLmZpbGVFeHRlbnNpb25Gb3JVUkwobnVsbCksIG51bGwsIGBGaWxlIGV4dGVuc2lvbiBmb3Ig bnVsbCBVUkwgc2hvdWxkIGJlIG51bGwuYCk7CiAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4 cGVjdEVxdWFsKFdJLmZpbGVFeHRlbnNpb25Gb3JVUkwoImludmFsaWQtdXJsIiksIG51bGwsIGBG aWxlIGV4dGVuc2lvbiBmb3IgaW52YWxpZCBVUkwgc2hvdWxkIGJlIG51bGwuYCk7CiAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFsKFdJLmZpbGVFeHRlbnNpb25Gb3JVUkwoImh0 dHBzOi8vZXhhbXBsZS5jb20iKSwgbnVsbCwgYEZpbGUgZXh0ZW5zaW9uIGZvciBVUkwgd2l0aG91 dCBsYXN0IHBhdGggY29tcG9uZW50IHNob3VsZCBiZSBudWxsLmApOwogICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5leHBlY3RFcXVhbChXSS5maWxlRXh0ZW5zaW9uRm9yVVJMKCJodHRwczovL2V4 YW1wbGUuY29tLyIpLCBudWxsLCBgRmlsZSBleHRlbnNpb24gZm9yIFVSTCB3aXRob3V0IGxhc3Qg cGF0aCBjb21wb25lbnQgc2hvdWxkIGJlIG51bGwuYCk7CkBAIC0zMSw2ICszMiw3IEBAIGZ1bmN0 aW9uIHRlc3QoKQogICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsKICAgICAgICAgbmFtZTogImZpbGVF eHRlbnNpb25Gb3JNSU1FVHlwZSIsCiAgICAgICAgIHRlc3QoKSB7CisgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmV4cGVjdEVxdWFsKFdJLmZpbGVFeHRlbnNpb25Gb3JNSU1FVHlwZShudWxsKSwg bnVsbCwgYEZpbGUgZXh0ZW5zaW9uIGZvciBudWxsIG1pbWUgdHlwZSBzaG91bGQgYmUgbnVsbC5g KTsKICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwoV0kuZmlsZUV4dGVuc2lv bkZvck1JTUVUeXBlKCJpbnZhbGlkLW1pbWV0eXBlIiksIG51bGwsIGBGaWxlIGV4dGVuc2lvbiBm b3IgaW52YWxpZCBtaW1lIHR5cGUgc2hvdWxkIGJlIG51bGwuYCk7CiAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmV4cGVjdEVxdWFsKFdJLmZpbGVFeHRlbnNpb25Gb3JNSU1FVHlwZSgiYXBwbGlj YXRpb24vdW5rbm93biIpLCBudWxsLCBgRmlsZSBleHRlbnNpb24gZm9yIHVua25vd24gbWltZSB0 eXBlIHNob3VsZCBiZSBudWxsLmApOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAwOTY2 YmIxNDBhOC4uYjdkZDgyNDJmYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE4IEBACiAyMDE3LTExLTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IG51bGwgaXMgbm90IGFu IG9iamVjdCAoZXZhbHVhdGluZyAnbWltZVR5cGUuZW5kc1dpdGgnKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MzI1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8zNTM2Njg5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NSU1FVHlwZVV0aWxpdGllcy5qczoKKyAg ICAgICAgKFdJLmZpbGVFeHRlbnNpb25Gb3JNSU1FVHlwZSk6CisgICAgICAgIChXSS5zaG91bGRU cmVhdE1JTUVUeXBlQXNUZXh0KToKKyAgICAgICAgSGFuZGxlIG51bGwgbWltZSB0eXBlcy4KKwor MjAxNy0xMS0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFNlbGVjdGluZyBhIERPTSBTZWFyY2ggUmVzdWx0IGluIFNlYXJj aCBUYWIgdW5leHBlY3RlZGx5IGNoYW5nZXMgVGFicwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MjIzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z Mzk0OTU1Nj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTUlNRVR5cGVVdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9CYXNlL01JTUVUeXBlVXRpbGl0aWVzLmpzCmluZGV4IDBlMWJiOWQ1MzY4Li41ZWE4 YTIyZDk0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NSU1FVHlwZVV0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01JTUVUeXBlVXRpbGl0aWVzLmpzCkBAIC04NCw2ICs4NCw5IEBAIFdJ Lm1pbWVUeXBlRm9yRmlsZUV4dGVuc2lvbiA9IGZ1bmN0aW9uKGV4dGVuc2lvbikKIAogV0kuZmls ZUV4dGVuc2lvbkZvck1JTUVUeXBlID0gZnVuY3Rpb24obWltZVR5cGUpCiB7CisgICAgaWYgKCFt aW1lVHlwZSkKKyAgICAgICAgcmV0dXJuIG51bGw7CisKICAgICBjb25zdCBtaW1lVHlwZVRvRXh0 ZW5zaW9uID0gewogICAgICAgICAvLyBEb2N1bWVudCB0eXBlcy4KICAgICAgICAgInRleHQvaHRt bCI6ICJodG1sIiwKQEAgLTEzNCw2ICsxMzcsOSBAQCBXSS5maWxlRXh0ZW5zaW9uRm9yTUlNRVR5 cGUgPSBmdW5jdGlvbihtaW1lVHlwZSkKIAogV0kuc2hvdWxkVHJlYXRNSU1FVHlwZUFzVGV4dCA9 IGZ1bmN0aW9uKG1pbWVUeXBlKQogeworICAgIGlmICghbWltZVR5cGUpCisgICAgICAgIHJldHVy biBmYWxzZTsKKwogICAgIGlmIChtaW1lVHlwZS5zdGFydHNXaXRoKCJ0ZXh0LyIpKQogICAgICAg ICByZXR1cm4gdHJ1ZTsKIAo=