179322 2017-11-06 09:06:52 -0800 ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object 2017-11-15 12:11:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179302 InRadar P2 Normal --- 1 cdumez cdumez beidson buildbot commit-queue dbates esprehn+autocc ggaren kangil.han sam webkit-bug-importer youennf oldest_to_newest 1368643 0 cdumez 2017-11-06 09:06:52 -0800 ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object unnecessarily. 1368644 1 326124 cdumez 2017-11-06 09:07:53 -0800 Created attachment 326124 Patch 1368647 2 326125 cdumez 2017-11-06 09:13:29 -0800 Created attachment 326125 Patch 1368718 3 326125 sam 2017-11-06 11:25:38 -0800 Comment on attachment 326125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326125&action=review > Source/WebCore/page/DOMWindow.h:140 > Navigator* navigator() const; > + Navigator* optionalNavigator() const { return m_navigator.get(); } Should/can navigator() return something non-null? 1368719 4 sam 2017-11-06 11:27:04 -0800 (In reply to Sam Weinig from comment #3) > Comment on attachment 326125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326125&action=review > > > Source/WebCore/page/DOMWindow.h:140 > > Navigator* navigator() const; > > + Navigator* optionalNavigator() const { return m_navigator.get(); } > > Should/can navigator() return something non-null? Nevermind, I remember it can't due to no-frame cases. 1368734 5 326125 commit-queue 2017-11-06 11:46:38 -0800 Comment on attachment 326125 Patch Clearing flags on attachment: 326125 Committed r224502: <https://trac.webkit.org/changeset/224502> 1368735 6 commit-queue 2017-11-06 11:46:40 -0800 All reviewed patches have been landed. Closing bug. 1372101 7 webkit-bug-importer 2017-11-15 12:11:00 -0800 <rdar://problem/35567095> 326124 2017-11-06 09:07:53 -0800 2017-11-06 09:13:27 -0800 Patch bug-179322-20171106090752.patch text/plain 2305 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3MzVmNGRkZDg4ZjZj NjBiNWE5NjRlYzFkN2QwYzdmNGJiOWZhOS4uOGExZmZiMDA5NGMwZjU4ZWFkZjE0MDJhOTU5MzFi YjQ0MWVhMjA0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2NyaXB0RXhlY3V0aW9uQ29u dGV4dDo6c2VydmljZVdvcmtlckNvbnRhaW5lcigpIHNob3VsZCBhdm9pZCBjb25zdHJ1Y3Rpbmcg YSBOYXZpZ2F0b3Igb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzkzMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXJ2aWNlV29ya2VyQ29udGFpbmVy KCkgc2hvdWxkIGF2b2lkIGNvbnN0cnVjdGluZyBhIE5hdmlnYXRvciBvYmplY3QKKyAgICAgICAg dW5uZWNlc3NhcmlseS4KKworICAgICAgICAqIGRvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnNlcnZpY2VXb3Jr ZXJDb250YWluZXIpOgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6CisKIDIwMTctMTEtMDUg IEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dp bkNhaXJvXSBGaXggYnVpbGQgYWZ0ZXIgcjIyNDQ2MwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1Nj cmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCmluZGV4IDM4MmQyYzg3NzJkMWRiOTJmOGJlNTNlODI2 YzJjMmEzOTdkY2I0NjEuLjE0MGEzMjViNTc0YTk4YjBmNTdhMjFjYzE4YWE1YzMxZWJiMDZmY2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKQEAg LTU0NSw5ICs1NDUsOSBAQCBTZXJ2aWNlV29ya2VyQ29udGFpbmVyKiBTY3JpcHRFeGVjdXRpb25D b250ZXh0OjpzZXJ2aWNlV29ya2VyQ29udGFpbmVyKCkKICAgICBOYXZpZ2F0b3JCYXNlKiBuYXZp Z2F0b3IgPSBudWxscHRyOwogICAgIGlmIChpczxEb2N1bWVudD4oKnRoaXMpKSB7CiAgICAgICAg IGlmIChhdXRvKiB3aW5kb3cgPSBkb3duY2FzdDxEb2N1bWVudD4oKnRoaXMpLmRvbVdpbmRvdygp KQotICAgICAgICAgICAgbmF2aWdhdG9yID0gd2luZG93LT5uYXZpZ2F0b3IoKTsKKyAgICAgICAg ICAgIG5hdmlnYXRvciA9IHdpbmRvdy0+b3B0aW9uYWxOYXZpZ2F0b3IoKTsKICAgICB9IGVsc2UK LSAgICAgICAgbmF2aWdhdG9yID0gJmRvd25jYXN0PFdvcmtlckdsb2JhbFNjb3BlPigqdGhpcyku bmF2aWdhdG9yKCk7CisgICAgICAgIG5hdmlnYXRvciA9ICZkb3duY2FzdDxXb3JrZXJHbG9iYWxT Y29wZT4oKnRoaXMpLm9wdGlvbmFsTmF2aWdhdG9yKCk7CiAKICAgICByZXR1cm4gbmF2aWdhdG9y ID8gbmF2aWdhdG9yLT5zZXJ2aWNlV29ya2VyKCkgOiBudWxscHRyOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9N V2luZG93LmgKaW5kZXggZTA0YWNmMzZiMzkxMjA3MzQ0MGI3MDE4ZjNiOWUxMzMwYWVmZGFiNi4u OTRjMmYyOTc0MGNkZWE1Njc0ZGFjYmRiZjc5ODFkNDFiMGU0OGY4OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVdpbmRvdy5oCkBAIC0xMzcsNiArMTM3LDcgQEAgcHVibGljOgogICAgIEJhclByb3AqIHN0YXR1 c2JhcigpIGNvbnN0OwogICAgIEJhclByb3AqIHRvb2xiYXIoKSBjb25zdDsKICAgICBOYXZpZ2F0 b3IqIG5hdmlnYXRvcigpIGNvbnN0OworICAgIE5hdmlnYXRvciogb3B0aW9uYWxOYXZpZ2F0b3Io KSBjb25zdCB7IHJldHVybiBtX25hdmlnYXRvci5nZXQoKTsgfQogICAgIE5hdmlnYXRvciogY2xp ZW50SW5mb3JtYXRpb24oKSBjb25zdCB7IHJldHVybiBuYXZpZ2F0b3IoKTsgfQogCiAgICAgTG9j YXRpb24qIGxvY2F0aW9uKCkgY29uc3Q7Cg== 326125 2017-11-06 09:13:29 -0800 2017-11-06 11:46:38 -0800 Patch bug-179322-20171106091328.patch text/plain 2304 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3MzVmNGRkZDg4ZjZj NjBiNWE5NjRlYzFkN2QwYzdmNGJiOWZhOS4uOGExZmZiMDA5NGMwZjU4ZWFkZjE0MDJhOTU5MzFi YjQ0MWVhMjA0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2NyaXB0RXhlY3V0aW9uQ29u dGV4dDo6c2VydmljZVdvcmtlckNvbnRhaW5lcigpIHNob3VsZCBhdm9pZCBjb25zdHJ1Y3Rpbmcg YSBOYXZpZ2F0b3Igb2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzkzMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXJ2aWNlV29ya2VyQ29udGFpbmVy KCkgc2hvdWxkIGF2b2lkIGNvbnN0cnVjdGluZyBhIE5hdmlnYXRvciBvYmplY3QKKyAgICAgICAg dW5uZWNlc3NhcmlseS4KKworICAgICAgICAqIGRvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnNlcnZpY2VXb3Jr ZXJDb250YWluZXIpOgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6CisKIDIwMTctMTEtMDUg IEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dp bkNhaXJvXSBGaXggYnVpbGQgYWZ0ZXIgcjIyNDQ2MwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1Nj cmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCmluZGV4IDM4MmQyYzg3NzJkMWRiOTJmOGJlNTNlODI2 YzJjMmEzOTdkY2I0NjEuLjc4ZDFjYzFiODEwZmIxZTA5MzJiNjQ5MDdiY2I4N2I4ZTY3MGIzOTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKQEAg LTU0NSw5ICs1NDUsOSBAQCBTZXJ2aWNlV29ya2VyQ29udGFpbmVyKiBTY3JpcHRFeGVjdXRpb25D b250ZXh0OjpzZXJ2aWNlV29ya2VyQ29udGFpbmVyKCkKICAgICBOYXZpZ2F0b3JCYXNlKiBuYXZp Z2F0b3IgPSBudWxscHRyOwogICAgIGlmIChpczxEb2N1bWVudD4oKnRoaXMpKSB7CiAgICAgICAg IGlmIChhdXRvKiB3aW5kb3cgPSBkb3duY2FzdDxEb2N1bWVudD4oKnRoaXMpLmRvbVdpbmRvdygp KQotICAgICAgICAgICAgbmF2aWdhdG9yID0gd2luZG93LT5uYXZpZ2F0b3IoKTsKKyAgICAgICAg ICAgIG5hdmlnYXRvciA9IHdpbmRvdy0+b3B0aW9uYWxOYXZpZ2F0b3IoKTsKICAgICB9IGVsc2UK LSAgICAgICAgbmF2aWdhdG9yID0gJmRvd25jYXN0PFdvcmtlckdsb2JhbFNjb3BlPigqdGhpcyku bmF2aWdhdG9yKCk7CisgICAgICAgIG5hdmlnYXRvciA9IGRvd25jYXN0PFdvcmtlckdsb2JhbFNj b3BlPigqdGhpcykub3B0aW9uYWxOYXZpZ2F0b3IoKTsKIAogICAgIHJldHVybiBuYXZpZ2F0b3Ig PyBuYXZpZ2F0b3ItPnNlcnZpY2VXb3JrZXIoKSA6IG51bGxwdHI7CiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuaAppbmRleCBlMDRhY2YzNmIzOTEyMDczNDQwYjcwMThmM2I5ZTEzMzBhZWZkYWI2Li45 NGMyZjI5NzQwY2RlYTU2NzRkYWNiZGJmNzk4MWQ0MWIwZTQ4Zjg4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9N V2luZG93LmgKQEAgLTEzNyw2ICsxMzcsNyBAQCBwdWJsaWM6CiAgICAgQmFyUHJvcCogc3RhdHVz YmFyKCkgY29uc3Q7CiAgICAgQmFyUHJvcCogdG9vbGJhcigpIGNvbnN0OwogICAgIE5hdmlnYXRv ciogbmF2aWdhdG9yKCkgY29uc3Q7CisgICAgTmF2aWdhdG9yKiBvcHRpb25hbE5hdmlnYXRvcigp IGNvbnN0IHsgcmV0dXJuIG1fbmF2aWdhdG9yLmdldCgpOyB9CiAgICAgTmF2aWdhdG9yKiBjbGll bnRJbmZvcm1hdGlvbigpIGNvbnN0IHsgcmV0dXJuIG5hdmlnYXRvcigpOyB9CiAKICAgICBMb2Nh dGlvbiogbG9jYXRpb24oKSBjb25zdDsK