179321 2017-11-06 08:46:38 -0800 ServiceWorkerContainer should take a PendingActivity while a service worker job is pending 2017-11-15 12:10:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179302 InRadar P2 Normal --- 1 cdumez cdumez beidson ggaren webkit-bug-importer youennf oldest_to_newest 1368637 0 cdumez 2017-11-06 08:46:38 -0800 ServiceWorkerContainer should take a PendingActivity while a service worker job is pending. 1368638 1 326123 cdumez 2017-11-06 08:48:21 -0800 Created attachment 326123 Patch 1368657 2 326123 youennf 2017-11-06 09:44:21 -0800 Comment on attachment 326123 Patch The usual style would probably be to have scheduleJob take a completion handler so that we can ensure to have setpending/unsetpending close one to the other or use makePendingActivity. Given m_jobMap is only used to add/remove jobs, it could probably be moved at a different level as well. 1368662 3 326123 cdumez 2017-11-06 09:48:02 -0800 Comment on attachment 326123 Patch Clearing flags on attachment: 326123 Committed r224496: <https://trac.webkit.org/changeset/224496> 1368663 4 cdumez 2017-11-06 09:48:04 -0800 All reviewed patches have been landed. Closing bug. 1372094 5 webkit-bug-importer 2017-11-15 12:10:38 -0800 <rdar://problem/35567078> 326123 2017-11-06 08:48:21 -0800 2017-11-06 09:48:02 -0800 Patch bug-179321-20171106084821.patch text/plain 2145 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3MzVmNGRkZDg4ZjZj NjBiNWE5NjRlYzFkN2QwYzdmNGJiOWZhOS4uYWY3NzVjZjk3NGZmNzU3MWJhMmQ3ZWM0OGE3YzRm Njc1MjFmYWRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckNvbnRh aW5lciBzaG91bGQgdGFrZSBhIFBlbmRpbmdBY3Rpdml0eSB3aGlsZSBhIHNlcnZpY2Ugd29ya2Vy IGpvYiBpcyBwZW5kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzkzMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTZXJ2aWNlV29ya2VyQ29udGFpbmVyIHNob3VsZCB0YWtlIGEgUGVuZGluZ0FjdGl2 aXR5IHdoaWxlIGEgc2VydmljZSB3b3JrZXIgam9iIGlzIHBlbmRpbmcuCisgICAgICAgIFNlcnZp Y2VXb3JrZXJDb250YWluZXIgaXMgYW4gQWN0aXZlRE9NT2JqZWN0IGFuZCB0YWtpbmcgc3VjaCBw ZW5kaW5nIGFjdGl2aXR5IG1ha2VzIHN1cmUKKyAgICAgICAgdGhlIG9iamVjdCBzdGF5cyBhbGl2 ZSB3aGlsZSBhIGpvYiBpcyBwZW5kaW5nIChhbmQgYSBwcm9taXNlIGlzIG5vdCByZXNvbHZlZCB5 ZXQpLiBJdCBhbHNvCisgICAgICAgIG1ha2VzIHN1cmUgdGhlIGRvY3VtZW50IGRvZXMgbm90IGdl dCBzdXNwZW5kZWQgaW4gdGhlIG1pZGRsZSBvZiBhIGpvYi4KKworICAgICAgICAqIHdvcmtlcnMv c2VydmljZS9TZXJ2aWNlV29ya2VyQ29udGFpbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNl cnZpY2VXb3JrZXJDb250YWluZXI6OnNjaGVkdWxlSm9iKToKKyAgICAgICAgKFdlYkNvcmU6OlNl cnZpY2VXb3JrZXJDb250YWluZXI6OmpvYkRpZEZpbmlzaCk6CisKIDIwMTctMTEtMDUgIEZ1amlp IEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJv XSBGaXggYnVpbGQgYWZ0ZXIgcjIyNDQ2MwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29y a2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwCmluZGV4IGM0YTFlY2M4 ZTBhMmVmNmUzNGZiOWQ0ZDljNTJmYmRhOWMwM2M3YTkuLjM5MDMwMzkzMjE0N2RmZTNlZGYxMDU2 MWIzYmFlZDI2Yzc4M2E4NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy dmljZS9TZXJ2aWNlV29ya2VyQ29udGFpbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5lci5jcHAKQEAgLTE5NCw2ICsxOTQsOCBA QCB2b2lkIFNlcnZpY2VXb3JrZXJDb250YWluZXI6OnNjaGVkdWxlSm9iKFJlZjxTZXJ2aWNlV29y a2VySm9iPiYmIGpvYikKIHsKICAgICBBU1NFUlQobV9zd0Nvbm5lY3Rpb24pOwogCisgICAgc2V0 UGVuZGluZ0FjdGl2aXR5KHRoaXMpOworCiAgICAgU2VydmljZVdvcmtlckpvYiYgcmF3Sm9iID0g am9iLmdldCgpOwogICAgIGF1dG8gcmVzdWx0ID0gbV9qb2JNYXAuYWRkKHJhd0pvYi5kYXRhKCku aWRlbnRpZmllcigpLCBXVEZNb3ZlKGpvYikpOwogICAgIEFTU0VSVF9VTlVTRUQocmVzdWx0LCBy ZXN1bHQuaXNOZXdFbnRyeSk7CkBAIC0zODQsNiArMzg2LDggQEAgdm9pZCBTZXJ2aWNlV29ya2Vy Q29udGFpbmVyOjpqb2JEaWRGaW5pc2goU2VydmljZVdvcmtlckpvYiYgam9iKQogewogICAgIGF1 dG8gdGFrZW4gPSBtX2pvYk1hcC50YWtlKGpvYi5kYXRhKCkuaWRlbnRpZmllcigpKTsKICAgICBB U1NFUlRfVU5VU0VEKHRha2VuLCAhdGFrZW4gfHwgdGFrZW4tPnB0cigpID09ICZqb2IpOworCisg ICAgdW5zZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CiB9CiAKIHVpbnQ2NF90IFNlcnZpY2VXb3Jr ZXJDb250YWluZXI6OmNvbm5lY3Rpb25JZGVudGlmaWVyKCkK