179292 2017-11-04 17:47:59 -0700 REGRESSION (r221338): Web Inspector: NavigationBar incorrectly calculates minimumWidth 2017-11-15 12:11:32 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 174229 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1368412 0 nvasilyev 2017-11-04 17:47:59 -0700 Regressed in http://trac.webkit.org/changeset/221338 (is there a way to link to the particular line on that Trac page?) https://github.com/WebKit/webkit/commit/0658355ecdb6d2a5124409ca09611c489214b680#diff-c25e9ae6392f7d5378a5d218d4b2522bL372 let totalItemWidth = this._visibleNavigationItems.reduce((total, item) => item.minimumWidth, 0); totalItemWidth here is always minimumWidth of the last item. 1368413 1 326054 nvasilyev 2017-11-04 17:51:50 -0700 Created attachment 326054 Patch 1368472 2 nvasilyev 2017-11-05 13:06:36 -0800 This regression had no user impact in US English localization because WI.Sidebar.AbsoluteMinimumWidth of 200px provided sufficient width to fit all navigation items in our sidebars. There could have been issues with other localizations. 1368551 3 326054 hi 2017-11-05 22:45:00 -0800 Comment on attachment 326054 Patch r=me 1368552 4 326054 commit-queue 2017-11-05 23:04:05 -0800 Comment on attachment 326054 Patch Clearing flags on attachment: 326054 Committed r224481: <https://trac.webkit.org/changeset/224481> 1368553 5 commit-queue 2017-11-05 23:04:06 -0800 All reviewed patches have been landed. Closing bug. 1372105 6 webkit-bug-importer 2017-11-15 12:11:32 -0800 <rdar://problem/35567113> 326054 2017-11-04 17:51:50 -0700 2017-11-05 23:04:05 -0800 Patch patch.txt text/plain 1574 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIxNzU3NDcuLmQ4NmVhZGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTExLTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMjEzMzgp OiBXZWIgSW5zcGVjdG9yOiBOYXZpZ2F0aW9uQmFyIGluY29ycmVjdGx5IGNhbGN1bGF0ZXMgbWlu aW11bVdpZHRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzkyOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvbkJhci5qczoKKyAgICAgICAgKFdJLk5h dmlnYXRpb25CYXIucHJvdG90eXBlLl9jYWxjdWxhdGVNaW5pbXVtV2lkdGgpOgorICAgICAgICB0 b3RhbEl0ZW1XaWR0aCB3YXMgdGhlIG1pbmltdW1XaWR0aCBvZiB0aGUgbGFzdCBpdGVtLgorCiAy MDE3LTExLTA0ICBEZXZpbiBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IGFkZCBjb250ZXh0bWVudSBpdGVtIHRvIGFyYml0cmFyaWx5IGFk ZCBIVE1ML0NoaWxkIHRvIERPTVRyZWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25CYXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uQmFyLmpzCmluZGV4IGM2MWYwMzMu LjJiY2NkZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL05hdmlnYXRpb25CYXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvbkJhci5qcwpAQCAtNDI3LDcgKzQyNyw3IEBAIFdJLk5h dmlnYXRpb25CYXIgPSBjbGFzcyBOYXZpZ2F0aW9uQmFyIGV4dGVuZHMgV0kuVmlldwogICAgICAg ICBpZiAoIXdhc0NvbGxhcHNlZCkKICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3Qu YWRkKFdJLk5hdmlnYXRpb25CYXIuQ29sbGFwc2VkU3R5bGVDbGFzc05hbWUpOwogCi0gICAgICAg IGxldCB0b3RhbEl0ZW1XaWR0aCA9IHRoaXMuX3Zpc2libGVOYXZpZ2F0aW9uSXRlbXMucmVkdWNl KCh0b3RhbCwgaXRlbSkgPT4gaXRlbS5taW5pbXVtV2lkdGgsIDApOworICAgICAgICBsZXQgdG90 YWxJdGVtV2lkdGggPSB0aGlzLl92aXNpYmxlTmF2aWdhdGlvbkl0ZW1zLnJlZHVjZSgodG90YWws IGl0ZW0pID0+IHRvdGFsICsgaXRlbS5taW5pbXVtV2lkdGgsIDApOwogCiAgICAgICAgIC8vIFJl bW92ZSB0aGUgY29sbGFwc2VkIHN0eWxlIGNsYXNzIGlmIHdlIHdlcmUgbm90IGNvbGxhcHNlZCBi ZWZvcmUuCiAgICAgICAgIGlmICghd2FzQ29sbGFwc2VkKQo=