17929 2008-03-18 17:57:44 -0700 Incorrect decompilation with |const|, comma 2008-03-18 23:18:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 13638 1 jruderman oliver gavin.sharp oliver sam oldest_to_newest 74363 0 jruderman 2008-03-18 17:57:44 -0700 > function f() { const x = (1, 2); } > f function f() { const x = 1, 2; } > eval("" + f) SyntaxError: Parse error Tested with (Safari 3.1) and (ToT Debug/testkjs). 74374 1 mrowe 2008-03-18 18:59:51 -0700 <rdar://problem/5806714> 74391 2 19879 oliver 2008-03-18 23:06:39 -0700 Created attachment 19879 Patch-fu! 74392 3 19879 mrowe 2008-03-18 23:12:41 -0700 Comment on attachment 19879 Patch-fu! r=me. It'd be good if you could improve the grammar in the changelog entry (giant run-on sentences make me sad), and reference the bug URL in the layout test changelog too for easy reference. 74393 4 oliver 2008-03-18 23:18:13 -0700 M JavaScriptCore/ChangeLog M JavaScriptCore/kjs/nodes2string.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/function-toString-parentheses-expected.txt M LayoutTests/fast/js/resources/function-toString-parentheses.js Committed r31148 19879 2008-03-18 23:06:39 -0700 2008-03-18 23:12:41 -0700 Patch-fu! const-fix.patch text/plain 3058 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA2ZWMyZWU1Li5jNjU3ODk0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDgtMDMtMTggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMTc5Mjk6IEluY29y cmVjdCBkZWNvbXBpbGF0aW9uIHdpdGggfGNvbnN0fCwgY29tbWEKKyAgICAgICAgaHR0cDovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MjkKKworICAgICAgICBUaGVyZSB3ZXJl IGFjdHVhbGx5IHR3byBidWdzIGhlcmUsIGZpcnN0IHdlIHdlcmVuJ3QgY29ycmVjdGx5IGhhbmRs aW5nIGNvbnN0CisgICAgICAgIG5vZGVzIHdpdGggbXVsdGlwbGUgZGVjbGFyYXRpb25zLCB0aGVu IHdlIHdlcmVuJ3QgZ2l2aW5nIHRoZSBjb3JyZWN0IHByZWNlZGVuY2UKKyAgICAgICAgdG8gdGhl IGluaXRpYWxpc2VyIHdoZW4gZW1pdHRpbmcgaXQuCisKKyAgICAgICAgKiBranMvbm9kZXMyc3Ry aW5nLmNwcDoKKyAgICAgICAgKEtKUzo6Q29uc3REZWNsTm9kZTo6c3RyZWFtVG8pOgorCiAyMDA4 LTAzLTE4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNYWNpZWouCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMyc3RyaW5n LmNwcCBiL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCmluZGV4IGEzOGUyMmQu LmZmZTQwMzMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3Bw CisrKyBiL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCkBAIC03NjcsMTEgKzc2 NywxMSBAQCB2b2lkIENvbnN0RGVjbE5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29u c3QKIHsKICAgICBzIDw8IG1faWRlbnQ7CiAgICAgaWYgKG1faW5pdCkKLSAgICAgICAgcyA8PCAi ID0gIiA8PCBtX2luaXQ7CisgICAgICAgIHMgPDwgIiA9ICIgPDwgUHJlY0Fzc2lnbm1lbnQgPDwg bV9pbml0OwogICAgIGZvciAoQ29uc3REZWNsTm9kZSogbiA9IG1fbmV4dC5nZXQoKTsgbjsgbiA9 IG4tPm1fbmV4dC5nZXQoKSkgewotICAgICAgICBzIDw8ICIsICIgPDwgbV9pZGVudDsKKyAgICAg ICAgcyA8PCAiLCAiIDw8IG4tPm1faWRlbnQ7CiAgICAgICAgIGlmIChtX2luaXQpCi0gICAgICAg ICAgICBzIDw8ICIgPSAiIDw8IG1faW5pdDsKKyAgICAgICAgICAgIHMgPDwgIiA9ICIgPDwgUHJl Y0Fzc2lnbm1lbnQgPDwgbi0+bV9pbml0OwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgxZWMxMjMuLjRk ZDFhOGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAwOC0wMy0xOCAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3QgY2FzZXMgZm9yIGNvbnZlcnRpbmcgY29uc3Qgbm9kZXMgdG8gc3RyaW5n LgorCisgICAgICAgICogZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50 aGVzZXMuanM6CisKIDIwMDgtMDMtMTggIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvanMvcmVzb3VyY2VzL2Z1bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLmpzIGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMu anMKaW5kZXggNzVkMTI2YS4uMzUzZDYyNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9q cy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMuanMKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMuanMK QEAgLTIwNSw0ICsyMDUsMTEgQEAgc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9z dFRlc3QoJ3ZhciBhID0gMSwgYiA9IDInKSIsICIndmFyIGEgPSAxLCBiID0KIHNob3VsZEJlKCJj b21waWxlQW5kU2VyaWFsaXplTGVmdG1vc3RUZXN0KCd2YXIgYSwgYiwgYycpIiwgIid2YXIgYSwg YiwgYyciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplTGVmdG1vc3RUZXN0KCd2YXIg YSA9IDEsIGIgPSAyLCBjID0gMycpIiwgIid2YXIgYSA9IDEsIGIgPSAyLCBjID0gMyciKTsKIAor c2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9zdFRlc3QoJ2NvbnN0IGEgPSAxJyki LCAiJ2NvbnN0IGEgPSAxJyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9z dFRlc3QoJ2NvbnN0IGEgPSAoMSwgMiknKSIsICInY29uc3QgYSA9ICgxLCAyKSciKTsKK3Nob3Vs ZEJlKCJjb21waWxlQW5kU2VyaWFsaXplTGVmdG1vc3RUZXN0KCdjb25zdCBhID0gMSwgYiA9IDEn KSIsICInY29uc3QgYSA9IDEsIGIgPSAxJyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxp emVMZWZ0bW9zdFRlc3QoJ2NvbnN0IGEgPSAoMSwgMiksIGIgPSAxJykiLCAiJ2NvbnN0IGEgPSAo MSwgMiksIGIgPSAxJyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9zdFRl c3QoJ2NvbnN0IGEgPSAxLCBiID0gKDEsIDIpJykiLCAiJ2NvbnN0IGEgPSAxLCBiID0gKDEsIDIp JyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9zdFRlc3QoJ2NvbnN0IGEg PSAoMSwgMiksIGIgPSAoMSwgMiknKSIsICInY29uc3QgYSA9ICgxLCAyKSwgYiA9ICgxLCAyKSci KTsKKwogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==