17928 2008-03-18 16:52:51 -0700 testkjs shouldn't require "-f" 2008-06-07 20:52:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 jruderman webkit-unassigned sam oldest_to_newest 74355 0 jruderman 2008-03-18 16:52:51 -0700 It would be nice if "testkjs a.js" worked. I have a bunch of tools for fuzzing and testcase reduction that don't expect to have to pass extra arguments like "-f". 82596 1 21569 zwarich 2008-06-07 20:34:38 -0700 Created attachment 21569 Proposed patch 82598 2 21569 mitz 2008-06-07 20:45:07 -0700 Comment on attachment 21569 Proposed patch + fprintf(stderr, "Usage: testkjs [options] [files] [-- arguments]\n"); Looks like it's really [options and files], but I guess it's okay for the usage message to suggest separating them. r=me 82600 3 zwarich 2008-06-07 20:52:38 -0700 Landed in r34437. 21569 2008-06-07 20:34:38 -0700 2008-06-07 20:45:07 -0700 Proposed patch dashf.diff text/plain 1830 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NDM2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDYt MDcgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE3OTI4OiB0ZXN0a2pz IHNob3VsZG4ndCByZXF1aXJlICItZiIKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzkyOD4KKworICAgICAgICAqIGtqcy90ZXN0a2pzLmNwcDoKKyAg ICAgICAgKHByaW50VXNhZ2VTdGF0ZW1lbnQpOgorICAgICAgICAocGFyc2VBcmd1bWVudHMpOgor CiAyMDA4LTA2LTA3ICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNhPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiBranMvdGVzdGtqcy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0ga2pzL3Rlc3RranMuY3BwCShyZXZpc2lvbiAzNDQzNikKKysrIGtqcy90ZXN0a2pz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI2LDEzICszMjYsMTcgQEAgc3RhdGljIGJvb2wgcnVu V2l0aFNjcmlwdHMoY29uc3QgVmVjdG9yPAogCiBzdGF0aWMgdm9pZCBwcmludFVzYWdlU3RhdGVt ZW50KCkKIHsKLSAgICBmcHJpbnRmKHN0ZGVyciwgIlVzYWdlOiB0ZXN0a2pzIC1mIGZpbGUxIFst ZiBmaWxlMi4uLl1bLXBdWy0tIGFyZ3VtZW50cy4uLl1cbiIpOworICAgIGZwcmludGYoc3RkZXJy LCAiVXNhZ2U6IHRlc3RranMgW29wdGlvbnNdIFtmaWxlc10gWy0tIGFyZ3VtZW50c11cbiIpOwor ICAgIGZwcmludGYoc3RkZXJyLCAiICAtZiAgU3BlY2lmaWVzIGEgc291cmNlIGZpbGUgKGRlcHJl Y2F0ZWQpXG4iKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIiAgLXAgIFByaW50cyBmb3JtYXR0ZWQg c291cmNlIGNvZGVcbiIpOworICAgIGZwcmludGYoc3RkZXJyLCAiICAtZCAgRHVtcHMgYnl0ZWNv ZGUgKGRlYnVnIGJ1aWxkcyBvbmx5KVxuIik7CisgICAgZnByaW50ZihzdGRlcnIsICIgIC1zICBJ bnN0YWxscyBzaWduYWwgaGFuZGxlcnMgdGhhdCBleGl0IG9uIGEgY3Jhc2ggKFVuaXggcGxhdGZv cm1zIG9ubHkpXG4iKTsKICAgICBleGl0KC0xKTsKIH0KIAogc3RhdGljIHZvaWQgcGFyc2VBcmd1 bWVudHMoaW50IGFyZ2MsIGNoYXIqKiBhcmd2LCBWZWN0b3I8VVN0cmluZz4mIGZpbGVOYW1lcywg VmVjdG9yPFVTdHJpbmc+JiBhcmd1bWVudHMsIGJvb2wmIHByZXR0eVByaW50LCBib29sJiBkdW1w KQogewotICAgIGlmIChhcmdjIDwgMykKKyAgICBpZiAoYXJnYyA8IDIpCiAgICAgICAgIHByaW50 VXNhZ2VTdGF0ZW1lbnQoKTsKIAogICAgIGludCBpID0gMTsKQEAgLTM2NSw5ICszNjksMTIgQEAg c3RhdGljIHZvaWQgcGFyc2VBcmd1bWVudHMoaW50IGFyZ2MsIGNoYQogICAgICAgICAgICAgKytp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAgICAgICAgYnJlYWs7CisgICAgICAg IGZpbGVOYW1lcy5hcHBlbmQoYXJndltpXSk7CiAgICAgfQotCisgICAgCisgICAgaWYgKGZpbGVO YW1lcy5pc0VtcHR5KCkpCisgICAgICAgIHByaW50VXNhZ2VTdGF0ZW1lbnQoKTsKKyAgICAKICAg ICBmb3IgKDsgaSA8IGFyZ2M7ICsraSkKICAgICAgICAgYXJndW1lbnRzLmFwcGVuZChhcmd2W2ld KTsKIH0K