179262 2017-11-03 12:38:59 -0700 PutProperytSlot should inform the IC about the property before effects. 2017-11-03 12:57:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller buildbot mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1368071 0 keith_miller 2017-11-03 12:38:59 -0700 ... 1368073 1 325934 keith_miller 2017-11-03 12:40:01 -0700 Created attachment 325934 Patch 1368077 2 325934 mark.lam 2017-11-03 12:41:41 -0700 Comment on attachment 325934 Patch r=me 1368079 3 keith_miller 2017-11-03 12:42:36 -0700 rdar://problem/35288362 1368085 4 keith_miller 2017-11-03 12:57:11 -0700 Committed r224416: <https://trac.webkit.org/changeset/224416> 325934 2017-11-03 12:40:01 -0700 2017-11-03 12:41:41 -0700 Patch bug-179262-20171103124000.patch text/plain 4592 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MzFiZTFhZmYzYTg0NjU2ZWFlNDAzOWFiZDJkOTI0OWVmNGE5ZDNjLi43NTRhNWQxMmZhMTMwNGQ3 MTc5NGY5NDU1ZDgwNmVmOWYzMWU1YzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0xMS0wMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBQdXRQcm9wZXJ5dFNsb3Qgc2hvdWxkIGluZm9ybSB0aGUgSUMgYWJv dXQgdGhlIHByb3BlcnR5IGJlZm9yZSBlZmZlY3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBhbiBpc3N1ZSB3aGVyZSB3 ZSBjaG9vc2UgdG8gY2FjaGUgc2V0dGVycyBiYXNlZCBvbgorICAgICAgICBpbmNvcnJlY3QgaW5m b3JtYXRpb24uIElmIHdlIGRpZCBzbyB3ZSBtaWdodCBlbmQgdXAgT1NSIGV4aXRpbmcKKyAgICAg ICAgbW9yZSB0aGFuIHdlIHdvdWxkIG90aGVyd2lzZSBuZWVkIHRvLiBUaGUgbmV3IG1vZGVsIGlz IHRoYXQgdGhlCisgICAgICAgIFB1dFByb3BlcnR5U2xvdCBzaG91bGQgaW5mb3JtIHRoZSBJQyBv ZiB3aGF0IHRoZSBwcm9wZXJ0eSBsb29rZWQKKyAgICAgICAgbGlrZSBiZWZvcmUgYW55IHBvdGVu dGlhbCBzaWRlIGVmZmVjdHMgbWlnaHQgaGF2ZSBvY2N1cnJlZC4KKworICAgICAgICAqIHJ1bnRp bWUvSlNPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cHV0SW5saW5lU2xvdyk6 CisgICAgICAgICogcnVudGltZS9Mb29rdXAuaDoKKyAgICAgICAgKEpTQzo6cHV0RW50cnkpOgor CiAyMDE3LTExLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBD YWNoZWRDYWxsIChhbmQgaXRzIGNsaWVudHMpIG5lZWRzIG92ZXJmbG93IGNoZWNrcy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAppbmRleCA3MDJiMWU3YjlmZDE3 NjU3YjZhYzIzODQwMGY0NTc1ZGU5Nzk1ZDRiLi4xMDM3NjQzZWM4MzZiYjU2YWZiNzIzOWZjMzhh YTE5OGFhYjg0MjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U09iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu Y3BwCkBAIC03NzYsMTkgKzc3NiwyMyBAQCBib29sIEpTT2JqZWN0OjpwdXRJbmxpbmVTbG93KEV4 ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgSlNWYWx1ZQogCiAgICAg ICAgICAgICBKU1ZhbHVlIGdzID0gb2JqLT5nZXREaXJlY3Qob2Zmc2V0KTsKICAgICAgICAgICAg IGlmIChncy5pc0dldHRlclNldHRlcigpKSB7Ci0gICAgICAgICAgICAgICAgYm9vbCByZXN1bHQg PSBjYWxsU2V0dGVyKGV4ZWMsIHNsb3QudGhpc1ZhbHVlKCksIGdzLCB2YWx1ZSwgc2xvdC5pc1N0 cmljdE1vZGUoKSA/IFN0cmljdE1vZGUgOiBOb3RTdHJpY3RNb2RlKTsKLSAgICAgICAgICAgICAg ICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7CisgICAgICAgICAgICAgICAgLy8g V2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCB3ZSBkZWNpZGUgdG8gY2FjaGUgdGhpcyBwcm9wZXJ0 eSBiZWZvcmUgd2UgcG90ZW50aWFsbHkgZXhlY3V0ZSBhcmliaXRyYXJ5IEpTLgogICAgICAgICAg ICAgICAgIGlmICghc3RydWN0dXJlKCktPmlzRGljdGlvbmFyeSgpKQogICAgICAgICAgICAgICAg ICAgICBzbG90LnNldENhY2hlYWJsZVNldHRlcihvYmosIG9mZnNldCk7CisKKyAgICAgICAgICAg ICAgICBib29sIHJlc3VsdCA9IGNhbGxTZXR0ZXIoZXhlYywgc2xvdC50aGlzVmFsdWUoKSwgZ3Ms IHZhbHVlLCBzbG90LmlzU3RyaWN0TW9kZSgpID8gU3RyaWN0TW9kZSA6IE5vdFN0cmljdE1vZGUp OworICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKICAg ICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICAgICAgfQogICAgICAgICAgICAg aWYgKGdzLmlzQ3VzdG9tR2V0dGVyU2V0dGVyKCkpIHsKLSAgICAgICAgICAgICAgICBib29sIHJl c3VsdCA9IGNhbGxDdXN0b21TZXR0ZXIoZXhlYywgZ3MsIGF0dHJpYnV0ZXMgJiBQcm9wZXJ0eUF0 dHJpYnV0ZTo6Q3VzdG9tQWNjZXNzb3IsIG9iaiwgc2xvdC50aGlzVmFsdWUoKSwgdmFsdWUpOwot ICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsKKyAgICAg ICAgICAgICAgICAvLyBXZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGRlY2lkZSB0byBjYWNo ZSB0aGlzIHByb3BlcnR5IGJlZm9yZSB3ZSBwb3RlbnRpYWxseSBleGVjdXRlIGFyaWJpdHJhcnkg SlMuCiAgICAgICAgICAgICAgICAgaWYgKGF0dHJpYnV0ZXMgJiBQcm9wZXJ0eUF0dHJpYnV0ZTo6 Q3VzdG9tQWNjZXNzb3IpCiAgICAgICAgICAgICAgICAgICAgIHNsb3Quc2V0Q3VzdG9tQWNjZXNz b3Iob2JqLCBqc0Nhc3Q8Q3VzdG9tR2V0dGVyU2V0dGVyKj4oZ3MuYXNDZWxsKCkpLT5zZXR0ZXIo KSk7CiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBzbG90LnNldEN1 c3RvbVZhbHVlKG9iaiwganNDYXN0PEN1c3RvbUdldHRlclNldHRlcio+KGdzLmFzQ2VsbCgpKS0+ c2V0dGVyKCkpOworCisgICAgICAgICAgICAgICAgYm9vbCByZXN1bHQgPSBjYWxsQ3VzdG9tU2V0 dGVyKGV4ZWMsIGdzLCBhdHRyaWJ1dGVzICYgUHJvcGVydHlBdHRyaWJ1dGU6OkN1c3RvbUFjY2Vz c29yLCBvYmosIHNsb3QudGhpc1ZhbHVlKCksIHZhbHVlKTsKKyAgICAgICAgICAgICAgICBSRVRV Uk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHJl c3VsdDsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIEFTU0VSVCghKGF0dHJpYnV0ZXMgJiBQ cm9wZXJ0eUF0dHJpYnV0ZTo6QWNjZXNzb3IpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0xvb2t1cC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TG9va3VwLmgKaW5kZXggNjAwNWQxYzg5MjU2YTJmYzRhNTEyNzViNDQyMDJiNDZmNzFhZGYxMi4u MDhkZGM3MDIzOTEwMDhkMTFhMjM0Njc1M2FmMTBiYWVjYjhjZTBkMyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTG9va3VwLmgKQEAgLTI4OSwxMiArMjg5LDE0IEBAIGlubGluZSBib29s IHB1dEVudHJ5KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgQ2xhc3NJbmZvKiwgY29uc3QgSGFzaFRh YmxlVmFsdWUqIGVuCiAgICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIShlbnRyeS0+YXR0cmli dXRlcygpICYgUHJvcGVydHlBdHRyaWJ1dGU6OkRPTUpJVEF0dHJpYnV0ZSksICJET01KSVRBdHRy aWJ1dGUgc3VwcG9ydHMgcmVhZG9ubHkgYXR0cmlidXRlcyBjdXJyZW50bHkuIik7CiAgICAgICAg IGJvb2wgaXNBY2Nlc3NvciA9IGVudHJ5LT5hdHRyaWJ1dGVzKCkgJiBQcm9wZXJ0eUF0dHJpYnV0 ZTo6Q3VzdG9tQWNjZXNzb3I7CiAgICAgICAgIEpTVmFsdWUgdXBkYXRlVGhpc1ZhbHVlID0gZW50 cnktPmF0dHJpYnV0ZXMoKSAmIFByb3BlcnR5QXR0cmlidXRlOjpDdXN0b21BY2Nlc3NvciA/IHNs b3QudGhpc1ZhbHVlKCkgOiBKU1ZhbHVlKGJhc2UpOwotICAgICAgICBib29sIHJlc3VsdCA9IGNh bGxDdXN0b21TZXR0ZXIoZXhlYywgZW50cnktPnByb3BlcnR5UHV0dGVyKCksIGlzQWNjZXNzb3Is IHVwZGF0ZVRoaXNWYWx1ZSwgdmFsdWUpOwotICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNj b3BlLCBmYWxzZSk7CisgICAgICAgIC8vIFdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgd2UgZGVj aWRlIHRvIGNhY2hlIHRoaXMgcHJvcGVydHkgYmVmb3JlIHdlIHBvdGVudGlhbGx5IGV4ZWN1dGUg YXJpYml0cmFyeSBKUy4KICAgICAgICAgaWYgKGlzQWNjZXNzb3IpCiAgICAgICAgICAgICBzbG90 LnNldEN1c3RvbUFjY2Vzc29yKGJhc2UsIGVudHJ5LT5wcm9wZXJ0eVB1dHRlcigpKTsKICAgICAg ICAgZWxzZQogICAgICAgICAgICAgc2xvdC5zZXRDdXN0b21WYWx1ZShiYXNlLCBlbnRyeS0+cHJv cGVydHlQdXR0ZXIoKSk7CisKKyAgICAgICAgYm9vbCByZXN1bHQgPSBjYWxsQ3VzdG9tU2V0dGVy KGV4ZWMsIGVudHJ5LT5wcm9wZXJ0eVB1dHRlcigpLCBpc0FjY2Vzc29yLCB1cGRhdGVUaGlzVmFs dWUsIHZhbHVlKTsKKyAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZmFsc2UpOwog ICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0KIAo=