17926 2008-03-18 16:41:40 -0700 Unformat deletes images 2010-10-25 15:19:08 -0700 1 1 1 Unclassified WebKit HTML Editing 525.x (Safari 3.1) All All RESOLVED FIXED http://rtef.info/demo.htm NeedsReduction P2 Normal --- 43017 1 fuck webkit-unassigned jparent justin.garcia ojan rniwa tkent tony oldest_to_newest 74349 0 fuck 2008-03-18 16:41:40 -0700 Go to http://rtef.info/demo.htm Switch to HTML mode Insert this code Please don't kill my brother, <img src="http://www.dcs.dk/imgNewDesign/frontBrother.gif" alt="Brother" /> Switch to RichText mode Select all content (button 1 or how ever you do it), hit unformat (button 2) 74353 1 fuck 2008-03-18 16:51:51 -0700 Probably should mention that unfromat calls "rteCommand('RemoveFormat') rteCommand('JustifyNone') and rteCommand('FormatBlock', '<p>') on the selected contnet. 105102 2 contact 2009-01-09 18:54:43 -0800 I have the same issue when executing : document.execCommand('RemoveFormat',false,null); on a mix text / img, img are deleted. I avoid selection on img by adding "-khtml-user-select:none" on them same problem. another thing the text lost class inherit properties <div id='editor' class='textclass'> .... my text ... </div> When apply "RemoveFormat" the text CSS class might be 'textclass' ! Same problem on Chrome Regards Jeff 299095 3 71792 rniwa 2010-10-25 14:02:24 -0700 Created attachment 71792 Patch 299096 4 rniwa 2010-10-25 14:03:31 -0700 This bug has been fixed since http://trac.webkit.org/changeset/70283. I'm adding two more tests to make sure we're not removing any images. 299104 5 71792 ojan 2010-10-25 14:25:55 -0700 Comment on attachment 71792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71792&action=review > LayoutTests/editing/execCommand/remove-format-image.html:2 > +<html> Don't need this tag. It just adds clutter. The doctype is useful because it forces standards mode though. > LayoutTests/editing/execCommand/remove-format-image.html:3 > +<body onload="runTests();"> Do you need to run this onload? Can't you just run the script inline? If you do that, you won't need the body tag in the test. > LayoutTests/editing/execCommand/remove-format-image.html:5 > +<div id="test1" contenteditable><storng>hello</strong> <img src="../resources/abe.png"> world</div> typo:storng 299113 6 rniwa 2010-10-25 14:43:33 -0700 (In reply to comment #5) > > LayoutTests/editing/execCommand/remove-format-image.html:2 > > +<html> > > Don't need this tag. It just adds clutter. The doctype is useful because it forces standards mode though. I don't think having <html> adds that much of cluttering. I think most of tests that do have DOCTYPE also has html, and I'd rather conform to that trend. Are you strongly inclined to remove this before landing? > > LayoutTests/editing/execCommand/remove-format-image.html:3 > > +<body onload="runTests();"> > > Do you need to run this onload? Can't you just run the script inline? If you do that, you won't need the body tag in the test. Yes. Images aren't necessarily loaded by the time the script is ran, and we get a different result when that happens. Or otherwise we'll make this test flaky. > > LayoutTests/editing/execCommand/remove-format-image.html:5 > > +<div id="test1" contenteditable><storng>hello</strong> <img src="../resources/abe.png"> world</div> > > typo:storng Oops, thanks. Will fix. 299122 7 ojan 2010-10-25 15:08:34 -0700 (In reply to comment #6) > (In reply to comment #5) > > > LayoutTests/editing/execCommand/remove-format-image.html:2 > > > +<html> > > > > Don't need this tag. It just adds clutter. The doctype is useful because it forces standards mode though. > > I don't think having <html> adds that much of cluttering. I think most of tests that do have DOCTYPE also has html, and I'd rather conform to that trend. Are you strongly inclined to remove this before landing? No. Either way is fine. While I agree that many tests have the html tag, I don't personally like it. The smaller a test is, the easier it is to make sense of and maintain. 299127 8 rniwa 2010-10-25 15:18:00 -0700 Committed r70493: <http://trac.webkit.org/changeset/70493> 299129 9 rniwa 2010-10-25 15:19:08 -0700 Thanks for the review, Ojan. 71792 2010-10-25 14:02:24 -0700 2010-10-25 14:25:55 -0700 Patch bug-17926-20101025140223.patch text/plain 2848 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwNDg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjUgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5mb3JtYXQgZGVsZXRlcyBpbWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTI2CisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRv IGVuc3VyZSBSZW1vdmVGb3JtYXRDb21tYW5kIGRvZXMgbm90IHJlbW92ZSBpbWFnZSBlbGVtZW50 cy4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLWZvcm1hdC1pbWFnZS1p bnB1dC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQv cmVtb3ZlLWZvcm1hdC1pbWFnZS1pbnB1dC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0yNSAgSmlh biBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQg TGV2aW4uCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3Jt YXQtaW1hZ2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcv ZXhlY0NvbW1hbmQvcmVtb3ZlLWZvcm1hdC1pbWFnZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3JtYXQtaW1hZ2Ut ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACitUaGlzIHRlc3RzIFJl bW92ZUZvcm1hbnQgY29tbWFuZCBub3QgcmVtb3ZpbmcgYW4gaW1hZ2UuICBZb3Ugc2hvdWxkIHNl ZSBvbmUgaW1hZ2UgZWxlbWVudCBpbiBlYWNoIG9mIHRoZSB0ZXN0IHJlc3VsdHMKKworQW4gaW1h Z2UgYmV0d2VlbiB0ZXh0OgorfCA8c3Rvcm5nPgorfCAgICI8I3NlbGVjdGlvbi1hbmNob3I+aGVs bG8gIgorfCAgIDxpbWc+Cit8ICAgICBzcmM9Ii4uL3Jlc291cmNlcy9hYmUucG5nIgorfCAgICIg d29ybGQ8I3NlbGVjdGlvbi1mb2N1cz4iCisKK1JlbW92ZUZvcm1hdCBvbiBhbiBpbWFnZSBmb2xs b3dlZCBieSBKdXN0aWZ5Tm9uZSBhbmQgRm9ybWF0QmxvY2sgd2l0aCBwLjoKK3wgPHA+Cit8ICAg PCNzZWxlY3Rpb24tYW5jaG9yPgorfCAgIDxpbWc+Cit8ICAgICBzcmM9Ii4uL3Jlc291cmNlcy9h YmUucG5nIgorfCAgIDwjc2VsZWN0aW9uLWZvY3VzPgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC9yZW1vdmUtZm9ybWF0LWltYWdlLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9yZW1vdmUtZm9ybWF0LWltYWdlLmh0bWwJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1mb3Jt YXQtaW1hZ2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdHMoKTsiPgorPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJ0ZXN0 MSIgY29udGVudGVkaXRhYmxlPjxzdG9ybmc+aGVsbG88L3N0cm9uZz4gPGltZyBzcmM9Ii4uL3Jl c291cmNlcy9hYmUucG5nIj4gd29ybGQ8L2Rpdj4KKzxkaXYgaWQ9InRlc3QyIiBjb250ZW50ZWRp dGFibGU+PGltZyBzcmM9Ii4uL3Jlc291cmNlcy9hYmUucG5nIj48L2Rpdj4KKzxzY3JpcHQ+CisK K2Z1bmN0aW9uIHJ1blRlc3RzKCkgeworICAgIE1hcmt1cC5kZXNjcmlwdGlvbignVGhpcyB0ZXN0 cyBSZW1vdmVGb3JtYW50IGNvbW1hbmQgbm90IHJlbW92aW5nIGFuIGltYWdlLiAgWW91IHNob3Vs ZCBzZWUgb25lIGltYWdlIGVsZW1lbnQgaW4gZWFjaCBvZiB0aGUgdGVzdCByZXN1bHRzJyk7Cisg ICAgd2luZG93LmdldFNlbGVjdGlvbigpLnNlbGVjdEFsbENoaWxkcmVuKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCd0ZXN0MScpKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnUmVtb3ZlRm9y bWF0JywgZmFsc2UsIG51bGwpOworICAgIE1hcmt1cC5kdW1wKCd0ZXN0MScsICdBbiBpbWFnZSBi ZXR3ZWVuIHRleHQnKTsKKworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZWxlY3RBbGxDaGls ZHJlbihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdDInKSk7CisgICAgZG9jdW1lbnQuZXhl Y0NvbW1hbmQoJ1JlbW92ZUZvcm1hdCcsIGZhbHNlLCBudWxsKTsKKyAgICBkb2N1bWVudC5leGVj Q29tbWFuZCgnSnVzdGlmeU5vbmUnLCBmYWxzZSwgbnVsbCk7CisgICAgZG9jdW1lbnQuZXhlY0Nv bW1hbmQoJ0Zvcm1hdEJsb2NrJywgZmFsc2UsICdwJyk7CisgICAgTWFya3VwLmR1bXAoJ3Rlc3Qy JywgJ1JlbW92ZUZvcm1hdCBvbiBhbiBpbWFnZSBmb2xsb3dlZCBieSBKdXN0aWZ5Tm9uZSBhbmQg Rm9ybWF0QmxvY2sgd2l0aCBwLicpOworCisgICAgTWFya3VwLm5vdGlmeURvbmUoKTsKK30KKwor TWFya3VwLndhaXRVbnRpbERvbmUoKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==