179259 2017-11-03 12:26:16 -0700 ASSERTION FAILED: NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()) 2017-11-03 17:36:11 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179157 InRadar P2 Normal --- 1 ryanhaddad rniwa buildbot cdumez eric.carlson jeremyj-wk jer.noble rniwa simon.fraser webkit-bug-importer youennf oldest_to_newest 1368064 0 ryanhaddad 2017-11-03 12:26:16 -0700 ASSERTION FAILED: NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()) /Volumes/Data/slave/sierra-debug/build/Source/WebCore/dom/Document.cpp(1959) : void WebCore::Document::updateLayout() 1 0x11d1dbaad WTFCrash 2 0x11156d781 WebCore::Document::updateLayout() 3 0x111572efe WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks) 4 0x1116082bf WebCore::Element::boundingClientRect() 5 0x11160864f WebCore::Element::getBoundingClientRect() 6 0x1129c3438 WebCore::VTTRegion::willRemoveTextTrackCueBox(WebCore::VTTCueBox*) 7 0x1129bf247 WebCore::VTTCue::removeDisplayTree() 8 0x1129bf168 WebCore::VTTCue::setIsActive(bool) 9 0x1118da855 WebCore::HTMLMediaElement::updateActiveTextTrackCues(WTF::MediaTime const&) 10 0x1118eed01 WebCore::HTMLMediaElement::userCancelledLoad() 11 0x1118ef258 WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer() 12 0x1118ef47e WebCore::HTMLMediaElement::stop() 13 0x1118ef519 non-virtual thunk to WebCore::HTMLMediaElement::stop() 14 0x1116c7f6e WebCore::ScriptExecutionContext::stopActiveDOMObjects() 15 0x1115769d5 WebCore::Document::stopActiveDOMObjects() 16 0x111576506 WebCore::Document::prepareForDestruction() 17 0x111d97990 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView>&&) 18 0x111d99f63 WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) 19 0x1062d5462 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() 20 0x111c1fed6 WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) 21 0x111c1ef6a WebCore::FrameLoader::commitProvisionalLoad() 22 0x111bd485c WebCore::DocumentLoader::commitIfReady() 23 0x111bd4b82 WebCore::DocumentLoader::finishedLoading() 24 0x111bdc6d5 WebCore::DocumentLoader::maybeLoadEmpty() 25 0x111bdc85d WebCore::DocumentLoader::startLoadingMainResource() 26 0x111c3a2b4 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8::operator()() const 27 0x111c39ff9 WTF::Function<void ()>::CallableWrapper<WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL)::$_8>::call() 28 0x10f956deb WTF::Function<void ()>::operator()() const 29 0x111c1d2cd WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, bool, WebCore::AllowNavigationToInvalidURL) 30 0x111c38be8 WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6::operator()(WebCore::ResourceRequest const&, WebCore::FormState*, bool) const 31 0x111c38b72 WTF::Function<void (WebCore::ResourceRequest const&, WebCore::FormState*, bool)>::CallableWrapper<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WebCore::FormState*, WebCore::AllowNavigationToInvalidURL)::$_6>::call(WebCore::ResourceRequest const&, WebCore::FormState*, bool) https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r224399%20(3860)/results.html 1368066 1 ryanhaddad 2017-11-03 12:27:48 -0700 CRASHING TEST: media/track/regions-webvtt/vtt-region-dom-layout.html CRASHING TEST: media/video-main-content-autoplay.html CRASHING TEST: media/video-main-content-allow-then-scroll.html 1368086 2 rniwa 2017-11-03 12:57:41 -0700 Looking... 1368245 3 325989 rniwa 2017-11-03 16:46:50 -0700 Created attachment 325989 Fixes the assertions 1368246 4 webkit-bug-importer 2017-11-03 16:48:44 -0700 <rdar://problem/35346321> 1368247 5 buildbot 2017-11-03 16:49:26 -0700 Attachment 325989 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1368250 6 325989 youennf 2017-11-03 16:52:31 -0700 Comment on attachment 325989 Fixes the assertions It seems like we can easily fall into that trap here or there... View in context: https://bugs.webkit.org/attachment.cgi?id=325989&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). Remove this for landing. 1368260 7 rniwa 2017-11-03 17:35:02 -0700 Thanks for the review! 1368261 8 rniwa 2017-11-03 17:36:11 -0700 Committed r224444: <https://trac.webkit.org/changeset/224444> 325989 2017-11-03 16:46:50 -0700 2017-11-03 16:52:31 -0700 Fixes the assertions bug-179259-20171103164649.patch text/plain 2542 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDQ0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTExLTAzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IE5v RXZlbnREaXNwYXRjaEFzc2VydGlvbjo6SW5NYWluVGhyZWFkOjppc0V2ZW50QWxsb3dlZCgpIHx8 IChmcmFtZVZpZXcgJiYgZnJhbWVWaWV3LT5pc0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5p bmcoKSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTI1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2 b2lkIHVwZGF0aW5nIHRoZSBsYXlvdXQgaW5zaWRlIEhUTUxNZWRpYUVsZW1lbnQ6OnN0b3AoKSBh bmQgTWVkaWFFbGVtZW50U2Vzc2lvbjo6fk1lZGlhRWxlbWVudFNlc3Npb24KKworICAgICAgICBO byBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1c2VyQ2FuY2VsbGVkTG9h ZCk6IERvbid0IHVwZGF0ZSBWVFQgY3VlcyB3aGVuIHRoZSBhY3RpdmUgRE9NIG9iamVjdHMgYXJl IGJlaW5nIHN0b3BwZWQuCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lv bk1hbmFnZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyTWFj OjpyZW1vdmVTZXNzaW9uKTogVXBkYXRlIHRoZSB1cGRhdGVOb3dQbGF5aW5nSW5mbyBhc3luY2hy b25vdXNseQorICAgICAgICBzaW5jZSB0aGlzIGZ1bmN0aW9uIGNhbiBiZSBjYWxsZWQgaW5zaWRl IEhUTUxNZWRpYUVsZW1lbnQ6On5IVE1MTWVkaWFFbGVtZW50LgorCiAyMDE3LTExLTAzICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjI0NDI4LCByMjI0NDM1LCBhbmQgcjIyNDQ0MC4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMjI0NDI1KQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTM0NCw3ICs1MzQ0LDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXNlckNhbmNlbGxl ZExvYWQKICAgICAvLyBSZXNldCBtX3JlYWR5U3RhdGUgc2luY2UgbV9wbGF5ZXIgaXMgZ29uZS4K ICAgICBtX3JlYWR5U3RhdGUgPSBIQVZFX05PVEhJTkc7CiAgICAgdXBkYXRlTWVkaWFDb250cm9s bGVyKCk7CisKICNpZiBFTkFCTEUoVklERU9fVFJBQ0spCisgICAgYXV0byogY29udGV4dCA9IHNj cmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKKyAgICBpZiAoIWNvbnRleHQgfHwgY29udGV4dC0+YWN0 aXZlRE9NT2JqZWN0c0FyZVN0b3BwZWQoKSkKKyAgICAgICAgcmV0dXJuOyAvLyBEb2N1bWVudCBp cyBhYm91dCB0byBiZSBkZXN0cnVjdGVkLiBBdm9pZCB1cGRhdGluZyBsYXlvdXQgaW4gdXBkYXRl QWN0aXZlVGV4dFRyYWNrQ3Vlcy4KKwogICAgIHVwZGF0ZUFjdGl2ZVRleHRUcmFja0N1ZXMoTWVk aWFUaW1lOjp6ZXJvVGltZSgpKTsKICNlbmRpZgogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMu bW0JKHJldmlzaW9uIDIyNDQyNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21h Yy9NZWRpYVNlc3Npb25NYW5hZ2VyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05NSw3ICs5NSw3 IEBAIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlck1hYzo6cmVtb3ZlU2Vzc2kKIHsKICAgICBQbGF0 Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnJlbW92ZVNlc3Npb24oc2Vzc2lvbik7CiAgICAgTE9H KE1lZGlhLCAiTWVkaWFTZXNzaW9uTWFuYWdlck1hYzo6cmVtb3ZlU2Vzc2lvbiIpOwotICAgIHVw ZGF0ZU5vd1BsYXlpbmdJbmZvKCk7CisgICAgc2NoZWR1bGVVcGRhdGVOb3dQbGF5aW5nSW5mbygp OwogfQogCiB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJNYWM6OnNlc3Npb25XaWxsRW5kUGxheWJh Y2soUGxhdGZvcm1NZWRpYVNlc3Npb24mIHNlc3Npb24pCg==