179238 2017-11-03 04:44:13 -0700 Use WK_IOS_TBA instead of WK_MAC_TBA to indicate availability of private functions on iOS 2017-11-15 12:14:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fred.wang fred.wang ajuma darin dbates eric.carlson fred.wang lforschler webkit-bug-importer youennf oldest_to_newest 1367877 0 fred.wang 2017-11-03 04:44:13 -0700 The changes happened in r224057 and r223207. Also I recently upgraded Xcode. These are the errors I get: /Users/fred/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests .mm:63:11: error: '_requestActiveNowPlayingSessionInfo:' is unavailable: not available on iOS [self _requestActiveNowPlayingSessionInfo:completionHandler]; ^ In file included from /Users/fred/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:32: /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:439:1: note: '_requestActiveNowPlayingSessionInfo:' has been explicitly marked unavailable here - (void)_requestActiveNowPlayingSessionInfo:(void(^)(BOOL, NSString*, do... ^ 1 error generated. /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:27: er ror: '_setCacheStoragePerOriginQuota:' is unavailable: not available on iOS [poolWebsiteDataStore _setCacheStoragePerOriginQuota: 400 * 1024]; ^ In file included from /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:46: /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:48:74: note: property '_cacheStoragePerOriginQuota' is declared unavailable here ...(nonatomic, setter=_setCacheStoragePerOriginQuota:) NSUInteger _cacheSto... ^ /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:48:74: note: '_setCacheStoragePerOriginQuota:' has been explicitly marked unavailable here /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:87:31: error: '_setCacheStorageDirectory:' is unavailable: not available on iOS [poolWebsiteDataStore _setCacheStorageDirectory: cacheStorageDirectory]; ^ In file included from /Users/fred/WebKit/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:46: /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:49:68: note: property '_cacheStorageDirectory' is declared unavailable here @property (nonatomic, setter=_setCacheStorageDirectory:) NSString* _cach... ^ /Users/fred/WebKit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebsiteDataStorePrivate.h:49:68: note: '_setCacheStorageDirectory:' has been explicitly marked unavailable here 2 errors generated. 1367880 1 325882 fred.wang 2017-11-03 04:45:50 -0700 Created attachment 325882 Patch This patch fixes the build errors, but I have no ideas whether it is correct. 1367901 2 ajuma 2017-11-03 06:36:24 -0700 Is the problem that on lines 48 and 49 of WKWebsiteDataStorePrivate.h, the ios version is set to WK_MAC_TBA instead of WK_IOS_TBA? 1367914 3 325893 fred.wang 2017-11-03 07:50:05 -0700 Created attachment 325893 Patch 1367924 4 fred.wang 2017-11-03 08:11:10 -0700 Committed r224396: <https://trac.webkit.org/changeset/224396> 1372114 5 webkit-bug-importer 2017-11-15 12:14:30 -0800 <rdar://problem/35567189> 325882 2017-11-03 04:45:50 -0700 2017-11-03 07:49:59 -0700 Patch 179238.patch text/plain 1744 fred.wang ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTm93UGxh eWluZ0NvbnRyb2xzVGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL05vd1BsYXlpbmdDb250cm9sc1Rlc3RzLm1tCmluZGV4IGVkMWY2NjhiNjcuLmU1NTZjMmU0 ZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTm93 UGxheWluZ0NvbnRyb2xzVGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Ob3dQbGF5aW5nQ29udHJvbHNUZXN0cy5tbQpAQCAtNTksNyArNTksOSBAQCAt IChCT09MKWhhc0FjdGl2ZU5vd1BsYXlpbmdTZXNzaW9uCiAgICAgICAgIF9yZWNlaXZlZE5vd1Bs YXlpbmdJbmZvUmVzcG9uc2UgPSB0cnVlOwogICAgIH07CiAKKyNpZiBVU0UoQVBQTEVfSU5URVJO QUxfU0RLKQogICAgIFtzZWxmIF9yZXF1ZXN0QWN0aXZlTm93UGxheWluZ1Nlc3Npb25JbmZvOmNv bXBsZXRpb25IYW5kbGVyXTsKKyNlbmRpZgogCiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVu KCZfcmVjZWl2ZWROb3dQbGF5aW5nSW5mb1Jlc3BvbnNlKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0Q29udHJvbGxlckNvY29hLm1tIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0Q29udHJvbGxlckNvY29hLm1tCmluZGV4IGViOTU4MWFk MTguLjYwMWNmMGRjNTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvY29jb2Ev VGVzdENvbnRyb2xsZXJDb2NvYS5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29h L1Rlc3RDb250cm9sbGVyQ29jb2EubW0KQEAgLTc5LDEyICs3OSwxNCBAQCB2b2lkIGluaXRpYWxp emVXZWJWaWV3Q29uZmlndXJhdGlvbihjb25zdCBjaGFyKiBsaWJyYXJ5UGF0aCwgV0tTdHJpbmdS ZWYgaW5qZWN0ZQogICAgIFdLQ29va2llTWFuYWdlclNldENvb2tpZVN0b3JhZ2VQYXJ0aXRpb25p bmdFbmFibGVkKFdLQ29udGV4dEdldENvb2tpZU1hbmFnZXIoY29udGV4dCksIHRydWUpOwogI2Vu ZGlmCiAKKyNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogICAgIFdLV2Vic2l0ZURhdGFTdG9y ZSogcG9vbFdlYnNpdGVEYXRhU3RvcmUgPSAoV0tXZWJzaXRlRGF0YVN0b3JlICopV0tDb250ZXh0 R2V0V2Vic2l0ZURhdGFTdG9yZSgoV0tDb250ZXh0UmVmKWdsb2JhbFdlYlZpZXdDb25maWd1cmF0 aW9uLnByb2Nlc3NQb29sKTsKICAgICBbcG9vbFdlYnNpdGVEYXRhU3RvcmUgX3NldENhY2hlU3Rv cmFnZVBlck9yaWdpblF1b3RhOiA0MDAgKiAxMDI0XTsKICAgICBpZiAobGlicmFyeVBhdGgpIHsK ICAgICAgICAgU3RyaW5nIGNhY2hlU3RvcmFnZURpcmVjdG9yeSA9IFN0cmluZyhsaWJyYXJ5UGF0 aCkgKyAnLycgKyAiQ2FjaGVTdG9yYWdlIjsKICAgICAgICAgW3Bvb2xXZWJzaXRlRGF0YVN0b3Jl IF9zZXRDYWNoZVN0b3JhZ2VEaXJlY3Rvcnk6IGNhY2hlU3RvcmFnZURpcmVjdG9yeV07CiAgICAg fQorI2VuZGlmCiAKICAgICBbZ2xvYmFsV2ViVmlld0NvbmZpZ3VyYXRpb24ud2Vic2l0ZURhdGFT dG9yZSBfc2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQ6WUVTXTsKICAgICBbZ2xvYmFs V2ViVmlld0NvbmZpZ3VyYXRpb24ud2Vic2l0ZURhdGFTdG9yZSBfcmVzb3VyY2VMb2FkU3RhdGlz dGljc1NldFNob3VsZFN1Ym1pdFRlbGVtZXRyeTpOT107Cg== 325893 2017-11-03 07:50:05 -0700 2017-11-03 07:56:51 -0700 Patch bug-179238-20171103155004.patch text/plain 3901 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhMzU2MjI3MTZkZTBkNDEx NTY3MzExMjNmOWFiZjQ3NTBlMDk4OGMuLjAyYWI0ZWY2Y2ZiODE1M2U0NmY2NGYzOTg4MjdjZGQy MzY4MmM1NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTEtMDMgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIFVzZSBXS19JT1NfVEJBIGluc3Rl YWQgb2YgV0tfTUFDX1RCQSB0byBpbmRpY2F0ZSBhdmFpbGFiaWxpdHkgb2YgcHJpdmF0ZSBmdW5j dGlvbnMgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzkyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlUHJpdmF0ZS5oOgorCiAyMDE3 LTExLTAyICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgRG9u J3QgdHJ5IHRvIGd1ZXNzIHBsdWdpbiBNSU1FIHR5cGUgZnJvbSBhIGZpbGUgZXh0ZW5zaW9uIGlu IGEgVVJMIChubyBvYnNlcnZhYmxlIGVmZmVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IGM5ZmQ1NDBiMDZjZWUy YjYyNTAxNDY4OGJlYzYxMDEwZjZjMDZhYjEuLjk2NmZiOWJhMTliOTZkNTU3MmUwZWNmMTQyOTI4 MzQ0ZDljMGYwNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXdQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlld1ByaXZhdGUuaApAQCAtNDM2LDcgKzQzNiw3IEBAIHR5cGVkZWYgTlNfT1BU SU9OUyhOU0ludGVnZXIsIF9XS1JlY3RFZGdlKSB7CiAtICh2b2lkKV9zZXRGb290ZXJCYW5uZXJI ZWlnaHQ6KGludCloZWlnaHQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIuMykpOwogI2Vu ZGlmCiAKLS0gKHZvaWQpX3JlcXVlc3RBY3RpdmVOb3dQbGF5aW5nU2Vzc2lvbkluZm86KHZvaWQo XikoQk9PTCwgTlNTdHJpbmcqLCBkb3VibGUsIGRvdWJsZSwgTlNJbnRlZ2VyKSljYWxsYmFjayBX S19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX01BQ19UQkEpKTsKKy0g KHZvaWQpX3JlcXVlc3RBY3RpdmVOb3dQbGF5aW5nU2Vzc2lvbkluZm86KHZvaWQoXikoQk9PTCwg TlNTdHJpbmcqLCBkb3VibGUsIGRvdWJsZSwgTlNJbnRlZ2VyKSljYWxsYmFjayBXS19BUElfQVZB SUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIAogLSAodm9pZClf c2V0UGFnZVNjYWxlOihDR0Zsb2F0KXNjYWxlIHdpdGhPcmlnaW46KENHUG9pbnQpb3JpZ2luIFdL X0FQSV9BVkFJTEFCTEUoaW9zKDEwLjMpKTsKIC0gKENHRmxvYXQpX3BhZ2VTY2FsZSBXS19BUElf QVZBSUxBQkxFKGlvcygxMC4zKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZVByaXZhdGUuaAppbmRleCA5MzIz Y2E1MjM0Mjk0MjhmMTcwNjkwMjFlMmNkOTMwZThlZTFiNWExLi5lNWNiY2YzNzJmZmZkZDJlYmQ0 M2QzNzYwYmI3YjkxN2MxNjM0OTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmVQcml2YXRlLmgKQEAgLTQ1 LDExICs0NSwxMSBAQCB0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdlciwgX1dLV2Vic2l0ZURh dGFTdG9yZUZldGNoT3B0aW9ucykgewogLSAodm9pZClfZmV0Y2hEYXRhUmVjb3Jkc09mVHlwZXM6 KE5TU2V0PE5TU3RyaW5nICo+ICopZGF0YVR5cGVzIHdpdGhPcHRpb25zOihfV0tXZWJzaXRlRGF0 YVN0b3JlRmV0Y2hPcHRpb25zKW9wdGlvbnMgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5T QXJyYXk8V0tXZWJzaXRlRGF0YVJlY29yZCAqPiAqKSljb21wbGV0aW9uSGFuZGxlcjsKIAogQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJs ZWQ6KSBCT09MIF9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZCBXS19BUElfQVZBSUxBQkxF KG1hY29zeCgxMC4xMiksIGlvcygxMC4wKSk7Ci1AcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVy PV9zZXRDYWNoZVN0b3JhZ2VQZXJPcmlnaW5RdW90YTopIE5TVUludGVnZXIgX2NhY2hlU3RvcmFn ZVBlck9yaWdpblF1b3RhIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3Mo V0tfTUFDX1RCQSkpOwotQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0Q2FjaGVTdG9y YWdlRGlyZWN0b3J5OikgTlNTdHJpbmcqIF9jYWNoZVN0b3JhZ2VEaXJlY3RvcnkgV0tfQVBJX0FW QUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19NQUNfVEJBKSk7CitAcHJvcGVydHkg KG5vbmF0b21pYywgc2V0dGVyPV9zZXRDYWNoZVN0b3JhZ2VQZXJPcmlnaW5RdW90YTopIE5TVUlu dGVnZXIgX2NhY2hlU3RvcmFnZVBlck9yaWdpblF1b3RhIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4 KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOworQHByb3BlcnR5IChub25hdG9taWMsIHNl dHRlcj1fc2V0Q2FjaGVTdG9yYWdlRGlyZWN0b3J5OikgTlNTdHJpbmcqIF9jYWNoZVN0b3JhZ2VE aXJlY3RvcnkgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19JT1Nf VEJBKSk7CiAKLUBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEJvdW5kSW50ZXJmYWNl SWRlbnRpZmllcjopIE5TU3RyaW5nICpfYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyIFdLX0FQSV9B VkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfTUFDX1RCQSkpOwotQHByb3BlcnR5 IChub25hdG9taWMsIHNldHRlcj1fc2V0QWxsb3dzQ2VsbHVsYXJBY2Nlc3M6KSBCT09MIF9hbGxv d3NDZWxsdWxhckFjY2VzcyBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9z KFdLX01BQ19UQkEpKTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldEJvdW5kSW50 ZXJmYWNlSWRlbnRpZmllcjopIE5TU3RyaW5nICpfYm91bmRJbnRlcmZhY2VJZGVudGlmaWVyIFdL X0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOworQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0QWxsb3dzQ2VsbHVsYXJBY2Nlc3M6KSBCT09M IF9hbGxvd3NDZWxsdWxhckFjY2VzcyBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJB KSwgaW9zKFdLX0lPU19UQkEpKTsKIAogLy8gUmVzb3VyY2VMb2FkU3RhdGlzdGljcyBTUEkgZm9y IHRlc3RpbmcuCiAtICh2b2lkKV9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzU2V0TGFzdFNlZW46KGRv dWJsZSlzZWNvbmRzIGZvckhvc3Q6KE5TU3RyaW5nICopaG9zdCBXS19BUElfQVZBSUxBQkxFKG1h Y29zeCgxMC4xMyksIGlvcygxMS4wKSk7Cg==