17923 2008-03-18 15:03:30 -0700 ARM platform endian defines inaccurate in JavaScriptCore 2008-03-20 07:34:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 15416 1 david.krause webkit-unassigned ddkilzer oldest_to_newest 74326 0 david.krause 2008-03-18 15:03:30 -0700 As part of bug 15416 (http://bugs.webkit.org/show_bug.cgi?id=15416), a change was made to JavaScriptCore/wtf/Platform.h that affected when the WTF_PLATFORM_MIDDLE_ENDIAN define is set. The specific changeset is http://trac.webkit.org/projects/webkit/changeset/31115. Basically, some ARM platforms that define __ARMEL__ still need the MIDDLE_ENDIAN define. Specifically, it affects those little-endian ARM platforms using FPA floating-point. See comment on original bug for more details at http://bugs.webkit.org/show_bug.cgi?id=15416#c15. The 31115 change causes JavaScript issues on those ARM platforms that no longer have the MIDDLE_ENDIAN define, but need it. The issue seen is that the JavaScript dtoa function falls into an infinite loop. 74327 1 mrowe 2008-03-18 15:08:24 -0700 How can the other platforms that need MIDDLE_ENDIAN be detected? 74328 2 david.krause 2008-03-18 15:11:53 -0700 The only recommendation I have was in my previous comment. I am not sure which defines are present for VFP floating-point, but for FPA the following works: #elif !defined(__ARM_EABI__) && !defined(__ARMEB__) && defined(__ARMEL__) && defined(__SOFTFP__) Right now, I only have access to my version of gcc, which sets __ARMEL__ and __SOFTFP__ for FPA. 74329 3 ddkilzer 2008-03-18 15:13:35 -0700 Is there not an __ARMEM__ macro for middle endian systems? Or is this sufficient (per Bug 15416 Comment #15)? #elif !defined(__ARM_EABI__) && !defined(__ARMEB__) && defined(__ARMEL__) && defined(__SOFTFP__) 74331 4 ddkilzer 2008-03-18 15:17:25 -0700 (In reply to comment #2) > The only recommendation I have was in my previous comment. I am not sure which > defines are present for VFP floating-point, but for FPA the following works: > > #elif !defined(__ARM_EABI__) && !defined(__ARMEB__) && defined(__ARMEL__) && > defined(__SOFTFP__) > > Right now, I only have access to my version of gcc, which sets __ARMEL__ and > __SOFTFP__ for FPA. If this is sufficient, please post a patch with changelog to this bug. Thanks! 74332 5 david.krause 2008-03-18 15:27:22 -0700 No __ARMEM__ macro exists. I'll post a patch as requested. 74431 6 19884 david.krause 2008-03-19 06:44:22 -0700 Created attachment 19884 Proposed patch Found a VFP toolchain, and it also defines __ARMEL__ and __SOFTFP__, so my earlier proposal would not have been appropriate. __VFP_FP__ is the define that indicates VFP support, which should not use MIDDLE_ENDIAN. 74517 7 19884 ddkilzer 2008-03-20 06:52:34 -0700 Comment on attachment 19884 Proposed patch Looks good! r=me 74521 8 ddkilzer 2008-03-20 07:34:13 -0700 Committed revision 31176. 19884 2008-03-19 06:44:22 -0700 2008-03-20 06:52:34 -0700 Proposed patch patch.txt text/plain 1236 david.krause SW5kZXg6IFdlYktpdC9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMzExNTIpCisrKyBXZWJLaXQv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMDgtMDMtMTkgIERhdmlkIEtyYXVzZSAgPGRhdmlkLmtyYXVzZUBnbWFpbC5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTIzCisgICAgICAgIEJ1ZyAxNzkyMzog QVJNIHBsYXRmb3JtIGVuZGlhbiBkZWZpbmVzIGluYWNjdXJhdGUKKworICAgICAgICAqIHd0Zi9Q bGF0Zm9ybS5oOiAKKyAgICAgICAgUmVwbGFjZWQgIWRlZmluZWQoX19BUk1FTF9fKSBjaGVjayB3 aXRoICFkZWZpbmVkKF9fVkZQX0ZQX18pCisgICAgICAgIGZvciBQTEFURk9STShNSURETEVfRU5E SUFOKQorCiAyMDA4LTAzLTE5ICBKYXNwZXIgQnJ5YW50LUdyZWVuZSAgPGphc3BlckB1bml4Lmdl ZWsubno+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBX ZWJLaXQvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAzMTE1MikKKysrIFdlYktp dC9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDcg KzE0OCw3IEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9BUk0gMQogI2lmIGRlZmluZWQoX19BUk1F Ql9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1fQklHX0VORElBTiAxCi0jZWxpZiAhZGVmaW5lZChf X0FSTV9FQUJJX18pICYmICFkZWZpbmVkKF9fQVJNRUJfXykgJiYgIWRlZmluZWQoX19BUk1FTF9f KQorI2VsaWYgIWRlZmluZWQoX19BUk1fRUFCSV9fKSAmJiAhZGVmaW5lZChfX0FSTUVCX18pICYm ICFkZWZpbmVkKF9fVkZQX0ZQX18pCiAjZGVmaW5lIFdURl9QTEFURk9STV9NSURETEVfRU5ESUFO IDEKICNlbmRpZgogI2lmICFkZWZpbmVkKF9fQVJNX0VBQklfXykK