179225 2017-11-02 19:31:16 -0700 Web Inspector: Uncaught Exception: null is not an object (evaluating 'selector.specificity.map')​ (at SpreadsheetCSSStyleDeclarationSection.js:​199:​51)​ 2017-11-03 16:31:54 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck nvasilyev bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1367717 0 joepeck 2017-11-02 19:31:16 -0700 Inspected an element using the element search and got an exception: TypeError:​ null is not an object (evaluating 'selector.specificity.map')​ (at SpreadsheetCSSStyleDeclarationSection.js:​199:​51)​ appendSelector @ SpreadsheetCSSStyleDeclarationSection.js:​199:​51 _renderSelector @ SpreadsheetCSSStyleDeclarationSection.js:​236:​35 layout @ SpreadsheetCSSStyleDeclarationSection.js:​109:​29 _layoutSubtree @ View.js:​278:​20 _visitViewTreeForLayout @ View.js:​374:​36 1367718 1 joepeck 2017-11-02 19:32:01 -0700 Inspect the inspector and inspect any DOM node <li> => exception. 1367719 2 webkit-bug-importer 2017-11-02 19:32:28 -0700 <rdar://problem/35329019> 1367754 3 bburg 2017-11-02 20:35:39 -0700 o_O 1368187 4 nvasilyev 2017-11-03 15:16:17 -0700 "using the element search" — using the bull eye icon, i.e. "Start element selection (⇧⌘C)"? I can't reproduce it. Would be great if you can show it on your machine. 1368195 5 nvasilyev 2017-11-03 15:24:03 -0700 I reproduced it :| 1368206 6 325976 nvasilyev 2017-11-03 15:44:19 -0700 Created attachment 325976 Patch 1368211 7 325976 joepeck 2017-11-03 15:50:26 -0700 Comment on attachment 325976 Patch r=me 1368212 8 325976 joepeck 2017-11-03 15:51:21 -0700 Comment on attachment 325976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325976&action=review > Source/WebInspectorUI/ChangeLog:12 > + Check if selector.specificity is falsy, the same way as in the old styles sidebar > + (defined in WI.CSSStyleDeclarationSection.prototype.refresh). A better comment would not describe what the if check is doing (its obviously checking for a truthy value), but would describe why the if check is necessary (sometimes the specificity does not exist because ....) 1368222 9 325982 nvasilyev 2017-11-03 16:11:58 -0700 Created attachment 325982 Patch 1368236 10 325982 commit-queue 2017-11-03 16:31:53 -0700 Comment on attachment 325982 Patch Clearing flags on attachment: 325982 Committed r224441: <https://trac.webkit.org/changeset/224441> 1368237 11 commit-queue 2017-11-03 16:31:54 -0700 All reviewed patches have been landed. Closing bug. 325976 2017-11-03 15:44:19 -0700 2017-11-03 16:11:58 -0700 Patch patch.txt text/plain 2085 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlkMDQwNDEuLjJkZDlhZjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTAzICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1 Z2h0IEV4Y2VwdGlvbjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdzZWxlY3Rv ci5zcGVjaWZpY2l0eS5tYXAnKSAoYXQgU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2Vj dGlvbi5qczoxOTk6NTEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzkyMjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MzI5MDE5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzOgorICAgICAg ICAoV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5wcm90b3R5cGUuX3Jl bmRlclNlbGVjdG9yKToKKyAgICAgICAgQ2hlY2sgaWYgc2VsZWN0b3Iuc3BlY2lmaWNpdHkgaXMg ZmFsc3ksIHRoZSBzYW1lIHdheSBhcyBpbiB0aGUgb2xkIHN0eWxlcyBzaWRlYmFyCisgICAgICAg IChkZWZpbmVkIGluIFdJLkNTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLnByb3RvdHlwZS5yZWZy ZXNoKS4KKwogMjAxNy0xMS0wMiAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXMgUmVkZXNpZ246IHR1cm4gb24gQ1NT IHNwcmVhZHNoZWV0IGVkaXRvciBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRp b25TZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qcwppbmRleCAyMTAyOGZmLi5m ZjJlM2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0Q1NTU3R5bGVE ZWNsYXJhdGlvblNlY3Rpb24uanMKQEAgLTE5Niw4ICsxOTYsOCBAQCBXSS5TcHJlYWRzaGVldENT U1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uID0gY2xhc3MgU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xh cmF0aW9uUwogICAgICAgICAgICAgaWYgKG1hdGNoZWQpCiAgICAgICAgICAgICAgICAgc2VsZWN0 b3JFbGVtZW50LmNsYXNzTGlzdC5hZGQoV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9u U2VjdGlvbi5NYXRjaGVkU2VsZWN0b3JFbGVtZW50U3R5bGVDbGFzc05hbWUpOwogCi0gICAgICAg ICAgICBsZXQgc3BlY2lmaWNpdHkgPSBzZWxlY3Rvci5zcGVjaWZpY2l0eS5tYXAoKG51bWJlcikg PT4gbnVtYmVyLnRvTG9jYWxlU3RyaW5nKCkpOwotICAgICAgICAgICAgaWYgKHNwZWNpZmljaXR5 KSB7CisgICAgICAgICAgICBpZiAoc2VsZWN0b3Iuc3BlY2lmaWNpdHkpIHsKKyAgICAgICAgICAg ICAgICBsZXQgc3BlY2lmaWNpdHkgPSBzZWxlY3Rvci5zcGVjaWZpY2l0eS5tYXAoKG51bWJlcikg PT4gbnVtYmVyLnRvTG9jYWxlU3RyaW5nKCkpOwogICAgICAgICAgICAgICAgIGxldCB0b29sdGlw ID0gV0kuVUlTdHJpbmcoIlNwZWNpZmljaXR5OiAoJWQsICVkLCAlZCkiKS5mb3JtYXQoLi4uc3Bl Y2lmaWNpdHkpOwogICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rvci5keW5hbWljKSB7CiAgICAg ICAgICAgICAgICAgICAgIHRvb2x0aXAgKz0gIlxuIjsK 325982 2017-11-03 16:11:58 -0700 2017-11-03 16:31:53 -0700 Patch patch.txt text/plain 2037 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlkMDQwNDEuLjM5OTEwMDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTAzICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1 Z2h0IEV4Y2VwdGlvbjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdzZWxlY3Rv ci5zcGVjaWZpY2l0eS5tYXAnKSAoYXQgU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2Vj dGlvbi5qczoxOTk6NTEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzkyMjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MzI5MDE5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qczoKKyAgICAg ICAgKFdJLlNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24ucHJvdG90eXBlLl9y ZW5kZXJTZWxlY3Rvcik6CisgICAgICAgIHNlbGVjdG9yLnNwZWNpZmljaXR5IG1heSBub3QgZXhp c3Qgd2hlbiB0aGUgc2VsZWN0b3IgaXMgZHluYW1pYyBhbmQgZG9lc24ndCBtYXRjaCB0aGUgc2Vs ZWN0ZWQgZWxlbWVudC4KKwogMjAxNy0xMS0wMiAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdHlsZXMgUmVkZXNpZ246IHR1 cm4gb24gQ1NTIHNwcmVhZHNoZWV0IGVkaXRvciBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxl RGVjbGFyYXRpb25TZWN0aW9uLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU3ByZWFkc2hlZXRDU1NTdHlsZURlY2xhcmF0aW9uU2VjdGlvbi5qcwppbmRleCAy MTAyOGZmLi5mZjJlM2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0 Q1NTU3R5bGVEZWNsYXJhdGlvblNlY3Rpb24uanMKQEAgLTE5Niw4ICsxOTYsOCBAQCBXSS5TcHJl YWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25TZWN0aW9uID0gY2xhc3MgU3ByZWFkc2hlZXRDU1NT dHlsZURlY2xhcmF0aW9uUwogICAgICAgICAgICAgaWYgKG1hdGNoZWQpCiAgICAgICAgICAgICAg ICAgc2VsZWN0b3JFbGVtZW50LmNsYXNzTGlzdC5hZGQoV0kuU3ByZWFkc2hlZXRDU1NTdHlsZURl Y2xhcmF0aW9uU2VjdGlvbi5NYXRjaGVkU2VsZWN0b3JFbGVtZW50U3R5bGVDbGFzc05hbWUpOwog Ci0gICAgICAgICAgICBsZXQgc3BlY2lmaWNpdHkgPSBzZWxlY3Rvci5zcGVjaWZpY2l0eS5tYXAo KG51bWJlcikgPT4gbnVtYmVyLnRvTG9jYWxlU3RyaW5nKCkpOwotICAgICAgICAgICAgaWYgKHNw ZWNpZmljaXR5KSB7CisgICAgICAgICAgICBpZiAoc2VsZWN0b3Iuc3BlY2lmaWNpdHkpIHsKKyAg ICAgICAgICAgICAgICBsZXQgc3BlY2lmaWNpdHkgPSBzZWxlY3Rvci5zcGVjaWZpY2l0eS5tYXAo KG51bWJlcikgPT4gbnVtYmVyLnRvTG9jYWxlU3RyaW5nKCkpOwogICAgICAgICAgICAgICAgIGxl dCB0b29sdGlwID0gV0kuVUlTdHJpbmcoIlNwZWNpZmljaXR5OiAoJWQsICVkLCAlZCkiKS5mb3Jt YXQoLi4uc3BlY2lmaWNpdHkpOwogICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rvci5keW5hbWlj KSB7CiAgICAgICAgICAgICAgICAgICAgIHRvb2x0aXAgKz0gIlxuIjsK