<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179204</bug_id>
          
          <creation_ts>2017-11-02 15:31:32 -0700</creation_ts>
          <short_desc>Reduce duplication in the toplevel Makefile</short_desc>
          <delta_ts>2017-11-15 12:30:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>aestes</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mitz</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1367583</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 15:31:32 -0700</bug_when>
    <thetext>Reduce duplication in the toplevel Makefile</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367584</commentid>
    <comment_count>1</comment_count>
      <attachid>325780</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 15:31:51 -0700</bug_when>
    <thetext>Created attachment 325780
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367606</commentid>
    <comment_count>2</comment_count>
      <attachid>325780</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-02 16:00:20 -0700</bug_when>
    <thetext>Comment on attachment 325780
Patch

Clearing flags on attachment: 325780

Committed r224361: &lt;https://trac.webkit.org/changeset/224361&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367607</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-02 16:00:21 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367611</commentid>
    <comment_count>4</comment_count>
      <attachid>325780</attachid>
    <who name="">mitz</who>
    <bug_when>2017-11-02 16:14:01 -0700</bug_when>
    <thetext>Comment on attachment 325780
Patch

Does this change the build order such that libwebrtc builds after WebCore?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367614</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 16:25:36 -0700</bug_when>
    <thetext>A good point! I will fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367617</commentid>
    <comment_count>6</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 16:31:11 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367618</commentid>
    <comment_count>7</comment_count>
      <attachid>325793</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 16:31:12 -0700</bug_when>
    <thetext>Created attachment 325793
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367633</commentid>
    <comment_count>8</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 17:01:53 -0700</bug_when>
    <thetext>Follow up landed in https://trac.webkit.org/changeset/224363/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367710</commentid>
    <comment_count>9</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 19:18:56 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367711</commentid>
    <comment_count>10</comment_count>
      <attachid>325820</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 19:18:57 -0700</bug_when>
    <thetext>Created attachment 325820
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367712</commentid>
    <comment_count>11</comment_count>
      <attachid>325820</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-11-02 19:19:23 -0700</bug_when>
    <thetext>Comment on attachment 325820
Patch

Not my greatest success.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367729</commentid>
    <comment_count>12</comment_count>
      <attachid>325820</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-02 19:51:02 -0700</bug_when>
    <thetext>Comment on attachment 325820
Patch

Clearing flags on attachment: 325820

Committed r224372: &lt;https://trac.webkit.org/changeset/224372&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1367730</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-02 19:51:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372170</commentid>
    <comment_count>14</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-15 12:30:45 -0800</bug_when>
    <thetext>&lt;rdar://problem/35567681&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325780</attachid>
            <date>2017-11-02 15:31:51 -0700</date>
            <delta_ts>2017-11-02 16:31:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179204-20171102153150.patch</filename>
            <type>text/plain</type>
            <size>1448</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvTWFrZWZpbGUg
Yi9Tb3VyY2UvTWFrZWZpbGUKaW5kZXggMDM0NDVkYzNjMmZjNjkxODIwYjNjZWQxNzVlNDAxZTA5
NGZjZDFhMy4uNTc0NDMxNjg4ODdiZGJhZmE4YWNjYmQyYjMzNDVkNjUxODg4MDVhYiAxMDA2NDQK
LS0tIGEvU291cmNlL01ha2VmaWxlCisrKyBiL1NvdXJjZS9NYWtlZmlsZQpAQCAtMSw4ICsxLDEx
IEBACi1NT0RVTEVTID0gYm1hbGxvYyBXVEYgSmF2YVNjcmlwdENvcmUgVGhpcmRQYXJ0eS9BTkdM
RSBUaGlyZFBhcnR5L2xpYndlYnJ0YyBXZWJDb3JlIFdlYkluc3BlY3RvclVJIFdlYktpdExlZ2Fj
eSBXZWJLaXQKK01PRFVMRVMgPSBibWFsbG9jIFdURiBKYXZhU2NyaXB0Q29yZSBUaGlyZFBhcnR5
L0FOR0xFIFdlYkNvcmUgV2ViS2l0TGVnYWN5IFdlYktpdAogCiBpZm5lcSAoLCQoU0RLUk9PVCkp
Ci0JaWZlcSAoLCQoZmluZHN0cmluZyBtYWNvc3gsJChTREtST09UKSkpCi0JCU1PRFVMRVMgPSBi
bWFsbG9jIFdURiBKYXZhU2NyaXB0Q29yZSBUaGlyZFBhcnR5L0FOR0xFIFRoaXJkUGFydHkvbGli
d2VicnRjIFdlYkNvcmUgV2ViS2l0TGVnYWN5IFdlYktpdAorCWlmbmVxICgsJChmaW5kc3RyaW5n
IG1hY29zeCwkKFNES1JPT1QpKSkKKwkJTU9EVUxFUyArPSBXZWJJbnNwZWN0b3JVSSBUaGlyZFBh
cnR5L2xpYndlYnJ0YworCWVuZGlmCisJaWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lLCQoU0RL
Uk9PVCkpKQorCQlNT0RVTEVTICs9IFRoaXJkUGFydHkvbGlid2VicnRjCiAJZW5kaWYKIGVuZGlm
CiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyOGI1Njk3OGY3Yzkx
ZjExNjk3MDE2ZDgzZmRmOGU5YzNjZjU5ZmMxLi42NjIwNTZjNTQ5YTM4NDM4NDEyZmY2YTE5ZjJm
MmRiYjMwMmI1YjhjIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTQgQEAKKzIwMTctMTEtMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmVkdWNlIGR1cGxpY2F0aW9uIGluIHRoZSB0b3BsZXZlbCBNYWtl
ZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5
MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT
b3VyY2UvTWFrZWZpbGU6CisgICAgICAgIE1ha2UgTU9EVUxFUyBhZGRpdGl2ZSBpbnN0ZWFkIG9m
IGNvbXBsZXRlbHkgcmVwZWF0ZWQsIGFuZCBvbmx5IGJ1aWxkCisgICAgICAgIGxpYndlYnJ0YyB3
aGVyZSBpdCdzIG5lZWRlZC4KKwogMjAxNy0xMS0wMiAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0Bp
Z2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0eXBvcyBpbiBsaWJyYXJ5IG5h
bWVzIGZvciB0aGUgR1RLKyBwb3J0Lgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325793</attachid>
            <date>2017-11-02 16:31:12 -0700</date>
            <delta_ts>2017-11-02 19:18:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179204-20171102163111.patch</filename>
            <type>text/plain</type>
            <size>1529</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDM2
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEx
LTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJl
ZHVjZSBkdXBsaWNhdGlvbiBpbiB0aGUgdG9wbGV2ZWwgTWFrZWZpbGUKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTIwNAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL01ha2VmaWxlOgorICAg
ICAgICBBZGRyZXNzIHNvbWUgcG9zdC1sYW5kaW5nIHJldmlldyBjb21tZW50cyB0byBrZWVwIHRo
ZSBvcmRlciBvZiB0aGUgTU9EVUxFUyBjb3JyZWN0LgorCiAyMDE3LTExLTAyICBUaW0gSG9ydG9u
ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZHVjZSBkdXBsaWNhdGlv
biBpbiB0aGUgdG9wbGV2ZWwgTWFrZWZpbGUKSW5kZXg6IFNvdXJjZS9NYWtlZmlsZQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvTWFrZWZpbGUJKHJldmlzaW9uIDIyNDM2MSkKKysrIFNvdXJjZS9NYWtl
ZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSwxNCArMSwyNCBAQAotTU9EVUxFUyA9IGJtYWxsb2Mg
V1RGIEphdmFTY3JpcHRDb3JlIFRoaXJkUGFydHkvQU5HTEUgV2ViQ29yZSBXZWJLaXRMZWdhY3kg
V2ViS2l0CitNT0RVTEVTID0gYm1hbGxvYyBXVEYgSmF2YVNjcmlwdENvcmUgVGhpcmRQYXJ0eS9B
TkdMRSAKIAogaWZuZXEgKCwkKFNES1JPT1QpKQotCWlmbmVxICgsJChmaW5kc3RyaW5nIG1hY29z
eCwkKFNES1JPT1QpKSkKLQkJTU9EVUxFUyArPSBXZWJJbnNwZWN0b3JVSSBUaGlyZFBhcnR5L2xp
YndlYnJ0YwotCWVuZGlmCiAJaWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lLCQoU0RLUk9PVCkp
KQogCQlNT0RVTEVTICs9IFRoaXJkUGFydHkvbGlid2VicnRjCiAJZW5kaWYKKwlpZm5lcSAoLCQo
ZmluZHN0cmluZyBtYWNvc3gsJChTREtST09UKSkpCisJCU1PRFVMRVMgKz0gVGhpcmRQYXJ0eS9s
aWJ3ZWJydGMKKwllbmRpZgorZW5kaWYKKworTU9EVUxFUyArPSBXZWJDb3JlIAorCitpZm5lcSAo
LCQoU0RLUk9PVCkpCisJaWZuZXEgKCwkKGZpbmRzdHJpbmcgbWFjb3N4LCQoU0RLUk9PVCkpKQor
CQlNT0RVTEVTICs9IFdlYkluc3BlY3RvclVJCisJZW5kaWYKIGVuZGlmCiAKK01PRFVMRVMgKz0g
V2ViS2l0TGVnYWN5IFdlYktpdAorCiBhbGw6CiAJQGZvciBkaXIgaW4gJChNT0RVTEVTKTsgZG8g
JHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9JCQ/OyBcCiAJaWYgWyAkJGV4aXRfc3Rh
dHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsgZG9uZQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325820</attachid>
            <date>2017-11-02 19:18:57 -0700</date>
            <delta_ts>2017-11-02 19:51:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179204-20171102191856.patch</filename>
            <type>text/plain</type>
            <size>1853</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvTWFrZWZpbGUg
Yi9Tb3VyY2UvTWFrZWZpbGUKaW5kZXggZmExYTRhMzdhNDExNDBjMTNmYzEwMDY4YTQ0MTdlYWI3
YTdiM2VlNC4uYjllYmUxYmQyYzc5OWQ4NGUzNzdjMDNlZWNmYTVmOGM1MWI2NTdlMiAxMDA2NDQK
LS0tIGEvU291cmNlL01ha2VmaWxlCisrKyBiL1NvdXJjZS9NYWtlZmlsZQpAQCAtMSwyMyArMSwy
MCBAQAotTU9EVUxFUyA9IGJtYWxsb2MgV1RGIEphdmFTY3JpcHRDb3JlIFRoaXJkUGFydHkvQU5H
TEUgCitMSUJXRUJSVENfTU9EVUxFID0gCitXRUJJTlNQRUNUT1JVSV9NT0RVTEUgPQogCiBpZm5l
cSAoLCQoU0RLUk9PVCkpCiAJaWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lLCQoU0RLUk9PVCkp
KQotCQlNT0RVTEVTICs9IFRoaXJkUGFydHkvbGlid2VicnRjCisJCUxJQldFQlJUQ19NT0RVTEUg
PSBUaGlyZFBhcnR5L2xpYndlYnJ0YwogCWVuZGlmCiAJaWZuZXEgKCwkKGZpbmRzdHJpbmcgbWFj
b3N4LCQoU0RLUk9PVCkpKQotCQlNT0RVTEVTICs9IFRoaXJkUGFydHkvbGlid2VicnRjCisJCUxJ
QldFQlJUQ19NT0RVTEUgPSBUaGlyZFBhcnR5L2xpYndlYnJ0YworCQlXRUJJTlNQRUNUT1JVSV9N
T0RVTEUgPSBXZWJJbnNwZWN0b3JVSQogCWVuZGlmCitlbHNlCisJTElCV0VCUlRDX01PRFVMRSA9
IFRoaXJkUGFydHkvbGlid2VicnRjCisJV0VCSU5TUEVDVE9SVUlfTU9EVUxFID0gV2ViSW5zcGVj
dG9yVUkKIGVuZGlmCiAKLU1PRFVMRVMgKz0gV2ViQ29yZSAKLQotaWZuZXEgKCwkKFNES1JPT1Qp
KQotCWlmbmVxICgsJChmaW5kc3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkKLQkJTU9EVUxFUyAr
PSBXZWJJbnNwZWN0b3JVSQotCWVuZGlmCi1lbmRpZgotCi1NT0RVTEVTICs9IFdlYktpdExlZ2Fj
eSBXZWJLaXQKK01PRFVMRVMgPSBibWFsbG9jIFdURiBKYXZhU2NyaXB0Q29yZSBUaGlyZFBhcnR5
L0FOR0xFICQoTElCV0VCUlRDX01PRFVMRSkgV2ViQ29yZSAkKFdFQklOU1BFQ1RPUlVJX01PRFVM
RSkgV2ViS2l0TGVnYWN5IFdlYktpdAogCiBhbGw6CiAJQGZvciBkaXIgaW4gJChNT0RVTEVTKTsg
ZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9JCQ/OyBcCmRpZmYgLS1naXQgYS9D
aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNTExMDFmMzQxN2VlMDljYWI5NmJhNWU4ZDU3NDhk
MGIzNTgyMjYxNi4uMGVkMTZhNTFlMTA0MTdiMmRiNThiYTM0M2JiNGUyYjYyNmU5N2I1OSAxMDA2
NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMyw2ICszLDE2IEBACiAgICAg
ICAgIFJlZHVjZSBkdXBsaWNhdGlvbiBpbiB0aGUgdG9wbGV2ZWwgTWFrZWZpbGUKICAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTIwNAogCisgICAgICAg
IFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogU291cmNlL01ha2VmaWxlOgorICAg
ICAgICBUYWtlIHRocmVlLiBBbiBlbXB0eSBTREtST09UIHNob3VsZCBiZSBsaWtlIE1hYyAoYW5k
IGJ1aWxkIGFsbCB0aGUgdGhpbmdzKS4KKworMjAxNy0xMS0wMiAgVGltIEhvcnRvbiAgPHRpbW90
aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgZHVwbGljYXRpb24gaW4gdGhl
IHRvcGxldmVsIE1ha2VmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xNzkyMDQKKwogICAgICAgICAqIFNvdXJjZS9NYWtlZmlsZToKICAgICAgICAg
QWRkcmVzcyBzb21lIHBvc3QtbGFuZGluZyByZXZpZXcgY29tbWVudHMgdG8ga2VlcCB0aGUgb3Jk
ZXIgb2YgdGhlIE1PRFVMRVMgY29ycmVjdC4KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>