179175 2017-11-02 08:59:00 -0700 [MediaStream] audioTrack.label is always empty on macOS 2017-11-02 10:00:25 -0700 1 1 1 Unclassified WebKit WebRTC Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1367347 0 eric.carlson 2017-11-02 08:59:00 -0700 track.label is never set when audio is captured in the UI process. 1367348 1 webkit-bug-importer 2017-11-02 09:00:00 -0700 <rdar://problem/35315438> 1367352 2 325716 eric.carlson 2017-11-02 09:05:40 -0700 Created attachment 325716 Proposed patch. 1367380 3 325716 commit-queue 2017-11-02 10:00:24 -0700 Comment on attachment 325716 Proposed patch. Clearing flags on attachment: 325716 Committed r224338: <https://trac.webkit.org/changeset/224338> 1367381 4 commit-queue 2017-11-02 10:00:25 -0700 All reviewed patches have been landed. Closing bug. 325716 2017-11-02 09:05:40 -0700 2017-11-02 10:00:24 -0700 Proposed patch. audio_device_name_patch_2.txt text/plain 6811 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE3LTExLTAyICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbV0g YXVkaW9UcmFjay5sYWJlbCBpcyBhbHdheXMgZW1wdHkgb24gbWFjT1MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTE3NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzUzMTU0Mzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNlU2V0 dGluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6 bGFiZWwgY29uc3QpOiBOZXcuCisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU1lZGlhU291cmNl U2V0dGluZ3M6OnNldExhYmVsKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU1l ZGlhU291cmNlU2V0dGluZ3M6OmVuY29kZSBjb25zdCk6IEVuY29kZSBsYWJlbC4KKyAgICAgICAg KFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6ZGVjb2RlKTogRGVjb2RlIGxh YmVsLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWTWVkaWFDYXB0dXJl U291cmNlLm1tOgorICAgICAgICAoV2ViQ29yZTo6QVZNZWRpYUNhcHR1cmVTb3VyY2U6OmluaXRp YWxpemVTZXR0aW5ncyk6IFNldCBsYWJlbC4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJlU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv cmVBdWRpb0NhcHR1cmVTb3VyY2U6OnNldHRpbmdzIGNvbnN0KTogRGl0dG8uCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tb2NrL01vY2tSZWFsdGltZU1lZGlhU291cmNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1vY2tSZWFsdGltZU1lZGlhU291cmNlOjppbml0aWFsaXplU2V0dGluZ3MpOiBEaXR0 by4KKwogMjAxNy0xMC0zMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIG5hdmlnYXRvci5zZXJ2aWNlV29ya2VyIHNob3VsZCBhbHdheXMgcmV0dXJuIHRoZSBzYW1l IG9iamVjdApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRp bWVNZWRpYVNvdXJjZVNldHRpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzLmgJKHJldmlzaW9u IDIyNDI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1l TWVkaWFTb3VyY2VTZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC05Niw2ICs5Niw5IEBAIHB1 YmxpYzoKICAgICBjb25zdCBSZWFsdGltZU1lZGlhU291cmNlU3VwcG9ydGVkQ29uc3RyYWludHMm IHN1cHBvcnRlZENvbnN0cmFpbnRzKCkgY29uc3QgeyByZXR1cm4gbV9zdXBwb3J0ZWRDb25zdHJh aW50czsgfQogICAgIHZvaWQgc2V0U3VwcG9ydGVkQ29uc3RyYWludHMoY29uc3QgUmVhbHRpbWVN ZWRpYVNvdXJjZVN1cHBvcnRlZENvbnN0cmFpbnRzJiBzdXBwb3J0ZWRDb25zdHJhaW50cykgeyBt X3N1cHBvcnRlZENvbnN0cmFpbnRzID0gc3VwcG9ydGVkQ29uc3RyYWludHM7IH0KIAorICAgIGNv bnN0IEF0b21pY1N0cmluZyYgbGFiZWwoKSBjb25zdCB7IHJldHVybiBtX2xhYmVsOyB9CisgICAg dm9pZCBzZXRMYWJlbChjb25zdCBBdG9taWNTdHJpbmcmIGxhYmVsKSB7IG1fbGFiZWwgPSBsYWJl bDsgfQorCiAgICAgdGVtcGxhdGU8Y2xhc3MgRW5jb2Rlcj4gdm9pZCBlbmNvZGUoRW5jb2RlciYp IGNvbnN0OwogICAgIHRlbXBsYXRlPGNsYXNzIERlY29kZXI+IHN0YXRpYyBib29sIGRlY29kZShE ZWNvZGVyJiwgUmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzJik7CiAKQEAgLTExMiw2ICsxMTUs NyBAQCBwcml2YXRlOgogCiAgICAgQXRvbWljU3RyaW5nIG1fZGV2aWNlSWQ7CiAgICAgQXRvbWlj U3RyaW5nIG1fZ3JvdXBJZDsKKyAgICBBdG9taWNTdHJpbmcgbV9sYWJlbDsKIAogICAgIFJlYWx0 aW1lTWVkaWFTb3VyY2VTdXBwb3J0ZWRDb25zdHJhaW50cyBtX3N1cHBvcnRlZENvbnN0cmFpbnRz OwogfTsKQEAgLTEyOSw2ICsxMzMsNyBAQCB2b2lkIFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5n czo6ZW5jb2RlCiAgICAgICAgIDw8IG1fZWNob0NhbmNlbGxhdGlvbgogICAgICAgICA8PCBtX2Rl dmljZUlkCiAgICAgICAgIDw8IG1fZ3JvdXBJZAorICAgICAgICA8PCBtX2xhYmVsCiAgICAgICAg IDw8IG1fc3VwcG9ydGVkQ29uc3RyYWludHM7CiAgICAgZW5jb2Rlci5lbmNvZGVFbnVtKG1fZmFj aW5nTW9kZSk7CiB9CkBAIC0xNDYsNiArMTUxLDcgQEAgYm9vbCBSZWFsdGltZU1lZGlhU291cmNl U2V0dGluZ3M6OmRlY29kZQogICAgICAgICAmJiBkZWNvZGVyLmRlY29kZShzZXR0aW5ncy5tX2Vj aG9DYW5jZWxsYXRpb24pCiAgICAgICAgICYmIGRlY29kZXIuZGVjb2RlKHNldHRpbmdzLm1fZGV2 aWNlSWQpCiAgICAgICAgICYmIGRlY29kZXIuZGVjb2RlKHNldHRpbmdzLm1fZ3JvdXBJZCkKKyAg ICAgICAgJiYgZGVjb2Rlci5kZWNvZGUoc2V0dGluZ3MubV9sYWJlbCkKICAgICAgICAgJiYgZGVj b2Rlci5kZWNvZGUoc2V0dGluZ3MubV9zdXBwb3J0ZWRDb25zdHJhaW50cykKICAgICAgICAgJiYg ZGVjb2Rlci5kZWNvZGVFbnVtKHNldHRpbmdzLm1fZmFjaW5nTW9kZSk7CiB9CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZNZWRpYUNhcHR1cmVTb3VyY2Uu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFj L0FWTWVkaWFDYXB0dXJlU291cmNlLm1tCShyZXZpc2lvbiAyMjQyNTEpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZNZWRpYUNhcHR1cmVTb3VyY2UubW0JKHdv cmtpbmcgY29weSkKQEAgLTIxNCw2ICsyMTQsNyBAQCB2b2lkIEFWTWVkaWFDYXB0dXJlU291cmNl Ojppbml0aWFsaXplU2V0CiAgICAgICAgIG1fY3VycmVudFNldHRpbmdzLnNldFN1cHBvcnRlZENv bnN0cmFpbnRzKHN1cHBvcnRlZENvbnN0cmFpbnRzKCkpOwogCiAgICAgbV9jdXJyZW50U2V0dGlu Z3Muc2V0RGV2aWNlSWQoaWQoKSk7CisgICAgbV9jdXJyZW50U2V0dGluZ3Muc2V0TGFiZWwobmFt ZSgpKTsKICAgICB1cGRhdGVTZXR0aW5ncyhtX2N1cnJlbnRTZXR0aW5ncyk7CiB9CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJl U291cmNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9tYWMvQ29yZUF1ZGlvQ2FwdHVyZVNvdXJjZS5jcHAJKHJldmlzaW9uIDIyNDI1MSkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9Db3JlQXVkaW9DYXB0dXJl U291cmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzk0LDYgKzc5NCw3IEBAIGNvbnN0IFJlYWx0 aW1lTWVkaWFTb3VyY2VTZXR0aW5ncyYgQ29yZUEKICAgICAgICAgc2V0dGluZ3Muc2V0Vm9sdW1l KHZvbHVtZSgpKTsKICAgICAgICAgc2V0dGluZ3Muc2V0U2FtcGxlUmF0ZShzYW1wbGVSYXRlKCkp OwogICAgICAgICBzZXR0aW5ncy5zZXREZXZpY2VJZChpZCgpKTsKKyAgICAgICAgc2V0dGluZ3Mu c2V0TGFiZWwobmFtZSgpKTsKICAgICAgICAgc2V0dGluZ3Muc2V0RWNob0NhbmNlbGxhdGlvbihl Y2hvQ2FuY2VsbGF0aW9uKCkpOwogCiAgICAgICAgIFJlYWx0aW1lTWVkaWFTb3VyY2VTdXBwb3J0 ZWRDb25zdHJhaW50cyBzdXBwb3J0ZWRDb25zdHJhaW50czsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21vY2svTW9ja1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svTW9ja1JlYWx0aW1lTWVkaWFTb3VyY2UuY3Bw CShyZXZpc2lvbiAyMjQyNTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tS ZWFsdGltZU1lZGlhU291cmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE3LDYgKzExNyw3IEBA IHZvaWQgTW9ja1JlYWx0aW1lTWVkaWFTb3VyY2U6OmluaXRpYWxpemUKICAgICBpZiAobV9jdXJy ZW50U2V0dGluZ3MuZGV2aWNlSWQoKS5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9jdXJyZW50U2V0 dGluZ3Muc2V0U3VwcG9ydGVkQ29uc3RyYWludHMoc3VwcG9ydGVkQ29uc3RyYWludHMoKSk7CiAg ICAgICAgIG1fY3VycmVudFNldHRpbmdzLnNldERldmljZUlkKGlkKCkpOworICAgICAgICBtX2N1 cnJlbnRTZXR0aW5ncy5zZXRMYWJlbChuYW1lKCkpOwogICAgIH0KIAogICAgIHVwZGF0ZVNldHRp bmdzKG1fY3VycmVudFNldHRpbmdzKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjQzMzIpCisr KyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE3LTExLTAyICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisg ICAgICAgIFtNZWRpYVN0cmVhbV0gYXVkaW9UcmFjay5sYWJlbCBpcyBhbHdheXMgZW1wdHkgb24g bWFjT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTE3NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUzMTU0Mzg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1VzZXJN ZWRpYUNhcHR1cmVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlhQ2FwdHVy ZU1hbmFnZXI6OmNyZWF0ZUNhcHR1cmVTb3VyY2UpOiBQYXNzIHNldHRpbmdzLmxhYmVsIHRvIFNv dXJjZSBjb25zdHJ1Y3Rvci4KKwogMjAxNy0xMS0wMiAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGln YWxpYS5jb20+CiAKICAgICAgICAgQWRkIHJlZmVyZW5jZXMgdG8gYnVnIDE3OTE2NyBpbiBGSVhN RSBjb21tZW50cwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRp YUNhcHR1cmVNYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAyMjQyNTEpCisr KyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODEsMTQgKzE4MSwxMyBAQCBXZWJDb3JlOjpDYXB0dXJl U291cmNlT3JFcnJvciBVc2VyTWVkaWFDCiAgICAgICAgIHJldHVybiB7IH07CiAKICAgICB1aW50 NjRfdCBpZCA9IG5leHRTZXNzaW9uSUQoKTsKLSAgICBib29sIHN1Y2NlZWRlZDsKLQogICAgIFJl YWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5ncyBzZXR0aW5nczsKICAgICBTdHJpbmcgZXJyb3JNZXNz YWdlOworICAgIGJvb2wgc3VjY2VlZGVkOwogICAgIGlmICghbV9wcm9jZXNzLnNlbmRTeW5jKE1l c3NhZ2VzOjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlclByb3h5OjpDcmVhdGVNZWRpYVNvdXJjZUZv ckNhcHR1cmVEZXZpY2VXaXRoQ29uc3RyYWludHMoaWQsIGRldmljZUlELCBzb3VyY2VUeXBlLCAq Y29uc3RyYWludHMpLCBNZXNzYWdlczo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQcm94eTo6Q3Jl YXRlTWVkaWFTb3VyY2VGb3JDYXB0dXJlRGV2aWNlV2l0aENvbnN0cmFpbnRzOjpSZXBseShzdWNj ZWVkZWQsIGVycm9yTWVzc2FnZSwgc2V0dGluZ3MpLCAwKSkKICAgICAgICAgcmV0dXJuIFdURk1v dmUoZXJyb3JNZXNzYWdlKTsKIAotICAgIGF1dG8gc291cmNlID0gYWRvcHRSZWYoKm5ldyBTb3Vy Y2UoU3RyaW5nOjpudW1iZXIoaWQpLCBzb3VyY2VUeXBlLCBlbXB0eVN0cmluZygpLCBpZCwgKnRo aXMpKTsKKyAgICBhdXRvIHNvdXJjZSA9IGFkb3B0UmVmKCpuZXcgU291cmNlKFN0cmluZzo6bnVt YmVyKGlkKSwgc291cmNlVHlwZSwgc2V0dGluZ3MubGFiZWwoKSwgaWQsICp0aGlzKSk7CiAgICAg c291cmNlLT5zZXRTZXR0aW5ncyhXVEZNb3ZlKHNldHRpbmdzKSk7CiAgICAgbV9zb3VyY2VzLnNl dChpZCwgc291cmNlLmNvcHlSZWYoKSk7CiAgICAgcmV0dXJuIFdlYkNvcmU6OkNhcHR1cmVTb3Vy Y2VPckVycm9yKFdURk1vdmUoc291cmNlKSk7Cg==