179172 2017-11-02 08:22:32 -0700 Implement FrameView::did[Start|End|Update]Scroll for subframes 2019-07-10 09:10:00 -0700 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=179125 https://bugs.webkit.org/show_bug.cgi?id=179167 P2 Normal --- 149264 1 fred.wang webkit-unassigned dbates koivisto simon.fraser oldest_to_newest 1367335 0 fred.wang 2017-11-02 08:22:32 -0700 While analyzing the difference between overflow node and subframes, I noticed that frame views don't do anything special for FrameView::didStartScroll, FrameView::didEndScroll and FrameView::didUpdateScroll, contrary to overflow layers. I am not sure whether it is actually needed for subframes? Moreoever for overflow node, it seems that it is only used when ENABLE_TOUCH_EVENTS is enabled which I can not try without the private iOS SDK (bug 179167). 1367336 1 325715 fred.wang 2017-11-02 08:24:16 -0700 Created attachment 325715 Patch (not tested) 1551634 2 fred.wang 2019-07-10 03:51:15 -0700 @Antti: Do you think this is actually something we need? 1551678 3 simon.fraser 2019-07-10 09:10:00 -0700 I don't think we need this patch. 325715 2017-11-02 08:24:16 -0700 2017-11-02 08:24:16 -0700 Patch (not tested) 0001-Bug-179172-Implement-FrameView-did-Start-End-Update-.patch text/plain 2457 fred.wang RnJvbSAzODBkODdiNzlkZjVhMDlmNjQ4ZGM2YTNiNmY4YWY0NTBkNTQ0ODdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmVkZXJpYyBXYW5nIDxmd2FuZ0BpZ2FsaWEuY29tPgpEYXRl OiBUaHUsIDIgTm92IDIwMTcgMTY6MjI6NTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBCdWcgMTc5 MTcyIC0gSW1wbGVtZW50IEZyYW1lVmlldzo6ZGlkW1N0YXJ0fEVuZHxVcGRhdGVdU2Nyb2xsCiBm b3Igc3ViZnJhbWVzCgotLS0KIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCB8IDMz ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuaCAgIHwgIDcgKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDM5MjMzMzcxNTYuLjEzYTRiNTJm ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTQ3Niw2ICs0NzYsMzkgQEAgdm9p ZCBGcmFtZVZpZXc6OnNldE1hcmdpbkhlaWdodChMYXlvdXRVbml0IGgpCiAgICAgbV9tYXJnaW5z LnNldEhlaWdodChoKTsKIH0KIAorI2lmIFBMQVRGT1JNKElPUykKK2Jvb2wgRnJhbWVWaWV3Ojpz aG91bGRDb21tdW5pY2F0ZVNjcm9sbEV2ZW50c1RvQ2hyb21lQ2xpZW50KCkKK3sKKyAgICBpZiAo IWZyYW1lKCkuaXNNYWluRnJhbWUoKSkgeworICAgICAgICBpZiAoYXV0byogcGFnZSA9IGZyYW1l KCkucGFnZSgpKSB7CisgICAgICAgICAgICBpZiAoYXV0byogc2Nyb2xsaW5nQ29vcmRpbmF0b3Ig PSBwYWdlLT5zY3JvbGxpbmdDb29yZGluYXRvcigpKQorICAgICAgICAgICAgICAgIHJldHVybiBz Y3JvbGxpbmdDb29yZGluYXRvci0+Y29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFtZVZpZXcoKnRo aXMpOworICAgICAgICB9CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIEZy YW1lVmlldzo6ZGlkU3RhcnRTY3JvbGwoKQoreworICAgIGlmIChzaG91bGRDb21tdW5pY2F0ZVNj cm9sbEV2ZW50c1RvQ2hyb21lQ2xpZW50KCkpCisgICAgICAgIGZyYW1lKCkucGFnZSgpLT5jaHJv bWUoKS5jbGllbnQoKS5kaWRTdGFydE92ZXJmbG93U2Nyb2xsKCk7Cit9CisKK3ZvaWQgRnJhbWVW aWV3OjpkaWRFbmRTY3JvbGwoKQoreworICAgIGlmIChzaG91bGRDb21tdW5pY2F0ZVNjcm9sbEV2 ZW50c1RvQ2hyb21lQ2xpZW50KCkpCisgICAgICAgIGZyYW1lKCkucGFnZSgpLT5jaHJvbWUoKS5j bGllbnQoKS5kaWRFbmRPdmVyZmxvd1Njcm9sbCgpOworfQorCit2b2lkIEZyYW1lVmlldzo6ZGlk VXBkYXRlU2Nyb2xsKCkKK3sKKyAgICAvLyBTZW5kIHRoaXMgbm90aWZpY2F0aW9uIHdoZW4gd2Ug c2Nyb2xsLCBzaW5jZSB0aGlzIGlzIGhvdyB3ZSBrZWVwIHNlbGVjdGlvbiB1cGRhdGVkLgorICAg IGlmIChzaG91bGRDb21tdW5pY2F0ZVNjcm9sbEV2ZW50c1RvQ2hyb21lQ2xpZW50KCkpCisgICAg ICAgIGZyYW1lKCkucGFnZSgpLT5jaHJvbWUoKS5jbGllbnQoKS5kaWRMYXlvdXQoQ2hyb21lQ2xp ZW50OjpTY3JvbGwpOworfQorI2VuZGlmCisKIEZyYW1lRmxhdHRlbmluZyBGcmFtZVZpZXc6OmVm ZmVjdGl2ZUZyYW1lRmxhdHRlbmluZygpIGNvbnN0CiB7CiAjaWYgUExBVEZPUk0oSU9TKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggZWVhZWYyYTc5Yy4uNGNmNDk1Mjk5ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5oCkBAIC02MjgsNiArNjI4LDEzIEBAIHB1YmxpYzoKIAogICAgIFdFQkNP UkVfRVhQT1JUIEZyYW1lRmxhdHRlbmluZyBlZmZlY3RpdmVGcmFtZUZsYXR0ZW5pbmcoKSBjb25z dDsKIAorI2lmIFBMQVRGT1JNKElPUykKKyAgICBib29sIHNob3VsZENvbW11bmljYXRlU2Nyb2xs RXZlbnRzVG9DaHJvbWVDbGllbnQoKTsKKyAgICB2b2lkIGRpZFN0YXJ0U2Nyb2xsKCkgZmluYWw7 CisgICAgdm9pZCBkaWRFbmRTY3JvbGwoKSBmaW5hbDsKKyAgICB2b2lkIGRpZFVwZGF0ZVNjcm9s bCgpIGZpbmFsOworI2VuZGlmCisKIHByb3RlY3RlZDoKICAgICBib29sIHNjcm9sbENvbnRlbnRz RmFzdFBhdGgoY29uc3QgSW50U2l6ZSYgc2Nyb2xsRGVsdGEsIGNvbnN0IEludFJlY3QmIHJlY3RU b1Njcm9sbCwgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QpIGZpbmFsOwogICAgIHZvaWQgc2Nyb2xs Q29udGVudHNTbG93UGF0aChjb25zdCBJbnRSZWN0JiB1cGRhdGVSZWN0KSBmaW5hbDsKLS0gCjIu MTQuMQoK