179169 2017-11-02 06:46:03 -0700 [WPE][JHBuild] Update WPEBackend and WPEBackend-mesa 2017-11-15 12:07:24 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez aperez bugs-noreply cgarcia clopez mcatanzaro webkit-bug-importer zan oldest_to_newest 1367321 0 clopez 2017-11-02 06:46:03 -0700 Update WPEBackend and WPEBackend-mesa to last master. WPEBackend (master) $ git log --oneline 5e2a29d2ccc637f7122ba72c1d62ef669b42f05c..master 3013faa Properly find EGL and pass any flag defined on the EGL pkgconfig 0272534 Merge pull request #5 from JPEWdev/license 3cd82aa Add license file baa960b Merge pull request #2 from blino/backend-load-error afe28ad wpe_view_backend_create: fail early if backend can not be loaded 4aff0ea Merge pull request #1 from vertexodessa/cmake28 98e3006 CMake version 2.8 is enough for the build WPEBackend-mesa (master) $ git log --oneline 0286aed84a09120de16c3ab08bdf83c91d4a1754..master ce2a0ad Merge pull request #7 from clopez/xdg-shell-protocol-match 1a91ded Merge pull request #5 from clopez/FindWaylandEGL 26a019a Only try to create the xdg-surface once. c7feee8 [WPEBackend-mesa] Correctly find libxkbcommon 07e5180 Find EGL and set definitions. a0519c6 Add missing FindWaylandEGL cmake file. 1367325 1 325714 clopez 2017-11-02 07:00:53 -0700 Created attachment 325714 Patch 1367329 2 325714 mcatanzaro 2017-11-02 07:40:50 -0700 Comment on attachment 325714 Patch I thought about switching these to use git, but I think the value of being able to blame issue to particular WebKit commits outweighs the convenience of not having to update the hashes here, so OK. Thanks very much for working on this. 1367331 3 clopez 2017-11-02 07:46:25 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 325714 [details] > Patch > > I thought about switching these to use git, but I think the value of being > able to blame issue to particular WebKit commits outweighs the convenience > of not having to update the hashes here, so OK. > I guess you meant here "switching these to _not_ use git" ? (Otherwise I don't understand what you mean) In any case, either when using tarballs or when using git something has always to be updated on the moduleset (either be the hashsum or the git hashid). I don't think we should be using vague references like pointing them always to "master", as that will risk introducing random breakage on the webkit build. I think is a good practice to mandate that each update to this modules should be tested by at least one webkit developer. The best way of doing that is like now, manually updating the git hashids in a webkit commit that needs to be reviewed. > Thanks very much for working on this. Thanks you for the review :) 1367332 4 325714 clopez 2017-11-02 07:48:12 -0700 Comment on attachment 325714 Patch Clearing flags on attachment: 325714 Committed r224331: <https://trac.webkit.org/changeset/224331> 1367333 5 mcatanzaro 2017-11-02 07:58:23 -0700 (In reply to Carlos Alberto Lopez Perez from comment #3) > I guess you meant here "switching these to _not_ use git" ? (Otherwise I > don't understand what you mean) No, I just read the commit too quickly. Anyway, I agree with your reasoning! 1367342 6 mcatanzaro 2017-11-02 08:54:19 -0700 Forgot to close it? 325714 2017-11-02 07:00:53 -0700 2017-11-02 07:48:12 -0700 Patch bug-179169-20171102150052.patch text/plain 1538 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MzI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDk1MWMxOGM5ODAzNDM5MjUxNWJhNWM2MTFlMDkwYjM3 Njk4MDY2Mi4uY2ZjMTVhN2VkNjY2ZTliMjVjOWJmZGZkOTgzYWJiNjU3N2E5MGVkMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTExLTAyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0pIQnVpbGRdIFVwZGF0ZSBXUEVCYWNrZW5kIGFuZCBX UEVCYWNrZW5kLW1lc2EKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3OTE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVwZGF0ZSBXUEVCYWNrZW5kIGFuZCBXUEVCYWNrZW5kLW1lc2EgdG8gbGFzdCBtYXN0 ZXIgYXMgb2YgdG9kYXkuCisKKyAgICAgICAgKiB3cGUvamhidWlsZC5tb2R1bGVzOgorCiAyMDE3 LTExLTAxICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBs ZW1lbnQgV0tGdWxsc2NyZWVuV2luZG93Q29udHJvbGxlciBmb3IgaU9TLgpkaWZmIC0tZ2l0IGEv VG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKaW5k ZXggZmRkNmU5MTYwODliYjNiNzA3YjA0ZTU5ZjEwOTBmYjE2MGQ5NjkzNi4uMzU3NTgyYzhhYzg0 YTkxNTVkNjI2ZmQ4ZDFjODdhZDA5Y2FhOTU5MCAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL2poYnVp bGQubW9kdWxlcworKysgYi9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzCkBAIC0xNzEsNyArMTcx LDcgQEAKIAogICA8Y21ha2UgaWQ9IndwZSI+CiAgICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29t IiBtb2R1bGU9IldlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BFQmFja2VuZC5naXQiCi0gICAgICAg ICAgICB0YWc9IjVlMmEyOWQyY2NjNjM3ZjcxMjJiYTcyYzFkNjJlZjY2OWI0MmYwNWMiIC8+Cisg ICAgICAgICAgICB0YWc9IjMwMTNmYWFlYmFiNDJlN2VmNzQ5N2IzODUwYTI5MDI5NzhlYjNkNmYi IC8+CiAgIDwvY21ha2U+CiAKICAgPGNtYWtlIGlkPSJ3cGUtbWVzYSI+CkBAIC0xODIsNyArMTgy LDcgQEAKICAgICAgIDxkZXAgcGFja2FnZT0ieGtiY29tbW9uIiAvPgogICAgIDwvZGVwZW5kZW5j aWVzPgogICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxlPSJXZWJQbGF0Zm9ybUZv ckVtYmVkZGVkL1dQRUJhY2tlbmQtbWVzYS5naXQiCi0gICAgICAgICAgICB0YWc9IjAyODZhZWQ4 NGEwOTEyMGRlMTZjM2FiMDhiZGY4M2M5MWQ0YTE3NTQiIC8+CisgICAgICAgICAgICB0YWc9ImNl MmEwYWQ5OGQxNzQ2ZDViMGZhNzQzMTIxYTZlYmIxNDhhYjkyYzEiIC8+CiAgIDwvY21ha2U+CiAK ICAgPGF1dG90b29scyBpZD0ibGliZ3BnLWVycm9yIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgo=