179148 2017-11-01 19:13:59 -0700 [Win] Fix compile errors in MediaPlayerPrivateAVFoundationCF.cpp 2017-11-15 12:24:54 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan commit-queue rniwa webkit-bug-importer oldest_to_newest 1367161 0 pvollan 2017-11-01 19:13:59 -0700 MediaPlayerPrivateAVFoundationCF.cpp(1116): error C2664: 'void WebCore::MediaPlayerPrivateAVFoundation::setResolvedURL(WebCore::URL &&)': cannot convert argument 1 from 'WTF::RetainPtr<CFURLRef>' to 'WebCore::URL &&' 1367163 1 325664 pvollan 2017-11-01 19:22:57 -0700 Created attachment 325664 Patch 1367166 2 325664 pvollan 2017-11-01 19:29:36 -0700 Comment on attachment 325664 Patch Thanks for reviewing! 1367174 3 325664 commit-queue 2017-11-01 20:00:11 -0700 Comment on attachment 325664 Patch Clearing flags on attachment: 325664 Committed r224311: <https://trac.webkit.org/changeset/224311> 1367175 4 commit-queue 2017-11-01 20:00:13 -0700 All reviewed patches have been landed. Closing bug. 1372139 5 webkit-bug-importer 2017-11-15 12:24:54 -0800 <rdar://problem/35567477> 325664 2017-11-01 19:22:57 -0700 2017-11-01 20:00:11 -0700 Patch bug-179148-20171102032258.patch text/plain 1847 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTAxICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBGaXggY29tcGls ZSBlcnJvcnMgaW4gTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkxNDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9jZi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRjo6cmVz b2x2ZWRVUkxDaGFuZ2VkKToKKwogMjAxNy0xMS0wMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9y dG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGp1c3QgUmVuZGVyRWxlbWVudCBzaXplIGFzc2Vy dGlvbiB0byBiZSBtb3JlIGFjY3VyYXRlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0Yu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9jZi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHJldmlzaW9u IDIyNDMwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9jZi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTExNSw3ICsxMTUsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkZXN0cm95SW1hZ2VHZW5lcmF0 b3IoKTsKICAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gY3JlYXRlSW1hZ2VGb3JUaW1lSW5SZWN0 KGNvbnN0IE1lZGlhVGltZSYsIGNvbnN0IEZsb2F0UmVjdCYpOwogCi0gICAgdm9pZCBjcmVhdGVB c3NldEZvclVSTChjb25zdCBTdHJpbmcmIHVybCwgYm9vbCBpbmhlcml0VVJJKTsKKyAgICB2b2lk IGNyZWF0ZUFzc2V0Rm9yVVJMKGNvbnN0IFVSTCYsIGJvb2wgaW5oZXJpdFVSSSk7CiAgICAgdm9p ZCBzZXRBc3NldChBVkNGVVJMQXNzZXRSZWYpOwogICAgIAogICAgIHZvaWQgY3JlYXRlUGxheWVy KElEaXJlY3QzRERldmljZTkqKTsKQEAgLTExMTMsNyArMTExMyw3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0Y6OnMKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uQ0Y6OnJlc29sdmVkVVJMQ2hhbmdlZCgpCiB7CiAgICAgaWYgKG1fYXZmV3JhcHBlciAm JiBtX2F2ZldyYXBwZXItPmF2QXNzZXQoKSkKLSAgICAgICAgc2V0UmVzb2x2ZWRVUkwoYWRvcHRD RihBVkNGQXNzZXRDb3B5UmVzb2x2ZWRVUkwobV9hdmZXcmFwcGVyLT5hdkFzc2V0KCkpKSk7Cisg ICAgICAgIHNldFJlc29sdmVkVVJMKFVSTChhZG9wdENGKEFWQ0ZBc3NldENvcHlSZXNvbHZlZFVS TChtX2F2ZldyYXBwZXItPmF2QXNzZXQoKSkpLmdldCgpKSk7CiAgICAgZWxzZQogICAgICAgICBz ZXRSZXNvbHZlZFVSTCh7IH0pOwogfQo=