179141 2017-11-01 15:53:10 -0700 Remove unused Element::alwaysCreateUserAgentShadowRoot() 2017-11-15 12:27:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164206 InRadar P2 Normal --- 1 dbates dbates cdumez darin rniwa webkit-bug-importer oldest_to_newest 1367089 0 dbates 2017-11-01 15:53:10 -0700 In changeset r208135, <http://trac.webkit.org/changeset/208135> (bug #164206), Element::createShadowRoot() was removed. And Element::createShadowRoot() was the only caller of Element::alwaysCreateUserAgentShadowRoot(). We should remove Element::alwaysCreateUserAgentShadowRoot(). 1367091 1 325643 dbates 2017-11-01 15:55:26 -0700 Created attachment 325643 Patch 1367109 2 325643 dbates 2017-11-01 16:32:18 -0700 Comment on attachment 325643 Patch Clearing flags on attachment: 325643 Committed r224307: <https://trac.webkit.org/changeset/224307> 1367110 3 dbates 2017-11-01 16:32:20 -0700 All reviewed patches have been landed. Closing bug. 1372152 4 webkit-bug-importer 2017-11-15 12:27:16 -0800 <rdar://problem/35567570> 325643 2017-11-01 15:55:26 -0700 2017-11-01 16:32:18 -0700 Patch bug-179141-20171101155526.patch text/plain 3684 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0Mjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM0ZTM3NjFlODM2MTZm NmE3ZDRlMTAxZjEyNDYzMTY5NjE1ODRhNi4uMjNkNTFkNTE3NTVkZjBiZDRjMzMwMjM2YjUwM2E2 ZWEzOTBkMGQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE3LTExLTAxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgdW51c2VkIEVs ZW1lbnQ6OmFsd2F5c0NyZWF0ZVVzZXJBZ2VudFNoYWRvd1Jvb3QoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MTQxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gY2hhbmdlc2V0IHIyMDgxMzUgRWxl bWVudDo6Y3JlYXRlU2hhZG93Um9vdCgpIHdhcyByZW1vdmVkLiBBbmQgRWxlbWVudDo6Y3JlYXRl U2hhZG93Um9vdCgpCisgICAgICAgIHdhcyB0aGUgb25seSBjYWxsZXIgb2YgRWxlbWVudDo6YWx3 YXlzQ3JlYXRlVXNlckFnZW50U2hhZG93Um9vdCgpLiBXZSBzaG91bGQgcmVtb3ZlCisgICAgICAg IEVsZW1lbnQ6OmFsd2F5c0NyZWF0ZVVzZXJBZ2VudFNoYWRvd1Jvb3QoKSBhcyBpdCBpcyB1bnVz ZWQuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVu dDo6ZGlkQWRkVXNlckFnZW50U2hhZG93Um9vdCk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50 OjphbHdheXNDcmVhdGVVc2VyQWdlbnRTaGFkb3dSb290IGNvbnN0KTogRGVsZXRlZC4KKyAgICAg ICAgKiBodG1sL0hUTUxCdXR0b25FbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNv bnRyb2xFbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisKKzIw MTctMTEtMDEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAgICAgICAgIFhN TEh0dHBSZXF1ZXN0IHNob3VsZCBub3Qgc25pZmYgY29udGVudCBlbmNvZGluZwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1NTk3CiAgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDkxMjYyND4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IGIwNmYxOWJlZmQ2 ZTRkZjg5ZGVjYjcwYzgyYWRlY2NjMjdiOGNhY2EuLjg3NDI3ZmIzMmExZDRkODM4N2NhMDZmMmQ5 M2Y5NjMxNTEyYWEwMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaApAQCAtNTgwLDcgKzU4MCw2IEBAIHBy aXZhdGU6CiAgICAgYm9vbCBpc1VzZXJBY3Rpb25FbGVtZW50SG92ZXJlZCgpIGNvbnN0OwogCiAg ICAgdmlydHVhbCB2b2lkIGRpZEFkZFVzZXJBZ2VudFNoYWRvd1Jvb3QoU2hhZG93Um9vdCopIHsg fQotICAgIHZpcnR1YWwgYm9vbCBhbHdheXNDcmVhdGVVc2VyQWdlbnRTaGFkb3dSb290KCkgY29u c3QgeyByZXR1cm4gZmFsc2U7IH0KIAogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhlIG5lZWQgZm9y IEF0dHIgdG8gY2FsbCB3aWxsTW9kaWZ5QXR0cmlidXRlL2RpZE1vZGlmeUF0dHJpYnV0ZS4KICAg ICBmcmllbmQgY2xhc3MgQXR0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEJ1dHRvbkVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQu aAppbmRleCBmYjE2NjFiZjcwYjQwZWJmMzJmZjMwZjJlMDQyM2UxNDlkZTg1NTQ4Li4yZWM4YTRl OTZkNjQyMTM3ZWRlMTJkZDM1NWIzYmI5MTcxNGFlZmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQnV0dG9uRWxlbWVudC5oCkBAIC01MCw5ICs1MCw2IEBAIHByaXZhdGU6CiAKICAgICBSZW5k ZXJQdHI8UmVuZGVyRWxlbWVudD4gY3JlYXRlRWxlbWVudFJlbmRlcmVyKFJlbmRlclN0eWxlJiYs IGNvbnN0IFJlbmRlclRyZWVQb3NpdGlvbiYpIGZpbmFsOwogCi0gICAgLy8gSFRNTEZvcm1Db250 cm9sRWxlbWVudCBhbHdheXMgY3JlYXRlcyBvbmUsIGJ1dCBidXR0b25zIGRvbid0IG5lZWQgaXQu Ci0gICAgYm9vbCBhbHdheXNDcmVhdGVVc2VyQWdlbnRTaGFkb3dSb290KCkgY29uc3QgZmluYWwg eyByZXR1cm4gZmFsc2U7IH0KLQogICAgIHZvaWQgcGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlm aWVkTmFtZSYsIGNvbnN0IEF0b21pY1N0cmluZyYpIGZpbmFsOwogICAgIGJvb2wgaXNQcmVzZW50 YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYpIGNvbnN0IGZpbmFsOwogICAgIHZv aWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCYpIGZpbmFsOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRleCA2ZmIxYjE1MjdkNzMwOTY4MDk0NmQw MDJkYWY2M2Q4YWEyODlmNWVjLi4zYzI4ZDI3NTE5OGJkZTYzODllYWNlODMyOWJkYmRiNjI2NWM4 ODllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1l bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaApA QCAtMTY2LDcgKzE2Niw2IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtYXRjaGVzSW52YWxpZFBzZXVk b0NsYXNzKCkgY29uc3Qgb3ZlcnJpZGU7CiAKICAgICBib29sIGlzRm9ybUNvbnRyb2xFbGVtZW50 KCkgY29uc3QgZmluYWwgeyByZXR1cm4gdHJ1ZTsgfQotICAgIGJvb2wgYWx3YXlzQ3JlYXRlVXNl ckFnZW50U2hhZG93Um9vdCgpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KIAogICAg IGludCB0YWJJbmRleCgpIGNvbnN0IGZpbmFsOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oCmluZGV4IDc2ZmVhYmQwN2IyYTQ3MmVmYmFkNGViYzczNWE1ZGM4M2UxMzVjMzgu LjYyZWRiYzI3YWVmMzY5NWY5M2MwYzBiODU3MDBkOWExMzFmNWZiMmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC01ODcsOCArNTg3LDYgQEAgcHJvdGVjdGVkOgog cHJpdmF0ZToKICAgICB2b2lkIGNyZWF0ZU1lZGlhUGxheWVyKCk7CiAKLSAgICBib29sIGFsd2F5 c0NyZWF0ZVVzZXJBZ2VudFNoYWRvd1Jvb3QoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVl OyB9Ci0KICAgICBib29sIHN1cHBvcnRzRm9jdXMoKSBjb25zdCBvdmVycmlkZTsKICAgICBib29s IGlzTW91c2VGb2N1c2FibGUoKSBjb25zdCBvdmVycmlkZTsKICAgICBib29sIHJlbmRlcmVySXNO ZWVkZWQoY29uc3QgUmVuZGVyU3R5bGUmKSBvdmVycmlkZTsK