179103 2017-10-31 23:11:26 -0700 innerText->renderBox() can be null in HTMLTextFormControlElement::setSelectionRange 2017-11-15 12:29:17 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez commit-queue koivisto webkit-bug-importer wenson_hsieh oldest_to_newest 1366771 0 rniwa 2017-10-31 23:11:26 -0700 We're missing a null check. <rdar://problem/35278949> 1366774 1 325546 rniwa 2017-10-31 23:13:54 -0700 Created attachment 325546 Fixes the bug 1367053 2 325546 commit-queue 2017-11-01 14:26:36 -0700 Comment on attachment 325546 Fixes the bug Clearing flags on attachment: 325546 Committed r224296: <https://trac.webkit.org/changeset/224296> 1367054 3 commit-queue 2017-11-01 14:26:38 -0700 All reviewed patches have been landed. Closing bug. 1372159 4 webkit-bug-importer 2017-11-15 12:29:17 -0800 <rdar://problem/35567635> 325546 2017-10-31 23:13:54 -0700 2017-11-01 14:26:36 -0700 Fixes the bug bug-179103-20171031231352.patch text/plain 2247 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDI3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTMxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlubmVyVGV4dC0+cmVuZGVyQm94 KCkgY2FuIGJlIG51bGwgaW4gSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNldFNlbGVjdGlv blJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzkxMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBhIG1pc3NpbmcgbnVsbCBjaGVjay4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5LCBubyBu ZXcgdGVzdHMgc2luY2Ugd2UgZG9uJ3QgaGF2ZSBhIHdvcmtpbmcgcmVwcm9kdWN0aW9uIGZvciB0 cnVuayBjb2RlLgorCisgICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6c2V0U2Vs ZWN0aW9uUmFuZ2UpOiBBZGRlZCBhIG51bGwgY2hlY2suCisKIDIwMTctMTAtMzEgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICB1cGRhdGVNYXNr ZWRBbmNlc3RvclNob3VsZElzb2xhdGVCbGVuZGluZygpIHNob3VsZCBjaGVjayB0aGUgTnVsbGFi aWxpdHkgb2YgdGhlIGNvbXB1dGVkU3R5bGUoKSBvZiB0aGUgZWxlbWVudCdzIGFuY2VzdG9ycwpJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxl bWVudC5jcHAJKHJldmlzaW9uIDIyNDE1NykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRl eHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTMsNyArMjkzLDcg QEAgdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6c2V0U2VsZQogICAgIGF1dG8gaW5u ZXJUZXh0ID0gaW5uZXJUZXh0RWxlbWVudCgpOwogICAgIGJvb2wgaGFzRm9jdXMgPSBkb2N1bWVu dCgpLmZvY3VzZWRFbGVtZW50KCkgPT0gdGhpczsKICAgICBpZiAoIWhhc0ZvY3VzICYmIGlubmVy VGV4dCkgewotICAgICAgICAvLyBGSVhNRTogUmVtb3ZpbmcgdGhpcyBzeW5jaHJvbm91cyBsYXlv dXQgcmVxdWlyZXMgZml4aW5nIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjg3OTc+CisgICAgICAg IC8vIEZJWE1FOiBSZW1vdmluZyB0aGlzIHN5bmNocm9ub3VzIGxheW91dCByZXF1aXJlcyBmaXhp bmcgc2V0U2VsZWN0aW9uV2l0aG91dFVwZGF0aW5nQXBwZWFyYW5jZSBub3QgbmVlZGluZyB1cC10 by1kYXRlIHN0eWxlLgogICAgICAgICBkb2N1bWVudCgpLnVwZGF0ZUxheW91dElnbm9yZVBlbmRp bmdTdHlsZXNoZWV0cygpOwogCiAgICAgICAgIC8vIERvdWJsZS1jaGVjayB0aGUgc3RhdGUgb2Yg aW5uZXJUZXh0RWxlbWVudCBhZnRlciB0aGUgbGF5b3V0LgpAQCAtMzAxLDcgKzMwMSw3IEBAIHZv aWQgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNldFNlbGUKICAgICAgICAgYXV0byogcmVu ZGVyZXJUZXh0Q29udHJvbCA9IHJlbmRlcmVyKCk7CiAKICAgICAgICAgaWYgKGlubmVyVGV4dCAm JiByZW5kZXJlclRleHRDb250cm9sKSB7Ci0gICAgICAgICAgICBpZiAocmVuZGVyZXJUZXh0Q29u dHJvbC0+c3R5bGUoKS52aXNpYmlsaXR5KCkgPT0gSElEREVOIHx8ICFpbm5lclRleHQtPnJlbmRl ckJveCgpLT5oZWlnaHQoKSkgeworICAgICAgICAgICAgaWYgKHJlbmRlcmVyVGV4dENvbnRyb2wt PnN0eWxlKCkudmlzaWJpbGl0eSgpID09IEhJRERFTiB8fCAhaW5uZXJUZXh0LT5yZW5kZXJCb3go KSB8fCAhaW5uZXJUZXh0LT5yZW5kZXJCb3goKS0+aGVpZ2h0KCkpIHsKICAgICAgICAgICAgICAg ICBjYWNoZVNlbGVjdGlvbihzdGFydCwgZW5kLCBkaXJlY3Rpb24pOwogICAgICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgICAgIH0K