179096 2017-10-31 17:55:19 -0700 transferFromImageBitmap should update canvas dimensions 2017-11-01 11:44:30 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino buildbot cdumez dino esprehn+autocc gyuyoung.kim sam webkit-bug-importer oldest_to_newest 1366709 0 dino 2017-10-31 17:55:19 -0700 When transferFromImageBitmap is called, the dimensions of the HTMLCanvasElement should be updated. 1366710 1 webkit-bug-importer 2017-10-31 17:55:54 -0700 <rdar://problem/35285218> 1366711 2 325530 dino 2017-10-31 17:59:25 -0700 Created attachment 325530 Patch 1366739 3 325530 sam 2017-10-31 19:06:02 -0700 Comment on attachment 325530 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325530&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:982 > m_imageBuffer = WTFMove(buffer); > } > > + if (m_imageBuffer && m_size != m_imageBuffer->internalSize()) > + m_size = m_imageBuffer->internalSize(); Why is this function const? 1366955 4 dino 2017-11-01 11:44:30 -0700 Committed r224283: <https://trac.webkit.org/changeset/224283> 325530 2017-10-31 17:59:25 -0700 2017-10-31 19:06:02 -0700 Patch bug-179096-20171101115922.patch text/plain 4278 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEzZWU2Zjg2OThkY2U2 OWMzNWVjYTgwMWNhNDJiYzdjMWU5YjMxNy4uYWVmNjM3OGYyNmM2NTRlOTQ0NzJhNmJmMzc1MjRj YjUyYzJiNTg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE3LTEwLTMxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICB0cmFuc2ZlckZyb21JbWFnZUJp dG1hcCBzaG91bGQgdXBkYXRlIGNhbnZhcyBkaW1lbnNpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwOTYKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM1Mjg1MjE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gdHJhbnNmZXJGcm9tSW1hZ2VCaXRtYXAgaXMgY2FsbGVkLCB0aGUgZGltZW5z aW9ucyBvZiB0aGUgSFRNTENhbnZhc0VsZW1lbnQKKyAgICAgICAgc2hvdWxkIGJlIHVwZGF0ZWQg dG8gcmVmbGVjdCB0aGUgc2l6ZSBvZiB0aGUgcGFzc2VkIEltYWdlQml0bWFwLgorCisgICAgICAg IFVwZGF0ZSBhbiBleGlzdGluZyBXUFQgcmVzdWx0LgorCisgICAgICAgICogaHRtbC9IVE1MQ2Fu dmFzRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6c2V0 SW1hZ2VCdWZmZXIgY29uc3QpOiBVcGRhdGUgdGhlCisgICAgICAgIHNpemUgb2YgdGhlIGVsZW1l bnQgYmFzZWQgb24gdGhlIGluY29taW5nIGJ1ZmZlci4KKyAgICAgICAgKiBodG1sL0hUTUxDYW52 YXNFbGVtZW50Lmg6IE1hcmsgbV9zaXplIGFzIG11dGFibGUgc28gd2UgY2FuCisgICAgICAgIGNh bGwgaXQgZnJvbSB0aGUgY29uc3QgZnVuY3Rpb24gc2V0SW1hZ2VCdWZmZXIuCisKKzIwMTctMTAt MzEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCiAgICAgICAgIEFjY2VwdCBTZXR0 aW5ncyBvYmplY3QgaW4gSW1hZ2VCaXRtYXBSZW5kZXJpbmdDb250ZXh0IGNvbnN0cnVjdG9yIGFu ZCBnZXRDb250ZXh0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzkwNzUKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1Mjc5OTY1PgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCA3OGE0ZmVmZWEyMzIwODVhNjA3 YzhjNmIxYzg1ZDEyYjM1MzI0ZjMxLi4yNmFiNDU4MjVlY2I5ODlmMjAyYzgwMTA1NjE0NWI4N2Nk ZDYzYmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApAQCAt OTc4LDYgKzk3OCw5IEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OnNldEltYWdlQnVmZmVyKHN0 ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4mJiBidWZmZXIpIGNvCiAgICAgICAgIG1faW1hZ2VC dWZmZXIgPSBXVEZNb3ZlKGJ1ZmZlcik7CiAgICAgfQogCisgICAgaWYgKG1faW1hZ2VCdWZmZXIg JiYgbV9zaXplICE9IG1faW1hZ2VCdWZmZXItPmludGVybmFsU2l6ZSgpKQorICAgICAgICBtX3Np emUgPSBtX2ltYWdlQnVmZmVyLT5pbnRlcm5hbFNpemUoKTsKKwogICAgIHNpemVfdCBjdXJyZW50 TWVtb3J5Q29zdCA9IG1lbW9yeUNvc3QoKTsKICAgICBhY3RpdmVQaXhlbE1lbW9yeSArPSBjdXJy ZW50TWVtb3J5Q29zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2Fu dmFzRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCmlu ZGV4IDQxNzkzNWI4YjFhYjc2NDAwYzkxYjkyZjkxOWRhYTU5OTg5Mzg5OTMuLmI0ZTJlMmNmMTZj YmUyNDE1MTkxMmJkYzY0MWY4YmZjZGExOTA4MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxD YW52YXNFbGVtZW50LmgKQEAgLTIwMCw3ICsyMDAsNyBAQCBwcml2YXRlOgogICAgIHN0ZDo6dW5p cXVlX3B0cjxDYW52YXNSZW5kZXJpbmdDb250ZXh0PiBtX2NvbnRleHQ7CiAKICAgICBGbG9hdFJl Y3QgbV9kaXJ0eVJlY3Q7Ci0gICAgSW50U2l6ZSBtX3NpemU7CisgICAgbXV0YWJsZSBJbnRTaXpl IG1fc2l6ZTsKIAogICAgIGJvb2wgbV9vcmlnaW5DbGVhbiB7IHRydWUgfTsKICAgICBib29sIG1f aWdub3JlUmVzZXQgeyBmYWxzZSB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXgg ZWMwMzg0MGMwNzdjNjA3MmMwODNhNDBjYmVkZTQwYzM4ZWUwOGE0YS4uYzU1NGM2ODEwNTkwMjll MTk2ZmE0Y2U0OWE2YjA0ODRjNTA3MTNiOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTAtMzEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUu Y29tPgorCisgICAgICAgIHRyYW5zZmVyRnJvbUltYWdlQml0bWFwIHNob3VsZCB1cGRhdGUgY2Fu dmFzIGRpbWVuc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3OTA5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUyODUyMTg+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGV4cGVjdGVk IHJlc3VsdHMgbm93IHRoYXQgd2UgcGFzcyBtb3JlIG9mIHRoaXMgdGVzdC4KKworICAgICAgICAq IHdlYi1wbGF0Zm9ybS10ZXN0cy9pbWFnZWJpdG1hcC1yZW5kZXJpbmdjb250ZXh0L2JpdG1hcHJl bmRlcmVyLWFzLWltYWdlc291cmNlLWV4cGVjdGVkLnR4dDoKKwogMjAxNy0xMC0zMCAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpcmUgdXBkYXRlZm91bmQgZXZl bnQgYWZ0ZXIgcmVzb2x2aW5nIHRoZSByZWdpc3RyYXRpb24gcHJvbWlzZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9pbWFnZWJpdG1hcC1y ZW5kZXJpbmdjb250ZXh0L2JpdG1hcHJlbmRlcmVyLWFzLWltYWdlc291cmNlLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaW1hZ2ViaXRt YXAtcmVuZGVyaW5nY29udGV4dC9iaXRtYXByZW5kZXJlci1hcy1pbWFnZXNvdXJjZS1leHBlY3Rl ZC50eHQKaW5kZXggMzllN2NjMmFiYzkyOGMyZmI2YmE1YWRhOWE2YjQ5MGM5NjM5ODI4ZS4uMjkx MDNkY2QwMDViYTliOGZkZTMwOWYxZjJlYjM3M2U1MzEzYjY0YSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9pbWFnZWJpdG1hcC1yZW5kZXJp bmdjb250ZXh0L2JpdG1hcHJlbmRlcmVyLWFzLWltYWdlc291cmNlLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ltYWdlYml0bWFw LXJlbmRlcmluZ2NvbnRleHQvYml0bWFwcmVuZGVyZXItYXMtaW1hZ2Vzb3VyY2UtZXhwZWN0ZWQu dHh0CkBAIC0xLDUgKzEsNSBAQAogCi1GQUlMIFRlc3QgdGhhdCBjcmVhdGVJbWFnZUJpdG1hcCBm cm9tIGEgYml0bWFwcmVuZGVyZXIgY2FudmFzIHByb2R1Y2VzIGNvcnJlY3QgcmVzdWx0IGFzc2Vy dF9lcXVhbHM6IGV4cGVjdGVkIDEwIGJ1dCBnb3QgMjAKK1BBU1MgVGVzdCB0aGF0IGNyZWF0ZUlt YWdlQml0bWFwIGZyb20gYSBiaXRtYXByZW5kZXJlciBjYW52YXMgcHJvZHVjZXMgY29ycmVjdCBy ZXN1bHQgCiBQQVNTIFRlc3QgdGhhdCBjcmVhdGVJbWFnZUJpdG1hcCBvbiBhIGJpdG1hcHJlbmRl cmVyIGNhbnZhcyB0aGF0IG5ldmVyIGNvbnN1bWVzIGFueSBzb3VyY2UgcHJvZHVjZXMgY29ycmVj dCByZXN1bHQgCiBQQVNTIFRlc3QgdGhhdCBjcmVhdGVJbWFnZUJpdG1hcCBvbiBhIGJpdG1hcHJl bmRlcmVyIGNhbnZhcyB0aGF0IGNvbnN1bWVzIG51bGwgcHJvZHVjZXMgY29ycmVjdCByZXN1bHQg CiAK