179088 2017-10-31 16:28:55 -0700 Fix a couple of service worker tests and unskip them 2017-11-15 12:29:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312 InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue ggaren lforschler sam webkit-bug-importer youennf oldest_to_newest 1366668 0 cdumez 2017-10-31 16:28:55 -0700 Fix a couple of service worker tests and unskip them. See https://github.com/w3c/web-platform-tests/pull/8019#issuecomment-340915312 1366670 1 325521 cdumez 2017-10-31 16:30:04 -0700 Created attachment 325521 Patch 1366723 2 325521 ap 2017-10-31 18:26:44 -0700 Comment on attachment 325521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325521&action=review > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" These don't seem fixed? 1366751 3 cdumez 2017-10-31 20:08:04 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 325521 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=325521&action=review > > > LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:2 > > +FAIL Rejecting the fetch event or using preventDefault() causes a network error assert_equals: expected "PASS" but got "FAIL: no controller" > > These don't seem fixed? The tests are fixed. We still do not pass them, which is expected since service workers is still being implemented. 1366752 4 325521 commit-queue 2017-10-31 20:26:45 -0700 Comment on attachment 325521 Patch Clearing flags on attachment: 325521 Committed r224271: <https://trac.webkit.org/changeset/224271> 1366753 5 commit-queue 2017-10-31 20:26:47 -0700 All reviewed patches have been landed. Closing bug. 1372158 6 webkit-bug-importer 2017-11-15 12:29:09 -0800 <rdar://problem/35567627> 325521 2017-10-31 16:30:04 -0700 2017-10-31 20:26:45 -0700 Patch bug-179088-20171031163004.patch text/plain 7098 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjYwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTU5MDkyMWJmMTcwOTc5ZTNmYWE4 ZDk3NjdiYjI4MWMzOWQ4ZjY3Yi4uOGI1NTRjN2U3Zjk2ZjBhZmEyMjBmZDA2MjFhNDUzMjBlNzBj NzY2MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEwLTMxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGEgY291cGxlIG9mIHNlcnZpY2Ugd29ya2Vy IHRlc3RzIGFuZCB1bnNraXAgdGhlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc5MDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVW5za2lwIHRoZSAyIHRlc3RzLgorCisgICAgICAgICogVGVzdEV4cGVj dGF0aW9uczoKKwogMjAxNy0xMC0zMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIHRlc3QgcnViYmVyLWJhbmRpbmcg aW4gb3ZlcmZsb3cgc2Nyb2xsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBlYzAz ODQwYzA3N2M2MDcyYzA4M2E0MGNiZWRlNDBjMzhlZTA4YTRhLi44YjBmZDkwNGE2OTk5ZjlhZDFl ZmY0NjIwMzdkYmE2ZDFkNTEwMjQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxNy0xMC0zMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgorCisgICAgICAgIEZpeCBhIGNvdXBsZSBvZiBzZXJ2aWNlIHdvcmtlciB0ZXN0cyBhbmQgdW5z a2lwIHRoZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3OTA4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1lcmdlIGZpeGVzIGZyb20gaHR0cHM6Ly9naXRodWIuY29tL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvcHVsbC84MDE5IGFuZCByZWJhc2VsaW5lIHRlc3RzLgorCisgICAgICAgICogd2ViLXBsYXRm b3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9mZXRjaC1ldmVudC1uZXR3 b3JrLWVycm9yLmh0dHBzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVz dHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2ZW50LXJlc3BvbmQtd2l0 aC1hcmd1bWVudC5odHRwcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogd2ViLXBsYXRmb3JtLXRl c3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9yZXNvdXJjZXMvZmV0Y2gtZXZlbnQt bmV0d29yay1lcnJvci1jb250cm9sbGVlLWlmcmFtZS5odG1sOgorICAgICAgICAqIHdlYi1wbGF0 Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvcmVzb3VyY2VzL2ZldGNo LWV2ZW50LXJlc3BvbmQtd2l0aC1hcmd1bWVudC1pZnJhbWUuaHRtbDoKKwogMjAxNy0xMC0zMCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpcmUgdXBkYXRlZm91 bmQgZXZlbnQgYWZ0ZXIgcmVzb2x2aW5nIHRoZSByZWdpc3RyYXRpb24gcHJvbWlzZQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggYWRhNDQxOGU3MTFkZjJkYzg2MGU4YjZiNDdlMmZjMmEzYjY1YjMzZS4u MGQ4MTE5ZTY0YzA1NGUxMzY3ZjVlNTUzMWFkODJmZWFkZGEyZDAwMCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zCkBAIC0xNDcsOCArMTQ3LDYgQEAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9z ZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZXh0ZW5kYWJsZS1ldmVudC0KIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2Zl dGNoLWNhbnZhcy10YWludGluZy1jYWNoZS5odHRwcy5odG1sIFsgU2tpcCBdCiBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9mZXRj aC1jYW52YXMtdGFpbnRpbmcuaHR0cHMuaHRtbCBbIFNraXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtY29ycy14 aHIuaHR0cHMuaHRtbCBbIFNraXAgXQotaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9z ZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtZXZlbnQtbmV0d29yay1lcnJvci5o dHRwcy5odG1sIFsgU2tpcCBdCi1pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZp Y2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9mZXRjaC1ldmVudC1yZXNwb25kLXdpdGgtYXJndW1l bnQuaHR0cHMuaHRtbCBbIFNraXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9z ZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtcmVzcG9uc2UtdGFpbnQuaHR0cHMu aHRtbCBbIFNraXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdv cmtlcnMvc2VydmljZS13b3JrZXIvZm9yZWlnbi1mZXRjaC1iYXNpY3MuaHR0cHMuaHRtbCBbIFNr aXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2Vy dmljZS13b3JrZXIvZm9yZWlnbi1mZXRjaC1ldmVudC5odHRwcy5odG1sIFsgU2tpcCBdCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZp Y2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9mZXRjaC1ldmVudC1uZXR3b3JrLWVycm9yLmh0dHBz LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2ZW50LW5ldHdvcmstZXJy b3IuaHR0cHMtZXhwZWN0ZWQudHh0CmluZGV4IDJiOGY1NjYwOTBmN2RiNjMzNjVjZTBlMmU4NWUz OTJlNTVkYjZmNWIuLjQxNzdkOTI4NGRlYzZkOGM3MzNlNTk2YjYzOGIzYjk4ZGQ3OTZkMzMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2Vy dmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2ZW50LW5ldHdvcmstZXJyb3IuaHR0 cHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2ZW50LW5ldHdv cmstZXJyb3IuaHR0cHMtZXhwZWN0ZWQudHh0CkBAIC0xLDcgKzEsMyBAQAotQ09OU09MRSBNRVNT QUdFOiBsaW5lIDU3OiBUeXBlRXJyb3I6IHdpbmRvdy5wYXJlbnQubm90aWZ5X2RvbmUgaXMgbm90 IGEgZnVuY3Rpb24uIChJbiAnd2luZG93LnBhcmVudC5ub3RpZnlfZG9uZSgnRkFJTDogbm8gY29u dHJvbGxlcicpJywgJ3dpbmRvdy5wYXJlbnQubm90aWZ5X2RvbmUnIGlzIHVuZGVmaW5lZCkKIAot Ci1IYXJuZXNzIEVycm9yIChUSU1FT1VUKSwgbWVzc2FnZSA9IG51bGwKLQotVElNRU9VVCBSZWpl Y3RpbmcgdGhlIGZldGNoIGV2ZW50IG9yIHVzaW5nIHByZXZlbnREZWZhdWx0KCkgY2F1c2VzIGEg bmV0d29yayBlcnJvciBUZXN0IHRpbWVkIG91dAorRkFJTCBSZWplY3RpbmcgdGhlIGZldGNoIGV2 ZW50IG9yIHVzaW5nIHByZXZlbnREZWZhdWx0KCkgY2F1c2VzIGEgbmV0d29yayBlcnJvciBhc3Nl cnRfZXF1YWxzOiBleHBlY3RlZCAiUEFTUyIgYnV0IGdvdCAiRkFJTDogbm8gY29udHJvbGxlciIK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtZXZlbnQtcmVzcG9uZC13aXRo LWFyZ3VtZW50Lmh0dHBzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ZldGNoLWV2 ZW50LXJlc3BvbmQtd2l0aC1hcmd1bWVudC5odHRwcy1leHBlY3RlZC50eHQKaW5kZXggNzMwODli M2QxNTcxZTExY2NmZWU1NDc5ZjVjNTg5MWI1YTZhZWNhMS4uYmM2OWQwMWIwNDM1YWZkMzI2ZGNm MWY2ZDc4YmViMjk0OTlhMGVkYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gt ZXZlbnQtcmVzcG9uZC13aXRoLWFyZ3VtZW50Lmh0dHBzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9z ZXJ2aWNlLXdvcmtlci9mZXRjaC1ldmVudC1yZXNwb25kLXdpdGgtYXJndW1lbnQuaHR0cHMtZXhw ZWN0ZWQudHh0CkBAIC0xLDcgKzEsMyBAQAotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDUyOiBUeXBl RXJyb3I6IHdpbmRvdy5wYXJlbnQubm90aWZ5X2RvbmUgaXMgbm90IGEgZnVuY3Rpb24uIChJbiAn d2luZG93LnBhcmVudC5ub3RpZnlfZG9uZSgnRkFJTDogbm8gY29udHJvbGxlcicpJywgJ3dpbmRv dy5wYXJlbnQubm90aWZ5X2RvbmUnIGlzIHVuZGVmaW5lZCkKIAotCi1IYXJuZXNzIEVycm9yIChU SU1FT1VUKSwgbWVzc2FnZSA9IG51bGwKLQotVElNRU9VVCByZXNwb25kV2l0aCgpIHRha2VzIGVp dGhlciBhIFJlc3BvbnNlIG9yIGEgcHJvbWlzZSB0aGF0IHJlc29sdmVzIHdpdGggYSBSZXNwb25z ZS4gT3RoZXIgdmFsdWVzIHNob3VsZCByYWlzZSBhIG5ldHdvcmsgZXJyb3IuIFRlc3QgdGltZWQg b3V0CitGQUlMIHJlc3BvbmRXaXRoKCkgdGFrZXMgZWl0aGVyIGEgUmVzcG9uc2Ugb3IgYSBwcm9t aXNlIHRoYXQgcmVzb2x2ZXMgd2l0aCBhIFJlc3BvbnNlLiBPdGhlciB2YWx1ZXMgc2hvdWxkIHJh aXNlIGEgbmV0d29yayBlcnJvci4gYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIlBBU1MiIGJ1dCBn b3QgIkZBSUw6IG5vIGNvbnRyb2xsZXIiCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2Vy L3Jlc291cmNlcy9mZXRjaC1ldmVudC1uZXR3b3JrLWVycm9yLWNvbnRyb2xsZWUtaWZyYW1lLmh0 bWwgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Ut d29ya2Vycy9zZXJ2aWNlLXdvcmtlci9yZXNvdXJjZXMvZmV0Y2gtZXZlbnQtbmV0d29yay1lcnJv ci1jb250cm9sbGVlLWlmcmFtZS5odG1sCmluZGV4IGUyOGY2MjM5MzRlYWM4YWY4ZmIxOWQ2Nzhk MjVkYzllYzhhMzk4ODMuLmY2YzE5MTliYmNmNjNhMGYyM2Y3ZWE0ZjBmOGJhYTBlNWJhZTQwMzUg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv c2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL3Jlc291cmNlcy9mZXRjaC1ldmVudC1uZXR3 b3JrLWVycm9yLWNvbnRyb2xsZWUtaWZyYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIv cmVzb3VyY2VzL2ZldGNoLWV2ZW50LW5ldHdvcmstZXJyb3ItY29udHJvbGxlZS1pZnJhbWUuaHRt bApAQCAtNTQsNyArNTQsNyBAQCBmdW5jdGlvbiBydW5fdGVzdHMoKSB7CiB9CiAKIGlmICghbmF2 aWdhdG9yLnNlcnZpY2VXb3JrZXIuY29udHJvbGxlcikKLSAgd2luZG93LnBhcmVudC5ub3RpZnlf ZG9uZSgnRkFJTDogbm8gY29udHJvbGxlcicpOworICB3aW5kb3cucGFyZW50Lm5vdGlmeV90ZXN0 X2RvbmUoJ0ZBSUw6IG5vIGNvbnRyb2xsZXInKTsKIGVsc2UKICAgcnVuX3Rlc3RzKCk7CiA8L3Nj cmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL3Jlc291cmNlcy9mZXRjaC1ldmVu dC1yZXNwb25kLXdpdGgtYXJndW1lbnQtaWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9y ZXNvdXJjZXMvZmV0Y2gtZXZlbnQtcmVzcG9uZC13aXRoLWFyZ3VtZW50LWlmcmFtZS5odG1sCmlu ZGV4IDMzYjQ3ZTc4YTM0OWRmZGE3MGY5ZGM5YTIzMGEzNDE1MjMwNTY0MGMuLjBlYmQxY2E4MTUz N2U1MjlhYWEwZTNlOTM5ODViOTIzNjRlOTIyNWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29y a2VyL3Jlc291cmNlcy9mZXRjaC1ldmVudC1yZXNwb25kLXdpdGgtYXJndW1lbnQtaWZyYW1lLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2 aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvcmVzb3VyY2VzL2ZldGNoLWV2ZW50LXJlc3BvbmQt d2l0aC1hcmd1bWVudC1pZnJhbWUuaHRtbApAQCAtNDksNyArNDksNyBAQCBmdW5jdGlvbiBydW5f dGVzdHMoKSB7CiB9CiAKIGlmICghbmF2aWdhdG9yLnNlcnZpY2VXb3JrZXIuY29udHJvbGxlcikK LSAgd2luZG93LnBhcmVudC5ub3RpZnlfZG9uZSgnRkFJTDogbm8gY29udHJvbGxlcicpOworICB3 aW5kb3cucGFyZW50Lm5vdGlmeV90ZXN0X2RvbmUoJ0ZBSUw6IG5vIGNvbnRyb2xsZXInKTsKIGVs c2UKICAgcnVuX3Rlc3RzKCk7CiA8L3NjcmlwdD4K