17908 2008-03-17 23:03:17 -0700 Various bugs in the Console completion code 2008-03-17 23:13:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy oldest_to_newest 74218 0 timothy 2008-03-17 23:03:17 -0700 Some bugs include: * Auto completion stay around when clicking to change caret selection. Fine when arrowing to change caret. * Can never move the caret to a previous spot in the prompt. It always jumps to the end. * The selection will sometimes jump to a random spot in the middle of the prompt when it was going to jump to the end. Happens when there are multiple text nodes. 74219 1 19860 timothy 2008-03-17 23:05:53 -0700 Created attachment 19860 Patch 74220 2 19860 mrowe 2008-03-17 23:12:13 -0700 Comment on attachment 19860 Patch r=me, small typo in the ChangeLog: "carent" 74221 3 timothy 2008-03-17 23:13:46 -0700 Landed in r31120. 19860 2008-03-17 23:05:53 -0700 2008-03-17 23:12:13 -0700 Patch 17908.patch text/plain 5210 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMTE5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMDMt MTcgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNzkwODogVmFyaW91cyBidWdz IGluIHRoZSBDb25zb2xlIGNvbXBsZXRpb24gY29kZQorICAgICAgICBodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwOAorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3Iv Q29uc29sZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQYW5lbC5jb21w bGV0ZSk6IE1vdmVkIHRoZSBjb2RlIHRoYXQgY2hlY2tlZCBmb3IgdGhlIGNhcmV0IGJlaW5nIGF0 IHRoZSBlbmQKKyAgICAgICAgb2YgdGhlIHByb21wdCBpbnRvIHRoZSBfY2FyZXRBdEVuZE9mUHJv bXB0IGhlbHBlciBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlUGFuZWwu bWVzc2FnZXNTZWxlY3RTdGFydCk6IENsZWFyIGFuZCByZWRvIHRoZSBhdXRvIGNvbXBsZXRlIHdo ZW4gdGhlIHNlbGVjdGlvbiBjaGFuZ2VzLgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQ YW5lbC5fY2FyZXRJbnNpZGVQcm9tcHQpOiBGaXhlZCBhIGxvZ2ljIGVycm9yIHRoYXQgYWx3YXlz IGNhdXNlZCBhIGZhbHNlIHJlc3VsdC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlUGFu ZWwuX2NhcmV0QXRFbmRPZlByb21wdCk6IEFkZGVkLiBUZXN0cyBpZiB0aGUgc2VsZWN0aW9uIGlz IGEgY2FyZW50IGF0IHRoZQorICAgICAgICBlbmQgb2YgdGhlIHByb21wdC4KKyAgICAgICAgKFdl Ykluc3BlY3Rvci5Db25zb2xlUGFuZWwuX21vdmVDYXJldFRvRW5kT2ZQcm9tcHQpOiBDaGFuZ2Vk IHRoZSBvZmZzZXQgdG8gdXNlIHRoZSBjaGlsZE5vZGVzIGxlbmd0aC4KKyAgICAgICAgVGhpcyBt YWtlcyBzdXJlIHRoZSBjYXJldCBpcyBhdCB0aGUgZW5kIHdoZW4gdGhlcmUgYXJlIG11bHRpcGxl IHRleHQgbm9kZXMgaW4gdGhlIHByb21wdC4KKwogMjAwOC0wMy0xNyAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhdmUgSHlhdHQu CkluZGV4OiBwYWdlL2luc3BlY3Rvci9Db25zb2xlUGFuZWwuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGFn ZS9pbnNwZWN0b3IvQ29uc29sZVBhbmVsLmpzCShyZXZpc2lvbiAzMTExNSkKKysrIHBhZ2UvaW5z cGVjdG9yL0NvbnNvbGVQYW5lbC5qcwkod29ya2luZyBjb3B5KQpAQCAtMTkwLDI2ICsxOTAsOCBA QCBXZWJJbnNwZWN0b3IuQ29uc29sZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHNl bGVjdGlvblJhbmdlID0gc2VsZWN0aW9uLmdldFJhbmdlQXQoMCk7CiAgICAgICAgIGlmICghc2Vs ZWN0aW9uUmFuZ2UuY29tbW9uQW5jZXN0b3JDb250YWluZXIuaXNEZXNjZW5kYW50KHRoaXMucHJv bXB0RWxlbWVudCkpCiAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgaWYgKGF1dG8pIHsK LSAgICAgICAgICAgIGlmICghc2VsZWN0aW9uLmlzQ29sbGFwc2VkKQotICAgICAgICAgICAgICAg IHJldHVybjsKLQotICAgICAgICAgICAgdmFyIG5vZGUgPSBzZWxlY3Rpb25SYW5nZS5zdGFydENv bnRhaW5lcjsKLSAgICAgICAgICAgIGlmIChub2RlLm5vZGVUeXBlID09PSBOb2RlLlRFWFRfTk9E RSAmJiBzZWxlY3Rpb25SYW5nZS5zdGFydE9mZnNldCA8IG5vZGUubm9kZVZhbHVlLmxlbmd0aCkK LSAgICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgICAgIHZhciBmb3VuZE5leHRUZXh0 ID0gZmFsc2U7Ci0gICAgICAgICAgICB3aGlsZSAobm9kZSkgewotICAgICAgICAgICAgICAgIGlm IChub2RlLm5vZGVUeXBlID09PSBOb2RlLlRFWFRfTk9ERSAmJiBub2RlLm5vZGVWYWx1ZS5sZW5n dGgpIHsKLSAgICAgICAgICAgICAgICAgICAgaWYgKGZvdW5kTmV4dFRleHQpCi0gICAgICAgICAg ICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgICAgIGZvdW5kTmV4dFRleHQg PSB0cnVlOwotICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgIG5vZGUgPSBub2Rl LnRyYXZlcnNlTmV4dE5vZGUoZmFsc2UsIHRoaXMucHJvbXB0RWxlbWVudCk7Ci0gICAgICAgICAg ICB9Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKGF1dG8gJiYgIXRoaXMuX2NhcmV0QXRFbmRPZlBy b21wdCgpKQorICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIC8vIFBhc3MgbW9yZSBjaGFy YWN0ZXJzIHRvIF9iYWNrd2FyZHNSYW5nZSBzbyB0aGUgcmFuZ2Ugd2lsbCBiZSBhcyBzaG9ydCBh cyBwb3NzaWJsZS4KICAgICAgICAgdmFyIHdvcmRQcmVmaXhSYW5nZSA9IHRoaXMuX2JhY2t3YXJk c1JhbmdlKCIgLj06Wyh7OyIsIHNlbGVjdGlvblJhbmdlLnN0YXJ0Q29udGFpbmVyLCBzZWxlY3Rp b25SYW5nZS5zdGFydE9mZnNldCwgdGhpcy5wcm9tcHRFbGVtZW50KTsKQEAgLTMzOCwxMiArMzIw LDE0IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICBp ZiAodGhpcy5fc2VsZWN0aW9uVGltZW91dCkKICAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlz Ll9zZWxlY3Rpb25UaW1lb3V0KTsKIAorICAgICAgICB0aGlzLmNsZWFyQXV0b0NvbXBsZXRlKCk7 CisKICAgICAgICAgZnVuY3Rpb24gbW92ZUJhY2tJZk91dHNpZGUoKQogICAgICAgICB7CiAgICAg ICAgICAgICBkZWxldGUgdGhpcy5fc2VsZWN0aW9uVGltZW91dDsKLSAgICAgICAgICAgIGlmICh0 aGlzLl9jYXJldEluc2lkZVByb21wdCgpIHx8ICF3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuaXNDb2xs YXBzZWQpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgdGhpcy5fbW92ZUNh cmV0VG9FbmRPZlByb21wdCgpOworICAgICAgICAgICAgaWYgKCF0aGlzLl9jYXJldEluc2lkZVBy b21wdCgpICYmIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5pc0NvbGxhcHNlZCkKKyAgICAgICAgICAg ICAgICB0aGlzLl9tb3ZlQ2FyZXRUb0VuZE9mUHJvbXB0KCk7CisgICAgICAgICAgICB0aGlzLmF1 dG9Db21wbGV0ZVNvb24oKTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX3NlbGVjdGlvblRp bWVvdXQgPSBzZXRUaW1lb3V0KG1vdmVCYWNrSWZPdXRzaWRlLmJpbmQodGhpcyksIDEwMCk7CkBA IC00NTUsNyArNDM5LDM1IEBAIFdlYkluc3BlY3Rvci5Db25zb2xlUGFuZWwucHJvdG90eXBlID0g ewogICAgICAgICBpZiAoIXNlbGVjdGlvbi5yYW5nZUNvdW50IHx8ICFzZWxlY3Rpb24uaXNDb2xs YXBzZWQpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHZhciBzZWxlY3Rpb25S YW5nZSA9IHNlbGVjdGlvbi5nZXRSYW5nZUF0KDApOwotICAgICAgICByZXR1cm4gc2VsZWN0aW9u UmFuZ2Uuc3RhcnRDb250YWluZXIgPT09IHRoaXMucHJvbXB0RWxlbWVudCAmJiBzZWxlY3Rpb25S YW5nZS5zdGFydENvbnRhaW5lci5pc0Rlc2NlbmRhbnQodGhpcy5wcm9tcHRFbGVtZW50KTsKKyAg ICAgICAgcmV0dXJuIHNlbGVjdGlvblJhbmdlLnN0YXJ0Q29udGFpbmVyID09PSB0aGlzLnByb21w dEVsZW1lbnQgfHwgc2VsZWN0aW9uUmFuZ2Uuc3RhcnRDb250YWluZXIuaXNEZXNjZW5kYW50KHRo aXMucHJvbXB0RWxlbWVudCk7CisgICAgfSwKKworICAgIF9jYXJldEF0RW5kT2ZQcm9tcHQ6IGZ1 bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCk7CisgICAgICAgIGlmICghc2VsZWN0aW9uLnJhbmdlQ291bnQgfHwgIXNlbGVjdGlvbi5p c0NvbGxhcHNlZCkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICB2YXIgc2Vs ZWN0aW9uUmFuZ2UgPSBzZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKTsKKyAgICAgICAgdmFyIG5vZGUg PSBzZWxlY3Rpb25SYW5nZS5zdGFydENvbnRhaW5lcjsKKyAgICAgICAgaWYgKG5vZGUgIT09IHRo aXMucHJvbXB0RWxlbWVudCAmJiAhbm9kZS5pc0Rlc2NlbmRhbnQodGhpcy5wcm9tcHRFbGVtZW50 KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBpZiAobm9kZS5ub2RlVHlw ZSA9PT0gTm9kZS5URVhUX05PREUgJiYgc2VsZWN0aW9uUmFuZ2Uuc3RhcnRPZmZzZXQgPCBub2Rl Lm5vZGVWYWx1ZS5sZW5ndGgpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAg dmFyIGZvdW5kTmV4dFRleHQgPSBmYWxzZTsKKyAgICAgICAgd2hpbGUgKG5vZGUpIHsKKyAgICAg ICAgICAgIGlmIChub2RlLm5vZGVUeXBlID09PSBOb2RlLlRFWFRfTk9ERSAmJiBub2RlLm5vZGVW YWx1ZS5sZW5ndGgpIHsKKyAgICAgICAgICAgICAgICBpZiAoZm91bmROZXh0VGV4dCkKKyAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgICAgIGZvdW5kTmV4dFRl eHQgPSB0cnVlOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBub2RlID0gbm9kZS50cmF2 ZXJzZU5leHROb2RlKGZhbHNlLCB0aGlzLnByb21wdEVsZW1lbnQpOworICAgICAgICB9CisKKyAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIF9tb3ZlQ2FyZXRUb0VuZE9mUHJvbXB0 OiBmdW5jdGlvbigpCkBAIC00NjMsNyArNDc1LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVQYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCk7CiAgICAgICAgIHZhciBzZWxlY3Rpb25SYW5nZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdl KCk7CiAKLSAgICAgICAgdmFyIG9mZnNldCA9IHRoaXMucHJvbXB0RWxlbWVudC5maXJzdENoaWxk ID8gMSA6IDA7CisgICAgICAgIHZhciBvZmZzZXQgPSB0aGlzLnByb21wdEVsZW1lbnQuY2hpbGRO b2Rlcy5sZW5ndGg7CiAgICAgICAgIHNlbGVjdGlvblJhbmdlLnNldFN0YXJ0KHRoaXMucHJvbXB0 RWxlbWVudCwgb2Zmc2V0KTsKICAgICAgICAgc2VsZWN0aW9uUmFuZ2Uuc2V0RW5kKHRoaXMucHJv bXB0RWxlbWVudCwgb2Zmc2V0KTsKIAo=