179074 2017-10-31 13:39:00 -0700 Make all register enums be backed by uint8_t. 2019-06-16 21:18:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 179083 1 keith_miller keith_miller buildbot commit-queue mark.lam msaboff saam oldest_to_newest 1366551 0 keith_miller 2017-10-31 13:39:00 -0700 Make all register enums be backed by uint8_t. 1366553 1 325483 keith_miller 2017-10-31 13:39:28 -0700 Created attachment 325483 Patch 1366555 2 325483 mark.lam 2017-10-31 13:40:54 -0700 Comment on attachment 325483 Patch r=me if it builds. 1366592 3 325483 commit-queue 2017-10-31 14:25:20 -0700 Comment on attachment 325483 Patch Clearing flags on attachment: 325483 Committed r224246: <https://trac.webkit.org/changeset/224246> 1366593 4 commit-queue 2017-10-31 14:25:22 -0700 All reviewed patches have been landed. Closing bug. 1366643 5 commit-queue 2017-10-31 16:10:22 -0700 Re-opened since this is blocked by bug 179083 325483 2017-10-31 13:39:28 -0700 2017-10-31 14:25:20 -0700 Patch bug-179074-20171031133927.patch text/plain 5977 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YWQwMzg0ZWI0MzExNTMzOWI5ZmM0Zjk3ODM5ZTc2NjY2ZjM5NGE2Li4yNjY4MjNhMjkyYzVkNjM3 YjVmOTA5OGQwYmFmOWYxNDIxODMxZjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNy0xMC0zMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBNYWtlIGFsbCByZWdpc3RlciBlbnVtcyBiZSBiYWNrZWQgYnkgdWlu dDhfdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTA3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmg6CisgICAgICAgICogYXNzZW1ibGVyL0FSTUFzc2Vt Ymxlci5oOgorICAgICAgICAqIGFzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oOgorICAgICAgICAq IGFzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmg6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyLmg6CisgICAgICAgICogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oOgorCisyMDE3LTEw LTMxICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFN0 cnVjdHVyZVN0dWJJbmZvIHNob3VsZCBoYXZlIEdQUlJlZyBtZW1iZXJzIG5vdCBpbnQ4X3RzCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwNzEKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxl ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oCmlu ZGV4IGVlZjY0NDM2ZTY3NGM1NzliNzhkMjExMWYzMDFmZGNkZjczN2ZhNTcuLjgzYzYwNDJmMTFi NGE4YWI1MDJkMjhkODQ4YzgyYWY1NjM5ODIzNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgKQEAgLTIwNSwxNiArMjA1LDE2IEBAIGVu dW0gUmVnaXN0ZXJJRCA6IHVpbnQ4X3QgewogICAgIHpyID0gMHgzZiwKIH07CiAKLXR5cGVkZWYg ZW51bSB7CitlbnVtIFNQUmVnaXN0ZXJJRCA6IHVpbnQ4X3QgewogICAgIHBjLAogICAgIG56Y3Ys CiAgICAgZnBzcgotfSBTUFJlZ2lzdGVySUQ7Cit9OwogCiAvLyBBUk02NCBhbHdheXMgaGFzIDMy IEZQVSByZWdpc3RlcnMgMTI4LWJpdHMgZWFjaC4gU2VlIGh0dHA6Ly9sbHZtLm9yZy9kZXZtdGcv MjAxMi0xMS9Ob3J0aG92ZXItQUFyY2g2NC5wZGYKIC8vIGFuZCBTZWN0aW9uIDUuMS4yIGluIGh0 dHA6Ly9pbmZvY2VudGVyLmFybS5jb20vaGVscC90b3BpYy9jb20uYXJtLmRvYy5paGkwMDU1Yi9J SEkwMDU1Ql9hYXBjczY0LnBkZi4KIC8vIEhvd2V2ZXIsIHdlIG9ubHkgdXNlIHRoZW0gZm9yIDY0 LWJpdCBkb3VibGVzLgotdHlwZWRlZiBlbnVtIHsKK2VudW0gRlBSZWdpc3RlcklEIDogdWludDhf dCB7CiAgICAgLy8gUGFyYW1ldGVyL3Jlc3VsdCByZWdpc3RlcnMuCiAgICAgcTAsCiAgICAgcTEs CkBAIC0yNTAsNyArMjUwLDcgQEAgdHlwZWRlZiBlbnVtIHsKICAgICBxMjksCiAgICAgcTMwLAog ICAgIHEzMSwKLX0gRlBSZWdpc3RlcklEOworfTsKIAogc3RhdGljIGNvbnN0ZXhwciBib29sIGlz U3AoUmVnaXN0ZXJJRCByZWcpIHsgcmV0dXJuIHJlZyA9PSBzcDsgfQogc3RhdGljIGNvbnN0ZXhw ciBib29sIGlzWnIoUmVnaXN0ZXJJRCByZWcpIHsgcmV0dXJuIHJlZyA9PSB6cjsgfQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKaW5kZXggYWI0Yzdh YjE5MzM4ODA1MzhjMDI3ZmY3YzlkODA1NzU5ZmFhNmI4ZS4uM2M3OWE0OWUyNDhhYThlNTc1OTk1 MWY1OTNiNzE5OGE5NDkzYTI2MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9BUk1Bc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL0FSTUFzc2VtYmxlci5oCkBAIC02NSwxMiArNjUsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAg ICAgICAgICAgICByMTUgPSBwYwogICAgICAgICB9OwogCi0gICAgICAgIHR5cGVkZWYgZW51bSB7 CisgICAgICAgIGVudW0gU1BSZWdpc3RlcklEIDogdWludDhfdCB7CiAgICAgICAgICAgICBhcHNy LAogICAgICAgICAgICAgZnBzY3IKLSAgICAgICAgfSBTUFJlZ2lzdGVySUQ7CisgICAgICAgIH07 CiAKLSAgICAgICAgdHlwZWRlZiBlbnVtIHsKKyAgICAgICAgZW51bSBGUFJlZ2lzdGVySUQgOiB1 aW50OF90IHsKICAgICAgICAgICAgIGQwLAogICAgICAgICAgICAgZDEsCiAgICAgICAgICAgICBk MiwKQEAgLTEwOCw3ICsxMDgsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICAgICAgLy8g UHNldWRvbnltcyBmb3Igc29tZSBvZiB0aGUgcmVnaXN0ZXJzLgogICAgICAgICAgICAgU0QwID0g ZDcsIC8qIFNhbWUgYXMgdGh1bWIgYXNzZW1ibGVyLiAqLwotICAgICAgICB9IEZQUmVnaXN0ZXJJ RDsKKyAgICAgICAgfTsKIAogICAgIH0gLy8gbmFtZXNwYWNlIEFSTVJlZ2lzdGVycwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgKaW5kZXgg NWRjNjg4YmYyYzViNzgyNTc1ZjdiMTkzNjkzODg5MWVhZTU5MTQ5Zi4uYTkzODg1MTM2MWNlZDA1 YjVjMmQwYzFjMjhmMGY1ZDcwZDE5ZmViYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaApAQCAtNjYsMTIgKzY2LDEyIEBAIGVudW0gUmVn aXN0ZXJJRCA6IHVpbnQ4X3QgewogICAgIHBjID0gcjE1CiB9OwogCi10eXBlZGVmIGVudW0gewor ZW51bSBTUFJlZ2lzdGVySUQgOiB1aW50OF90IHsKICAgICBhcHNyLAogICAgIGZwc2NyCi19IFNQ UmVnaXN0ZXJJRDsKK307CiAKLXR5cGVkZWYgZW51bSB7CitlbnVtIEZQU2luZ2xlUmVnaXN0ZXJJ RCA6IHVpbnQ4X3QgewogICAgIHMwLAogICAgIHMxLAogICAgIHMyLApAQCAtMTA0LDkgKzEwNCw5 IEBAIHR5cGVkZWYgZW51bSB7CiAgICAgczI5LAogICAgIHMzMCwKICAgICBzMzEsCi19IEZQU2lu Z2xlUmVnaXN0ZXJJRDsKK307CiAKLXR5cGVkZWYgZW51bSB7CitlbnVtIEZQRG91YmxlUmVnaXN0 ZXJJRCA6IHVpbnQ4X3QgewogICAgIGQwLAogICAgIGQxLAogICAgIGQyLApAQCAtMTQxLDEwICsx NDEsMTAgQEAgdHlwZWRlZiBlbnVtIHsKICAgICBkMzAsCiAgICAgZDMxLAogI2VuZGlmIC8vIENQ VShBUk1fTkVPTikgfHwgQ1BVKEFSTV9WRlBfVjNfRDMyKQotfSBGUERvdWJsZVJlZ2lzdGVySUQ7 Cit9OwogCiAjaWYgQ1BVKEFSTV9ORU9OKQotdHlwZWRlZiBlbnVtIHsKK2VudW0gRlBRdWFkUmVn aXN0ZXJJRCA6IHVpbnQ4X3QgewogICAgIHEwLAogICAgIHExLAogICAgIHEyLApAQCAtMTYxLDcg KzE2MSw3IEBAIHR5cGVkZWYgZW51bSB7CiAgICAgcTEzLAogICAgIHExNCwKICAgICBxMTUsCi19 IEZQUXVhZFJlZ2lzdGVySUQ7Cit9OwogI2VuZGlmIC8vIENQVShBUk1fTkVPTikKIAogaW5saW5l IEZQU2luZ2xlUmVnaXN0ZXJJRCBhc1NpbmdsZShGUERvdWJsZVJlZ2lzdGVySUQgcmVnKQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAppbmRleCA4 ZDU1NTczNWNlYjE1Zjg5MTllMGNiMDE5ZmZjNzM0OTE1NDE0ZTBjLi4xNDNjNTZmNzE1OTQ0ZGUw MjUyYmM5MTdhZWJiNTQzOWVmNzQ3MjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaApAQCAtMTEwLDEyICsxMTAsMTIgQEAgZW51bSBSZWdp c3RlcklEIDogdWludDhfdCB7CiB9OwogCiAvLyBDdXJyZW50bHksIHdlIGRvbid0IGhhdmUgc3Vw cG9ydCBmb3IgYW55IHNwZWNpYWwgcHVycG9zZSByZWdpc3RlcnMuCi10eXBlZGVmIGVudW0gewor ZW51bSBTUFJlZ2lzdGVySUQgOiB1aW50OF90IHsKICAgICBmaXJzdEludmFsaWRTUFIsCiAgICAg bGFzdEludmFsaWRTUFIgPSAtMSwKLX0gU1BSZWdpc3RlcklEOworfTsKIAotdHlwZWRlZiBlbnVt IHsKK2VudW0gRlBSZWdpc3RlcklEIDogdWludDhfdCB7CiAgICAgZjAsCiAgICAgZjEsCiAgICAg ZjIsCkBAIC0xNDgsNyArMTQ4LDcgQEAgdHlwZWRlZiBlbnVtIHsKICAgICBmMjksCiAgICAgZjMw LAogICAgIGYzMQotfSBGUFJlZ2lzdGVySUQ7Cit9OwogCiB9IC8vIG5hbWVzcGFjZSBNSVBTUmVn aXN0ZXJzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXIuaAppbmRleCBjZjQxY2U4YTRmOTQxMDA1MTcxMTljNTY1NWYzNGIxZTE1ODQ2YjBlLi4y ZGVmN2VlNDNhMDNhYWY0YzcxMGI5MDQyNmM0OGZjNTk4ODIwM2U0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCkBAIC0xOTIxLDggKzE5 MjEsOCBAQCBwcml2YXRlOgogICAgIAogcHVibGljOgogICAgIAotICAgIGVudW0gUmVnaXN0ZXJJ RCB7IE5vUmVnaXN0ZXIgfTsKLSAgICBlbnVtIEZQUmVnaXN0ZXJJRCB7IE5vRlBSZWdpc3RlciB9 OworICAgIGVudW0gUmVnaXN0ZXJJRCA6IHVpbnQ4X3QgeyBOb1JlZ2lzdGVyIH07CisgICAgZW51 bSBGUFJlZ2lzdGVySUQgOiB1aW50OF90IHsgTm9GUFJlZ2lzdGVyIH07CiB9OwogCiB9IC8vIG5h bWVzcGFjZSBKU0MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv WDg2QXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2Vt Ymxlci5oCmluZGV4IDI3YzBlMGM2MjBjZmE3ZDdmZTM3MGEzZGUwZDUwZDU1YjRiZjI2YzAuLmQ0 ZDdjYjhkYmFjNTQzNDZiNjEwNjZjY2M5Yzg1ZTVlYmJlYjMzNzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApAQCAtNjIsMTIgKzYyLDEyIEBA IGVudW0gUmVnaXN0ZXJJRCA6IHVpbnQ4X3QgewogI2VuZGlmCiB9OwogCi10eXBlZGVmIGVudW0g eworZW51bSBTUFJlZ2lzdGVySUQgOiB1aW50OF90IHsKICAgICBlaXAsCiAgICAgZWZsYWdzCi19 IFNQUmVnaXN0ZXJJRDsKK307CiAKLXR5cGVkZWYgZW51bSB7CitlbnVtIFhNTVJlZ2lzdGVySUQg OiB1aW50OF90IHsKICAgICB4bW0wLAogICAgIHhtbTEsCiAgICAgeG1tMiwKQEAgLTg2LDcgKzg2 LDcgQEAgdHlwZWRlZiBlbnVtIHsKICAgICB4bW0xNCwKICAgICB4bW0xNQogI2VuZGlmCi19IFhN TVJlZ2lzdGVySUQ7Cit9OwogCiB9IC8vIG5hbWVzcGFjZSBYODZSZWdpc3RlcgogCg==