179047 2017-10-31 00:37:33 -0700 OwnedCommitViewer should include the preceding commit. 2017-10-31 00:57:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 dewei_zhu webkit-unassigned dewei_zhu rniwa oldest_to_newest 1366333 0 dewei_zhu 2017-10-31 00:37:33 -0700 OwnedCommitViewer should include the preceding commit. 1366335 1 325426 dewei_zhu 2017-10-31 00:44:21 -0700 Created attachment 325426 Patch 1366338 2 325426 rniwa 2017-10-31 00:57:45 -0700 Comment on attachment 325426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325426&action=review > Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:39 > + let fetchSingleCommit = !precedingRevision || precedingRevision == lastRevision; Use const. > Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:59 > + this._precedingCommit = precedingCommit[0]; You should check this._fetchingPromise != promise here to avoid showing results for the old range. > Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:88 > + let commits_to_process = commits && precedingCommit && precedingCommit.ownsCommits() ? [precedingCommit].concat(commits) : commits; Use camelCase. In fact, I think we can just assign directly to commits in the case we have precedingCommit. 325426 2017-10-31 00:44:21 -0700 2017-10-31 00:57:45 -0700 Patch bug-179047-20171031004420.patch text/plain 4560 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjE5CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBkYmQ1ZjQyNjU5MmEzZGY5NzZjNzc3NjE2YjYxYTJjYTRjMzg0MjliLi5mZjExODQ0NzEw MGQ5YTJmNmY3MWY5NmUwMjdiZWNkYWMxN2RmOWU2IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNy0xMC0zMSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBPd25lZENvbW1pdFZpZXdlciBzaG91bGQgaW5jbHVkZSB0 aGUgcHJlY2VkaW5nIGNvbW1pdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3OTA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE93bmVkQ29tbWl0Vmlld2VyIHNob3dzIHRoZSBkaWZmZXJlbmNlIGJldHdl ZW4gb3duZWQgY29tbWl0cy4KKyAgICAgICAgVG8gc2hvdyBjaGFuZ2VzIG1hZGUgYnkgZmlyc3Qg b3duZWQgY29tbWl0LCB3ZSBuZWVkIHRvIGhhdmUgdGhlIHByZWNlZGluZyBjb21taXQgaW5mb3Jt YXRpb24uCisKKyAgICAgICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy9jb21taXQtbG9nLXZpZXdl ci5qczoKKyAgICAgICAgKENvbW1pdExvZ1ZpZXdlcik6CisgICAgICAgIChDb21taXRMb2dWaWV3 ZXIucHJvdG90eXBlLl9mZXRjaENvbW1pdExvZ3MpOiBGZXRjaCBwcmVjZWRpbmcgY29tbWl0IGlm IHRoZSBjb21taXRzIGZldGNoZWQgaXMgbm90IGEgc2luZ2xlIGNvbW1pdC4KKyAgICAgICAgKENv bW1pdExvZ1ZpZXdlci5wcm90b3R5cGUucmVuZGVyKToKKyAgICAgICAgKENvbW1pdExvZ1ZpZXdl ci5wcm90b3R5cGUuX3JlbmRlckNvbW1pdExpc3QpOiBDb25kaXRpb25hbGx5IHJlbmRlcmluZyBw cmVjZWRpbmcgY29tbWl0IGluIGNvbW1pdCBsaXN0LgorCiAyMDE3LTEwLTI0ICBEZXdlaSBaaHUg IDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBhIGJ1ZyBpbiBzeW5jaW5nIHNj cmlwdCB0aGF0IHRlc3QvYnVpbGQgc3luY2VyIGlzIG5ldmVyIHNldC4KZGlmZiAtLWdpdCBhL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jb21taXQtbG9nLXZp ZXdlci5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9j b21taXQtbG9nLXZpZXdlci5qcwppbmRleCBhNmU2Y2MyNWU2ODIxM2E1YjI4OTQ2ZTc5MmJkMjlk YjllZjJmZjE5Li5kNDMwNDZiZjE5MWZiNzdlODMwYmFmZTUxMzljNDY0YTEyOTkzODY4IDEwMDY0 NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY29t bWl0LWxvZy12aWV3ZXIuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9jb21wb25lbnRzL2NvbW1pdC1sb2ctdmlld2VyLmpzCkBAIC04LDYgKzgsNyBAQCBjbGFzcyBD b21taXRMb2dWaWV3ZXIgZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsKICAgICAgICAgdGhpcy5fcmVw b3NpdG9yeSA9IG51bGw7CiAgICAgICAgIHRoaXMuX2ZldGNoaW5nUHJvbWlzZSA9IG51bGw7CiAg ICAgICAgIHRoaXMuX2NvbW1pdHMgPSBudWxsOworICAgICAgICB0aGlzLl9wcmVjZWRpbmdDb21t aXQgPSBudWxsOwogICAgICAgICB0aGlzLl9yZW5kZXJDb21taXRMaXN0TGF6aWx5ID0gbmV3IExh emlseUV2YWx1YXRlZEZ1bmN0aW9uKHRoaXMuX3JlbmRlckNvbW1pdExpc3QuYmluZCh0aGlzKSk7 CiAgICAgICAgIHRoaXMuX3Nob3dSZXBvc2l0b3J5TmFtZSA9IHRydWU7CiAgICAgfQpAQCAtMzUs NyArMzYsOCBAQCBjbGFzcyBDb21taXRMb2dWaWV3ZXIgZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsK ICAgICAgICAgfQogCiAgICAgICAgIGxldCBwcm9taXNlOwotICAgICAgICBpZiAoIXByZWNlZGlu Z1JldmlzaW9uIHx8IHByZWNlZGluZ1JldmlzaW9uID09IGxhc3RSZXZpc2lvbikKKyAgICAgICAg bGV0IGZldGNoU2luZ2xlQ29tbWl0ID0gIXByZWNlZGluZ1JldmlzaW9uIHx8IHByZWNlZGluZ1Jl dmlzaW9uID09IGxhc3RSZXZpc2lvbjsKKyAgICAgICAgaWYgKGZldGNoU2luZ2xlQ29tbWl0KQog ICAgICAgICAgICAgcHJvbWlzZSA9IENvbW1pdExvZy5mZXRjaEZvclNpbmdsZVJldmlzaW9uKHJl cG9zaXRvcnksIGxhc3RSZXZpc2lvbik7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHByb21p c2UgPSBDb21taXRMb2cuZmV0Y2hCZXR3ZWVuUmV2aXNpb25zKHJlcG9zaXRvcnksIHByZWNlZGlu Z1JldmlzaW9uLCBsYXN0UmV2aXNpb24pOwpAQCAtNDgsNyArNTAsMTggQEAgY2xhc3MgQ29tbWl0 TG9nVmlld2VyIGV4dGVuZHMgQ29tcG9uZW50QmFzZSB7CiAgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgdGhpcy5fZmV0Y2hpbmdQcm9taXNlID0gbnVsbDsKICAgICAgICAgICAg IHRoaXMuX2NvbW1pdHMgPSBjb21taXRzOwotICAgICAgICAgICAgdGhpcy5lbnF1ZXVlVG9SZW5k ZXIoKTsKKyAgICAgICAgICAgIGlmIChmZXRjaFNpbmdsZUNvbW1pdCkgeworICAgICAgICAgICAg ICAgIHRoaXMuX3ByZWNlZGluZ0NvbW1pdCA9IG51bGw7CisgICAgICAgICAgICAgICAgdGhpcy5l bnF1ZXVlVG9SZW5kZXIoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9 CisgICAgICAgICAgICByZXR1cm4gQ29tbWl0TG9nLmZldGNoRm9yU2luZ2xlUmV2aXNpb24ocmVw b3NpdG9yeSwgcHJlY2VkaW5nUmV2aXNpb24pLnRoZW4oKHByZWNlZGluZ0NvbW1pdCkgPT4gewor ICAgICAgICAgICAgICAgIHRoaXMuX3ByZWNlZGluZ0NvbW1pdCA9IHByZWNlZGluZ0NvbW1pdFsw XTsKKyAgICAgICAgICAgICAgICB0aGlzLmVucXVldWVUb1JlbmRlcigpOworICAgICAgICAgICAg fSwgKGVycm9yKSA9PiB7CisgICAgICAgICAgICAgICAgdGhpcy5fcHJlY2VkaW5nQ29tbWl0ID0g bnVsbDsKKyAgICAgICAgICAgICAgICB0aGlzLmVucXVldWVUb1JlbmRlcigpOworICAgICAgICAg ICAgfSk7CiAgICAgICAgIH0sIChlcnJvcikgPT4gewogICAgICAgICAgICAgaWYgKHRoaXMuX2Zl dGNoaW5nUHJvbWlzZSAhPSBwcm9taXNlKQogICAgICAgICAgICAgICAgIHJldHVybjsKQEAgLTY1 LDE2ICs3OCwxNyBAQCBjbGFzcyBDb21taXRMb2dWaWV3ZXIgZXh0ZW5kcyBDb21wb25lbnRCYXNl IHsKICAgICAgICAgY29uc3Qgc2hvdWxkU2hvd1JlcG9zaXRvcnlOYW1lID0gdGhpcy5fcmVwb3Np dG9yeSAmJiAodGhpcy5fY29tbWl0cyB8fCB0aGlzLl9mZXRjaGluZ1Byb21pc2UpICYmIHRoaXMu X3Nob3dSZXBvc2l0b3J5TmFtZTsKICAgICAgICAgdGhpcy5jb250ZW50KCdyZXBvc2l0b3J5LW5h bWUnKS50ZXh0Q29udGVudCA9IHNob3VsZFNob3dSZXBvc2l0b3J5TmFtZSA/IHRoaXMuX3JlcG9z aXRvcnkubmFtZSgpIDogJyc7CiAgICAgICAgIHRoaXMuY29udGVudCgnc3Bpbm5lci1jb250YWlu ZXInKS5zdHlsZS5kaXNwbGF5ID0gdGhpcy5fZmV0Y2hpbmdQcm9taXNlID8gbnVsbCA6ICdub25l JzsKLSAgICAgICAgdGhpcy5fcmVuZGVyQ29tbWl0TGlzdExhemlseS5ldmFsdWF0ZSh0aGlzLl9j b21taXRzKTsKKyAgICAgICAgdGhpcy5fcmVuZGVyQ29tbWl0TGlzdExhemlseS5ldmFsdWF0ZSh0 aGlzLl9jb21taXRzLCB0aGlzLl9wcmVjZWRpbmdDb21taXQpOwogICAgIH0KIAotICAgIF9yZW5k ZXJDb21taXRMaXN0KGNvbW1pdHMpCisgICAgX3JlbmRlckNvbW1pdExpc3QoY29tbWl0cywgcHJl Y2VkaW5nQ29tbWl0KQogICAgIHsKICAgICAgICAgY29uc3QgZWxlbWVudCA9IENvbXBvbmVudEJh c2UuY3JlYXRlRWxlbWVudDsKICAgICAgICAgY29uc3QgbGluayA9IENvbXBvbmVudEJhc2UuY3Jl YXRlTGluazsKKyAgICAgICAgbGV0IGNvbW1pdHNfdG9fcHJvY2VzcyA9IGNvbW1pdHMgJiYgcHJl Y2VkaW5nQ29tbWl0ICYmIHByZWNlZGluZ0NvbW1pdC5vd25zQ29tbWl0cygpID8gW3ByZWNlZGlu Z0NvbW1pdF0uY29uY2F0KGNvbW1pdHMpIDogY29tbWl0czsKICAgICAgICAgbGV0IHByZXZpb3Vz Q29tbWl0ID0gbnVsbDsKIAotICAgICAgICB0aGlzLnJlbmRlclJlcGxhY2UodGhpcy5jb250ZW50 KCdjb21taXRzLWxpc3QnKSwgKGNvbW1pdHMgfHwgW10pLm1hcCgoY29tbWl0KSA9PiB7CisgICAg ICAgIHRoaXMucmVuZGVyUmVwbGFjZSh0aGlzLmNvbnRlbnQoJ2NvbW1pdHMtbGlzdCcpLCAoY29t bWl0c190b19wcm9jZXNzIHx8IFtdKS5tYXAoKGNvbW1pdCkgPT4gewogICAgICAgICAgICAgY29u c3QgbGFiZWwgPSBjb21taXQubGFiZWwoKTsKICAgICAgICAgICAgIGNvbnN0IHVybCA9IGNvbW1p dC51cmwoKTsKICAgICAgICAgICAgIGNvbnN0IG93bnNDb21taXRzID0gcHJldmlvdXNDb21taXQg JiYgcHJldmlvdXNDb21taXQub3duc0NvbW1pdHMoKSAmJiBjb21taXQub3duc0NvbW1pdHMoKTsK