179044 2017-10-30 20:21:51 -0700 Web Inspector: UIProcess ASSERT in ~RemoteWebInspectorProxy when InspectorProcess crashes 2017-11-15 12:31:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen buildbot commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1366307 0 joepeck 2017-10-30 20:21:51 -0700 UIProcess ASSERT in ~RemoteWebInspectorProxy when InspectorProcess crashes > Exception Type: EXC_BAD_ACCESS (SIGSEGV) > Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef > Exception Note: EXC_CORPSE_NOTIFY > > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 com.apple.JavaScriptCore 0x0000000107b3d944 WTFCrash + 36 (Assertions.cpp:270) > 1 com.apple.WebKit 0x000000010bffbe95 WebKit::RemoteWebInspectorProxy::~RemoteWebInspectorProxy() + 85 (RemoteWebInspectorProxy.cpp:46) > 2 com.apple.WebKit 0x000000010bffbfc5 WebKit::RemoteWebInspectorProxy::~RemoteWebInspectorProxy() + 21 (RemoteWebInspectorProxy.cpp:47) > 3 com.apple.WebKit 0x000000010bffbfe9 WebKit::RemoteWebInspectorProxy::~RemoteWebInspectorProxy() + 25 (RemoteWebInspectorProxy.cpp:45) > 4 com.apple.WebKit 0x000000010ba28d3f WTF::RefCounted<WebKit::RemoteWebInspectorProxy>::deref() const + 79 (RefCounted.h:145) > 5 com.apple.WebKit 0x000000010ba29135 void WTF::derefIfNotNull<WebKit::RemoteWebInspectorProxy>(WebKit::RemoteWebInspectorProxy*) + 53 (RefPtr.h:46) > 6 com.apple.WebKit 0x000000010ba290f3 WTF::RefPtr<WebKit::RemoteWebInspectorProxy>::~RefPtr() + 83 (RefPtr.h:69) > 7 com.apple.WebKit 0x000000010ba289c5 WTF::RefPtr<WebKit::RemoteWebInspectorProxy>::~RefPtr() + 21 (RefPtr.h:69) > 8 com.apple.WebKit 0x000000010ba2899b -[_WKRemoteWebInspectorViewController .cxx_destruct] + 235 (_WKRemoteWebInspectorViewController.mm:70) > 9 libobjc.A.dylib 0x00007fff5a27742e object_cxxDestructFromClass(objc_object*, objc_class*) + 127 > 10 libobjc.A.dylib 0x00007fff5a2702b1 objc_destructInstance + 92 > 11 libobjc.A.dylib 0x00007fff5a270244 object_dispose + 22 > 12 com.apple.WebInspector 0x000000010ac1781d .... > 13 com.apple.WebKit 0x000000010ba2884f -[_WKRemoteWebInspectorViewController closeFromFrontend] + 111 (_WKRemoteWebInspectorViewController.mm:139) > 14 com.apple.WebKit 0x000000010ba29010 WebKit::_WKRemoteWebInspectorProxyClient::closeFromFrontend() + 32 (_WKRemoteWebInspectorViewController.mm:62) > 15 com.apple.WebKit 0x000000010bffc950 WebKit::RemoteWebInspectorProxy::frontendDidClose() + 48 (RemoteWebInspectorProxy.cpp:88) > 16 com.apple.WebKit 0x000000010bffc915 WebKit::RemoteWebInspectorProxy::closeFromCrash() + 21 (RemoteWebInspectorProxy.cpp:71) > 17 com.apple.WebKit 0x000000010bffdb78 -[WKRemoteWebInspectorProxyObjCAdapter inspectorViewControllerInspectorDidCrash:] + 40 (RemoteWebInspectorProxyMac.mm:66) > 18 com.apple.WebKit 0x000000010c8598af -[WKInspectorViewController webViewWebContentProcessDidTerminate:] + 143 (WKInspectorViewController.mm:198) > 19 com.apple.WebKit 0x000000010bc55d6d WebKit::NavigationState::NavigationClient::processDidTerminate(WebKit::WebPageProxy&, WebKit::ProcessTerminationReason) + 269 (NavigationState.mm:896) > 20 com.apple.WebKit 0x000000010c4d1927 WebKit::WebPageProxy::processDidTerminate(WebKit::ProcessTerminationReason) + 231 (WebPageProxy.cpp:5469) > 21 com.apple.WebKit 0x000000010c6acc7e WebKit::WebProcessProxy::didClose(IPC::Connection&) + 510 (WebProcessProxy.cpp:639) > 22 com.apple.WebKit 0x000000010c6acdfc non-virtual thunk to WebKit::WebProcessProxy::didClose(IPC::Connection&) + 44 > 23 com.apple.WebKit 0x000000010bb4f426 IPC::Connection::connectionDidClose()::$_13::operator()() + 246 (Connection.cpp:806) > 24 com.apple.WebKit 0x000000010bb4f2a9 WTF::Function<void ()>::CallableWrapper<IPC::Connection::connectionDidClose()::$_13>::call() + 25 (Function.h:101) > 25 com.apple.JavaScriptCore 0x0000000107b72f8b WTF::Function<void ()>::operator()() const + 139 (Function.h:56) > 26 com.apple.JavaScriptCore 0x0000000107b935c3 WTF::RunLoop::performWork() + 211 (RunLoop.cpp:107) > 27 com.apple.JavaScriptCore 0x0000000107b93e44 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38) > ... 1366309 1 325419 joepeck 2017-10-30 20:31:40 -0700 Created attachment 325419 [PATCH] Proposed Fix 1366310 2 buildbot 2017-10-30 20:33:31 -0700 Attachment 325419 did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp:85: 'protect' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1366604 3 325419 commit-queue 2017-10-31 14:44:02 -0700 Comment on attachment 325419 [PATCH] Proposed Fix Clearing flags on attachment: 325419 Committed r224249: <https://trac.webkit.org/changeset/224249> 1366605 4 commit-queue 2017-10-31 14:44:03 -0700 All reviewed patches have been landed. Closing bug. 1372173 5 webkit-bug-importer 2017-11-15 12:31:13 -0800 <rdar://problem/35567693> 325419 2017-10-30 20:31:40 -0700 2017-10-31 14:44:02 -0700 [PATCH] Proposed Fix assert-1.patch text/plain 1366 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMWRlNDZlMjYzZDMuLmIyNzQ5MDUxYTZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE2IEBACiAyMDE3LTEwLTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVUlQcm9jZXNzIEFTU0VSVCBpbiB+UmVtb3RlV2Vi SW5zcGVjdG9yUHJveHkgd2hlbiBJbnNwZWN0b3JQcm9jZXNzIGNyYXNoZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTA0NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1JlbW90ZVdl Ykluc3BlY3RvclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlV2ViSW5zcGVjdG9y UHJveHk6OmZyb250ZW5kRGlkQ2xvc2UpOgorICAgICAgICBBZGQgYSBwcm90ZWN0b3IgdG8ga2Vl cCB0aGUgcHJveHkgYWxpdmUgZm9yIHRoZSBkdXJhdGlvbiBvZiB0aGlzIG1ldGhvZC4KKworMjAx Ny0xMC0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAg IE1ha2UgU2VydmljZVdvcmtlciBhIFJlbW90ZSBJbnNwZWN0b3IgZGVidWdnYWJsZSB0YXJnZXQK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTA0Mwog ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQxMjYwMDg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAKaW5kZXggOGU4Mzg5NWM5Mzku LjJmMWU3MTE3YjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVX ZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3Rl V2ViSW5zcGVjdG9yUHJveHkuY3BwCkBAIC04Miw2ICs4Miw4IEBAIHZvaWQgUmVtb3RlV2ViSW5z cGVjdG9yUHJveHk6OnNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2Up CiAKIHZvaWQgUmVtb3RlV2ViSW5zcGVjdG9yUHJveHk6OmZyb250ZW5kRGlkQ2xvc2UoKQogewor ICAgIFJlZjxSZW1vdGVXZWJJbnNwZWN0b3JQcm94eT4gcHJvdGVjdCgqdGhpcyk7CisKICAgICBp ZiAobV9jbGllbnQpCiAgICAgICAgIG1fY2xpZW50LT5jbG9zZUZyb21Gcm9udGVuZCgpOwogCg==