179038 2017-10-30 17:28:37 -0700 [WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables 2017-11-15 12:08:42 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 178894 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro tpopela webkit-bug-importer zan oldest_to_newest 1366245 0 mcatanzaro 2017-10-30 17:28:37 -0700 Always use SET_AND_EXPOSE_TO_BUILD to set build variables (as noted by Tom) This doesn't actually fix anything, but it's quite risky not to do so, as build defines could wind up set to unexpected values. 1366297 1 325413 mcatanzaro 2017-10-30 19:40:04 -0700 Created attachment 325413 Patch 1368612 2 325413 commit-queue 2017-11-06 06:43:44 -0800 Comment on attachment 325413 Patch Clearing flags on attachment: 325413 Committed r224490: <https://trac.webkit.org/changeset/224490> 1368613 3 commit-queue 2017-11-06 06:43:45 -0800 All reviewed patches have been landed. Closing bug. 325413 2017-10-30 19:40:04 -0700 2017-11-06 06:43:44 -0800 Patch bug-179038-20171030214003.patch text/plain 2776 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY1MjVmMjFiMDJiNTFiNGQ4YTk4ZDZl YTY1YzNiYWM3YWI4YzEyZDEuLjJlNGI1MjhkNjM3MTJiMTVjYmQ5Yzg0YWFiZDA3ZjI4M2NkY2M4 Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTctMTAtMzAgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCisgICAgICAgIFtXUEVdW0dUS10gQWx3YXlzIHVzZSBT RVRfQU5EX0VYUE9TRV9UT19CVUlMRCB0byBzZXQgYnVpbGQgdmFyaWFibGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwMzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgor CisyMDE3LTEwLTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4K KwogICAgICAgICBbV1BFXSBGaXggYnVpbGQgd2FybmluZ3MKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODg5OQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBhYmVh NGMzMDZkYmE5NWNjZjQxNzBhNTBiMGJjODdhMjE5MTJjNGEwLi41NmI3MWRmZTcxZTNjYmViNWMw MWI3ZWYyNzdmYjAxNzk2Njc3MmFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTUyMCw3ICs1MjAsNiBAQAog I2VuZGlmCiAKICNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKLSNkZWZpbmUgVVNF X0NBSVJPIDEKICNkZWZpbmUgVVNFX0dMSUIgMQogI2RlZmluZSBVU0VfRlJFRVRZUEUgMQogI2Rl ZmluZSBVU0VfSEFSRkJVWlogMQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCBmYWMyMzVlNzA2NmUw ZmMzMzkyZDVmZjAyN2YwNGJiZTA5YWQ5YzRhLi40MjJlNTA2ZmZjNTA0YjNhMzVjZWRmOTNmNWM3 MTRhNmRjZDE3NzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQor KysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtNDYsOCArNDYsOCBAQCBXRUJL SVRfT1BUSU9OX0JFR0lOKCkKIAogaW5jbHVkZShHU3RyZWFtZXJEZWZpbml0aW9ucykKIAotc2V0 KFVTRV9DQUlSTyBPTikKLXNldChVU0VfWERHTUlNRSBPTikKK1NFVF9BTkRfRVhQT1NFX1RPX0JV SUxEKFVTRV9DQUlSTyBUUlVFKQorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1hER01JTUUg VFJVRSkKIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9HQ1JZUFQgVFJVRSkKIAogIyBGb3Ig b2xkIHZlcnNpb25zIG9mIEhhcmZCdXp6IHRoYXQgZG8gbm90IGV4cG9zZSBhbiBBUEkgZm9yIHRo ZSBPcGVuVHlwZSBNQVRICmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFr ZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDFkZjk0ODcyZmM3M2YwNzli NjE3YTcyNDJjNDBkZjFkNmNhYjQ0OTkuLmNiOGI4NGVmZTJjYTQ0NzIxNGIxZDhjZGQ1MGI4MGUw ZTEzMDA0MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC03NSw4ICs3NSw4IEBAIGlmIChFTkFC TEVfWFNMVCkKICAgICBmaW5kX3BhY2thZ2UoTGliWHNsdCAxLjEuNyBSRVFVSVJFRCkKIGVuZGlm ICgpCiAKLXNldChVU0VfQ0FJUk8gT04pCi1zZXQoVVNFX1hER01JTUUgT04pCitTRVRfQU5EX0VY UE9TRV9UT19CVUlMRChVU0VfQ0FJUk8gVFJVRSkKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVT RV9YREdNSU1FIFRSVUUpCiBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfR0NSWVBUIFRSVUUp CiAKIGlmIChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg5MmU0MDc4OGJjYjUzOWI3MTdiY2M4MzFmZWFhM2YyZjBl OGExYjMuLjUxZjc5MzIyYjliNWZjNDM5ODNmNTQwNDBhMmQzZTNlMTg0YTY0YTAgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0xMC0z MCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAg W1dQRV1bR1RLXSBBbHdheXMgdXNlIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEIHRvIHNldCBidWls ZCB2YXJpYWJsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3OTAzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMTctMTAtMjYgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBVc2UgcHJvcGVyIHNoYXJl ZCBvYmplY3QgdmVyc2lvbmluZyBmb3IgbGliV1BFV2ViS2l0LnNvCg==