179009 2017-10-30 06:38:10 -0700 [WPE] Clean up OptionsWPE.cmake 2017-12-13 16:21:35 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 180780 178894 1 mcatanzaro mcatanzaro bugs-noreply clopez mcatanzaro webkit-bug-importer zan oldest_to_newest 1365995 0 mcatanzaro 2017-10-30 06:38:10 -0700 Clean up OptionsWPE.cmake. Some of the public options look like things we might not want to expose, and there's unneeded code to support disabling options that are not public. 1366318 1 mcatanzaro 2017-10-30 21:14:19 -0700 Zan, as part of this change, I'm auditing the public options list. I'd like to expose only options that we actually support toggling on or off, like we do for GTK. I'm guessing that the following public options should be removed: ENABLE_3D_TRANSFORMS (should be always on) ENABLE_CSS_SELECTORS_LEVEL4 (should be always on) ENABLE_DEVICE_ORIENTATION (should be always off) ENABLE_GEOLOCATION (should be always off) ENABLE_MEDIA_CONTROLS_SCRIPT (should be always on, and probably removed as all ports use it now) ENABLE_MEDIA_SOURCE (should be always off until Alicia is ready to turn it on, then always on) I don't know about ENABLE_ACCELERATED_2D_CANVAS... what do you think? It is public on GTK, since apparently it's useful for performance on embedded devices. But since it's off by default, do you know if WPE has ever been tested in this configuration? We should probably leave it private unless we know someone is using it, I guess? What about ENABLE_WEB_CRYPTO? I assumed that you would want it always on, especially since the GCrypt dependency is required for CryptoDigest anyway, so it's not possible to avoid that dependency. Can I make it private? And how about ENABLE_WEBGL? Would anyone really ever want to turn that off? Can we hide it too? 1366441 2 mcatanzaro 2017-10-31 10:27:29 -0700 Decision is to do as suggested above, except ENABLE_ACCELERATED_2D_CANVAS to remain public, and ENABLE_MEDIA_SOURCE to become private and ON by default. 1366703 3 325527 mcatanzaro 2017-10-31 17:37:01 -0700 Created attachment 325527 Patch 1368630 4 mcatanzaro 2017-11-06 08:27:29 -0800 Committed r224492: <https://trac.webkit.org/changeset/224492> 1368636 5 mcatanzaro 2017-11-06 08:36:49 -0800 Committed r224493: <https://trac.webkit.org/changeset/224493> 325527 2017-10-31 17:37:01 -0700 2017-11-05 22:51:10 -0800 Patch bug-179009-20171031193700.patch text/plain 5854 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDFkZjk0 ODcyZmM3M2YwNzliNjE3YTcyNDJjNDBkZjFkNmNhYjQ0OTkuLjkyN2ZkZDUxNjNmZWRkMDhlNjFj YjkyNjM1YTRkOTgyZmQ2NGM3OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0xMCwyNyArMTAs MzIgQEAgV0VCS0lUX09QVElPTl9CRUdJTigpCiAKIGluY2x1ZGUoR1N0cmVhbWVyRGVmaW5pdGlv bnMpCiAKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV8zRF9UUkFOU0ZP Uk1TIFBVQkxJQyBPTikKKyMgUHVibGljIG9wdGlvbnMgc2hhcmVkIHdpdGggb3RoZXIgV2ViS2l0 IHBvcnRzLiBEbyBub3QgYWRkIGFueSBvcHRpb25zIGhlcmUKKyMgd2l0aG91dCBhcHByb3ZhbCBm cm9tIGEgV1BFIHJldmlld2VyLiBUaGVyZSBtdXN0IGJlIHN0cm9uZyByZWFzb24gdG8gc3VwcG9y dAorIyBjaGFuZ2luZyB0aGUgdmFsdWUgb2YgdGhlIG9wdGlvbi4KIFdFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMgUFVCTElDIE9GRikK LVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfU0VMRUNUT1JTX0xF VkVMNCBQVUJMSUMgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf REVWSUNFX09SSUVOVEFUSU9OIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfRU5DUllQVEVEX01FRElBIFBVQkxJQyBPRkYpCi1XRUJLSVRfT1BUSU9O X0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0FNRVBBRCBQVUJMSUMgT0ZGKQotV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dFT0xPQ0FUSU9OIFBVQkxJQyBPRkYpCitX RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfWFNMVCBQVUJMSUMgT04pCisK KyMgUHJpdmF0ZSBvcHRpb25zIHNoYXJlZCB3aXRoIG90aGVyIFdlYktpdCBwb3J0cy4gQWRkIG9w dGlvbnMgaGVyZSBvbmx5IGlmCisjIHdlIG5lZWQgYSB2YWx1ZSBkaWZmZXJlbnQgZnJvbSB0aGUg ZGVmYXVsdCBkZWZpbmVkIGluIFdlYktpdEZlYXR1cmVzLmNtYWtlLgorIyBDaGFuZ2luZyB0aGVz ZSBvcHRpb25zIGlzIGNvbXBsZXRlbHkgdW5zdXBwb3J0ZWQuCitXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfM0RfVFJBTlNGT1JNUyBQUklWQVRFIE9OKQorV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19TRUxFQ1RPUlNfTEVWRUw0IFBSSVZB VEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfSU5ERVhFRF9E QVRBQkFTRSBQUklWQVRFIE9OKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX0lOREVYRURfREFUQUJBU0VfSU5fV09SS0VSUyBQUklWQVRFIE9GRikKLVdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQgUFVCTElD IE9OKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJD RSBQVUJMSUMgT0ZGKQorIyBGSVhNRTogVHVybiBvbiBFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRV9J Tl9XT1JLRVJTCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFf Q09OVFJPTFNfU0NSSVBUIFBSSVZBVEUgT04pCisjIEZJWE1FOiBUdXJuIG9uIEVOQUJMRV9NRURJ QV9TT1VSQ0UKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9T T1VSQ0UgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfTUhUTUwgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1BVQkxJQ19TVUZGSVhfTElTVCBQUklWQVRFIE9OKQogV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFTU9URV9JTlNQRUNUT1IgUFJJ VkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJUTEVf Q1JZUFRPIFBSSVZBVEUgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfVE9VQ0hfRVZFTlRTIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9UT1VDSF9FVkVOVFMgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9VU0VSX01FU1NBR0VfSEFORExFUlMgUFJJVkFURSBPTikKLVdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfQ1JZUFRPIFBVQkxJQyBP TikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJHTCBQVUJMSUMg T04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfWFNMVCBQVUJMSUMg T04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX0NSWVBUTyBQ UklWQVRFIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQkdM IFBSSVZBVEUgT04pCiAKIGlmIChDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJMaW51eCIpCiAg ICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FTU9SWV9TQU1QTEVS IFBSSVZBVEUgT04pCkBAIC01MSw1OSArNTYsNDUgQEAgc2V0KEVOQUJMRV9BUElfVEVTVFMgJHtE RVZFTE9QRVJfTU9ERX0pCiBzZXQoSmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBFIFNUQVRJQykK IHNldChXZWJDb3JlX0xJQlJBUllfVFlQRSBTVEFUSUMpCiAKLWZpbmRfcGFja2FnZShJQ1UgUkVR VUlSRUQpCi1maW5kX3BhY2thZ2UoVGhyZWFkcyBSRVFVSVJFRCkKLWZpbmRfcGFja2FnZShaTElC IFJFUVVJUkVEKQotZmluZF9wYWNrYWdlKEdMSUIgMi40MC4wIFJFUVVJUkVEIENPTVBPTkVOVFMg Z2lvIGdpby11bml4IGdvYmplY3QgZ3RocmVhZCBnbW9kdWxlKQotCiBmaW5kX3BhY2thZ2UoQ2Fp cm8gMS4xMC4yIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEZvbnRjb25maWcgMi44LjAgUkVRVUlS RUQpCitmaW5kX3BhY2thZ2UoR0xJQiAyLjQwLjAgUkVRVUlSRUQgQ09NUE9ORU5UUyBnaW8gZ2lv LXVuaXggZ29iamVjdCBndGhyZWFkIGdtb2R1bGUpCiBmaW5kX3BhY2thZ2UoRnJlZXR5cGUyIDIu NC4yIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEhhcmZCdXp6IDAuOS4xOCBSRVFVSVJFRCkKK2Zp bmRfcGFja2FnZShJQ1UgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoSlBFRyBSRVFVSVJFRCkKIGZp bmRfcGFja2FnZShMaWJFcG94eSAxLjQuMCBSRVFVSVJFRCkKLWZpbmRfcGFja2FnZShMaWJHY3J5 cHQgMS42LjAgUkVRVUlSRUQpCitmaW5kX3BhY2thZ2UoTGliR2NyeXB0IDEuNy4wIFJFUVVJUkVE KQogZmluZF9wYWNrYWdlKExpYlNvdXAgMi40Mi4wIFJFUVVJUkVEKQorZmluZF9wYWNrYWdlKExp YnRhc24xIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKExpYlhtbDIgMi44LjAgUkVRVUlSRUQpCiBm aW5kX3BhY2thZ2UoUE5HIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFNxbGl0ZSBSRVFVSVJFRCkK K2ZpbmRfcGFja2FnZShUaHJlYWRzIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFdlYlAgUkVRVUlS RUQpCi0KIGZpbmRfcGFja2FnZShXUEVCYWNrZW5kIFJFUVVJUkVEKQotCi1pZiAoRU5BQkxFX1hT TFQpCi0gICAgZmluZF9wYWNrYWdlKExpYlhzbHQgMS4xLjcgUkVRVUlSRUQpCi1lbmRpZiAoKQot Ci1zZXQoVVNFX0NBSVJPIE9OKQotc2V0KFVTRV9YREdNSU1FIE9OKQotU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoVVNFX0dDUllQVCBUUlVFKQorZmluZF9wYWNrYWdlKFpMSUIgUkVRVUlSRUQpCiAK IGlmIChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTKQogICAgIGZpbmRfcGFja2FnZShDYWly b0dMIDEuMTAuMiBSRVFVSVJFRCBDT01QT05FTlRTIGNhaXJvLWVnbCkKIGVuZGlmICgpCiAKLWlm IChFTkFCTEVfU1VCVExFX0NSWVBUTykKLSAgICBmaW5kX3BhY2thZ2UoTGlidGFzbjEgUkVRVUlS RUQpCi0gICAgaWYgKE5PVCBMSUJUQVNOMV9GT1VORCkKLSAgICAgICAgbWVzc2FnZShGQVRBTF9F UlJPUiAibGlidGFzbjEgaXMgcmVxdWlyZWQgdG8gZW5hYmxlIFdlYiBDcnlwdG8gQVBJIHN1cHBv cnQuIikKLSAgICBlbmRpZiAoKQotICAgIGlmIChMSUJHQ1JZUFRfVkVSU0lPTiBWRVJTSU9OX0xF U1MgMS43LjApCi0gICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgImxpYmdjcnlwdCAxLjcuMCBp cyByZXF1aXJlZCB0byBlbmFibGUgV2ViIENyeXB0byBBUEkgc3VwcG9ydC4iKQotICAgIGVuZGlm ICgpCitpZiAoRU5BQkxFX1hTTFQpCisgICAgZmluZF9wYWNrYWdlKExpYlhzbHQgMS4xLjcgUkVR VUlSRUQpCiBlbmRpZiAoKQogCiBhZGRfZGVmaW5pdGlvbnMoLURCVUlMRElOR19XUEVfXz0xKQog YWRkX2RlZmluaXRpb25zKC1ER0VUVEVYVF9QQUNLQUdFPSJXUEUiKQogYWRkX2RlZmluaXRpb25z KC1EREFUQV9ESVI9IiR7Q01BS0VfSU5TVEFMTF9EQVRBRElSfSIpCi1hZGRfZGVmaW5pdGlvbnMo LURVU0VSX0FHRU5UX01BSk9SX1ZFUlNJT049IjYwMSIpCithZGRfZGVmaW5pdGlvbnMoLURVU0VS X0FHRU5UX01BSk9SX1ZFUlNJT049IjYwNSIpCiBhZGRfZGVmaW5pdGlvbnMoLURVU0VSX0FHRU5U X01JTk9SX1ZFUlNJT049IjEiKQogCi1zZXQoVVNFX1VESVM4NiAxKQotCitTRVRfQU5EX0VYUE9T RV9UT19CVUlMRChVU0VfQ0FJUk8gVFJVRSkKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9F R0wgVFJVRSkKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9HQ1JZUFQgVFJVRSkKIFNFVF9B TkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9MSUJFUE9YWSBUUlVFKQogU0VUX0FORF9FWFBPU0VfVE9f QlVJTEQoVVNFX09QRU5HTF9FU18yIFRSVUUpCi1TRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0Vf RUdMIFRSVUUpCitTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfWERHTUlNRSBUUlVFKQogCiBT RVRfQU5EX0VYUE9TRV9UT19CVUlMRChFTkFCTEVfR1JBUEhJQ1NfQ09OVEVYVF8zRCBUUlVFKQog CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggM2Y2ZjY5OWE2NDQ1ZDk0 MDBiZDZiYjUzYTU5M2FhYzJmOGEwYzM3MC4uMDA0ZjNiZDU3YWFkYjhlNTg1Yjg0NzQ4M2FmZDA2 MDUyMWI4MDk3MSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTEwLTMxICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdh bGlhLmNvbT4KKworICAgICAgICBbV1BFXSBDbGVhbiB1cCBPcHRpb25zV1BFLmNtYWtlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwMDkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9PcHRpb25zV1BFLmNtYWtlOgorCiAyMDE3LTEwLTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9u c0dUSy5jbWFrZSBhbmQgTkVXUyBmb3IgMi4xOS4xIHJlbGVhc2UuCg==