<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>178989</bug_id>
          
          <creation_ts>2017-10-29 13:30:57 -0700</creation_ts>
          <short_desc>Use if conditional function in DerivedSources.make to reduce duplication</short_desc>
          <delta_ts>2017-11-15 12:40:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>aestes</cc>
    
    <cc>darin</cc>
    
    <cc>lforschler</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1365834</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-10-29 13:30:57 -0700</bug_when>
    <thetext>Use if conditional function in DerivedSources.make to reduce duplication.

See &lt;https://www.gnu.org/software/make/manual/html_node/Conditional-Functions.html#Conditional-Functions&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365835</commentid>
    <comment_count>1</comment_count>
      <attachid>325289</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-10-29 13:33:42 -0700</bug_when>
    <thetext>Created attachment 325289
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1366067</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-10-30 10:57:53 -0700</bug_when>
    <thetext>Committed r224186: &lt;https://trac.webkit.org/changeset/224186&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372203</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-15 12:40:11 -0800</bug_when>
    <thetext>&lt;rdar://problem/35567934&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325289</attachid>
            <date>2017-10-29 13:33:42 -0700</date>
            <delta_ts>2017-10-29 18:33:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-178989-20171029133339.patch</filename>
            <type>text/plain</type>
            <size>4045</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBmOWYzZjI1MzNjNzRk
ODUxMjdlMjVkMWZmMzZhY2VmOTZjYTQ1OS4uNTFiOWE0ZGNhNTYxNGNhODIyZDMzMmQ3ODVmMGQw
N2ZlOGI3YWZmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTI5ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgaWYgY29uZGl0aW9u
YWwgZnVuY3Rpb24gaW4gRGVyaXZlZFNvdXJjZXMubWFrZSB0byByZWR1Y2UgZHVwbGljYXRpb24K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODk4OQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIERlcml2
ZWRTb3VyY2VzLm1ha2Ugd2UgY3VycmVudGx5IGR1cGxpY2F0ZSBtb3N0IG9mIHRoZSBNYWtlZmls
ZSByZWNpcGUgZm9yIGdlbmVyYXRpbmcgSFRNTC9TVkcKKyAgICAgICAgdGFncyBhbmQgYXR0cmli
dXRlcyB0byBzdXBwb3J0IHBhc3NpbmcgdGhlIG9wdGlvbmFsIGNvbW1hbmQgbGluZSBvcHRpb24g
LS1leHRyYURlZmluZXMgd2hlbiBvbmUKKyAgICAgICAgb3IgbW9yZSBIVE1ML1NWRyBjb21waWxl
LXRpbWUgZmVhdHVyZXMgYXJlIGVuYWJsZWQuIEluc3RlYWQgd2UgY2FuIG1ha2UgdXNlIG9mIGEg
TWFrZWZpbGUKKyAgICAgICAgY29uZGl0aW9uYWwgZnVuY3Rpb24gaW4gdGhlIHJlY2lwZSBpdHNl
bGYgdG8gYXZvaWQgY29kZSBkdXBsaWNhdGlvbi4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2Vz
Lm1ha2U6CisKIDIwMTctMTAtMjkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgQXNzZXJ0IHRoYXQgbm8gc2NyaXB0IGlzIGV4ZWN1dGVkIGR1cmluZyBzdHlsZSBy
ZWNhbGMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UgYi9T
b3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlCmluZGV4IGNhNjcyYzVkNDMwY2RkMTJh
ZDYxYzQ1YWY4N2UyZDZlNWM0ZGNiNjEuLmFjM2E2YzYzMzM2NTRiYzI4ZGI4M2Q3NDAxY2JiNDdj
Y2YyZTAzYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UK
KysrIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQpAQCAtMTMwOCwxNyArMTMw
OCw4IEBAIGVuZGlmCiAKIGFsbCA6IEpTSFRNTEVsZW1lbnRXcmFwcGVyRmFjdG9yeS5jcHAgSlNI
VE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5LmggSFRNTEVsZW1lbnRGYWN0b3J5LmNwcCBIVE1MRWxl
bWVudEZhY3RvcnkuaCBIVE1MRWxlbWVudFR5cGVIZWxwZXJzLmggSFRNTE5hbWVzLmNwcCBIVE1M
TmFtZXMuaAogCi1pZmRlZiBIVE1MX0ZMQUdTCi0KLUpTSFRNTEVsZW1lbnRXcmFwcGVyRmFjdG9y
eSVjcHAgSlNIVE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5JWggSFRNTEVsZW1lbnRGYWN0b3J5JWNw
cCBIVE1MRWxlbWVudEZhY3RvcnklaCBIVE1MRWxlbWVudFR5cGVIZWxwZXJzJWggSFRNTE5hbWVz
JWNwcCBIVE1MTmFtZXMlaCA6IGRvbS9tYWtlX25hbWVzLnBsIGJpbmRpbmdzL3NjcmlwdHMvSGFz
aGVyLnBtIGJpbmRpbmdzL3NjcmlwdHMvU3RhdGljU3RyaW5nLnBtIGh0bWwvSFRNTFRhZ05hbWVz
LmluIGh0bWwvSFRNTEF0dHJpYnV0ZU5hbWVzLmluCi0JJChQRVJMKSAkPCAtLXRhZ3MgJChXZWJD
b3JlKS9odG1sL0hUTUxUYWdOYW1lcy5pbiAtLWF0dHJzICQoV2ViQ29yZSkvaHRtbC9IVE1MQXR0
cmlidXRlTmFtZXMuaW4gLS1mYWN0b3J5IC0td3JhcHBlckZhY3RvcnkgLS1leHRyYURlZmluZXMg
IiQoSFRNTF9GTEFHUykiCi0KLWVsc2UKLQogSlNIVE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5JWNw
cCBKU0hUTUxFbGVtZW50V3JhcHBlckZhY3RvcnklaCBIVE1MRWxlbWVudEZhY3RvcnklY3BwIEhU
TUxFbGVtZW50RmFjdG9yeSVoIEhUTUxFbGVtZW50VHlwZUhlbHBlcnMlaCBIVE1MTmFtZXMlY3Bw
IEhUTUxOYW1lcyVoIDogZG9tL21ha2VfbmFtZXMucGwgYmluZGluZ3Mvc2NyaXB0cy9IYXNoZXIu
cG0gYmluZGluZ3Mvc2NyaXB0cy9TdGF0aWNTdHJpbmcucG0gaHRtbC9IVE1MVGFnTmFtZXMuaW4g
aHRtbC9IVE1MQXR0cmlidXRlTmFtZXMuaW4KLQkkKFBFUkwpICQ8IC0tdGFncyAkKFdlYkNvcmUp
L2h0bWwvSFRNTFRhZ05hbWVzLmluIC0tYXR0cnMgJChXZWJDb3JlKS9odG1sL0hUTUxBdHRyaWJ1
dGVOYW1lcy5pbiAtLWZhY3RvcnkgLS13cmFwcGVyRmFjdG9yeQotCi1lbmRpZgorCSQoUEVSTCkg
JDwgLS10YWdzICQoV2ViQ29yZSkvaHRtbC9IVE1MVGFnTmFtZXMuaW4gLS1hdHRycyAkKFdlYkNv
cmUpL2h0bWwvSFRNTEF0dHJpYnV0ZU5hbWVzLmluIC0tZmFjdG9yeSAtLXdyYXBwZXJGYWN0b3J5
ICQoaWYgJChIVE1MX0ZMQUdTKSwgLS1leHRyYURlZmluZXMgIiQoSFRNTF9GTEFHUykiKQogCiBY
TUxOU05hbWVzLmNwcCA6IGRvbS9tYWtlX25hbWVzLnBsIGJpbmRpbmdzL3NjcmlwdHMvSGFzaGVy
LnBtIGJpbmRpbmdzL3NjcmlwdHMvU3RhdGljU3RyaW5nLnBtIHhtbC94bWxuc2F0dHJzLmluCiAJ
JChQRVJMKSAkPCAtLWF0dHJzICQoV2ViQ29yZSkveG1sL3htbG5zYXR0cnMuaW4KQEAgLTEzMzgs
MTUgKzEzMjksOCBAQCBlbmRpZgogCiBhbGwgOiBKU1NWR0VsZW1lbnRXcmFwcGVyRmFjdG9yeS5j
cHAgSlNTVkdFbGVtZW50V3JhcHBlckZhY3RvcnkuaCBTVkdFbGVtZW50RmFjdG9yeS5jcHAgU1ZH
RWxlbWVudEZhY3RvcnkuaCBTVkdFbGVtZW50VHlwZUhlbHBlcnMuaCBTVkdOYW1lcy5jcHAgU1ZH
TmFtZXMuaAogCi1pZmRlZiBTVkdfRkxBR1MKLUpTU1ZHRWxlbWVudFdyYXBwZXJGYWN0b3J5JWNw
cCBKU1NWR0VsZW1lbnRXcmFwcGVyRmFjdG9yeSVoIFNWR0VsZW1lbnRGYWN0b3J5JWNwcCBTVkdF
bGVtZW50RmFjdG9yeSVoIFNWR0VsZW1lbnRUeXBlSGVscGVycyVoIFNWR05hbWVzJWNwcCBTVkdO
YW1lcyVoIDogZG9tL21ha2VfbmFtZXMucGwgYmluZGluZ3Mvc2NyaXB0cy9IYXNoZXIucG0gYmlu
ZGluZ3Mvc2NyaXB0cy9TdGF0aWNTdHJpbmcucG0gc3ZnL3N2Z3RhZ3MuaW4gc3ZnL3N2Z2F0dHJz
LmluCi0JJChQRVJMKSAkPCAtLXRhZ3MgJChXZWJDb3JlKS9zdmcvc3ZndGFncy5pbiAtLWF0dHJz
ICQoV2ViQ29yZSkvc3ZnL3N2Z2F0dHJzLmluIC0tZXh0cmFEZWZpbmVzICIkKFNWR19GTEFHUyki
IC0tZmFjdG9yeSAtLXdyYXBwZXJGYWN0b3J5Ci1lbHNlCi0KIEpTU1ZHRWxlbWVudFdyYXBwZXJG
YWN0b3J5JWNwcCBKU1NWR0VsZW1lbnRXcmFwcGVyRmFjdG9yeSVoIFNWR0VsZW1lbnRGYWN0b3J5
JWNwcCBTVkdFbGVtZW50RmFjdG9yeSVoIFNWR0VsZW1lbnRUeXBlSGVscGVycyVoIFNWR05hbWVz
JWNwcCBTVkdOYW1lcyVoIDogZG9tL21ha2VfbmFtZXMucGwgYmluZGluZ3Mvc2NyaXB0cy9IYXNo
ZXIucG0gYmluZGluZ3Mvc2NyaXB0cy9TdGF0aWNTdHJpbmcucG0gc3ZnL3N2Z3RhZ3MuaW4gc3Zn
L3N2Z2F0dHJzLmluCi0JJChQRVJMKSAkPCAtLXRhZ3MgJChXZWJDb3JlKS9zdmcvc3ZndGFncy5p
biAtLWF0dHJzICQoV2ViQ29yZSkvc3ZnL3N2Z2F0dHJzLmluIC0tZmFjdG9yeSAtLXdyYXBwZXJG
YWN0b3J5Ci0KLWVuZGlmCisJJChQRVJMKSAkPCAtLXRhZ3MgJChXZWJDb3JlKS9zdmcvc3ZndGFn
cy5pbiAtLWF0dHJzICQoV2ViQ29yZSkvc3ZnL3N2Z2F0dHJzLmluIC0tZmFjdG9yeSAtLXdyYXBw
ZXJGYWN0b3J5ICQoaWYgJChTVkdfRkxBR1MpLCAtLWV4dHJhRGVmaW5lcyAiJChTVkdfRkxBR1Mp
IikKIAogWExpbmtOYW1lcy5jcHAgOiBkb20vbWFrZV9uYW1lcy5wbCBiaW5kaW5ncy9zY3JpcHRz
L0hhc2hlci5wbSBiaW5kaW5ncy9zY3JpcHRzL1N0YXRpY1N0cmluZy5wbSBzdmcveGxpbmthdHRy
cy5pbgogCSQoUEVSTCkgJDwgLS1hdHRycyAkKFdlYkNvcmUpL3N2Zy94bGlua2F0dHJzLmluCg==
</data>
<flag name="review"
          id="344794"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>