178969 2017-10-27 19:14:58 -0700 Correctly determine affinity when inserting text via Keyboard Suggestions 2017-10-30 14:25:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1365624 0 megan_gardner 2017-10-27 19:14:58 -0700 Correctly determine affinity when inserting text via Keyboard Suggestions 1365625 1 325231 megan_gardner 2017-10-27 19:20:06 -0700 Created attachment 325231 Patch 1365626 2 webkit-bug-importer 2017-10-27 19:21:11 -0700 <rdar://problem/35233885> 1366117 3 325231 rniwa 2017-10-30 12:11:11 -0700 Comment on attachment 325231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325231&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1865 > + // correctly determine affinity, using logic currently only present in VisiblePosition Nit: Capitalize "correctly". 1366176 4 megan_gardner 2017-10-30 14:25:18 -0700 https://trac.webkit.org/r224201 325231 2017-10-27 19:20:06 -0700 2017-10-30 12:11:11 -0700 Patch bug-178969-20171027192005.patch text/plain 3152 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDA2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTI3ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29ycmVjdGx5IGRl dGVybWluZSBhZmZpbml0eSB3aGVuIGluc2VydGluZyB0ZXh0IHZpYSBLZXlib2FyZCBTdWdnZXN0 aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 OTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl cmUgaGFzIGJlZW4gdGFsayBhYm91dCByZW5hbWluZyB0aGVzZSBlbnVtcywgYnV0IGluIHRoZSBt ZWFudGltZSB3ZSBzaG91bGQgYXQgbGVhc3QgaGF2ZSBhIGNvbW1lbnQgCisgICAgICAgIGNsYXJp Znlpbmcgd2hhdCB0aGV5IGFjdHVhbGx5IG1lYW4uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG9u bHkgYWRkaW5nIGEgY29tbWVudCwgbm8gdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogZWRpdGlu Zy9UZXh0QWZmaW5pdHkuaDoKKwogMjAxNy0xMC0yNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgW1BheW1lbnQgUmVxdWVzdF0gUmVzdHJpY3QgQVBJIHVzZSB0byBz ZWN1cmUsIHNhbWUtb3JpZ2luIGZyYW1lcwpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9U ZXh0QWZmaW5pdHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRB ZmZpbml0eS5oCShyZXZpc2lvbiAyMjQwNjcpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Rl eHRBZmZpbml0eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBACiAjcHJhZ21hIG9u Y2UKIAogbmFtZXNwYWNlIFdlYkNvcmUgewotCisvLyBVUFNUUkVBTSBtZWFucyBiZWZvcmUgYSBs aW5lIGJyZWFrIERPV05TVFJFQU0gbWVhbiBhZnRlciBhIGxpbmUgYnJlYWsKIGVudW0gRUFmZmlu aXR5IHsgVVBTVFJFQU0gPSAwLCBET1dOU1RSRUFNID0gMSB9OwogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjI0MTQyKQorKysgU291cmNlL1dlYktpdC9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0xMC0yNyAgTWVn YW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3Rs eSBkZXRlcm1pbmUgYWZmaW5pdHkgd2hlbiBpbnNlcnRpbmcgdGV4dCB2aWEgS2V5Ym9hcmQgU3Vn Z2VzdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3ODk2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSB0aGUgbG9naWMgb2YgVmlzaWJsZVBvc2l0aW9uIHRvIGNvcnJlY3RseSBkZXRlcm1pbmUg Y3Vyc29yIGFmZmluaXR5LiBXZSB3ZXJlCisgICAgICAgIGRlZmF1bHRpbmcgdG8gdXBzdHJlYW0s IGJ1dCB0aGF0IGluIGluY29ycmVjdCBhbmQgcmVzdWx0ZWQgaW4gaGl0dGluZyBhc3NlcnRzIHRo YXQKKyAgICAgICAgd2Ugc2hvdWxkIG5vdC4gVGhpcyBzaG91bGQgZ2l2ZSB1cyB0aGUgY29ycmVj dCBhZmZpbml0eSBpbiBhbGwgY2FzZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv aW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnN5bmNBcHBseUF1 dG9jb3JyZWN0aW9uKToKKwogMjAxNy0xMC0yNyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIEFwcGxlIEVsIENhcGl0YW4gYnVp bGQgZm9sbG93aW5nIDxodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjI0MTM0PgpJ bmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBh Z2VJT1MubW0JKHJldmlzaW9uIDIyNDA2OCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xODYyLDcgKzE4NjIs MTIgQEAgdm9pZCBXZWJQYWdlOjpzeW5jQXBwbHlBdXRvY29ycmVjdGlvbihjbwogICAgICAgICBy ZXR1cm47CiAgICAgfQogICAgIAotICAgIGZyYW1lLnNlbGVjdGlvbigpLnNldFNlbGVjdGVkUmFu Z2UocmFuZ2UuZ2V0KCksIFVQU1RSRUFNLCB0cnVlKTsKKyAgICAvLyBjb3JyZWN0bHkgZGV0ZXJt aW5lIGFmZmluaXR5LCB1c2luZyBsb2dpYyBjdXJyZW50bHkgb25seSBwcmVzZW50IGluIFZpc2li bGVQb3NpdGlvbgorICAgIEVBZmZpbml0eSBhZmZpbml0eSA9IERPV05TVFJFQU07CisgICAgaWYg KHJhbmdlICYmIHJhbmdlLT5jb2xsYXBzZWQoKSkKKyAgICAgICAgYWZmaW5pdHkgPSBWaXNpYmxl UG9zaXRpb24ocmFuZ2UtPnN0YXJ0UG9zaXRpb24oKSwgVVBTVFJFQU0pLmFmZmluaXR5KCk7Cisg ICAgCisgICAgZnJhbWUuc2VsZWN0aW9uKCkuc2V0U2VsZWN0ZWRSYW5nZShyYW5nZS5nZXQoKSwg YWZmaW5pdHksIHRydWUpOwogICAgIGlmIChjb3JyZWN0aW9uLmxlbmd0aCgpKQogICAgICAgICBm cmFtZS5lZGl0b3IoKS5pbnNlcnRUZXh0KGNvcnJlY3Rpb24sIDAsIG9yaWdpbmFsVGV4dC5pc0Vt cHR5KCkgPyBUZXh0RXZlbnRJbnB1dEtleWJvYXJkIDogVGV4dEV2ZW50SW5wdXRBdXRvY29tcGxl dGlvbik7CiAgICAgZWxzZQo=